@teachinglab/omd 0.7.30 → 0.7.31

package/canvas/features/resizeHandleManager.js

@@ -20,6 +20,7 @@ export class ResizeHandleManager {
         this.selectionBorderColor = '#007bff';
         this.selectionBorderWidth = 2;
         this.selectionBorder = null;
+        this.selectionBorderPadding = { top: 8, right: 8, bottom: 8, left: 8 };
         
         // Resize constraints
         this.minSize = 20;
@@ -270,11 +271,19 @@ export class ResizeHandleManager {
      * @param {string}  [style.dasharray]   - SVG stroke-dasharray value (e.g. '4,2' or 'none')
      * @param {number}  [style.cornerRadius]- rx/ry corner radius of the border rect
      */
-    setSelectionStyle({ color, width, dasharray, cornerRadius } = {}) {
+    setSelectionStyle({ color, width, dasharray, cornerRadius, padding, paddingX, paddingY, paddingTop, paddingRight, paddingBottom, paddingLeft } = {}) {
         if (color !== undefined)       this.selectionBorderColor = color;
         if (width !== undefined)       this.selectionBorderWidth = width;
         if (dasharray !== undefined)   this.selectionBorderDasharray = dasharray;
         if (cornerRadius !== undefined) this.selectionBorderCornerRadius = cornerRadius;
+        const basePadding = padding ?? null;
+        const nextPadding = {
+            top: paddingTop ?? paddingY ?? basePadding ?? this.selectionBorderPadding.top,
+            right: paddingRight ?? paddingX ?? basePadding ?? this.selectionBorderPadding.right,
+            bottom: paddingBottom ?? paddingY ?? basePadding ?? this.selectionBorderPadding.bottom,
+            left: paddingLeft ?? paddingX ?? basePadding ?? this.selectionBorderPadding.left
+        };
+        this.selectionBorderPadding = nextPadding;
 
         // Re-apply to live border if one exists
         if (this.selectionBorder) {
@@ -286,6 +295,7 @@ export class ResizeHandleManager {
                 this.selectionBorder.setAttribute('rx', this.selectionBorderCornerRadius);
                 this.selectionBorder.setAttribute('ry', this.selectionBorderCornerRadius);
             }
+            this._updateSelectionBorder();
         }
     }
 
@@ -385,12 +395,12 @@ export class ResizeHandleManager {
         if (!this.selectionBorder || !this.selectedElement) return;
         
         const bounds = this._getTransformedBounds();
-        const padding = 3;
+        const padding = this.selectionBorderPadding;
         
-        this.selectionBorder.setAttribute('x', bounds.x - padding);
-        this.selectionBorder.setAttribute('y', bounds.y - padding);
-        this.selectionBorder.setAttribute('width', bounds.width + padding * 2);
-        this.selectionBorder.setAttribute('height', bounds.height + padding * 2);
+        this.selectionBorder.setAttribute('x', bounds.x - padding.left);
+        this.selectionBorder.setAttribute('y', bounds.y - padding.top);
+        this.selectionBorder.setAttribute('width', bounds.width + padding.left + padding.right);
+        this.selectionBorder.setAttribute('height', bounds.height + padding.top + padding.bottom);
     }
     
     /**

package/canvas/tools/PointerTool.js

@@ -50,6 +50,13 @@ export class PointerTool extends Tool {
         this.dragStartPoint = null;
         this.potentialDeselect = null;
         this.hasSeparatedForDrag = false;
+
+        this.selectionBoundsPadding = {
+            top: options.selectionBoundsPaddingTop ?? options.selectionBoundsPaddingY ?? options.selectionBoundsPadding ?? 14,
+            right: options.selectionBoundsPaddingRight ?? options.selectionBoundsPaddingX ?? options.selectionBoundsPadding ?? 14,
+            bottom: options.selectionBoundsPaddingBottom ?? options.selectionBoundsPaddingY ?? options.selectionBoundsPadding ?? 14,
+            left: options.selectionBoundsPaddingLeft ?? options.selectionBoundsPaddingX ?? options.selectionBoundsPadding ?? 14
+        };
         
         // Initialize resize handle manager for OMD visuals
         this.resizeHandleManager = new ResizeHandleManager(canvas);
@@ -595,12 +602,12 @@ export class PointerTool extends Tool {
         if (!hasPoints) return null;
         
         // Add padding to match the visual box
-        const padding = 8;
+        const padding = this.selectionBoundsPadding;
         return {
-            x: minX - padding,
-            y: minY - padding,
-            width: (maxX + padding) - (minX - padding),
-            height: (maxY + padding) - (minY - padding)
+            x: minX - padding.left,
+            y: minY - padding.top,
+            width: (maxX + padding.right) - (minX - padding.left),
+            height: (maxY + padding.bottom) - (minY - padding.top)
         };
     }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@teachinglab/omd",
-  "version": "0.7.30",
+  "version": "0.7.31",
   "description": "omd",
   "main": "./index.js",
   "module": "./index.js",

package/src/omdShapes.js

@@ -2,6 +2,39 @@
 import { omdColor } from "./omdColor.js";
 import { jsvgGroup, jsvgPath, jsvgLine, jsvgTextLine, jsvgEllipse } from "@teachinglab/jsvg";
 
+const DEFAULT_SHAPE_PADDING = 10;
+const LABEL_SHAPE_PADDING = 38;
+
+function getShapePadding(showLabels) {
+    return showLabels ? LABEL_SHAPE_PADDING : DEFAULT_SHAPE_PADDING;
+}
+
+function getClosedPolygonVertices(shapePath) {
+    const points = Array.isArray(shapePath?.points) ? shapePath.points : [];
+    if (points.length <= 1) return points.slice();
+
+    const first = points[0];
+    const last = points[points.length - 1];
+    const isClosed = first.x === last.x && first.y === last.y;
+    return isClosed ? points.slice(0, -1) : points.slice();
+}
+
+function getPolygonCentroid(points) {
+    if (!points.length) return { x: 0, y: 0 };
+
+    let sumX = 0;
+    let sumY = 0;
+    for (const point of points) {
+        sumX += point.x;
+        sumY += point.y;
+    }
+
+    return {
+        x: sumX / points.length,
+        y: sumY / points.length
+    };
+}
+
 export class omdRightTriangle extends jsvgGroup
 {
     constructor()
@@ -69,8 +102,9 @@ export class omdRightTriangle extends jsvgGroup
     updateLayout()
     {
         // Center the triangle within the viewBox
-        const offsetX = 10; // Left margin
-        const offsetY = this.unitScale * this.verticalLeg + 10; // Bottom margin
+        const padding = getShapePadding(this.showLabels);
+        const offsetX = padding;
+        const offsetY = this.unitScale * this.verticalLeg + padding;
 
         this.shapePath.clearPoints();
         this.shapePath.addPoint(offsetX, offsetY);
@@ -92,8 +126,8 @@ export class omdRightTriangle extends jsvgGroup
         }
 
         // Set viewBox to center the shape
-        this.width = this.unitScale * this.horizontalLeg + 20;
-        this.height = this.unitScale * this.verticalLeg + 20;
+        this.width = this.unitScale * this.horizontalLeg + padding * 2;
+        this.height = this.unitScale * this.verticalLeg + padding * 2;
         this.svgObject.setAttribute('viewBox', `0 0 ${this.width} ${this.height}`);
     }
 }
@@ -150,8 +184,9 @@ export class omdIsoscelesTriangle extends jsvgGroup
 
         const baseWidth = this.unitScale * this.triangleBase;
         const triangleHeight = this.unitScale * this.triangleHeight;
-        const offsetX = 10;
-        const offsetY = triangleHeight + 10;
+        const padding = getShapePadding(this.showLabels);
+        const offsetX = padding;
+        const offsetY = triangleHeight + padding;
 
         this.shapePath.addPoint( offsetX, offsetY );
         this.shapePath.addPoint( offsetX + baseWidth, offsetY );
@@ -169,8 +204,8 @@ export class omdIsoscelesTriangle extends jsvgGroup
         }
 
         // Set dimensions and viewBox for API compatibility
-        this.width = this.unitScale * this.triangleBase + 20;
-        this.height = this.unitScale * this.triangleHeight + 20;
+        this.width = this.unitScale * this.triangleBase + padding * 2;
+        this.height = this.unitScale * this.triangleHeight + padding * 2;
         this.svgObject.setAttribute('viewBox', `0 0 ${this.width} ${this.height}`);
     }
 }
@@ -222,8 +257,9 @@ export class omdRectangle extends jsvgGroup
     updateLayout()
     {
         // Center the rectangle within the viewBox
-        const offsetX = 10;
-        const offsetY = this.unitScale * this.rectHeight + 10;
+        const padding = getShapePadding(this.showLabels);
+        const offsetX = padding;
+        const offsetY = this.unitScale * this.rectHeight + padding;
 
         this.shapePath.clearPoints();
         this.shapePath.addPoint(offsetX, offsetY);
@@ -245,8 +281,8 @@ export class omdRectangle extends jsvgGroup
         }
 
         // Set viewBox
-        this.width = this.unitScale * this.rectWidth + 20;
-        this.height = this.unitScale * this.rectHeight + 20;
+        this.width = this.unitScale * this.rectWidth + padding * 2;
+        this.height = this.unitScale * this.rectHeight + padding * 2;
         this.svgObject.setAttribute('viewBox', `0 0 ${this.width} ${this.height}`);
     }
 }
@@ -367,19 +403,37 @@ export class omdCircle extends jsvgGroup
     updateLayout()
     {
         const diameter = 2.0 * this.radius * this.unitScale;
+        const radiusPx = this.radius * this.unitScale;
+        const centerX = radiusPx + 10;
+        const centerY = radiusPx + 10;
 
         this.shapePath.setWidthAndHeight( diameter, diameter );
-        this.shapePath.setPosition( this.radius * this.unitScale + 10, this.radius * this.unitScale + 10 );
+        this.shapePath.setPosition( centerX, centerY );
 
         this.labelsHolder.removeAllChildren();
         if ( this.showLabels )
         {
+            const angleRadians = -Math.PI / 6;
+            const endX = centerX + Math.cos(angleRadians) * radiusPx * 0.82;
+            const endY = centerY + Math.sin(angleRadians) * radiusPx * 0.82;
+
+            const radiusLine = new jsvgLine();
+            radiusLine.setStrokeColor("black");
+            radiusLine.setStrokeWidth(1.5);
+            radiusLine.setEndpoints(centerX, centerY, endX, endY);
+            this.labelsHolder.addChild(radiusLine);
+
             const label = new jsvgTextLine();
             label.setAlignment("center");
             label.setFontFamily( "Albert Sans" );
             label.setFontColor( "black" );
             label.setFontSize( 12 );
-            label.setPosition( this.radius * this.unitScale + 10, this.radius * this.unitScale + 14 );
+            label.svgObject.setAttribute('dominant-baseline', 'middle');
+            label.setRotation(angleRadians * 180 / Math.PI);
+            label.setPosition(
+                (centerX + endX) * 0.5 + 3,
+                (centerY + endY) * 0.5 - 4
+            );
             label.setText( `r=${this.radius}` );
             this.labelsHolder.addChild( label );
         }
@@ -440,6 +494,10 @@ export class omdRegularPolygon extends jsvgGroup
     updateLayout()
     {
         this.shapePath.clearPoints();
+        const radiusPx = this.radius * this.unitScale;
+        const padding = this.showLabels ? 48 : 14;
+        const centerX = radiusPx + padding;
+        const centerY = radiusPx + padding;
 
         var angleOffset = 0;
         if ( this.numberOfSides % 2 == 1 )
@@ -453,8 +511,8 @@ export class omdRegularPolygon extends jsvgGroup
         {
             var A = -2.0 * Math.PI / this.numberOfSides * i;
             A += angleOffset;
-            var pX = Math.cos(A) * this.radius * this.unitScale;
-            var pY = Math.sin(A) * this.radius * this.unitScale;
+            var pX = centerX + Math.cos(A) * radiusPx;
+            var pY = centerY + Math.sin(A) * radiusPx;
             this.shapePath.addPoint( pX, pY );
         }
 
@@ -472,9 +530,9 @@ export class omdRegularPolygon extends jsvgGroup
         }
 
         // Set dimensions and viewBox for API compatibility
-        this.width = 2.0 * this.radius * this.unitScale + 20;
-        this.height = 2.0 * this.radius * this.unitScale + 20;
-        this.svgObject.setAttribute('viewBox', `-${this.width/2} -${this.height/2} ${this.width} ${this.height}`);
+        this.width = 2.0 * radiusPx + padding * 2;
+        this.height = 2.0 * radiusPx + padding * 2;
+        this.svgObject.setAttribute('viewBox', `0 0 ${this.width} ${this.height}`);
     }
 }
 
@@ -489,76 +547,77 @@ export class omdShapeLabelSet extends jsvgGroup
 
     initializeWithShapePath( shapePath, labelTextArray=[] )
     {
-        // this assumes counterclockwise path
+        const polygonPoints = getClosedPolygonVertices(shapePath);
+        const centroid = getPolygonCentroid(polygonPoints);
 
         // create lines
-        for( var i=0; i<shapePath.points.length-1; i++ )
+        for (let i = 0; i < polygonPoints.length; i++)
         {
-            if ( i >= labelTextArray.length || labelTextArray[i].length == 0 )
+            if ( i >= labelTextArray.length )
+                continue;
+
+            const labelValue = labelTextArray[i];
+            const labelString = String(labelValue ?? "");
+            if ( labelString.length === 0 )
                 continue;
             
             // get points
-            var point0 = shapePath.points[i];
-            var x0 = point0.x;
-            var y0 = point0.y;
+            const point0 = polygonPoints[i];
+            const x0 = point0.x;
+            const y0 = point0.y;
 
-            var point1 = shapePath.points[i+1];
-            var x1 = point1.x;
-            var y1 = point1.y;
+            const point1 = polygonPoints[(i + 1) % polygonPoints.length];
+            const x1 = point1.x;
+            const y1 = point1.y;
 
             // get normalized vector
-            var dX = x1 - x0;
-            var dY = y1 - y0;
-            var L = Math.sqrt( dX*dX + dY*dY );
+            let dX = x1 - x0;
+            let dY = y1 - y0;
+            const L = Math.sqrt( dX*dX + dY*dY );
             dX /= L;
             dY /= L;
             
-            // get normal
-            var normalX = -1.0 * dY;
-            var normalY = dX;
+            // get outward normal based on the polygon centroid rather than path winding
+            const centerX = (x0 + x1) / 2.0;
+            const centerY = (y0 + y1) / 2.0;
+            let normalX = -1.0 * dY;
+            let normalY = dX;
+            const toMidX = centerX - centroid.x;
+            const toMidY = centerY - centroid.y;
+            if ( toMidX * normalX + toMidY * normalY < 0 )
+            {
+                normalX *= -1.0;
+                normalY *= -1.0;
+            }
 
             // make line
-            var labelLine = new jsvgLine();
-            var newLineX0 = x0 + normalX * 10.0;
-            var newLineY0 = y0 + normalY * 10.0;
-            var newLineX1 = x1 + normalX * 10.0;
-            var newLineY1 = y1 + normalY * 10.0;
+            const labelLine = new jsvgLine();
+            const newLineX0 = x0 + normalX * 10.0;
+            const newLineY0 = y0 + normalY * 10.0;
+            const newLineX1 = x1 + normalX * 10.0;
+            const newLineY1 = y1 + normalY * 10.0;
             labelLine.setEndpoints( newLineX0, newLineY0, newLineX1, newLineY1 );
             this.addChild( labelLine );
 
-            // center point
-            var centerX = (x0 + x1) / 2.0;
-            var centerY = (y0 + y1) / 2.0;
-
-            var angle = Math.atan2( dY, dX );
-            angle *= 180 / Math.PI;
-            angle += 180.0;
-            angle = angle % 360.0;
-            var originalAngle = angle;            
-
-            // flip upside-down text
-            var offset = 0;
-            if ( angle > 90 && angle < 270 )
-            {
-                angle -= 180.0;
-                offset += 10.0;
-            }
+            let angle = Math.atan2( dY, dX ) * 180 / Math.PI;
+            if ( angle > 90 || angle < -90 )
+                angle += 180.0;
 
             // label text
-            var textCenterX = centerX + normalX * (15.0+offset);
-            var textCenterY = centerY + normalY * (15.0+offset);
-            var labelText = new jsvgTextLine();
+            const textCenterX = centerX + normalX * 18.0;
+            const textCenterY = centerY + normalY * 18.0;
+            const labelText = new jsvgTextLine();
             labelText.setAlignment("center");
             labelText.setFontFamily( "Albert Sans" );
             labelText.setFontColor( "black" );
             labelText.setFontSize( 12 );
             labelText.setPosition( textCenterX, textCenterY );
             labelText.setRotation( angle );
+            labelText.svgObject.setAttribute('dominant-baseline', 'middle');
             this.addChild( labelText );
 
-            labelText.setText( labelTextArray[i] );
+            labelText.setText( labelString );
         }
     }
 
 }
-