@tea-agent/loop-agent 0.41.1-beta.0 → 0.42.0-next.2

package/dist/infrastructure/console/dir-lock.js

@@ -0,0 +1,132 @@
+import { randomBytes } from "node:crypto";
+import { lstat, mkdir, readFile, rename, rm, utimes, writeFile } from "node:fs/promises";
+import path from "node:path";
+import { ensureSecureDir } from "./app-data.js";
+const OWNER_FILE = "owner";
+const DEFAULT_STALE_MS = 30_000;
+function delay(ms) {
+    return new Promise((resolve) => setTimeout(resolve, ms));
+}
+function freshToken() {
+    return randomBytes(16).toString("hex");
+}
+function ownerPath(lockDir) {
+    return path.join(lockDir, OWNER_FILE);
+}
+/**
+ * A lock's freshness is the owner-file heartbeat, not the containing
+ * directory mtime. Creating or editing a file does not refresh the directory
+ * mtime, so using the latter could make a healthy long-running lock appear
+ * stale and permit a second holder into its critical section.
+ */
+async function lockTimestamp(lockDir) {
+    const ownerStat = await lstat(ownerPath(lockDir)).catch(() => undefined);
+    if (ownerStat?.isFile())
+        return ownerStat.mtimeMs;
+    return (await lstat(lockDir).catch(() => undefined))?.mtimeMs;
+}
+export async function isDirLockStale(lockDir, staleMs, nowMs = Date.now()) {
+    const timestamp = await lockTimestamp(lockDir);
+    return timestamp === undefined || nowMs - timestamp > staleMs;
+}
+async function refreshDirLock(lockDir, token) {
+    const owner = await readFile(ownerPath(lockDir), "utf-8").catch(() => undefined);
+    if (owner !== token)
+        return;
+    const now = new Date();
+    await utimes(ownerPath(lockDir), now, now).catch(() => { });
+}
+/**
+ * Cross-process exclusive directory lock (mkdir-based). Ownership is
+ * token-guarded: each holder writes a unique owner file inside the lock
+ * directory and only ever removes a lock whose owner token matches its own.
+ *
+ * Release protocol (B2): verify owner AND freshness BEFORE touching the lock
+ * path. Takeover only ever targets a stale lock, so a holder that releases a
+ * lock it still owns (fresh) cannot have been taken over between the verify
+ * and the rename — it moves its own lock, never a successor's. A stale lock is
+ * deliberately left alone (a takeover may be in flight); only the post-rename
+ * tombstone check restores a lock moved by an unexpected race, never deletes a
+ * successor's live lock.
+ */
+export async function acquireDirLock(lockDir, options) {
+    const token = options?.token ?? freshToken();
+    const staleMs = options?.staleMs ?? DEFAULT_STALE_MS;
+    ensureSecureDir(path.dirname(lockDir));
+    for (;;) {
+        try {
+            await mkdir(lockDir);
+        }
+        catch (error) {
+            const code = error?.code;
+            if (code !== "EEXIST")
+                throw error;
+            const stat = await lstat(lockDir).catch(() => undefined);
+            if (stat?.isDirectory() && await isDirLockStale(lockDir, staleMs)) {
+                const tombstone = `${lockDir}.${freshToken()}.tomb`;
+                try {
+                    await rename(lockDir, tombstone);
+                    await rm(tombstone, { recursive: true, force: true });
+                }
+                catch {
+                    // another process won the takeover; retry the loop
+                }
+                continue;
+            }
+            await delay(20);
+            continue;
+        }
+        try {
+            await writeFile(ownerPath(lockDir), token, {
+                flag: "wx",
+                mode: 0o600,
+            });
+        }
+        catch {
+            await rm(lockDir, { recursive: true, force: true });
+            continue;
+        }
+        break;
+    }
+    const heartbeat = setInterval(() => { void refreshDirLock(lockDir, token); }, Math.max(10, Math.floor(staleMs / 3)));
+    heartbeat.unref();
+    let released = false;
+    const release = async () => {
+        if (released)
+            return;
+        released = true;
+        clearInterval(heartbeat);
+        // Verify the lock is still ours AND fresh before renaming it away. If the
+        // owner no longer matches, a successor holds the lock — never touch it.
+        const stat = await lstat(lockDir).catch(() => undefined);
+        if (!stat?.isDirectory())
+            return;
+        if (await isDirLockStale(lockDir, staleMs)) {
+            // Our lock went stale: a takeover may be in flight or imminent. Leave
+            // it alone — removing it now could delete a successor's live lock.
+            return;
+        }
+        const owner = await readFile(ownerPath(lockDir), "utf-8").catch(() => undefined);
+        if (owner !== token)
+            return;
+        const tombstone = `${lockDir}.${token}.release`;
+        try {
+            await rename(lockDir, tombstone);
+        }
+        catch {
+            // lock path already gone (a takeover removed it); nothing of ours.
+            return;
+        }
+        const movedOwner = await readFile(path.join(tombstone, OWNER_FILE), "utf-8").catch(() => undefined);
+        if (movedOwner !== token) {
+            // Raced with a takeover in the microsecond window between the fresh
+            // verify and the rename: restore the moved lock if the path is still
+            // free; otherwise leave the tombstone for reconcile — never delete a
+            // successor's live lock.
+            await rename(tombstone, lockDir).catch(() => { });
+            return;
+        }
+        await rm(tombstone, { recursive: true, force: true }).catch(() => { });
+    };
+    return { token, release };
+}

package/dist/infrastructure/console/operation-store.js

@@ -0,0 +1,197 @@
+import { randomBytes } from "node:crypto";
+import path from "node:path";
+import { listJsonFiles, readJsonIfExists, sha256Json, writeSecureJson, } from "./app-data.js";
+export const TERMINAL_OPERATION_STATES = new Set(["succeeded", "failed", "timed-out", "restarting"]);
+function operationFile(appData, operationId) {
+    return path.join(appData.operations, `${operationId}.json`);
+}
+function requestIndexFile(appData, clientRequestId) {
+    const safe = clientRequestId.replace(/[^a-zA-Z0-9._-]+/g, "_").slice(0, 180);
+    return path.join(appData.operations, `req-${safe}.json`);
+}
+export function computeActionPayloadHash(action, actionParams) {
+    return sha256Json({ action, actionParams });
+}
+export function newOperationId() {
+    return `op_${randomBytes(12).toString("hex")}`;
+}
+export class OperationStore {
+    appData;
+    /**
+     * Per-key write lock. Concurrent update/save/create on the same operation
+     * or clientRequestId must not race rename() into the same JSON path
+     * (Windows EPERM) or last-write-wins lost patches.
+     */
+    writeChains = new Map();
+    constructor(appData) {
+        this.appData = appData;
+    }
+    serialize(key, op) {
+        const prev = this.writeChains.get(key) ?? Promise.resolve();
+        const next = prev.then(op, op);
+        this.writeChains.set(key, next.then(() => undefined, () => undefined));
+        return next;
+    }
+    async create(input) {
+        const clientRequestId = input.clientRequestId.trim();
+        if (!clientRequestId) {
+            throw new Error("clientRequestId is required for mutation operations");
+        }
+        const payloadHash = computeActionPayloadHash(input.action, input.actionParams);
+        return this.serialize(`req:${clientRequestId}`, async () => {
+            const indexPath = requestIndexFile(this.appData, clientRequestId);
+            const existingIndex = await readJsonIfExists(indexPath);
+            if (existingIndex) {
+                const existing = await this.get(existingIndex.operationId);
+                if (existing) {
+                    if (existing.payloadHash === payloadHash) {
+                        return { kind: "idempotent", operation: existing };
+                    }
+                    return {
+                        kind: "conflict",
+                        code: "REQUEST_ID_REUSE_CONFLICT",
+                        message: `clientRequestId ${clientRequestId} was reused with a different payload`,
+                        existing,
+                    };
+                }
+            }
+            const operationId = newOperationId();
+            const now = new Date().toISOString();
+            const operation = {
+                schemaVersion: 1,
+                operationId,
+                clientRequestId,
+                action: input.action,
+                actionParams: input.actionParams,
+                payloadHash,
+                state: "queued",
+                createdAt: now,
+                taskId: input.taskId,
+                cliArgs: input.cliArgs,
+                ...(input.externalCommand
+                    ? { externalCommand: input.externalCommand }
+                    : {}),
+            };
+            await writeSecureJson(operationFile(this.appData, operationId), operation);
+            await writeSecureJson(indexPath, { operationId, payloadHash });
+            return { kind: "created", operation };
+        });
+    }
+    async get(operationId) {
+        return readJsonIfExists(operationFile(this.appData, operationId));
+    }
+    async save(operation) {
+        return this.serialize(operation.operationId, async () => {
+            await writeSecureJson(operationFile(this.appData, operation.operationId), operation);
+            return operation;
+        });
+    }
+    async update(operationId, patch) {
+        return this.serialize(operationId, async () => {
+            const current = await this.get(operationId);
+            if (!current) {
+                throw new Error(`operation not found: ${operationId}`);
+            }
+            const next = {
+                ...current,
+                ...patch,
+                operationId: current.operationId,
+                schemaVersion: 1,
+                clientRequestId: current.clientRequestId,
+                payloadHash: current.payloadHash,
+                action: current.action,
+                createdAt: current.createdAt,
+            };
+            await writeSecureJson(operationFile(this.appData, operationId), next);
+            return next;
+        });
+    }
+    async list() {
+        const files = await listJsonFiles(this.appData.operations);
+        const ops = [];
+        for (const file of files) {
+            const base = path.basename(file);
+            if (base.startsWith("req-"))
+                continue;
+            const rec = await readJsonIfExists(file);
+            if (rec?.operationId)
+                ops.push(rec);
+        }
+        ops.sort((a, b) => a.createdAt.localeCompare(b.createdAt));
+        return ops;
+    }
+    /**
+     * On Console boot: any non-terminal operation that cannot be proven still
+     * running becomes needs-reconcile (never invent succeeded/failed).
+     */
+    async reconcileOnBoot(options) {
+        const isAlive = options?.isProcessAlive ??
+            ((pid) => {
+                try {
+                    process.kill(pid, 0);
+                    return true;
+                }
+                catch {
+                    return false;
+                }
+            });
+        const changed = [];
+        for (const op of await this.list()) {
+            if (TERMINAL_OPERATION_STATES.has(op.state))
+                continue;
+            // A consoleUpdateAndInit whose record already proves a requested
+            // handoff died before writing its terminal state: the update and
+            // restart themselves succeeded — the booting process IS the
+            // handoff target. Mark it succeeded instead of surfacing the
+            // generic needs-reconcile failure copy to the operator.
+            if (op.action === "consoleUpdateAndInit" &&
+                op.state === "needs-reconcile" &&
+                isProvenConsoleUpdateHandoff(op.result)) {
+                changed.push(await this.update(op.operationId, {
+                    state: "succeeded",
+                    errorCode: undefined,
+                    errorMessage: undefined,
+                }));
+                continue;
+            }
+            if (op.state === "needs-reconcile")
+                continue;
+            let next;
+            if (op.state === "running" &&
+                typeof op.pid === "number" &&
+                isAlive(op.pid, op.processStartIdentity)) {
+                // still running — leave as-is
+                continue;
+            }
+            // queued/starting/running without proven process → needs-reconcile
+            next = await this.update(op.operationId, {
+                state: "needs-reconcile",
+                errorCode: "OPERATION_NEEDS_RECONCILE",
+                errorMessage: "Console restart or lost process evidence; operation needs reconcile (not cancelled)",
+            });
+            changed.push(next);
+        }
+        return changed;
+    }
+}
+export function isTerminalOperationState(state) {
+    return TERMINAL_OPERATION_STATES.has(state);
+}
+/**
+ * True when a consoleUpdateAndInit result proves the handoff was requested
+ * (install verified + init clean + new Console spawned). Used by boot
+ * reconcile to close the record as succeeded even though the old process
+ * died before writing its terminal state.
+ */
+function isProvenConsoleUpdateHandoff(result) {
+    if (!result || typeof result !== "object")
+        return false;
+    const shape = result;
+    return (shape.state === "restarting" &&
+        shape.maintenance?.handoff?.status === "requested");
+}
+export function clipPreview(text, max = 4096) {
+    if (text.length <= max)
+        return text;
+    return `${text.slice(0, max)}\n…[truncated ${text.length - max} chars]`;
+}

package/dist/infrastructure/harness/artifact-store.js

@@ -1,6 +1,6 @@
 import { mkdir } from "node:fs/promises";
 import path from "node:path";
-import { writeJsonAtomic, writeTextAtomic, } from "./atomic-write.js";
+import { writeJsonAtomic, writeBufferAtomic, writeTextAtomic, } from "./atomic-write.js";
 function resolveRepoRootFromDagRunDir(runDir) {
     const normalized = path.resolve(runDir);
     const lifecycleDir = path.dirname(normalized);
@@ -26,12 +26,16 @@ function dagWriteOptions(runDir, options) {
     return {
         repoRoot: options?.repoRoot ?? resolveRepoRootFromDagRunDir(runDir),
         allowCompletedFactsWrite: options?.allowCompletedFactsWrite,
+        mode: options?.mode,
+        directoryMode: options?.directoryMode,
     };
 }
 function pathWriteOptions(targetPath, options) {
     return {
         repoRoot: options?.repoRoot ?? resolveRepoRootFromHarnessPath(targetPath),
         allowCompletedFactsWrite: options?.allowCompletedFactsWrite,
+        mode: options?.mode,
+        directoryMode: options?.directoryMode,
     };
 }
 function completedRelocationWriteOptions(runDir) {
@@ -48,6 +52,11 @@ export async function writeDagNodeTextArtifact(runDir, nodeId, fileName, content
     await writeTextAtomic(targetPath, content, dagWriteOptions(runDir, options));
     return targetPath;
 }
+export async function writeDagNodeBufferArtifact(runDir, nodeId, fileName, bytes, options) {
+    const targetPath = path.join(runDir, nodeId, fileName);
+    await writeBufferAtomic(targetPath, bytes, dagWriteOptions(runDir, options));
+    return targetPath;
+}
 export async function writeDagNodeJsonArtifact(runDir, nodeId, fileName, value, options) {
     const targetPath = path.join(runDir, nodeId, fileName);
     await writeJsonAtomic(targetPath, value, dagWriteOptions(runDir, options));

package/dist/infrastructure/harness/atomic-write.js

@@ -30,10 +30,17 @@ async function writeAtomic(targetPath, content, options) {
     const resolved = options?.repoRoot && !path.isAbsolute(targetPath)
         ? path.resolve(options.repoRoot, targetPath)
         : path.resolve(targetPath);
-    await mkdir(path.dirname(resolved), { recursive: true });
+    await mkdir(path.dirname(resolved), {
+        recursive: true,
+        ...(options?.directoryMode !== undefined
+            ? { mode: options.directoryMode }
+            : {}),
+    });
     const tempPath = `${resolved}.${process.pid}.${(atomicWriteSequence += 1)}.tmp`;
     try {
-        await writeFile(tempPath, content, "utf-8");
+        await writeFile(tempPath, content, {
+            ...(options?.mode !== undefined ? { mode: options.mode } : {}),
+        });
         try {
             await rename(tempPath, resolved);
         }
@@ -54,6 +61,9 @@ export async function writeJsonAtomic(targetPath, value, options) {
 export async function writeTextAtomic(targetPath, text, options) {
     await writeAtomic(targetPath, text, options);
 }
+export async function writeBufferAtomic(targetPath, bytes, options) {
+    await writeAtomic(targetPath, bytes, options);
+}
 export function serializeJsonl(entries) {
     if (entries.length === 0)
         return "";

package/dist/shared/context-transfer/artifact-revision.js

@@ -0,0 +1,172 @@
+import { createHash } from "node:crypto";
+import { artifactRevisionV1Schema } from "../context-transfer.js";
+import { redactSecretsWithFindings } from "../preview.js";
+export const ARTIFACT_REVISION_LIMITS = Object.freeze({
+    singleFileBytes: 10 * 1024 * 1024,
+    diffPreviewBytes: 64 * 1024,
+});
+function sha256(bytes) {
+    return createHash("sha256").update(bytes).digest("hex");
+}
+function isTextMedia(mediaType) {
+    return mediaType.startsWith("text/") || mediaType.includes("json") || mediaType.includes("xml");
+}
+function stableJson(bytes) {
+    try {
+        const value = JSON.parse(bytes.toString("utf8"));
+        const sort = (input) => {
+            if (Array.isArray(input))
+                return input.map(sort);
+            if (input && typeof input === "object") {
+                return Object.fromEntries(Object.entries(input)
+                    .sort(([a], [b]) => a.localeCompare(b))
+                    .map(([key, child]) => [key, sort(child)]));
+            }
+            return input;
+        };
+        return `${JSON.stringify(sort(value), null, 2)}\n`;
+    }
+    catch {
+        return undefined;
+    }
+}
+function boundedLineDiff(before, after) {
+    const beforeLines = before.split(/\r?\n/);
+    const afterLines = after.split(/\r?\n/);
+    const rows = [];
+    const limit = Math.max(beforeLines.length, afterLines.length);
+    for (let index = 0; index < limit; index += 1) {
+        if (beforeLines[index] === afterLines[index])
+            continue;
+        if (beforeLines[index] !== undefined)
+            rows.push(`- ${beforeLines[index]}`);
+        if (afterLines[index] !== undefined)
+            rows.push(`+ ${afterLines[index]}`);
+    }
+    const complete = rows.join("\n");
+    const preview = Buffer.from(complete, "utf8");
+    if (preview.byteLength <= ARTIFACT_REVISION_LIMITS.diffPreviewBytes) {
+        return { summary: complete, truncated: false };
+    }
+    return {
+        summary: preview.subarray(0, ARTIFACT_REVISION_LIMITS.diffPreviewBytes).toString("utf8") + "\n[diff truncated]",
+        truncated: true,
+    };
+}
+export function validateAndDescribeArtifactRevision(input) {
+    if (input.declaration.revisionPolicy !== "replace-file") {
+        throw new Error("ARTIFACT_NOT_REVISION_ELIGIBLE");
+    }
+    if (input.candidateBytes.byteLength > ARTIFACT_REVISION_LIMITS.singleFileBytes) {
+        throw new Error("ARTIFACT_REVISION_SCHEMA_INVALID: candidate exceeds size limit");
+    }
+    if (sha256(input.parentBytes) !== input.parentSha256) {
+        throw new Error("ARTIFACT_REVISION_DRIFT: parent artifact hash mismatch");
+    }
+    if (input.mediaType !== input.declaration.mediaType) {
+        throw new Error("ARTIFACT_REVISION_SCHEMA_INVALID: media type mismatch");
+    }
+    const textCandidate = isTextMedia(input.mediaType);
+    if (textCandidate &&
+        redactSecretsWithFindings(input.candidateBytes.toString("utf8"))
+            .findingCount > 0) {
+        throw new Error("SECRET_SCAN_CONFIRMATION_REQUIRED");
+    }
+    const candidateSha256 = sha256(input.candidateBytes);
+    if (candidateSha256 === input.parentSha256) {
+        throw new Error("ARTIFACT_REVISION_SCHEMA_INVALID: replacement is unchanged");
+    }
+    let kind = "binary";
+    let summary = `binary ${input.parentBytes.byteLength} -> ${input.candidateBytes.byteLength} bytes; ${input.parentSha256} -> ${candidateSha256}`;
+    let truncated = false;
+    let diffPreview;
+    const schemaChecks = [];
+    if (input.declaration.schemaId || input.mediaType.includes("json")) {
+        const before = stableJson(input.parentBytes);
+        const after = stableJson(input.candidateBytes);
+        if (!before || !after) {
+            throw new Error("ARTIFACT_REVISION_SCHEMA_INVALID: expected valid JSON");
+        }
+        kind = "json";
+        const declaredSchemaId = input.declaration.schemaId;
+        if (declaredSchemaId) {
+            const validator = input.artifactSchemaResolver?.(declaredSchemaId);
+            if (!validator) {
+                // Fail closed (W4.3): a declared schema without a registered
+                // validator must not pass as "JSON syntax only" — revision
+                // eligibility would silently outrun actual verification.
+                throw new Error(`ARTIFACT_REVISION_SCHEMA_INVALID: no registered revision validator for ${declaredSchemaId}; artifact cannot be staged until its schema is registered`);
+            }
+            const parsed = JSON.parse(after);
+            const result = validator.safeParse(parsed);
+            if (!result.success) {
+                const issue = result.error.issues[0];
+                const issuePath = issue
+                    ? issue.path.map((part) => String(part)).join(".")
+                    : "(root)";
+                throw new Error(`ARTIFACT_REVISION_SCHEMA_INVALID: candidate does not satisfy ${declaredSchemaId} at ${issuePath}: ${issue?.message ?? "schema violation"}`);
+            }
+            schemaChecks.push({
+                id: "artifact-schema",
+                status: "pass",
+                detail: declaredSchemaId,
+            });
+        }
+        const diff = boundedLineDiff(before, after);
+        summary = diff.summary;
+        truncated = diff.truncated;
+        diffPreview = Buffer.from(diff.summary, "utf8");
+    }
+    else if (isTextMedia(input.mediaType)) {
+        kind = "text";
+        const diff = boundedLineDiff(input.parentBytes.toString("utf8"), input.candidateBytes.toString("utf8"));
+        summary = diff.summary;
+        truncated = diff.truncated;
+        diffPreview = Buffer.from(diff.summary, "utf8");
+    }
+    const revision = artifactRevisionV1Schema.parse({
+        schemaVersion: 1,
+        revisionId: input.revisionId,
+        state: "validated",
+        parent: {
+            runId: input.parentRunId,
+            nodeId: input.producerNodeId,
+            artifactPath: input.declaration.path,
+            artifactSha256: input.parentSha256,
+            ...(input.declaration.schemaId ? { artifactSchemaId: input.declaration.schemaId } : {}),
+        },
+        candidate: {
+            stagingPath: input.stagingPath,
+            sha256: candidateSha256,
+            bytes: input.candidateBytes.byteLength,
+            mediaType: input.mediaType,
+            uploadedAt: input.uploadedAt,
+            uploadedBy: "operator",
+        },
+        validation: {
+            status: "pass",
+            checks: [
+                { id: "parent-hash", status: "pass" },
+                { id: "declared-path", status: "pass" },
+                { id: "media-type", status: "pass" },
+                textCandidate
+                    ? { id: "secret-scan", status: "pass" }
+                    : {
+                        id: "secret-scan",
+                        status: "warning",
+                        detail: "binary candidate was not decoded for text secret scanning",
+                    },
+                ...(kind === "json" ? [{ id: "json-syntax", status: "pass" }] : []),
+                ...schemaChecks,
+            ],
+        },
+        diff: {
+            kind,
+            summary,
+            ...(diffPreview ? { previewPath: `artifact-revisions/${input.revisionId}/diff.txt` } : {}),
+            truncated,
+        },
+        expiresAt: input.expiresAt,
+    });
+    return { revision, ...(diffPreview ? { diffPreview } : {}) };
+}