@tea-agent/loop-agent 0.39.0-next.23 → 0.39.0-next.25

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (94) hide show
  1. package/CHANGELOG.md +3 -0
  2. package/README.md +2 -0
  3. package/dist/build-stamp.json +2 -2
  4. package/dist/executors/pi-event-serializer.js +42 -1
  5. package/dist/executors/pi-sdk-executor.js +5 -5
  6. package/dist/executors/shell-executor.js +1 -1
  7. package/dist/worker/console/pi-readiness.js +4 -4
  8. package/dist/worker/console/static/assets/{abnfDiagram-N423BO3Z-tnlecWET.js → abnfDiagram-N423BO3Z-C4kVYweA.js} +1 -1
  9. package/dist/worker/console/static/assets/{arc-LVmtsShq.js → arc-Bj2M8iO5.js} +1 -1
  10. package/dist/worker/console/static/assets/{architectureDiagram-T3A2C74G-Bot2nhjX.js → architectureDiagram-T3A2C74G-CLlXe4-6.js} +1 -1
  11. package/dist/worker/console/static/assets/{blockDiagram-VBNYF7ZC-B8wcEMRC.js → blockDiagram-VBNYF7ZC-psEp5xH0.js} +1 -1
  12. package/dist/worker/console/static/assets/{c4Diagram-5PPSVZJV-Cj4_jsBk.js → c4Diagram-5PPSVZJV-DeKcOCGJ.js} +1 -1
  13. package/dist/worker/console/static/assets/channel-CPF4N7pf.js +1 -0
  14. package/dist/worker/console/static/assets/{chunk-2GRJ4B5K-indAMcNl.js → chunk-2GRJ4B5K-K0C744p1.js} +1 -1
  15. package/dist/worker/console/static/assets/{chunk-2Q5K7J3B-BoVy7yeK.js → chunk-2Q5K7J3B-xbNw4J9-.js} +1 -1
  16. package/dist/worker/console/static/assets/{chunk-5RXB4S5H-BluRngmE.js → chunk-5RXB4S5H-DjLaSDUO.js} +1 -1
  17. package/dist/worker/console/static/assets/{chunk-5VM5RSS4-DyBfxRXh.js → chunk-5VM5RSS4-CtiPlKel.js} +1 -1
  18. package/dist/worker/console/static/assets/{chunk-6Q2QTUOP-DEQqTXL2.js → chunk-6Q2QTUOP-DZtolir7.js} +1 -1
  19. package/dist/worker/console/static/assets/{chunk-GF5L2VYU-KUGA4ndX.js → chunk-GF5L2VYU-CPcdNeew.js} +1 -1
  20. package/dist/worker/console/static/assets/{chunk-JWPE2WC7-DfXKSh2I.js → chunk-JWPE2WC7-NgHc6V37.js} +1 -1
  21. package/dist/worker/console/static/assets/{chunk-KBJHAD2P-BSnwJm3J.js → chunk-KBJHAD2P-DQ_T-hg8.js} +1 -1
  22. package/dist/worker/console/static/assets/{chunk-RYQCIY6F-DeEfgdtO.js → chunk-RYQCIY6F-DgLsxcVP.js} +1 -1
  23. package/dist/worker/console/static/assets/{chunk-XXDRQBXY-avXbO4RW.js → chunk-XXDRQBXY-UrVoM9z1.js} +1 -1
  24. package/dist/worker/console/static/assets/classDiagram-JCYQIIEL-C2DwA_Y1.js +1 -0
  25. package/dist/worker/console/static/assets/classDiagram-v2-OCEON4UE-C2DwA_Y1.js +1 -0
  26. package/dist/worker/console/static/assets/{cose-bilkent-JH36ORCC-CpfsIlv4.js → cose-bilkent-JH36ORCC-CLkYvTb3.js} +1 -1
  27. package/dist/worker/console/static/assets/{cynefin-VYW2F7L2-Bspf3ng8.js → cynefin-VYW2F7L2-BwT_xKrE.js} +1 -1
  28. package/dist/worker/console/static/assets/{cynefinDiagram-MW4NZA55-BJGfcaVQ.js → cynefinDiagram-MW4NZA55-Bi9tuzif.js} +1 -1
  29. package/dist/worker/console/static/assets/{dagre-VZM6K2ZE-DvBTZtam.js → dagre-VZM6K2ZE-BCIqkWBV.js} +1 -1
  30. package/dist/worker/console/static/assets/{diagram-7IWD3JNH-BUJCj_7u.js → diagram-7IWD3JNH-Dip6l9_Z.js} +1 -1
  31. package/dist/worker/console/static/assets/{diagram-B4RE2ZJO-CrpLm_RP.js → diagram-B4RE2ZJO-B-xkh_wK.js} +1 -1
  32. package/dist/worker/console/static/assets/{diagram-LBJQPF4R-Dt5sd0fM.js → diagram-LBJQPF4R-DZO0kTt_.js} +1 -1
  33. package/dist/worker/console/static/assets/{diagram-Q27KOJAE-FE0WGVt3.js → diagram-Q27KOJAE-D6ZplNbZ.js} +1 -1
  34. package/dist/worker/console/static/assets/{diagram-UB23O5K3-C22W8Vsw.js → diagram-UB23O5K3-BPekbhoS.js} +1 -1
  35. package/dist/worker/console/static/assets/{ebnfDiagram-BXEA7PRR-Dug0ybod.js → ebnfDiagram-BXEA7PRR-BtmaJpK5.js} +1 -1
  36. package/dist/worker/console/static/assets/{erDiagram-JOGREHBK-Muy74GVP.js → erDiagram-JOGREHBK-6DS0Xc44.js} +1 -1
  37. package/dist/worker/console/static/assets/{flowDiagram-UKHOOZJN-Dg7DfZPD.js → flowDiagram-UKHOOZJN-CihnROSm.js} +1 -1
  38. package/dist/worker/console/static/assets/{ganttDiagram-PKOTCBZU-BgDMbjEX.js → ganttDiagram-PKOTCBZU-CZC4zOE2.js} +1 -1
  39. package/dist/worker/console/static/assets/{gitGraphDiagram-DS77QQ5N-CCwz0FDR.js → gitGraphDiagram-DS77QQ5N-Dq1fhzGN.js} +1 -1
  40. package/dist/worker/console/static/assets/{index-CnJwuIKx.js → index-DTZOKgAn.js} +62 -62
  41. package/dist/worker/console/static/assets/{infoDiagram-6WML65LV-DQfSRCnK.js → infoDiagram-6WML65LV-DlSl4BGx.js} +1 -1
  42. package/dist/worker/console/static/assets/{ishikawaDiagram-WSZJBQD7-DbP56Q0A.js → ishikawaDiagram-WSZJBQD7-snnzFl_U.js} +1 -1
  43. package/dist/worker/console/static/assets/{journeyDiagram-NVQOT4AX-DnU6-oGf.js → journeyDiagram-NVQOT4AX-BDE7qpMx.js} +1 -1
  44. package/dist/worker/console/static/assets/{kanban-definition-27J2QSJJ-D20nWOTw.js → kanban-definition-27J2QSJJ-CD2Ci04G.js} +1 -1
  45. package/dist/worker/console/static/assets/{linear-BF_t08wv.js → linear-DdnapKIH.js} +1 -1
  46. package/dist/worker/console/static/assets/{mermaid.core-DTwZdcUQ.js → mermaid.core-BVjAT9b8.js} +5 -5
  47. package/dist/worker/console/static/assets/{mindmap-definition-FAOFIHXS-CgABKTml.js → mindmap-definition-FAOFIHXS-D0yJk-zA.js} +1 -1
  48. package/dist/worker/console/static/assets/{pegDiagram-VL7TDLO6-KF8xVdyI.js → pegDiagram-VL7TDLO6-BVo9tFP-.js} +1 -1
  49. package/dist/worker/console/static/assets/{pieDiagram-7S7Q4E2Y-kdvBlmug.js → pieDiagram-7S7Q4E2Y-DnOV-mZ_.js} +1 -1
  50. package/dist/worker/console/static/assets/{quadrantDiagram-CIZ2JOQS-Dz_5Gx-J.js → quadrantDiagram-CIZ2JOQS-CzUJo58i.js} +1 -1
  51. package/dist/worker/console/static/assets/{railroadDiagram-AXF67PYL-CoUkUsjS.js → railroadDiagram-AXF67PYL-Bvikrolh.js} +1 -1
  52. package/dist/worker/console/static/assets/{requirementDiagram-LRYGKXZP-Cp0SKNOb.js → requirementDiagram-LRYGKXZP-DtaSVCap.js} +1 -1
  53. package/dist/worker/console/static/assets/{sankeyDiagram-W5VNT64P-nvgfxhl4.js → sankeyDiagram-W5VNT64P-C2c9A0wW.js} +1 -1
  54. package/dist/worker/console/static/assets/{sequenceDiagram-SI44F4Z6-DUyqpiIH.js → sequenceDiagram-SI44F4Z6-DmXJcU7r.js} +1 -1
  55. package/dist/worker/console/static/assets/{sizeCapture-X5ZJPWSS-FCodLTFq.js → sizeCapture-X5ZJPWSS-B4GUFW92.js} +1 -1
  56. package/dist/worker/console/static/assets/{stateDiagram-OKZ733FA-NVAbafR9.js → stateDiagram-OKZ733FA-Dsad2MXf.js} +1 -1
  57. package/dist/worker/console/static/assets/stateDiagram-v2-UEYNNEHI-B8FB_cNk.js +1 -0
  58. package/dist/worker/console/static/assets/{swimlanes-SLNWSIFB-H29rigTf.js → swimlanes-SLNWSIFB-DGq48Fbi.js} +2 -2
  59. package/dist/worker/console/static/assets/swimlanesDiagram-ULZ7WXOC-CrZYaWfx.js +8 -0
  60. package/dist/worker/console/static/assets/{timeline-definition-Z64GVDOM-CNFQjoyV.js → timeline-definition-Z64GVDOM-CSSi6OFf.js} +1 -1
  61. package/dist/worker/console/static/assets/{vennDiagram-T6HMQDX7-BWf8nCZL.js → vennDiagram-T6HMQDX7-BqyzPrWv.js} +1 -1
  62. package/dist/worker/console/static/assets/{wardleyDiagram-T6FBY63Y-D58QQyvD.js → wardleyDiagram-T6FBY63Y-DlznVb6S.js} +1 -1
  63. package/dist/worker/console/static/assets/{xychartDiagram-ELKLHX3M-DjF1qJhp.js → xychartDiagram-ELKLHX3M-CfBcgJ_K.js} +1 -1
  64. package/dist/worker/console/static/index.html +1 -1
  65. package/dist/workflows/dag/backend-test-case-coverage-analysis.js +54 -2
  66. package/dist/workflows/dag/backend-test-scenario-partitions.js +73 -1
  67. package/dist/workflows/dag/init-hybrid.js +2 -2
  68. package/docs/operations/local-development-environment.md +1 -5
  69. package/docs/skills/vetted-skill-registry.md +14 -0
  70. package/docs/templates/README.md +1 -1
  71. package/docs/templates/backend-test-dag.json +2 -2
  72. package/package.json +8 -4
  73. package/skills/analyze-product-requirements/SKILL.md +8 -5
  74. package/skills/analyze-product-requirements/references/acceptance-criteria.md +1 -1
  75. package/skills/analyze-product-requirements/references/clarification-and-knowledge.md +10 -6
  76. package/skills/analyze-product-requirements/references/example.md +50 -0
  77. package/skills/analyze-product-requirements/references/forward-test-cases.md +11 -7
  78. package/skills/analyze-product-requirements/references/kb-integration.md +5 -5
  79. package/skills/analyze-product-requirements/references/product-analysis-schema.md +8 -4
  80. package/skills/analyze-product-requirements/references/product-requirement-schema.md +2 -2
  81. package/skills/analyze-product-requirements/references/requirement-clarification-schema.md +1 -1
  82. package/skills/analyze-product-requirements/scripts/test-validators.mjs +11 -1
  83. package/skills/analyze-product-requirements/scripts/validate-product-analysis.mjs +20 -1
  84. package/skills/analyze-product-requirements/scripts/validate-requirement-clarification.mjs +9 -0
  85. package/skills/improve-codebase-architecture/SKILL.md +81 -0
  86. package/skills/improve-codebase-architecture/deepening.md +37 -0
  87. package/skills/improve-codebase-architecture/html-report.md +123 -0
  88. package/skills/improve-codebase-architecture/interface-design.md +44 -0
  89. package/skills/improve-codebase-architecture/language.md +53 -0
  90. package/dist/worker/console/static/assets/channel-Bor-DZxZ.js +0 -1
  91. package/dist/worker/console/static/assets/classDiagram-JCYQIIEL-Cztq0Lcf.js +0 -1
  92. package/dist/worker/console/static/assets/classDiagram-v2-OCEON4UE-Cztq0Lcf.js +0 -1
  93. package/dist/worker/console/static/assets/stateDiagram-v2-UEYNNEHI-j9D1xnHc.js +0 -1
  94. package/dist/worker/console/static/assets/swimlanesDiagram-ULZ7WXOC-DQ4huT5W.js +0 -8
@@ -54,11 +54,30 @@ const inferenceLines = contentLines(inferences);
54
54
  const questionLines = contentLines(questions);
55
55
  const noInferenceSentinel = /^-\s*无未确认的推断需求[。.]?$/.test(inferenceLines[0] ?? "");
56
56
  const noQuestionSentinel = /^-\s*无待确认问题[。.]?$/.test(questionLines[0] ?? "");
57
- const unexpectedQuestionLines = questionLines.slice(1).filter((line) => !/^-\s*理由[::]\s*\S/.test(line));
57
+ const unexpectedQuestionLines = questionLines.slice(1).filter((line) => !/^-\s*理由[::]\s*\S/.test(line) && !/^-\s*一致性核对[::]\s*\S/.test(line));
58
58
  if (status === "no-clarification-required" && (!noInferenceSentinel || inferenceLines.length !== 1)) errors.push("no-clarification-required analysis must declare no unconfirmed inferred requirements.");
59
59
  if (status === "no-clarification-required" && (!noQuestionSentinel || unexpectedQuestionLines.length)) errors.push("no-clarification-required analysis must declare no pending questions.");
60
60
  if (status === "no-clarification-required" && /(?:\bQ-\d{3,}\b|\bBR-\d{3,}\b|\bP[012]\b|[??])/.test(questions)) errors.push("no-clarification-required analysis cannot contain question markers, priorities, branches, or question sentences.");
61
61
  if (status === "ready-for-clarification" && !/(?:\bP[012]\b|[??])/.test(questions)) errors.push("ready-for-clarification analysis must contain at least one prioritized or explicit question.");
62
+ // 「输入↔规范一致性核对」检查:事实行格式、冲突标记与待确认问题引用
63
+ const factLines = facts.split(/\r?\n/).filter((line) => /^[ \t]*-[ \t]*(?:KB|CODE)-FACT-\d+\b/.test(line));
64
+ for (const line of factLines) {
65
+ const id = line.match(/\b(?:KB|CODE)-FACT-\d+\b/)?.[0];
66
+ if (!/与输入关系[::]\s*(?:一致|补充|冲突)/.test(line)) errors.push(`${id} must declare 与输入关系:一致|补充|冲突.`);
67
+ if (/^[ \t]*-[ \t]*CODE-FACT-\d+\b/.test(line) && !/证据类别[::]\s*(?:项目规范|代码现状)/.test(line)) errors.push(`${id} must declare 证据类别:项目规范|代码现状.`);
68
+ }
69
+ const conflictFactIds = factLines.filter((line) => /与输入关系[::]\s*冲突/.test(line)).map((line) => line.match(/\b(?:KB|CODE)-FACT-\d+\b/)?.[0]);
70
+ for (const id of conflictFactIds) {
71
+ if (!questions.includes(id)) errors.push(`${id} is marked 与输入关系:冲突 but is not referenced by 待确认问题.`);
72
+ }
73
+ const citedConflictIds = [...(questions.match(/冲突来源[::][^\n]*/g) ?? [])].flatMap((line) => line.match(/\b(?:KB|CODE)-FACT-\d+\b/g) ?? []);
74
+ for (const id of citedConflictIds) {
75
+ if (!conflictFactIds.includes(id)) errors.push(`${id} cited as 冲突来源 but its fact is not marked 与输入关系:冲突.`);
76
+ }
77
+ if (status === "no-clarification-required") {
78
+ if (conflictFactIds.length > 0) errors.push("no-clarification-required analysis cannot contain facts marked 与输入关系:冲突.");
79
+ if (!/^[ \t]*-[ \t]*一致性核对[::][^\n]*未发现冲突条目/m.test(questions)) errors.push("no-clarification-required analysis must record a 一致性核对 line stating no conflicts found.");
80
+ }
62
81
  if (/\bAC-(?:FE|BE)-\d{3,}\b|^Given[::]|^When[::]|^Then[::]/m.test(text)) errors.push("Product Analysis must use acceptance concerns, not formal AC IDs or Given/When/Then blocks.");
63
82
  if (/^##\s+(?:\d+[.、]?\s*)?(?:用户角色|初步验收标准汇总)\s*$/m.test(text)) errors.push("Product Analysis must not contain standalone 用户角色 or 初步验收标准汇总 sections.");
64
83
 
@@ -104,6 +104,15 @@ if (!questionBlocks.length) {
104
104
  if (status === "complete" && !/^[ \t]*-[ \t]*共同理解[::][ \t]*已确认\s*$/m.test(section(clarification.text, 2, "决策索引") ?? "")) {
105
105
  errors.push("Complete question-based clarification must record 共同理解:已确认 in 决策索引.");
106
106
  }
107
+ // 「输入↔规范一致性核对」闭环:PA 待确认问题的冲突事实必须被 Q-* 覆盖
108
+ const analysisAnalysis = section(analysis.text, 2, "需求分析") ?? "";
109
+ const paQuestions = section(analysisAnalysis, 3, "待确认问题") ?? "";
110
+ const paConflictIds = [...(paQuestions.match(/冲突来源[::][^\n]*/g) ?? [])].flatMap((line) => line.match(/\b(?:KB|CODE)-FACT-\d+\b/g) ?? []);
111
+ for (const id of [...new Set(paConflictIds)]) {
112
+ const covering = questionBlocks.filter((block) => block.text.includes(id));
113
+ if (!covering.length) errors.push(`${id} referenced by Product Analysis pending questions must be covered by a Q-* record.`);
114
+ else if (status === "complete" && !covering.some((block) => (field(block.text, "状态") ?? "") === "confirmed")) errors.push(`${id} must be confirmed by an explicit user answer before clarification can be complete.`);
115
+ }
107
116
  }
108
117
 
109
118
  printResult("Requirement Clarification", clarification.path, errors);
@@ -0,0 +1,81 @@
1
+ ---
2
+ name: improve-codebase-architecture
3
+ description: Find deepening opportunities in a codebase, informed by the domain language in CONTEXT.md and the decisions in docs/adr/. Use when the user wants to improve architecture, find refactoring opportunities, consolidate tightly-coupled modules, or make a codebase more testable and AI-navigable.
4
+ ---
5
+
6
+ # Improve Codebase Architecture
7
+
8
+ Surface architectural friction and propose **deepening opportunities** — refactors that turn shallow modules into deep ones. The aim is testability and AI-navigability.
9
+
10
+ ## Glossary
11
+
12
+ Use these terms exactly in every suggestion. Consistent language is the point — don't drift into "component," "service," "API," or "boundary." Full definitions in [language.md](language.md).
13
+
14
+ - **Module** — anything with an interface and an implementation (function, class, package, slice).
15
+ - **Interface** — everything a caller must know to use the module: types, invariants, error modes, ordering, config. Not just the type signature.
16
+ - **Implementation** — the code inside.
17
+ - **Depth** — leverage at the interface: a lot of behaviour behind a small interface. **Deep** = high leverage. **Shallow** = interface nearly as complex as the implementation.
18
+ - **Seam** — where an interface lives; a place behaviour can be altered without editing in place. (Use this, not "boundary.")
19
+ - **Adapter** — a concrete thing satisfying an interface at a seam.
20
+ - **Leverage** — what callers get from depth.
21
+ - **Locality** — what maintainers get from depth: change, bugs, knowledge concentrated in one place.
22
+
23
+ Key principles (see [language.md](language.md) for the full list):
24
+
25
+ - **Deletion test**: imagine deleting the module. If complexity vanishes, it was a pass-through. If complexity reappears across N callers, it was earning its keep.
26
+ - **The interface is the test surface.**
27
+ - **One adapter = hypothetical seam. Two adapters = real seam.**
28
+
29
+ This skill is _informed_ by the project's domain model. The domain language gives names to good seams; ADRs record decisions the skill should not re-litigate.
30
+
31
+ ## Process
32
+
33
+ ### 1. Explore
34
+
35
+ Read the project's domain glossary and any ADRs in the area you're touching first.
36
+
37
+ Then use the Agent tool with `subagent_type=Explore` to walk the codebase. Don't follow rigid heuristics — explore organically and note where you experience friction:
38
+
39
+ - Where does understanding one concept require bouncing between many small modules?
40
+ - Where are modules **shallow** — interface nearly as complex as the implementation?
41
+ - Where have pure functions been extracted just for testability, but the real bugs hide in how they're called (no **locality**)?
42
+ - Where do tightly-coupled modules leak across their seams?
43
+ - Which parts of the codebase are untested, or hard to test through their current interface?
44
+
45
+ Apply the **deletion test** to anything you suspect is shallow: would deleting it concentrate complexity, or just move it? A "yes, concentrates" is the signal you want.
46
+
47
+ ### 2. Present candidates as an HTML report
48
+
49
+ Write a self-contained HTML file to the OS temp directory so nothing lands in the repo. Resolve the temp dir from `$TMPDIR`, falling back to `/tmp` (or `%TEMP%` on Windows), and write to `<tmpdir>/architecture-review-<timestamp>.html` so each run gets a fresh file. Open it for the user — `xdg-open <path>` on Linux, `open <path>` on macOS, `start <path>` on Windows — and tell them the absolute path.
50
+
51
+ The report uses **Tailwind via CDN** for layout and styling, and **Mermaid via CDN** for diagrams where a graph/flow/sequence reliably communicates the structure. Mix Mermaid with hand-crafted CSS/SVG visuals — use Mermaid when relationships are graph-shaped (call graphs, dependencies, sequences), and hand-built divs/SVG when you want something more editorial (mass diagrams, cross-sections, collapse animations). Each candidate gets a **before/after visualisation**. Be visual.
52
+
53
+ For each candidate, the same template as before, but rendered as a card:
54
+
55
+ - **Files** — which files/modules are involved
56
+ - **Problem** — why the current architecture is causing friction
57
+ - **Solution** — plain English description of what would change
58
+ - **Benefits** — explained in terms of locality and leverage, and how tests would improve
59
+ - **Before / After diagram** — side-by-side, custom-drawn, illustrating the shallowness and the deepening
60
+ - **Recommendation strength** — one of `Strong`, `Worth exploring`, `Speculative`, rendered as a badge
61
+
62
+ End the report with a **Top recommendation** section: which candidate you'd tackle first and why.
63
+
64
+ **Use CONTEXT.md vocabulary for the domain, and [language.md](language.md) vocabulary for the architecture.** If `CONTEXT.md` defines "Order," talk about "the Order intake module" — not "the FooBarHandler," and not "the Order service."
65
+
66
+ **ADR conflicts**: if a candidate contradicts an existing ADR, only surface it when the friction is real enough to warrant revisiting the ADR. Mark it clearly in the card (e.g. a warning callout: _"contradicts ADR-0007 — but worth reopening because…"_). Don't list every theoretical refactor an ADR forbids.
67
+
68
+ See [html-report.md](html-report.md) for the full HTML scaffold, diagram patterns, and styling guidance.
69
+
70
+ Do NOT propose interfaces yet. After the file is written, ask the user: "Which of these would you like to explore?"
71
+
72
+ ### 3. Grilling loop
73
+
74
+ Once the user picks a candidate, drop into a grilling conversation. Walk the design tree with them — constraints, dependencies, the shape of the deepened module, what sits behind the seam, what tests survive.
75
+
76
+ Side effects happen inline as decisions crystallize:
77
+
78
+ - **Naming a deepened module after a concept not in `CONTEXT.md`?** Add the term to `CONTEXT.md` — same discipline as `/grill-with-docs` (see [context-format.md](../grill-with-docs/context-format.md)). Create the file lazily if it doesn't exist.
79
+ - **Sharpening a fuzzy term during the conversation?** Update `CONTEXT.md` right there.
80
+ - **User rejects the candidate with a load-bearing reason?** Offer an ADR, framed as: _"Want me to record this as an ADR so future architecture reviews don't re-suggest it?"_ Only offer when the reason would actually be needed by a future explorer to avoid re-suggesting the same thing — skip ephemeral reasons ("not worth it right now") and self-evident ones. See [adr-format.md](../grill-with-docs/adr-format.md).
81
+ - **Want to explore alternative interfaces for the deepened module?** See [interface-design.md](interface-design.md).
@@ -0,0 +1,37 @@
1
+ # Deepening
2
+
3
+ How to deepen a cluster of shallow modules safely, given its dependencies. Assumes the vocabulary in [language.md](language.md) — **module**, **interface**, **seam**, **adapter**.
4
+
5
+ ## Dependency categories
6
+
7
+ When assessing a candidate for deepening, classify its dependencies. The category determines how the deepened module is tested across its seam.
8
+
9
+ ### 1. In-process
10
+
11
+ Pure computation, in-memory state, no I/O. Always deepenable — merge the modules and test through the new interface directly. No adapter needed.
12
+
13
+ ### 2. Local-substitutable
14
+
15
+ Dependencies that have local test stand-ins (PGLite for Postgres, in-memory filesystem). Deepenable if the stand-in exists. The deepened module is tested with the stand-in running in the test suite. The seam is internal; no port at the module's external interface.
16
+
17
+ ### 3. Remote but owned (Ports & Adapters)
18
+
19
+ Your own services across a network boundary (microservices, internal APIs). Define a **port** (interface) at the seam. The deep module owns the logic; the transport is injected as an **adapter**. Tests use an in-memory adapter. Production uses an HTTP/gRPC/queue adapter.
20
+
21
+ Recommendation shape: *"Define a port at the seam, implement an HTTP adapter for production and an in-memory adapter for testing, so the logic sits in one deep module even though it's deployed across a network."*
22
+
23
+ ### 4. True external (Mock)
24
+
25
+ Third-party services (Stripe, Twilio, etc.) you don't control. The deepened module takes the external dependency as an injected port; tests provide a mock adapter.
26
+
27
+ ## Seam discipline
28
+
29
+ - **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a port unless at least two adapters are justified (typically production + test). A single-adapter seam is just indirection.
30
+ - **Internal seams vs external seams.** A deep module can have internal seams (private to its implementation, used by its own tests) as well as the external seam at its interface. Don't expose internal seams through the interface just because tests use them.
31
+
32
+ ## Testing strategy: replace, don't layer
33
+
34
+ - Old unit tests on shallow modules become waste once tests at the deepened module's interface exist — delete them.
35
+ - Write new tests at the deepened module's interface. The **interface is the test surface**.
36
+ - Tests assert on observable outcomes through the interface, not internal state.
37
+ - Tests should survive internal refactors — they describe behaviour, not implementation. If a test has to change when the implementation changes, it's testing past the interface.
@@ -0,0 +1,123 @@
1
+ # HTML Report Format
2
+
3
+ The architectural review is rendered as a single self-contained HTML file in the OS temp directory. Tailwind and Mermaid both come from CDNs. Mermaid handles graph-shaped diagrams reliably; hand-built divs and inline SVG handle the more editorial visuals (mass diagrams, cross-sections). Mix the two — don't lean on Mermaid for everything, it'll start to look generic.
4
+
5
+ ## Scaffold
6
+
7
+ ```html
8
+ <!doctype html>
9
+ <html lang="en">
10
+ <head>
11
+ <meta charset="utf-8" />
12
+ <title>Architecture review — {{repo name}}</title>
13
+ <script src="https://cdn.tailwindcss.com"></script>
14
+ <script type="module">
15
+ import mermaid from "https://cdn.jsdelivr.net/npm/mermaid@11/dist/mermaid.esm.min.mjs";
16
+ mermaid.initialize({ startOnLoad: true, theme: "neutral", securityLevel: "loose" });
17
+ </script>
18
+ <style>
19
+ /* small custom layer for things Tailwind doesn't cover cleanly:
20
+ dashed seam lines, hand-drawn-feeling arrow heads, etc. */
21
+ .seam { stroke-dasharray: 4 4; }
22
+ .leak { stroke: #dc2626; }
23
+ .deep { background: linear-gradient(135deg, #0f172a, #1e293b); }
24
+ </style>
25
+ </head>
26
+ <body class="bg-stone-50 text-slate-900 font-sans">
27
+ <main class="max-w-5xl mx-auto px-6 py-12 space-y-12">
28
+ <header>...</header>
29
+ <section id="candidates" class="space-y-10">...</section>
30
+ <section id="top-recommendation">...</section>
31
+ </main>
32
+ </body>
33
+ </html>
34
+ ```
35
+
36
+ ## Header
37
+
38
+ Repo name, date, and a compact legend: solid box = module, dashed line = seam, red arrow = leakage, thick dark box = deep module. No introduction paragraph — straight into the candidates.
39
+
40
+ ## Candidate card
41
+
42
+ The diagrams carry the weight. Prose is sparse, plain, and uses the glossary terms ([language.md](language.md)) without ceremony.
43
+
44
+ Each candidate is one `<article>`:
45
+
46
+ - **Title** — short, names the deepening (e.g. "Collapse the Order intake pipeline").
47
+ - **Badge row** — recommendation strength (`Strong` = emerald, `Worth exploring` = amber, `Speculative` = slate), plus a tag for the dependency category (`in-process`, `local-substitutable`, `ports & adapters`, `mock`).
48
+ - **Files** — monospaced list, `font-mono text-sm`.
49
+ - **Before / After diagram** — the centrepiece. Two columns, side by side. See patterns below.
50
+ - **Problem** — one sentence. What hurts.
51
+ - **Solution** — one sentence. What changes.
52
+ - **Wins** — bullets, ≤6 words each. e.g. "Tests hit one interface", "Pricing logic stops leaking", "Delete 4 shallow wrappers".
53
+ - **ADR callout** (if applicable) — one line in an amber-tinted box.
54
+
55
+ No paragraphs of explanation. If the diagram needs a paragraph to be understood, redraw the diagram.
56
+
57
+ ## Diagram patterns
58
+
59
+ Pick the pattern that fits the candidate. Mix them. Don't make every diagram look the same — variety is part of the point.
60
+
61
+ ### Mermaid graph (the workhorse for dependencies / call flow)
62
+
63
+ Use a Mermaid `flowchart` or `graph` when the point is "X calls Y calls Z, and look at the mess." Wrap it in a Tailwind-styled card so it doesn't feel parachuted in. Style with classDef to colour leakage edges red and the deep module dark. Sequence diagrams work well for "before: 6 round-trips; after: 1."
64
+
65
+ ```html
66
+ <div class="rounded-lg border border-slate-200 bg-white p-4">
67
+ <pre class="mermaid">
68
+ flowchart LR
69
+ A[OrderHandler] --> B[OrderValidator]
70
+ B --> C[OrderRepo]
71
+ C -.leak.-> D[PricingClient]
72
+ classDef leak stroke:#dc2626,stroke-width:2px;
73
+ class C,D leak
74
+ </pre>
75
+ </div>
76
+ ```
77
+
78
+ ### Hand-built boxes-and-arrows (when Mermaid's layout fights you)
79
+
80
+ Modules as `<div>`s with borders and labels. Arrows as inline SVG `<line>` or `<path>` elements positioned absolutely over a relative container. Reach for this when you want the "after" diagram to feel like one thick-bordered deep module with greyed-out internals — Mermaid won't render that with the right weight.
81
+
82
+ ### Cross-section (good for layered shallowness)
83
+
84
+ Stack horizontal bands (`h-12 border-l-4`) to show layers a call passes through. Before: 6 thin layers each doing nothing. After: 1 thick band labelled with the consolidated responsibility.
85
+
86
+ ### Mass diagram (good for "interface as wide as implementation")
87
+
88
+ Two rectangles per module — one for interface surface area, one for implementation. Before: interface rectangle is nearly as tall as the implementation rectangle (shallow). After: interface rectangle is short, implementation rectangle is tall (deep).
89
+
90
+ ### Call-graph collapse
91
+
92
+ Before: a tree of function calls rendered as nested boxes. After: the same tree collapsed into one box, with the now-internal calls shown faded inside it.
93
+
94
+ ## Style guidance
95
+
96
+ - Lean editorial, not corporate-dashboard. Generous whitespace. Serif optional for headings (`font-serif` works well with stone/slate).
97
+ - Colour sparingly: one accent (emerald or indigo) plus red for leakage and amber for warnings.
98
+ - Keep diagrams ~320px tall so before/after sits comfortably side by side without scrolling.
99
+ - Use `text-xs uppercase tracking-wider` for module labels inside diagrams — they should read as schematic, not as UI.
100
+ - The only scripts are the Tailwind CDN and the Mermaid ESM import. The report is otherwise static — no app code, no interactivity beyond Mermaid's own rendering.
101
+
102
+ ## Top recommendation section
103
+
104
+ One larger card. Candidate name, one sentence on why, anchor link to its card. That's it.
105
+
106
+ ## Tone
107
+
108
+ Plain English, concise — but the architectural nouns and verbs come straight from [language.md](language.md). Concision is not an excuse to drift.
109
+
110
+ **Use exactly:** module, interface, implementation, depth, deep, shallow, seam, adapter, leverage, locality.
111
+
112
+ **Never substitute:** component, service, unit (for module) · API, signature (for interface) · boundary (for seam) · layer, wrapper (for module, when you mean module).
113
+
114
+ **Phrasings that fit the style:**
115
+
116
+ - "Order intake module is shallow — interface nearly matches the implementation."
117
+ - "Pricing leaks across the seam."
118
+ - "Deepen: one interface, one place to test."
119
+ - "Two adapters justify the seam: HTTP in prod, in-memory in tests."
120
+
121
+ **Wins bullets** name the gain in glossary terms: *"locality: bugs concentrate in one module"*, *"leverage: one interface, N call sites"*, *"interface shrinks; implementation absorbs the wrappers"*. Don't write *"easier to maintain"* or *"cleaner code"* — those terms aren't in the glossary and don't earn their place.
122
+
123
+ No hedging, no throat-clearing, no "it's worth noting that…". If a sentence could be a bullet, make it a bullet. If a bullet could be cut, cut it. If a term isn't in [language.md](language.md), reach for one that is before inventing a new one.
@@ -0,0 +1,44 @@
1
+ # Interface Design
2
+
3
+ When the user wants to explore alternative interfaces for a chosen deepening candidate, use this parallel sub-agent pattern. Based on "Design It Twice" (Ousterhout) — your first idea is unlikely to be the best.
4
+
5
+ Uses the vocabulary in [language.md](language.md) — **module**, **interface**, **seam**, **adapter**, **leverage**.
6
+
7
+ ## Process
8
+
9
+ ### 1. Frame the problem space
10
+
11
+ Before spawning sub-agents, write a user-facing explanation of the problem space for the chosen candidate:
12
+
13
+ - The constraints any new interface would need to satisfy
14
+ - The dependencies it would rely on, and which category they fall into (see [deepening.md](deepening.md))
15
+ - A rough illustrative code sketch to ground the constraints — not a proposal, just a way to make the constraints concrete
16
+
17
+ Show this to the user, then immediately proceed to Step 2. The user reads and thinks while the sub-agents work in parallel.
18
+
19
+ ### 2. Spawn sub-agents
20
+
21
+ Spawn 3+ sub-agents in parallel using the Agent tool. Each must produce a **radically different** interface for the deepened module.
22
+
23
+ Prompt each sub-agent with a separate technical brief (file paths, coupling details, dependency category from [deepening.md](deepening.md), what sits behind the seam). The brief is independent of the user-facing problem-space explanation in Step 1. Give each agent a different design constraint:
24
+
25
+ - Agent 1: "Minimize the interface — aim for 1–3 entry points max. Maximise leverage per entry point."
26
+ - Agent 2: "Maximise flexibility — support many use cases and extension."
27
+ - Agent 3: "Optimise for the most common caller — make the default case trivial."
28
+ - Agent 4 (if applicable): "Design around ports & adapters for cross-seam dependencies."
29
+
30
+ Include both [language.md](language.md) vocabulary and CONTEXT.md vocabulary in the brief so each sub-agent names things consistently with the architecture language and the project's domain language.
31
+
32
+ Each sub-agent outputs:
33
+
34
+ 1. Interface (types, methods, params — plus invariants, ordering, error modes)
35
+ 2. Usage example showing how callers use it
36
+ 3. What the implementation hides behind the seam
37
+ 4. Dependency strategy and adapters (see [deepening.md](deepening.md))
38
+ 5. Trade-offs — where leverage is high, where it's thin
39
+
40
+ ### 3. Present and compare
41
+
42
+ Present designs sequentially so the user can absorb each one, then compare them in prose. Contrast by **depth** (leverage at the interface), **locality** (where change concentrates), and **seam placement**.
43
+
44
+ After comparing, give your own recommendation: which design you think is strongest and why. If elements from different designs would combine well, propose a hybrid. Be opinionated — the user wants a strong read, not a menu.
@@ -0,0 +1,53 @@
1
+ # Language
2
+
3
+ Shared vocabulary for every suggestion this skill makes. Use these terms exactly — don't substitute "component," "service," "API," or "boundary." Consistent language is the whole point.
4
+
5
+ ## Terms
6
+
7
+ **Module**
8
+ Anything with an interface and an implementation. Deliberately scale-agnostic — applies equally to a function, class, package, or tier-spanning slice.
9
+ _Avoid_: unit, component, service.
10
+
11
+ **Interface**
12
+ Everything a caller must know to use the module correctly. Includes the type signature, but also invariants, ordering constraints, error modes, required configuration, and performance characteristics.
13
+ _Avoid_: API, signature (too narrow — those refer only to the type-level surface).
14
+
15
+ **Implementation**
16
+ What's inside a module — its body of code. Distinct from **Adapter**: a thing can be a small adapter with a large implementation (a Postgres repo) or a large adapter with a small implementation (an in-memory fake). Reach for "adapter" when the seam is the topic; "implementation" otherwise.
17
+
18
+ **Depth**
19
+ Leverage at the interface — the amount of behaviour a caller (or test) can exercise per unit of interface they have to learn. A module is **deep** when a large amount of behaviour sits behind a small interface. A module is **shallow** when the interface is nearly as complex as the implementation.
20
+
21
+ **Seam** _(from Michael Feathers)_
22
+ A place where you can alter behaviour without editing in that place. The *location* at which a module's interface lives. Choosing where to put the seam is its own design decision, distinct from what goes behind it.
23
+ _Avoid_: boundary (overloaded with DDD's bounded context).
24
+
25
+ **Adapter**
26
+ A concrete thing that satisfies an interface at a seam. Describes *role* (what slot it fills), not substance (what's inside).
27
+
28
+ **Leverage**
29
+ What callers get from depth. More capability per unit of interface they have to learn. One implementation pays back across N call sites and M tests.
30
+
31
+ **Locality**
32
+ What maintainers get from depth. Change, bugs, knowledge, and verification concentrate at one place rather than spreading across callers. Fix once, fixed everywhere.
33
+
34
+ ## Principles
35
+
36
+ - **Depth is a property of the interface, not the implementation.** A deep module can be internally composed of small, mockable, swappable parts — they just aren't part of the interface. A module can have **internal seams** (private to its implementation, used by its own tests) as well as the **external seam** at its interface.
37
+ - **The deletion test.** Imagine deleting the module. If complexity vanishes, the module wasn't hiding anything (it was a pass-through). If complexity reappears across N callers, the module was earning its keep.
38
+ - **The interface is the test surface.** Callers and tests cross the same seam. If you want to test *past* the interface, the module is probably the wrong shape.
39
+ - **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a seam unless something actually varies across it.
40
+
41
+ ## Relationships
42
+
43
+ - A **Module** has exactly one **Interface** (the surface it presents to callers and tests).
44
+ - **Depth** is a property of a **Module**, measured against its **Interface**.
45
+ - A **Seam** is where a **Module**'s **Interface** lives.
46
+ - An **Adapter** sits at a **Seam** and satisfies the **Interface**.
47
+ - **Depth** produces **Leverage** for callers and **Locality** for maintainers.
48
+
49
+ ## Rejected framings
50
+
51
+ - **Depth as ratio of implementation-lines to interface-lines** (Ousterhout): rewards padding the implementation. We use depth-as-leverage instead.
52
+ - **"Interface" as the TypeScript `interface` keyword or a class's public methods**: too narrow — interface here includes every fact a caller must know.
53
+ - **"Boundary"**: overloaded with DDD's bounded context. Say **seam** or **interface**.
@@ -1 +0,0 @@
1
- import{ag as o,ah as n}from"./mermaid.core-DTwZdcUQ.js";const t=(a,r)=>o.lang.round(n.parse(a)[r]);export{t as c};
@@ -1 +0,0 @@
1
- import{s as a,c as s,a as e,C as t}from"./chunk-GF5L2VYU-KUGA4ndX.js";import{_ as i}from"./mermaid.core-DTwZdcUQ.js";import"./chunk-5VM5RSS4-DyBfxRXh.js";import"./chunk-XXDRQBXY-avXbO4RW.js";import"./chunk-KBJHAD2P-BSnwJm3J.js";import"./chunk-2GRJ4B5K-indAMcNl.js";import"./index-CnJwuIKx.js";var n={parser:e,get db(){return new t},renderer:s,styles:a,init:i(r=>{r.class||(r.class={}),r.class.arrowMarkerAbsolute=r.arrowMarkerAbsolute},"init")};export{n as diagram};
@@ -1 +0,0 @@
1
- import{s as a,c as s,a as e,C as t}from"./chunk-GF5L2VYU-KUGA4ndX.js";import{_ as i}from"./mermaid.core-DTwZdcUQ.js";import"./chunk-5VM5RSS4-DyBfxRXh.js";import"./chunk-XXDRQBXY-avXbO4RW.js";import"./chunk-KBJHAD2P-BSnwJm3J.js";import"./chunk-2GRJ4B5K-indAMcNl.js";import"./index-CnJwuIKx.js";var n={parser:e,get db(){return new t},renderer:s,styles:a,init:i(r=>{r.class||(r.class={}),r.class.arrowMarkerAbsolute=r.arrowMarkerAbsolute},"init")};export{n as diagram};
@@ -1 +0,0 @@
1
- import{s as r,b as e,a,S as s}from"./chunk-5RXB4S5H-BluRngmE.js";import{_ as i}from"./mermaid.core-DTwZdcUQ.js";import"./chunk-XXDRQBXY-avXbO4RW.js";import"./chunk-KBJHAD2P-BSnwJm3J.js";import"./chunk-2GRJ4B5K-indAMcNl.js";import"./index-CnJwuIKx.js";var u={parser:a,get db(){return new s(2)},renderer:e,styles:r,init:i(t=>{t.state||(t.state={}),t.state.arrowMarkerAbsolute=t.arrowMarkerAbsolute},"init")};export{u as diagram};
@@ -1,8 +0,0 @@
1
- import{c as r,s as e}from"./flowDiagram-UKHOOZJN-Dg7DfZPD.js";import{_ as a}from"./mermaid.core-DTwZdcUQ.js";import"./chunk-5VM5RSS4-DyBfxRXh.js";import"./chunk-XXDRQBXY-avXbO4RW.js";import"./chunk-KBJHAD2P-BSnwJm3J.js";import"./chunk-2GRJ4B5K-indAMcNl.js";import"./channel-Bor-DZxZ.js";import"./index-CnJwuIKx.js";var o=a(t=>`${e(t)}
2
- .swimlane.cluster rect {
3
- stroke: ${t.clusterBorder} !important;
4
- }
5
- [data-look="neo"].cluster rect {
6
- filter: none;
7
- }
8
- `,"getStyles"),s=o,n=r({defaultLayout:"swimlane",styles:s});export{n as diagram};