@tea-agent/loop-agent 0.32.0 → 0.33.0

package/dist/worker/observe/static/views/dag-inspector.js

@@ -36,6 +36,7 @@ import {
 	formatSessionEventTime,
 	renderSessionTimeline,
 } from "./session-timeline.js";
+import { createCustomSelect } from "../custom-select.js";
 
 // Current inspector selection. Tab handlers reference this mutable slot so a
 // reused inspector shell never keeps stale node closures: every render writes
@@ -1189,24 +1190,26 @@ function buildAttemptBar(dagRunId, node) {
 
 	const bar = el("div", "dag-inspector-attempt-bar");
 	bar.appendChild(el("label", "dag-inspector-attempt-label", "执行分次"));
-	const select = document.createElement("select");
-	select.className = "dag-inspector-attempt-select";
-	select.setAttribute("aria-label", "选择执行分次");
-	for (const option of options) {
-		const optionEl = document.createElement("option");
-		optionEl.value = option.key;
-		optionEl.textContent = option.label;
-		select.appendChild(optionEl);
-	}
-	select.value = selectedKey;
-	select.addEventListener("change", () => {
-		uiState.dagInspectorAttempt = {
-			dagRunId,
-			nodeId: node.nodeId,
-			key: select.value,
-		};
-		renderDagInspectorForCurrent();
+	const select = createCustomSelect({
+		ariaLabel: "选择执行分次",
+		className: "dag-inspector-attempt-select",
+		value: selectedKey,
+		options: options.map((option) => ({
+			value: option.key,
+			label: option.label,
+		})),
+		onChange: (nextKey) => {
+			uiState.dagInspectorAttempt = {
+				dagRunId,
+				nodeId: node.nodeId,
+				key: String(nextKey),
+			};
+			renderDagInspectorForCurrent();
+		},
 	});
+	// Keep raw key on the root for existing integration assertions that read
+	// `.value` after assign + change (StubNode handler contract).
+	select.value = selectedKey;
 	bar.appendChild(select);
 
 	const selected =

package/dist/worker/observe/static/views/dag.js

@@ -93,6 +93,141 @@ import {
 } from "./dag-inspector.js";
 import { mergeSessionEvents } from "./session-timeline.js";
 
+const ANSI_ESCAPE_RE =
+	// CSI + OSC sequences commonly present in shell/test error previews.
+	// biome-ignore lint/suspicious/noControlCharactersInRegex: intentional ANSI strip
+	/\u001b\[[0-9;?]*[ -/]*[@-~]|\u001b\][^\u0007\u001b]*(?:\u0007|\u001b\\)/g;
+// biome-ignore lint/suspicious/noControlCharactersInRegex: intentional control-char strip
+const CONTROL_CHARS_RE = /[\u0000-\u0008\u000B\u000C\u000E-\u001F\u007F]/g;
+const ERROR_NAME_LINE_RE =
+	/(?:^|\b)(?:Error|AssertionError|TypeError|ReferenceError|SyntaxError|RangeError)\b/;
+const FAIL_LINE_RE = /\bFAIL\b/;
+const SEPARATOR_LINE_RE = /^[\s\-_=*~#.]+$/;
+// Shell prompts and common package/test runners only — not result lines like
+// "node exited 1" or real runner errors such as "npm ERR! code 1".
+const COMMAND_LINE_RE =
+	/^(?:[$>#%]\s+|\s*(?:(?:npm|pnpm|yarn|npx)(?!\s+ERR\b)|vitest|tsc|eslint)\b)/i;
+
+/**
+ * Extract a short first-error summary from a raw errorPreview for the DAG
+ * node table 备注 column. Never returns the full multi-line dump.
+ */
+export function extractFirstErrorSummary(errorPreview) {
+	if (typeof errorPreview !== "string" || !errorPreview) return "";
+	const cleaned = errorPreview
+		.replace(ANSI_ESCAPE_RE, "")
+		.replace(CONTROL_CHARS_RE, "");
+	const lines = cleaned
+		.split(/\r?\n/)
+		.map((line) => line.replace(/\s+/g, " ").trim())
+		.filter((line) => line.length > 0);
+	if (lines.length === 0) return "";
+
+	const errorLine = lines.find((line) => ERROR_NAME_LINE_RE.test(line));
+	if (errorLine) return errorLine;
+
+	const failLine = lines.find((line) => FAIL_LINE_RE.test(line));
+	if (failLine) return failLine;
+
+	const effective = lines.find(
+		(line) => !SEPARATOR_LINE_RE.test(line) && !COMMAND_LINE_RE.test(line),
+	);
+	return effective ?? "";
+}
+
+/** Resolve 备注 cell content for a DAG node (failed → summary; else label). */
+export function resolveNodeRemark(node) {
+	const failed = isNodeFailed(node?.status);
+	if (failed) {
+		const summary = extractFirstErrorSummary(node?.errorPreview);
+		return {
+			failed: true,
+			text: summary || "—",
+			isErrorSummary: Boolean(summary),
+		};
+	}
+	const label = typeof node?.label === "string" ? node.label.trim() : "";
+	return {
+		failed: false,
+		text: label || "—",
+		isErrorSummary: false,
+	};
+}
+
+/**
+ * Sole production constructor for the DAG node table (sort, rows, buildTable,
+ * remark cells, title tooltips, row click → selectDagNode).
+ * Tests must call this (or renderDagDetail) instead of hand-building DOM.
+ */
+export function buildDagNodeTable(dagRunId, nodes) {
+	const sortedNodes = [...nodes].sort((a, b) => {
+		const ra = Number(a.rank);
+		const rb = Number(b.rank);
+		if (!Number.isNaN(ra) && !Number.isNaN(rb) && ra !== rb) return ra - rb;
+		if (a.rank !== b.rank) return (a.rank ?? "").localeCompare(b.rank ?? "");
+		return a.nodeId.localeCompare(b.nodeId);
+	});
+
+	const rows = sortedNodes.map((node, index) => {
+		const active = isNodeActive(node.status);
+		const failed = isNodeFailed(node.status);
+		let className = "";
+		if (active) className = "dag-active-node";
+		if (failed) className = "dag-error-node";
+		if (node.nodeId === uiState.selectedDagNodeId) {
+			className = className
+				? `${className} dag-node-selected`
+				: "dag-node-selected";
+		}
+		const remark = resolveNodeRemark(node);
+		const remarkCell = remark.isErrorSummary
+			? el("span", "dag-node-error-summary", remark.text)
+			: remark.text;
+		return {
+			className,
+			onClick: () => selectDagNode(dagRunId, node.nodeId),
+			cells: [
+				index + 1,
+				node.nodeId,
+				node.rank ?? "—",
+				node.executor ?? "—",
+				node.model ?? "—",
+				node.status ? badge(node.status) : "—",
+				formatMs(node.durationMs),
+				(typeof node.executionSummary?.historyLabel === "string" &&
+					node.executionSummary.historyLabel.trim()) ||
+					"—",
+				remarkCell,
+			],
+		};
+	});
+	const nodeTable = buildTable(
+		[
+			"序号",
+			"节点 ID",
+			"依赖层",
+			"执行方式",
+			"模型",
+			"状态",
+			"耗时",
+			"执行历史",
+			"备注",
+		],
+		rows,
+	);
+	nodeTable.classList.add("dag-node-table");
+	for (const row of nodeTable.tBodies[0]?.rows ?? []) {
+		// Title tooltips for long ID/model/remark text only; remark never
+		// carries full errorPreview (summary or — only).
+		for (const columnIndex of [1, 4, 8]) {
+			const cell = row.cells[columnIndex];
+			const text = cell?.textContent ?? "";
+			if (text) cell.title = text;
+		}
+	}
+	return nodeTable;
+}
+
 export async function renderDagDetail(dagRunId, initial = true) {
 	showView("dag");
 	setBreadcrumb([
@@ -299,65 +434,7 @@ export async function renderDagDetail(dagRunId, initial = true) {
 	if (nodes.length === 0) {
 		mountViewState(nodesEl, "empty", UI_TEXT.noNodes);
 	} else {
-		const sortedNodes = [...nodes].sort((a, b) => {
-			const ra = Number(a.rank);
-			const rb = Number(b.rank);
-			if (!Number.isNaN(ra) && !Number.isNaN(rb) && ra !== rb) return ra - rb;
-			if (a.rank !== b.rank) return (a.rank ?? "").localeCompare(b.rank ?? "");
-			return a.nodeId.localeCompare(b.nodeId);
-		});
-
-		const rows = sortedNodes.map((node, index) => {
-			const active = isNodeActive(node.status);
-			const failed = isNodeFailed(node.status);
-			let className = "";
-			if (active) className = "dag-active-node";
-			if (failed) className = "dag-error-node";
-			if (node.nodeId === uiState.selectedDagNodeId) {
-				className = className
-					? `${className} dag-node-selected`
-					: "dag-node-selected";
-			}
-			return {
-				className,
-				onClick: () => selectDagNode(dagRunId, node.nodeId),
-				cells: [
-					index + 1,
-					node.nodeId,
-					node.rank ?? "—",
-					node.executor ?? "—",
-					node.model ?? "—",
-					node.status ? badge(node.status) : "—",
-					formatMs(node.durationMs),
-					(typeof node.executionSummary?.historyLabel === "string" &&
-						node.executionSummary.historyLabel.trim()) ||
-						"—",
-					node.errorPreview ?? node.label ?? "—",
-				],
-			};
-		});
-		const nodeTable = buildTable(
-			[
-				"序号",
-				"节点 ID",
-				"依赖层",
-				"执行方式",
-				"模型",
-				"状态",
-				"耗时",
-				"执行历史",
-				"备注",
-			],
-			rows,
-		);
-		nodeTable.classList.add("dag-node-table");
-		for (const row of nodeTable.tBodies[0]?.rows ?? []) {
-			for (const columnIndex of [1, 4, 8]) {
-				const cell = row.cells[columnIndex];
-				if (cell?.textContent) cell.title = cell.textContent;
-			}
-		}
-		nodesEl.appendChild(nodeTable);
+		nodesEl.appendChild(buildDagNodeTable(dagRunId, nodes));
 	}
 	nodesEl.scrollLeft = nodesScrollLeft;