@tdk-landscape/tdk-cli-core 1.3.68 → 1.3.69

package/CHANGELOG.md

@@ -4,6 +4,9 @@ Notable changes to the `tdk` CLI. Versions match [npm](https://www.npmjs.com/pac
 
 ## Unreleased
 
+- `tdk resource --type backend` adds `@types/node` to the new service. The Docker build uses a tsconfig with `"types": ["node"]`, so without it the image failed at `bun run build` with `TS2688: Cannot find type definition file for 'node'`. This was the next blocker on a clean machine, after the base-image race and the default Prisma feature.
+- `tdk doctor` now checks **every** entry in the Docker tsconfig's `types` list against the service's dependencies. It only looked at `"bun"`, so a missing `@types/node` passed. It names the service, the entry and the package to add, and handles subpath (`vitest/globals`) and scoped entries.
+
 ## 1.3.67 (2026-09-28)
 
 - The clean-machine quickstart run (`tdk project`, `tdk resource`, `tdk up`, wait for `/health`) now starts by itself after every successful release and tests exactly the version just published. It also still runs nightly and on demand.

package/cli/dist/commands/doctor.js

@@ -447,10 +447,35 @@ function checkStartupScripts() {
  * -- and the failure only surfaces later as `tsc: TS2688: Cannot find type
  * definition file for 'bun'` inside `bun run build`, mid Docker image build.
  */
+/**
+ * Package names that can satisfy a `compilerOptions.types` entry. TypeScript
+ * resolves `"node"` from `@types/node` or from a package named `node`, and
+ * `"vitest/globals"` from `vitest`; scoped entries name their own package.
+ */
+function typePackageCandidates(entry) {
+    if (entry.startsWith("@")) {
+        return [entry.split("/").slice(0, 2).join("/")];
+    }
+    const base = entry.split("/")[0] ?? entry;
+    return [`@types/${base}`, base];
+}
+/** The package to tell the user to install for a `types` entry. */
+function neededTypePackage(entry) {
+    const candidates = typePackageCandidates(entry);
+    // "node" -> @types/node; "vitest/globals" and scoped entries name their own package.
+    return entry.includes("/") || entry.startsWith("@")
+        ? candidates[candidates.length - 1]
+        : candidates[0];
+}
+const KNOWN_TYPE_PACKAGE_VERSIONS = {
+    "@types/bun": "^1.4.2",
+    "@types/node": "^20.0.0",
+};
 export function checkTypeScriptTypeDependencies() {
     const projectRoot = findProjectRoot() ?? process.cwd();
     const resources = discoverResourcesFromRoot(projectRoot);
     const problems = [];
+    const missingPackages = new Set();
     for (const resource of resources) {
         const packageJsonPath = join(resource.path, "package.json");
         const dockerTsconfigPath = join(resource.path, ".autogenerated", "tsconfig.docker.autogenerated.json");
@@ -460,27 +485,41 @@ export function checkTypeScriptTypeDependencies() {
         const tsconfig = readJsonFile(dockerTsconfigPath);
         const compilerOptions = tsconfig?.compilerOptions;
         const types = compilerOptions?.types;
-        if (!Array.isArray(types) || !types.includes("bun")) {
+        if (!Array.isArray(types)) {
             continue;
         }
         const pkg = readJsonFile(packageJsonPath);
-        const devDependencies = pkg?.devDependencies ?? {};
-        if (!devDependencies["@types/bun"]) {
-            problems.push(resource.name);
+        const installed = new Set([
+            ...Object.keys(pkg?.devDependencies ?? {}),
+            ...Object.keys(pkg?.dependencies ?? {}),
+        ]);
+        const missing = types
+            .filter((entry) => typeof entry === "string")
+            .filter((entry) => !typePackageCandidates(entry).some((name) => installed.has(name)));
+        for (const entry of missing) {
+            missingPackages.add(neededTypePackage(entry));
+        }
+        if (missing.length > 0) {
+            const described = missing.map((m) => `"${m}" (needs ${neededTypePackage(m)})`).join(", ");
+            problems.push(`${resource.name}: "types" lists ${described}`);
         }
     }
     if (problems.length === 0) {
         return {
             name: "TypeScript Type Dependencies",
             didPass: true,
-            message: "All services with a bun-typed tsconfig have @types/bun installed",
+            message: 'Every service\'s Docker tsconfig "types" entry has its @types package installed',
         };
     }
+    const lines = [...missingPackages].map((name) => {
+        const version = KNOWN_TYPE_PACKAGE_VERSIONS[name];
+        return version ? `"${name}": "${version}"` : `${name} (bun add -d ${name})`;
+    });
     return {
         name: "TypeScript Type Dependencies",
         didPass: false,
-        message: `Services set "types": ["bun"] in their Docker tsconfig but are missing the "@types/bun" devDependency, so \`bun run build\` fails with TS2688:\n    ${problems.join("\n    ")}`,
-        fix: 'Add to each service\'s package.json devDependencies: "@types/bun": "^1.4.2"',
+        message: `Docker tsconfig "types" names packages the service does not depend on, so \`bun run build\` fails with TS2688 (Cannot find type definition file):\n    ${problems.join("\n    ")}`,
+        fix: `Add to each service's package.json devDependencies: ${lines.join(", ")}`,
     };
 }
 function readJsonFile(path) {

package/cli/dist/commands/resource.js

@@ -84,6 +84,9 @@ export function createPackageJson(name, type) {
         },
         devDependencies: {
             "@types/bun": "^1.4.2",
+            // The generated Docker tsconfig sets "types": ["node"]; without this the
+            // image's `bun run build` fails with TS2688. ^20 matches the services that build.
+            "@types/node": "^20.0.0",
             typescript: "^7.0.2",
             vitest: "^5.0.0",
             "@biomejs/biome": "^2.5.13",

package/cli/package.json

@@ -1,7 +1,7 @@
 {
   "name": "tdk-cli-internal",
   "private": true,
-  "version": "1.3.68",
+  "version": "1.3.69",
   "description": "TDK CLI - Tilt Development Kit command line interface",
   "keywords": [
     "tdk",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tdk-landscape/tdk-cli-core",
-  "version": "1.3.68",
+  "version": "1.3.69",
   "description": "Run 100 microservices on a 16 GB laptop without Kubernetes. Scaffold services and run them locally with hot reload, built on Tilt.",
   "homepage": "https://tdk-landscape.github.io/tdk-website",
   "repository": {