@tdk-landscape/tdk-cli-core 1.3.52 → 1.3.54

package/cli/src/commands/__tests__/error-handling.test.ts

@@ -1,78 +0,0 @@
-import { describe, expect, it } from "vitest";
-import {
-  createKebabCaseValidator,
-  isValidPort,
-  validateResourceName,
-} from "../../utils/validation.js";
-
-describe("error handling", () => {
-  describe("resource name validation", () => {
-    it("should validate resource names using actual validation utility", () => {
-      expect(validateResourceName("my-service")).toEqual({ valid: true });
-      expect(validateResourceName("service123")).toEqual({ valid: true });
-      expect(validateResourceName("api-gateway")).toEqual({ valid: true });
-
-      expect(validateResourceName("")).toEqual({
-        valid: false,
-        error: "Resource name is required",
-      });
-      expect(validateResourceName("MyService")).toEqual({
-        valid: false,
-        error: "Use lowercase letters, numbers, and hyphens only",
-      });
-      expect(validateResourceName("my_service")).toEqual({
-        valid: false,
-        error: "Use lowercase letters, numbers, and hyphens only",
-      });
-    });
-
-    it("should create kebab-case validators for different contexts", () => {
-      const resourceValidator = createKebabCaseValidator("resource");
-      const stackValidator = createKebabCaseValidator("stack");
-
-      expect(resourceValidator("my-resource")).toBe(true);
-      expect(resourceValidator("")).toBe("Resource name is required");
-      expect(resourceValidator("MyResource")).toBe(
-        "Use lowercase letters, numbers, and hyphens only",
-      );
-
-      expect(stackValidator("my-stack")).toBe(true);
-      expect(stackValidator("")).toBe("Stack name is required");
-      expect(stackValidator("MyStack")).toBe("Use kebab-case (lowercase, numbers, hyphens only)");
-    });
-  });
-
-  describe("port assignment", () => {
-    it("should validate port is within valid range using isValidPort", () => {
-      // Valid ports (isValidPort allows ports 1-65535, not just 1024+)
-      expect(isValidPort(3000)).toBe(true);
-      expect(isValidPort(8080)).toBe(true);
-      expect(isValidPort(1024)).toBe(true);
-      expect(isValidPort(1)).toBe(true); // Valid per isValidPort (just > 0)
-      expect(isValidPort(65535)).toBe(true);
-
-      // Invalid ports
-      expect(isValidPort(65536)).toBe(false);
-      expect(isValidPort(0)).toBe(false);
-      expect(isValidPort(-1)).toBe(false);
-    });
-  });
-
-  describe("stack name validation", () => {
-    it("should validate stack name format using createKebabCaseValidator", () => {
-      const validNames = ["main", "api-services", "v1-stack", "test123"];
-
-      const invalidNames = ["My Stack", "my_stack", "MyStack", ""];
-
-      const stackValidator = createKebabCaseValidator("stack");
-
-      for (const name of validNames) {
-        expect(stackValidator(name)).toBe(true);
-      }
-
-      for (const name of invalidNames) {
-        expect(typeof stackValidator(name)).toBe("string");
-      }
-    });
-  });
-});

package/cli/src/commands/__tests__/phases-model.test.ts

@@ -1,161 +0,0 @@
-import { describe, expect, it } from "vitest";
-
-/**
- * Project → Phase → Stack → Resource (PPSR) model.
- *
- * project.json now organizes services by release phase:
- *
- *   project
- *     └── phases
- *           ├── pre_alpha.enabledStacks: ["proxy", "billing", "checkout-app"]
- *           ├── alpha.enabledStacks: []
- *           ├── beta.enabledStacks: []
- *           └── out_of_scope.enabledStacks: []
- *
- * Each entry in enabledStacks[] is a stack name (e.g. "billing").
- * A stack owns one or more resources/services (e.g. "checkout-app" has
- * service.json with stack: "billing").
- */
-describe("Project → Phase → Stack → Resource model", () => {
-  it("defines phases with enabledStacks (not legacy stacks/services)", () => {
-    const projectConfig = {
-      version: "1.0",
-      project: { name: "checkout-app", version: "1.0.0" },
-      phases: {
-        pre_alpha: {
-          name: "Pre-Alpha",
-          description: "Core infrastructure and MVP services",
-          enabledStacks: ["proxy", "database-management", "app", "billing", "checkout-app"],
-        },
-        alpha: {
-          name: "Alpha",
-          description: "Essential business services",
-          enabledStacks: [],
-        },
-        beta: {
-          name: "Beta",
-          description: "Extended features",
-          enabledStacks: [],
-        },
-        out_of_scope: {
-          name: "Out of Scope",
-          description: "Future releases",
-          enabledStacks: [],
-        },
-      },
-    };
-
-    expect(projectConfig).toHaveProperty("phases");
-    expect(projectConfig).not.toHaveProperty("stacks");
-    expect(projectConfig.phases.pre_alpha).toHaveProperty("enabledStacks");
-    expect(projectConfig.phases.pre_alpha).not.toHaveProperty("services");
-    expect(projectConfig.phases.pre_alpha.enabledStacks).toContain("billing");
-    expect(projectConfig.phases.pre_alpha.enabledStacks).toContain("checkout-app");
-  });
-
-  it("keeps the PSR stack concept separate from phases", () => {
-    const service = {
-      appName: "checkout-app",
-      appType: "frontend",
-      stack: "billing",
-      port: 3210,
-    };
-
-    const phase = {
-      name: "Pre-Alpha",
-      enabledStacks: ["billing", "checkout-app"],
-    };
-
-    // The service belongs to the "billing" stack, while the phase controls
-    // whether that stack is enabled for this project.
-    expect(service.stack).toBe("billing");
-    expect(phase.enabledStacks).toContain("billing");
-    expect(phase.enabledStacks).toContain("checkout-app");
-    expect(service.appName).toBe("checkout-app");
-  });
-
-  it("deduplicates enabledStacks per phase", () => {
-    const enabledStacks = Array.from(new Set(["proxy", "billing", "checkout-app", "billing"]));
-
-    expect(enabledStacks).toEqual(["proxy", "billing", "checkout-app"]);
-    expect(enabledStacks.filter((s) => s === "billing")).toHaveLength(1);
-  });
-
-  it("maps legacy stacks/services to phases/enabledStacks", () => {
-    const legacy = {
-      stacks: {
-        pre_alpha: {
-          name: "Pre-Alpha",
-          description: "Core infrastructure and MVP services",
-          services: ["proxy", "billing"],
-        },
-        alpha: {
-          name: "Alpha",
-          description: "Essential business services",
-          services: [],
-        },
-        beta: {
-          name: "Beta",
-          description: "Extended features",
-          services: [],
-        },
-        out_of_scope: {
-          name: "Out of Scope",
-          description: "Future releases",
-          services: [],
-        },
-      },
-    };
-
-    const phases = {
-      pre_alpha: {
-        name: legacy.stacks.pre_alpha.name,
-        description: legacy.stacks.pre_alpha.description,
-        enabledStacks: legacy.stacks.pre_alpha.services,
-      },
-      alpha: {
-        name: legacy.stacks.alpha.name,
-        description: legacy.stacks.alpha.description,
-        enabledStacks: legacy.stacks.alpha.services,
-      },
-      beta: {
-        name: legacy.stacks.beta.name,
-        description: legacy.stacks.beta.description,
-        enabledStacks: legacy.stacks.beta.services,
-      },
-      out_of_scope: {
-        name: legacy.stacks.out_of_scope.name,
-        description: legacy.stacks.out_of_scope.description,
-        enabledStacks: legacy.stacks.out_of_scope.services,
-      },
-    };
-
-    expect(phases.pre_alpha.enabledStacks).toEqual(["proxy", "billing"]);
-    expect(phases).not.toHaveProperty("services");
-    expect(phases.pre_alpha).not.toHaveProperty("services");
-  });
-
-  it("generates spec.master PRE_ALPHA_RESOURCES from phases.pre_alpha.enabledStacks", () => {
-    const enabledStacks = ["proxy", "billing", "checkout-app"];
-    const resourceEntries = enabledStacks.map((stack) => `"${stack}": True`);
-    const specMaster = `PRE_ALPHA_RESOURCES = {\n${resourceEntries.join(",\n")}\n}`;
-
-    expect(specMaster).toContain("PRE_ALPHA_RESOURCES = {");
-    expect(specMaster).toContain('"billing": True');
-    expect(specMaster).toContain('"checkout-app": True');
-    expect(specMaster).not.toContain('"services"');
-  });
-
-  it("keeps focus lists derived from phases for CLI --focus", () => {
-    const preAlpha = ["proxy", "billing", "checkout-app"];
-    const alpha = ["api"];
-    const beta = ["worker"];
-    const focusPreAlpha = preAlpha;
-    const focusAlpha = [...preAlpha, ...alpha];
-    const focusBeta = [...preAlpha, ...alpha, ...beta];
-
-    expect(focusPreAlpha).toEqual(preAlpha);
-    expect(focusAlpha).toContain("checkout-app");
-    expect(focusBeta).toContain("checkout-app");
-  });
-});

package/cli/src/commands/__tests__/project-resource-features-e2e.test.ts

@@ -1,187 +0,0 @@
-import { execFileSync } from "node:child_process";
-import { existsSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { dirname, join, resolve } from "node:path";
-import { fileURLToPath } from "node:url";
-import { afterEach, describe, expect, it } from "vitest";
-
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = dirname(__filename);
-const repoRoot = resolve(__dirname, "../../../..");
-const cliBin = join(repoRoot, "cli", "bin", "tdk.js");
-
-function runTdk(args: string[], cwd: string, input?: string): string {
-  return execFileSync(process.execPath, [cliBin, ...args], {
-    cwd,
-    encoding: "utf-8",
-    input,
-    env: {
-      ...process.env,
-      TDK_EXTENSION_SOURCE: repoRoot,
-    },
-  });
-}
-
-function starlarkSection(content: string, name: string): string {
-  const start = content.indexOf(`${name} = {`);
-  expect(start).toBeGreaterThanOrEqual(0);
-  const end = content.indexOf("\n}", start);
-  expect(end).toBeGreaterThan(start);
-  return content.slice(start, end + 2);
-}
-
-describe("project and resource feature E2E", () => {
-  let projectRoot = "";
-
-  afterEach(() => {
-    if (projectRoot?.startsWith(tmpdir())) {
-      rmSync(projectRoot, { recursive: true, force: true });
-    }
-  });
-
-  it("keeps Verdaccio as an explicit premium project feature", () => {
-    projectRoot = mkdtempSync(join(tmpdir(), "tdk-project-feature-"));
-
-    runTdk(["project", "--yes"], projectRoot);
-
-    const projectJsonPath = join(projectRoot, ".tdk", "project.json");
-    const projectJson = JSON.parse(readFileSync(projectJsonPath, "utf-8"));
-    expect(projectJson.phases.pre_alpha.enabledStacks).not.toContain("verdaccio");
-    expect(projectJson.optional_infra.verdaccio).toBe(false);
-
-    let spec = readFileSync(join(projectRoot, ".tdk", ".tdk-out", "spec.master"), "utf-8");
-    expect(starlarkSection(spec, "PRE_ALPHA_RESOURCES")).not.toContain('"verdaccio": True');
-    expect(starlarkSection(spec, "OPTIONAL_INFRA_RESOURCES")).toContain('"verdaccio": False');
-
-    // Without TDK_LICENSE_KEY granting it, enabling verdaccio must be refused
-    // outright (config.ts:toggleInfraService) rather than silently accepted
-    // and then downgraded back to false by generateMasterConfigs.
-    expect(() => runTdk(["config", "enable-infra", "verdaccio"], projectRoot)).toThrow(
-      /Premium feature/,
-    );
-
-    const updatedProjectJson = JSON.parse(readFileSync(projectJsonPath, "utf-8"));
-    expect(updatedProjectJson.phases.pre_alpha.enabledStacks).not.toContain("verdaccio");
-    expect(updatedProjectJson.optional_infra.verdaccio).toBe(false);
-
-    spec = readFileSync(join(projectRoot, ".tdk", ".tdk-out", "spec.master"), "utf-8");
-    expect(starlarkSection(spec, "PRE_ALPHA_RESOURCES")).not.toContain('"verdaccio": True');
-    expect(starlarkSection(spec, "OPTIONAL_INFRA_RESOURCES")).toContain('"verdaccio": False');
-  }, 10000);
-
-  it("warns instead of silently stripping stale Verdaccio state when no premium license grants it", () => {
-    // generateMasterConfigs() intentionally does not enforce the license
-    // gate itself (see the comment above hasVerdaccioLicense's call site in
-    // template-engine.ts): the real enforcement is that the free-tier
-    // verdaccio_loader.star in this public repo is a no-op stub, so hand-
-    // edited state here has no functional effect without the private
-    // premium overlay. It just warns so the user isn't left guessing.
-    projectRoot = mkdtempSync(join(tmpdir(), "tdk-stale-verdaccio-"));
-
-    runTdk(["project", "--yes"], projectRoot);
-
-    const projectJsonPath = join(projectRoot, ".tdk", "project.json");
-    const projectJson = JSON.parse(readFileSync(projectJsonPath, "utf-8"));
-    projectJson.phases.pre_alpha.enabledStacks.push("verdaccio");
-    projectJson.optional_infra.verdaccio = true;
-    writeFileSync(projectJsonPath, JSON.stringify(projectJson, null, 2));
-
-    runTdk(["config", "regenerate"], projectRoot);
-
-    const updatedProjectJson = JSON.parse(readFileSync(projectJsonPath, "utf-8"));
-    expect(updatedProjectJson.phases.pre_alpha.enabledStacks).toContain("verdaccio");
-    expect(updatedProjectJson.optional_infra.verdaccio).toBe(true);
-
-    const spec = readFileSync(join(projectRoot, ".tdk", ".tdk-out", "spec.master"), "utf-8");
-    expect(starlarkSection(spec, "PRE_ALPHA_RESOURCES")).toContain('"verdaccio": True');
-    expect(starlarkSection(spec, "OPTIONAL_INFRA_RESOURCES")).toContain('"verdaccio": True');
-  }, 10000);
-
-  it("copies Docker runtime assets and creates the root workspace manifest during project generation", () => {
-    projectRoot = mkdtempSync(join(tmpdir(), "tdk-project-runtime-assets-"));
-
-    runTdk(["project", "--yes"], projectRoot);
-
-    const rootPackageJson = JSON.parse(readFileSync(join(projectRoot, "package.json"), "utf-8"));
-    expect(rootPackageJson.private).toBe(true);
-    expect(rootPackageJson.workspaces).toEqual(["services/*/*"]);
-
-    for (const file of [
-      "install-deps.sh",
-      "bun-hoisted-symlink-fix.sh",
-      "prisma-bun-client-link-fix.sh",
-      "prisma-normalize-client.sh",
-    ]) {
-      expect(
-        existsSync(join(projectRoot, "shared-platform-engineering", "docker-templates", file)),
-      ).toBe(true);
-    }
-  }, 10000);
-
-  it("vendors free env injection instead of Infisical credentials by default", () => {
-    projectRoot = mkdtempSync(join(tmpdir(), "tdk-project-env-injection-"));
-
-    runTdk(["project", "--yes"], projectRoot);
-
-    const envGenerator = readFileSync(
-      join(
-        projectRoot,
-        ".tdk",
-        ".tdk-out",
-        "tdk-cli-ext",
-        "engine",
-        "topologies",
-        "platform",
-        "docker",
-        "secrets",
-        "infisical.star",
-      ),
-      "utf-8",
-    );
-    expect(envGenerator).toContain("TDK_SECRET_PROVIDER");
-    expect(envGenerator).not.toContain("INFISICAL_CLIENT_SECRET");
-
-    const dockerfileGenerator = readFileSync(
-      join(
-        projectRoot,
-        ".tdk",
-        ".tdk-out",
-        "tdk-cli-ext",
-        "engine",
-        "topologies",
-        "platform",
-        "docker",
-        "dockerfile",
-        "dockerfile.star",
-      ),
-      "utf-8",
-    );
-    expect(dockerfileGenerator).toContain("use_infisical=False");
-  }, 10000);
-
-  it("writes default resource-level features into generated service.json files", () => {
-    projectRoot = mkdtempSync(join(tmpdir(), "tdk-resource-feature-"));
-    runTdk(["project", "--yes"], projectRoot);
-
-    runTdk(
-      ["resource", "api", "--type", "backend", "--stack", "alpha", "--path", "services/alpha/api"],
-      projectRoot,
-      "\n",
-    );
-    runTdk(
-      ["resource", "web", "--type", "frontend", "--stack", "alpha", "--path", "services/alpha/web"],
-      projectRoot,
-      "\n",
-    );
-
-    const backendService = JSON.parse(
-      readFileSync(join(projectRoot, "services", "alpha", "api", "service.json"), "utf-8"),
-    );
-    expect(backendService.featuresEnabled).toEqual(["prisma"]);
-
-    const frontendService = JSON.parse(
-      readFileSync(join(projectRoot, "services", "alpha", "web", "service.json"), "utf-8"),
-    );
-    expect(frontendService.featuresEnabled).toEqual(["api-client", "env-config", "api-index"]);
-  }, 10000);
-});

package/cli/src/commands/__tests__/project.test.ts

@@ -1,68 +0,0 @@
-import { describe, expect, it } from "vitest";
-
-const EXPECTED_TEMPLATES = [
-  "TILT_RESOURCE_DEFAULTS.star.hbs",
-  "TILT_TECH_STACK.star.hbs",
-  "Tiltfile.hbs",
-  "spec.master.hbs",
-] as const;
-
-const TEMPLATE_PATTERNS = {
-  "TILT_RESOURCE_DEFAULTS.star.hbs": [
-    "BASE_PORT_FRONTEND",
-    "BASE_PORT_BACKEND",
-    "HEALTH_CHECK_PATH",
-    "starlarkArray",
-  ],
-  "TILT_TECH_STACK.star.hbs": ["BUNDLER", "RUNTIME", "ORM", "assert_tech_stack"],
-  "Tiltfile.hbs": ["TDK CLI", ".tdk/.tdk-out", "spec.master"],
-} as const;
-
-describe("project command", () => {
-  it("should verify all expected templates exist", () => {
-    expect(EXPECTED_TEMPLATES).toHaveLength(4);
-    for (const template of EXPECTED_TEMPLATES) {
-      expect(EXPECTED_TEMPLATES).toContain(template);
-    }
-  });
-
-  it("should have templates with all required content patterns", () => {
-    for (const templateName of Object.keys(TEMPLATE_PATTERNS)) {
-      expect(EXPECTED_TEMPLATES).toContain(templateName);
-    }
-
-    for (const [, patterns] of Object.entries(TEMPLATE_PATTERNS)) {
-      for (const pattern of patterns) {
-        expect(patterns).toContain(pattern);
-      }
-    }
-  });
-});
-
-describe("project command templates", () => {
-  it("should have valid Handlebars template patterns", () => {
-    const handlebarsPatterns = ["{{", "}}"];
-
-    expect(handlebarsPatterns).toContain("{{");
-    expect(handlebarsPatterns).toContain("}}");
-  });
-
-  it("should have templates with required content patterns defined", () => {
-    for (const pattern of [
-      "BASE_PORT_FRONTEND",
-      "BASE_PORT_BACKEND",
-      "HEALTH_CHECK_PATH",
-      "starlarkArray",
-    ]) {
-      expect(TEMPLATE_PATTERNS["TILT_RESOURCE_DEFAULTS.star.hbs"]).toContain(pattern);
-    }
-
-    for (const pattern of ["BUNDLER", "RUNTIME", "ORM", "assert_tech_stack"]) {
-      expect(TEMPLATE_PATTERNS["TILT_TECH_STACK.star.hbs"]).toContain(pattern);
-    }
-
-    for (const pattern of ["TDK CLI", ".tdk/.tdk-out", "spec.master"]) {
-      expect(TEMPLATE_PATTERNS["Tiltfile.hbs"]).toContain(pattern);
-    }
-  });
-});