@tdk-landscape/tdk-cli-core 1.3.45 → 1.3.49

package/openspec/changes/archive/2026-04-28-star-files-parameter-fixes/specs/parameter-ordering-standard/spec.md

@@ -0,0 +1,12 @@
+## ADDED Requirements
+
+### Requirement: Parameter ordering with optional parameters last
+All function signatures SHALL place optional parameters (those with default values) after required parameters.
+
+#### Scenario: Optional parameter follows required parameters
+- **WHEN** a function has both required and optional parameters
+- **THEN** all required parameters SHALL appear before any optional parameters in the signature
+
+#### Scenario: Write function parameter is last
+- **WHEN** a function accepts a `write_fn` parameter with default value `None`
+- **THEN** `write_fn` SHALL be the last parameter in the function signature

package/openspec/changes/archive/2026-04-28-star-files-parameter-fixes/tasks.md

@@ -0,0 +1,194 @@
+## 1. Discovery Directory - Registry and Core Functions
+
+- [x] 1.1 Fix parameter names in `discovery/registry.star` - standardize `write_fn` parameter names (lines 1-50)
+- [x] 1.2 Fix parameter names in `discovery/registry.star` - standardize `write_fn` parameter names (lines 51-100)
+- [x] 1.3 Fix parameter names in `discovery/registry.star` - standardize `write_fn` parameter names (lines 101-150)
+- [x] 1.4 Fix parameter ordering in `discovery/registry.star` - move optional parameters to end
+- [x] 1.5 Add parameter documentation to `discovery/registry.star` functions
+- [x] 1.6 Fix parameter names in `discovery/discovery_orchestrator.star` - standardize all `write_fn` parameters
+- [x] 1.7 Fix parameter ordering in `discovery/discovery_orchestrator.star`
+- [x] 1.8 Add parameter documentation to `discovery/discovery_orchestrator.star`
+- [x] 1.9 Fix parameter names in `discovery/incremental_discovery.star` - standardize `write_fn` parameters
+- [x] 1.10 Fix function naming alignment in `discovery/incremental_discovery.star` - ensure `register_new_service` naming
+
+## 2. Discovery Directory - Manifest Functions
+
+- [x] 2.1 Fix parameter names in `discovery/manifest/loading.star` - standardize `write_fn` parameters
+- [x] 2.2 Fix parameter ordering in `discovery/manifest/loading.star`
+- [x] 2.3 Add parameter documentation to `discovery/manifest/loading.star`
+- [x] 2.4 Fix parameter names in `discovery/manifest/normalize.star` - standardize `write_fn` parameters
+- [x] 2.5 Fix parameter ordering in `discovery/manifest/normalize.star`
+- [x] 2.6 Add parameter documentation to `discovery/manifest/normalize.star`
+- [x] 2.7 Fix parameter names in `discovery/manifest/validation.star` - standardize `write_fn` parameters
+- [x] 2.8 Fix parameter ordering in `discovery/manifest/validation.star`
+- [x] 2.9 Add parameter documentation to `discovery/manifest/validation.star`
+- [x] 2.10 Fix parameter names in `discovery/config.star` - standardize all write function parameters
+
+## 3. Engine Topologies Tilt - Registry and Discovery (Deprecated System)
+
+- [x] 3.1 Fix parameter names in `engine/topologies/tilt/discovery/registry.star` - standardize `write_fn` (lines 1-50)
+- [x] 3.2 Fix parameter names in `engine/topologies/tilt/discovery/registry.star` - standardize `write_fn` (lines 51-100)
+- [x] 3.3 Fix parameter names in `engine/topologies/tilt/discovery/registry.star` - standardize `write_fn` (lines 101-150)
+- [x] 3.4 Fix parameter ordering in `engine/topologies/tilt/discovery/registry.star`
+- [x] 3.5 Add parameter documentation to `engine/topologies/tilt/discovery/registry.star`
+- [x] 3.6 Fix parameter names in `engine/topologies/tilt/discovery/discovery_orchestrator.star`
+- [x] 3.7 Fix parameter ordering in `engine/topologies/tilt/discovery/discovery_orchestrator.star`
+- [x] 3.8 Add parameter documentation to `engine/topologies/tilt/discovery/discovery_orchestrator.star`
+- [x] 3.9 Fix function naming alignment in `engine/topologies/tilt/discovery/incremental_discovery.star` - rename `register_new_resource` to `register_new_service`
+- [x] 3.10 Fix parameter names and documentation in `engine/topologies/tilt/discovery/incremental_discovery.star`
+
+## 4. Engine Topologies Tilt - Generators
+
+- [x] 4.1 Fix parameter names in `engine/topologies/tilt/generators/vite/backend.star` - standardize `write_fn`
+- [x] 4.2 Fix parameter ordering in `engine/topologies/tilt/generators/vite/backend.star`
+- [x] 4.3 Add parameter documentation to `engine/topologies/tilt/generators/vite/backend.star`
+- [x] 4.4 Fix parameter names in `engine/topologies/tilt/generators/vite/frontend.star` - standardize `write_fn`
+- [x] 4.5 Fix parameter ordering in `engine/topologies/tilt/generators/vite/frontend.star`
+- [x] 4.6 Add parameter documentation to `engine/topologies/tilt/generators/vite/frontend.star`
+- [x] 4.7 Fix parameter names in `engine/topologies/tilt/generators/docker/frontend.star` - standardize `write_fn`
+- [x] 4.8 Fix parameter ordering in `engine/topologies/tilt/generators/docker/frontend.star`
+- [x] 4.9 Fix parameter names in `engine/topologies/tilt/generators/docker/backend.star` - standardize `write_fn`
+- [x] 4.10 Fix parameter ordering in `engine/topologies/tilt/generators/docker/backend.star`
+
+## 5. Engine Topologies Tilt - More Generators
+
+- [x] 5.1 Fix parameter names in `engine/topologies/tilt/generators/docker/compose.star` - standardize `write_fn`
+- [x] 5.2 Fix parameter ordering in `engine/topologies/tilt/generators/docker/compose.star`
+- [x] 5.3 Fix parameter names in `engine/topologies/tilt/generators/tsconfig/generator.star` - standardize `write_fn`
+- [x] 5.4 Fix parameter ordering in `engine/topologies/tilt/generators/tsconfig/generator.star`
+- [x] 5.5 Fix parameter names in `engine/topologies/tilt/generators/nginx/generator.star` - standardize `write_fn`
+- [x] 5.6 Fix parameter ordering in `engine/topologies/tilt/generators/nginx/generator.star`
+- [x] 5.7 Fix parameter names in `engine/topologies/tilt/generators/npmrc/generator.star` - standardize `write_fn`
+- [x] 5.8 Fix parameter ordering in `engine/topologies/tilt/generators/npmrc/generator.star`
+- [x] 5.9 Fix parameter names in `engine/topologies/tilt/generators/env/generator.star` - standardize `write_fn`
+- [x] 5.10 Fix parameter ordering in `engine/topologies/tilt/generators/env/generator.star`
+
+## 6. Engine Topologies Tilt - Infisical Generators
+
+- [x] 6.1 Fix parameter names in `engine/topologies/tilt/generators/infisical/path_manager.star` - standardize `write_fn` (functions 1-8)
+- [x] 6.2 Fix parameter names in `engine/topologies/tilt/generators/infisical/path_manager.star` - standardize `write_fn` (functions 9-17)
+- [x] 6.3 Fix parameter ordering in `engine/topologies/tilt/generators/infisical/path_manager.star`
+- [x] 6.4 Add parameter documentation to `engine/topologies/tilt/generators/infisical/path_manager.star`
+- [x] 6.5 Fix parameter names in `engine/topologies/tilt/generators/infisical/star_to_json.star`
+- [x] 6.6 Fix parameter ordering in `engine/topologies/tilt/generators/infisical/star_to_json.star`
+- [x] 6.7 Fix parameter names in `engine/topologies/tilt/generators/infisical/sync.star`
+- [x] 6.8 Fix parameter ordering in `engine/topologies/tilt/generators/infisical/sync.star`
+- [x] 6.9 Fix parameter names in `engine/topologies/tilt/generators/validators.star` - standardize `write_fn`
+- [x] 6.10 Fix parameter ordering in `engine/topologies/tilt/generators/validators.star`
+
+## 7. Engine Topologies Tilt - Resource Orchestration
+
+- [x] 7.1 Fix parameter names in `engine/topologies/tilt/resources/orchestrator/apply_compose_resource_registration.star` (functions 1-7)
+- [x] 7.2 Fix parameter names in `engine/topologies/tilt/resources/orchestrator/apply_compose_resource_registration.star` (functions 8-15)
+- [x] 7.3 Fix parameter ordering in `engine/topologies/tilt/resources/orchestrator/apply_compose_resource_registration.star`
+- [x] 7.4 Fix parameter names in `engine/topologies/tilt/resources/libs_resource_definition.star`
+- [x] 7.5 Fix parameter ordering in `engine/topologies/tilt/resources/libs_resource_definition.star`
+- [x] 7.6 Fix parameter names in `engine/topologies/tilt/resources/frontend_resource.star`
+- [x] 7.7 Fix parameter ordering in `engine/topologies/tilt/resources/frontend_resource.star`
+- [x] 7.8 Fix parameter names in `engine/topologies/tilt/resources/backend_resource.star`
+- [x] 7.9 Fix parameter ordering in `engine/topologies/tilt/resources/backend_resource.star`
+- [x] 7.10 Fix parameter names in `engine/topologies/tilt/resources/database_resource.star`
+
+## 8. Engine Topologies Tilt - Database and Infrastructure Resources
+
+- [x] 8.1 Fix parameter ordering in `engine/topologies/tilt/resources/database_resource.star`
+- [x] 8.2 Fix parameter names in `engine/topologies/tilt/resources/infra_resource.star`
+- [x] 8.3 Fix parameter ordering in `engine/topologies/tilt/resources/infra_resource.star`
+- [x] 8.4 Fix parameter names in `engine/topologies/tilt/resources/proxy_resource.star`
+- [x] 8.5 Fix parameter ordering in `engine/topologies/tilt/resources/proxy_resource.star`
+- [x] 8.6 Fix parameter names in `engine/topologies/tilt/resources/migration_resource.star`
+- [x] 8.7 Fix parameter ordering in `engine/topologies/tilt/resources/migration_resource.star`
+- [x] 8.8 Fix parameter names in `engine/topologies/tilt/resources/seed_resource.star`
+- [x] 8.9 Fix parameter ordering in `engine/topologies/tilt/resources/seed_resource.star`
+- [x] 8.10 Fix parameter names in `engine/topologies/tilt/resources/security_resource.star`
+
+## 9. Engine Topologies Platform - Docker and Networking
+
+- [x] 9.1 Fix parameter names in `engine/topologies/platform/docker/layers.star` - standardize `write_fn`
+- [x] 9.2 Fix parameter ordering in `engine/topologies/platform/docker/layers.star`
+- [x] 9.3 Add parameter documentation to `engine/topologies/platform/docker/layers.star`
+- [x] 9.4 Fix parameter names in `engine/topologies/platform/docker/networking.star`
+- [x] 9.5 Fix parameter ordering in `engine/topologies/platform/docker/networking.star`
+- [x] 9.6 Fix parameter names in `engine/topologies/platform/docker/volumes.star`
+- [x] 9.7 Fix parameter ordering in `engine/topologies/platform/docker/volumes.star`
+- [x] 9.8 Fix parameter names in `engine/topologies/platform/docker/security.star`
+- [x] 9.9 Fix parameter ordering in `engine/topologies/platform/docker/security.star`
+- [x] 9.10 Add parameter documentation to `engine/topologies/platform/docker/security.star`
+
+## 10. Engine Topologies Platform - Compose and Proxies
+
+- [x] 10.1 Fix parameter names in `engine/topologies/platform/compose/generator.star`
+- [x] 10.2 Fix parameter ordering in `engine/topologies/platform/compose/generator.star`
+- [x] 10.3 Add parameter documentation to `engine/topologies/platform/compose/generator.star`
+- [x] 10.4 Fix parameter names in `engine/topologies/platform/proxy/caddy.star`
+- [x] 10.5 Fix parameter ordering in `engine/topologies/platform/proxy/caddy.star`
+- [x] 10.6 Fix parameter names in `engine/topologies/platform/proxy/nginx.star`
+- [x] 10.7 Fix parameter ordering in `engine/topologies/platform/proxy/nginx.star`
+- [x] 10.8 Fix parameter names in `engine/topologies/platform/state/persistence.star`
+- [x] 10.9 Fix parameter ordering in `engine/topologies/platform/state/persistence.star`
+- [x] 10.10 Add parameter documentation to `engine/topologies/platform/state/persistence.star`
+
+## 11. Engine Topologies Tilt - Manifest Loading and Validation
+
+- [x] 11.1 Fix parameter names in `engine/topologies/tilt/manifest/loading.star` - standardize `write_fn`
+- [x] 11.2 Fix parameter ordering in `engine/topologies/tilt/manifest/loading.star`
+- [x] 11.3 Add parameter documentation to `engine/topologies/tilt/manifest/loading.star`
+- [x] 11.4 Fix parameter names in `engine/topologies/tilt/manifest/normalize.star`
+- [x] 11.5 Fix parameter ordering in `engine/topologies/tilt/manifest/normalize.star`
+- [x] 11.6 Add parameter documentation to `engine/topologies/tilt/manifest/normalize.star`
+- [x] 11.7 Fix parameter names in `engine/topologies/tilt/manifest/validation.star`
+- [x] 11.8 Fix parameter ordering in `engine/topologies/tilt/manifest/validation.star`
+- [x] 11.9 Add parameter documentation to `engine/topologies/tilt/manifest/validation.star`
+- [x] 11.10 Fix parameter names in `engine/topologies/tilt/manifest/config.star`
+
+## 12. Engine Topologies Tilt - Config and Utilities
+
+- [x] 12.1 Fix parameter ordering in `engine/topologies/tilt/manifest/config.star`
+- [x] 12.2 Add parameter documentation to `engine/topologies/tilt/manifest/config.star`
+- [x] 12.3 Fix parameter names in `engine/topologies/tilt/utils/file.star`
+- [x] 12.4 Fix parameter ordering in `engine/topologies/tilt/utils/file.star`
+- [x] 12.5 Add parameter documentation to `engine/topologies/tilt/utils/file.star`
+- [x] 12.6 Fix parameter names in `engine/topologies/tilt/utils/path.star`
+- [x] 12.7 Fix parameter ordering in `engine/topologies/tilt/utils/path.star`
+- [x] 12.8 Fix parameter names in `engine/topologies/tilt/utils/string.star`
+- [x] 12.9 Fix parameter ordering in `engine/topologies/tilt/utils/string.star`
+- [x] 12.10 Add parameter documentation to `engine/topologies/tilt/utils/string.star`
+
+## 13. Engine Topologies Tilt - Core System Files
+
+- [x] 13.1 Fix parameter names in `engine/topologies/tilt/core/ports.star`
+- [x] 13.2 Fix parameter ordering in `engine/topologies/tilt/core/ports.star`
+- [x] 13.3 Add parameter documentation to `engine/topologies/tilt/core/ports.star`
+- [x] 13.4 Fix parameter names in `engine/topologies/tilt/core/deps.star`
+- [x] 13.5 Fix parameter ordering in `engine/topologies/tilt/core/deps.star`
+- [x] 13.6 Add parameter documentation to `engine/topologies/tilt/core/deps.star`
+- [x] 13.7 Fix parameter names in `engine/topologies/tilt/core/build.star`
+- [x] 13.8 Fix parameter ordering in `engine/topologies/tilt/core/build.star`
+- [x] 13.9 Add parameter documentation to `engine/topologies/tilt/core/build.star`
+- [x] 13.10 Fix parameter names in `engine/topologies/tilt/core/watch.star`
+
+## 14. Engine Topologies Platform - Security and Secrets
+
+- [x] 14.1 Fix parameter ordering in `engine/topologies/tilt/core/watch.star`
+- [x] 14.2 Add parameter documentation to `engine/topologies/tilt/core/watch.star`
+- [x] 14.3 Fix parameter names in `engine/topologies/platform/security/secrets.star`
+- [x] 14.4 Fix parameter ordering in `engine/topologies/platform/security/secrets.star`
+- [x] 14.5 Add parameter documentation to `engine/topologies/platform/security/secrets.star`
+- [x] 14.6 Fix parameter names in `engine/topologies/platform/security/infisical.star`
+- [x] 14.7 Fix parameter ordering in `engine/topologies/platform/security/infisical.star`
+- [x] 14.8 Add parameter documentation to `engine/topologies/platform/security/infisical.star`
+- [x] 14.9 Fix parameter names in `engine/topologies/platform/security/tls.star`
+- [x] 14.10 Fix parameter ordering in `engine/topologies/platform/security/tls.star`
+
+## 15. Final Cleanup and Verification
+
+- [x] 15.1 Fix parameter names in `engine/topologies/tilt/Tiltfile` - standardize any `write_fn` parameters
+- [x] 15.2 Fix parameter ordering in `engine/topologies/tilt/Tiltfile`
+- [x] 15.3 Fix parameter names in `specs/specs/TILT_SERVICE_DEFAULTS.star`
+- [x] 15.4 Fix parameter ordering in `specs/specs/TILT_SERVICE_DEFAULTS.star`
+- [x] 15.5 Add parameter documentation to `specs/specs/TILT_SERVICE_DEFAULTS.star`
+- [x] 15.6 Fix parameter names in `specs/specs/TILT_TECH_STACK.star`
+- [x] 15.7 Fix parameter ordering in `specs/specs/TILT_TECH_STACK.star`
+- [x] 15.8 Run full test suite to verify all parameter changes work correctly
+- [x] 15.9 Verify no `write_file_fn` or `write_file_if_changed_fn` remains in any .star file
+- [x] 15.10 Final review: Ensure all function parameters have consistent naming and documentation

package/openspec/changes/archive/2026-04-29-scan-repo-gaps-fix/.openspec.yaml

@@ -0,0 +1,2 @@
+schema: spec-driven
+created: 2026-04-28

package/openspec/changes/archive/2026-04-29-scan-repo-gaps-fix/codebase-audit-report.md

@@ -0,0 +1,62 @@
+# TDK Codebase Audit Report
+
+Generated: 2026-04-29
+
+## Summary
+
+- **Total markers found:** 4
+- **CLI (User-facing):** 4
+- **Discovery:** 0
+- **Engine:** 0
+
+## Findings
+
+### CLI (User-Facing) - Priority: HIGH
+
+```
+cli/src/commands/resource.ts:164:  // TODO: Check database, cache, etc.
+cli/src/commands/resource.ts:168:// TODO: Add your routes here
+cli/src/commands/resource.ts:231:// TODO: Implement your worker logic here
+cli/src/commands/config.ts:32:            // TODO: Implement diff logic
+```
+
+**Details:**
+
+1. **resource.ts:164** - Database/cache health check TODO in backend index template
+   - Context: Health check endpoint needs to verify database/cache connectivity
+   - Impact: Generated services won't properly report health status
+   
+2. **resource.ts:168** - Routes placeholder TODO in backend index template
+   - Context: Placeholder comment for developers to add their own routes
+   - Impact: Documentation/placeholder - low functional impact
+   
+3. **resource.ts:231** - Worker logic TODO in worker index template
+   - Context: Worker template only has a basic loop, no actual job processing
+   - Impact: Generated workers aren't functional without implementation
+   
+4. **config.ts:32** - Diff logic TODO in config regenerate command
+   - Context: Dry-run mode shows what would change but doesn't implement actual diff
+   - Impact: Users can't see differences between current and new config
+
+### Discovery - Priority: MEDIUM
+
+```
+No findings
+```
+
+### Engine - Priority: MEDIUM
+
+```
+No findings
+```
+
+## Next Steps
+
+1. ✅ Review HIGH priority (CLI) findings - COMPLETED
+2. Implement or remove TODOs as appropriate:
+   - Implement health check with database/cache verification (resource.ts:164)
+   - Add example routes template (resource.ts:168)
+   - Create functional worker template with job processing structure (resource.ts:231)
+   - Implement diff logic for config dry-run (config.ts:32)
+3. Add tests for any new functionality
+4. Re-run audit to verify cleanup

package/openspec/changes/archive/2026-04-29-scan-repo-gaps-fix/design.md

@@ -0,0 +1,84 @@
+## Context
+
+TDK CLI is a multi-language monorepo with TypeScript (CLI), Python (Discovery), and Starlark (Engine/Tilt configs). During initial exploration, several gaps were identified:
+
+**Current State:**
+- CLI `resource.ts` has 4 TODO comments for unimplemented features (database/cache checks, routes, worker logic, diff logic)
+- CLI `config.ts` has incomplete diff implementation
+- Test coverage exists but gaps likely in error handling paths
+- No systematic audit system for tracking technical debt
+
+**Constraints:**
+- Must not break existing functionality
+- Changes should be minimal and focused
+- All fixes must include tests where applicable
+- Must maintain compatibility with existing Tilt workflows
+
+## Goals / Non-Goals
+
+**Goals:**
+- Implement automated scanning to find TODO/FIXME/BUG/HACK markers across all languages
+- Fix high-priority TODOs in CLI commands (resource.ts, config.ts)
+- Add missing test coverage for critical error paths
+- Remove dead code and unused imports
+- Document all changes with clear commit messages
+
+**Non-Goals:**
+- Major refactoring or architecture changes
+- Adding new features beyond fixing existing TODOs
+- Rewriting working code without TODOs
+- Breaking changes to existing APIs
+
+## Decisions
+
+**Decision 1: Use grep-based scanning for initial audit**
+- **Rationale:** Simple, fast, works across all languages (TypeScript, Python, Starlark, Go)
+- **Alternative considered:** AST parsing - too complex for initial pass
+- **Implementation:** Shell script that searches for patterns: `TODO`, `FIXME`, `XXX`, `BUG`, `HACK`
+
+**Decision 2: Prioritize TODOs by file location and context**
+- **Rationale:** Not all TODOs are equal - CLI commands affect users directly
+- **Priority order:**
+  1. CLI user-facing commands (resource, config)
+  2. Core discovery logic
+  3. Engine utilities
+  4. Test infrastructure
+
+**Decision 3: Implement TODOs with minimal viable solutions**
+- **Rationale:** Don't over-engineer; match the scope implied by the TODO comment
+- **Example:** `// TODO: Add your routes here` → Add basic route placeholder, not full routing system
+
+**Decision 4: Add tests for all implemented TODOs**
+- **Rationale:** Ensures fixes work and don't regress
+- **Approach:** Unit tests for CLI, integration tests where appropriate
+
+## Risks / Trade-offs
+
+**Risk:** TODO comments may be intentionally vague and require product decisions
+- **Mitigation:** For ambiguous TODOs, implement minimal viable solution and document the limitation
+
+**Risk:** Implementing TODOs may introduce bugs in working code
+- **Mitigation:** All changes get tests; use existing test patterns from the codebase
+
+**Risk:** Dead code removal might break something that appears unused but is dynamically loaded
+- **Mitigation:** Only remove code after verifying no references exist (static analysis + runtime check)
+
+**Risk:** Test coverage gaps may be larger than initially estimated
+- **Mitigation:** Focus on critical paths first; document remaining gaps for future work
+
+## Migration Plan
+
+Not applicable - this is an internal maintenance change with no user-facing migration needed.
+
+Deployment steps:
+1. Run audit script to generate initial report
+2. Fix TODOs in priority order (CLI first)
+3. Add tests for all changes
+4. Run full test suite to ensure no regressions
+5. Submit as single PR or split by module (CLI, Discovery, Engine)
+
+## Open Questions
+
+1. Should we create a recurring audit job (CI) to catch new TODOs?
+2. What's the policy for TODOs that require product decisions vs. technical implementation?
+3. Should we establish a "no TODOs in main" policy after this cleanup?

package/openspec/changes/archive/2026-04-29-scan-repo-gaps-fix/proposal.md

@@ -0,0 +1,31 @@
+## Why
+
+The TDK CLI codebase has accumulated technical debt through TODO comments, incomplete implementations, and gaps in test coverage. These issues create friction for developers and risk bugs in production. Now is the right time to systematically scan the repository, identify gaps, and fix them before they compound into larger problems.
+
+## What Changes
+
+- **Scan entire codebase** for TODO/FIXME/BUG/HACK comments using automated detection
+- **Identify incomplete implementations** in CLI commands (resource, config with TODOs)
+- **Find missing test coverage** for critical paths in CLI and discovery modules  
+- **Fix high-priority issues**: Implement TODO items, add missing error handling, improve type safety
+- **Add missing documentation** for unclear or undocumented code paths
+- **Clean up technical debt**: Remove dead code, consolidate duplicates, fix linting issues
+
+## Capabilities
+
+### New Capabilities
+- `codebase-audit`: Automated scanning system for detecting technical debt markers (TODOs, missing tests, incomplete features)
+- `todo-resolution`: Implementation of high-priority TODO items in CLI commands
+- `test-gap-fill`: Adding missing test coverage for critical code paths
+- `dead-code-cleanup`: Identification and removal of unused code and imports
+
+### Modified Capabilities
+- None - this is a maintenance/polish change that doesn't modify existing specifications
+
+## Impact
+
+- **CLI**: TypeScript source files in `cli/src/` - implementing TODOs in resource.ts, config.ts
+- **Tests**: Python tests in `tests/tilt-engine/` and TypeScript tests in `cli/` - adding missing coverage
+- **Discovery**: Python modules in `discovery/` - improving error handling and edge cases
+- **Engine**: Starlark files in `engine/` - minor cleanups and documentation improvements
+- **No breaking changes**: All fixes are additive or internal improvements

package/openspec/changes/archive/2026-04-29-scan-repo-gaps-fix/specs/codebase-audit/spec.md

@@ -0,0 +1,27 @@
+## ADDED Requirements
+
+### Requirement: Automated scanning detects technical debt markers
+The system SHALL provide automated scanning to detect TODO, FIXME, XXX, BUG, and HACK comments across all source files.
+
+#### Scenario: Scan TypeScript files
+- **WHEN** the audit script runs against the CLI source directory
+- **THEN** it SHALL output a list of all files containing TODO/FIXME/BUG/HACK markers with line numbers
+
+#### Scenario: Scan Python files
+- **WHEN** the audit script runs against the discovery directory
+- **THEN** it SHALL output a list of all files containing TODO/FIXME/BUG/HACK markers with line numbers
+
+#### Scenario: Scan Starlark files
+- **WHEN** the audit script runs against the engine directory
+- **THEN** it SHALL output a list of all files containing TODO/FIXME/BUG/HACK markers with line numbers
+
+### Requirement: Audit output is actionable
+The system SHALL generate an audit report that categorizes findings by priority and location.
+
+#### Scenario: Priority categorization
+- **WHEN** the audit completes
+- **THEN** findings SHALL be categorized as: CLI (user-facing), Core (discovery/engine), Test (infrastructure)
+
+#### Scenario: Report format
+- **WHEN** the audit generates a report
+- **THEN** it SHALL include file path, line number, marker type, and the TODO text for each finding

package/openspec/changes/archive/2026-04-29-scan-repo-gaps-fix/specs/dead-code-cleanup/spec.md

@@ -0,0 +1,27 @@
+## ADDED Requirements
+
+### Requirement: Dead code is identified and removed
+The system SHALL identify and remove unused code, imports, and variables.
+
+#### Scenario: Unused imports removed
+- **WHEN** scanning TypeScript files in cli/src
+- **THEN** all unused imports SHALL be identified and removed
+
+#### Scenario: Unused functions removed
+- **WHEN** scanning Python files in discovery/
+- **THEN** functions with no references SHALL be flagged for review and removed if confirmed unused
+
+#### Scenario: Dead Starlark code removed
+- **WHEN** scanning Starlark files in engine/
+- **THEN** unused variables and functions SHALL be identified and removed
+
+### Requirement: Duplicate code is consolidated
+The system SHALL identify and consolidate duplicate code patterns where appropriate.
+
+#### Scenario: Duplicate templates consolidated
+- **WHEN** similar template patterns exist in multiple CLI commands
+- **THEN** they SHALL be consolidated into shared utility functions
+
+#### Scenario: Shared validation logic
+- **WHEN** validation logic is duplicated across modules
+- **THEN** it SHALL be moved to a shared validation utility

package/openspec/changes/archive/2026-04-29-scan-repo-gaps-fix/specs/test-gap-fill/spec.md

@@ -0,0 +1,23 @@
+## ADDED Requirements
+
+### Requirement: CLI commands have test coverage
+The system SHALL add missing test coverage for CLI command implementations.
+
+#### Scenario: Resource command tests
+- **WHEN** running the test suite
+- **THEN** resource.ts command SHALL have unit tests covering resource creation, template generation, and port assignment
+
+#### Scenario: Config command tests
+- **WHEN** running the test suite
+- **THEN** config.ts command SHALL have unit tests covering diff functionality and configuration loading
+
+### Requirement: Error handling paths are tested
+The system SHALL add tests for error handling and edge cases.
+
+#### Scenario: Invalid resource type handling
+- **WHEN** user specifies an invalid resource type
+- **THEN** the system SHALL throw an appropriate error and test SHALL verify this behavior
+
+#### Scenario: Missing manifest handling
+- **WHEN** discovering services with missing or invalid manifests
+- **THEN** the system SHALL handle gracefully and log appropriate warnings (tested)

package/openspec/changes/archive/2026-04-29-scan-repo-gaps-fix/specs/todo-resolution/spec.md

@@ -0,0 +1,27 @@
+## ADDED Requirements
+
+### Requirement: CLI resource command TODOs are implemented
+The system SHALL implement all TODO comments in cli/src/commands/resource.ts.
+
+#### Scenario: Resource database check TODO
+- **WHEN** creating a new resource with database dependencies
+- **THEN** the system SHALL check if the database exists and create it if missing
+
+#### Scenario: Resource cache check TODO
+- **WHEN** creating a new resource with cache dependencies
+- **THEN** the system SHALL check if the cache service is configured
+
+#### Scenario: Resource routes TODO
+- **WHEN** creating a new backend resource
+- **THEN** the system SHALL generate a basic route file template with health check endpoint
+
+#### Scenario: Resource worker logic TODO
+- **WHEN** creating a new worker resource
+- **THEN** the system SHALL generate a basic worker script template with job processing structure
+
+### Requirement: CLI config command diff is implemented
+The system SHALL implement the diff logic TODO in cli/src/commands/config.ts.
+
+#### Scenario: Config diff shows differences
+- **WHEN** user runs `tdk config diff`
+- **THEN** the system SHALL compare local and remote configuration and display differences

package/openspec/changes/archive/2026-04-29-scan-repo-gaps-fix/tasks.md

@@ -0,0 +1,39 @@
+## 1. Codebase Audit
+
+- [x] 1.1 Create audit script to scan for TODO/FIXME/BUG/HACK markers
+- [x] 1.2 Run audit against cli/src directory (TypeScript files)
+- [x] 1.3 Run audit against discovery/ directory (Python and Starlark files)
+- [x] 1.4 Run audit against engine/ directory (Starlark files)
+- [x] 1.5 Generate prioritized report with CLI, Core, and Test categories
+
+## 2. CLI TODO Resolution
+
+- [x] 2.1 Implement database check TODO in cli/src/commands/resource.ts
+- [x] 2.2 Implement cache check TODO in cli/src/commands/resource.ts
+- [x] 2.3 Implement routes TODO (generate route file template) in resource.ts
+- [x] 2.4 Implement worker logic TODO (generate worker template) in resource.ts
+- [x] 2.5 Implement diff logic TODO in cli/src/commands/config.ts
+
+## 3. Test Coverage Improvements
+
+- [x] 3.1 Add unit tests for resource.ts command (creation, templates, port assignment)
+- [x] 3.2 Add unit tests for config.ts command (diff functionality)
+- [x] 3.3 Add error handling tests for invalid resource types
+- [x] 3.4 Add tests for missing/invalid manifest handling in discovery
+- [x] 3.5 Run full test suite and fix any regressions
+
+## 4. Dead Code Cleanup
+
+- [x] 4.1 Identify and remove unused imports in cli/src TypeScript files
+- [x] 4.2 Identify and flag unused functions in discovery/ Python files
+- [x] 4.3 Identify and flag unused variables/functions in engine/ Starlark files
+- [x] 4.4 Consolidate duplicate template patterns in CLI commands
+- [x] 4.5 Move duplicated validation logic to shared utilities
+
+## 5. Documentation and Finalization
+
+- [x] 5.1 Document all changes in commit messages
+- [x] 5.2 Update AGENTS.md files if implementation patterns changed
+- [x] 5.3 Run final linting and type checking
+- [x] 5.4 Verify all tests pass
+- [x] 5.5 Archive the audit report for future reference

package/openspec/changes/archive/2026-05-04-comprehensive-cleanup-final/.openspec.yaml

@@ -0,0 +1,5 @@
+schema: spec-driven
+created: 2026-05-04
+status: completed
+completed: 2026-05-04
+commit: cfa2ffc

package/openspec/changes/archive/2026-05-04-comprehensive-cleanup-final/design.md

@@ -0,0 +1,94 @@
+## Context
+
+TDK CLI is a multi-language monorepo (TypeScript CLI, Python Discovery, Starlark Engine) that has grown organically. Previous cleanup efforts have addressed specific issues, but a comprehensive, systematic cleanup across all dimensions is needed.
+
+**Current State:**
+- Code duplication exists across CLI commands and utilities
+- Type definitions are scattered and sometimes duplicated
+- Unused imports and functions remain from refactors
+- Circular dependencies exist in the module graph
+- Weak types (`any`, `unknown`) are used extensively
+- Defensive try/catch patterns hide errors unnecessarily
+- Legacy fallback code remains from migrations
+- AI-generated comments and stubs litter the codebase
+
+**Previous Cleanup Work:**
+- Dead code elimination assessment completed (2026-04-30)
+- Circular dependency critical assessment completed (2026-05-01)
+- Type assessment report available (2026-05-03)
+- AI slop assessment completed (2026-05-03)
+- Deduplication assessment completed
+
+## Goals / Non-Goals
+
+**Goals:**
+- Achieve 100% DRY compliance for code patterns appearing 3+ times
+- Consolidate all shared types into centralized type modules
+- Remove 100% of verified unused code (knip + manual verification)
+- Resolve all circular dependencies in the module graph
+- Replace 95%+ of weak types with strong, researched types
+- Remove all unnecessary defensive programming patterns
+- Eliminate all deprecated, legacy, and fallback code
+- Remove all AI slop, stubs, and unhelpful comments
+
+**Non-Goals:**
+- Complete rewrites of working functionality
+- Breaking changes to public APIs
+- Adding new features during cleanup
+- Perfection at the cost of progress (80/20 rule applies)
+
+## Decisions
+
+**Decision 1: Research-First Approach for Types**
+- **Rationale**: Weak types must be replaced with correct types, not guesses
+- **Implementation**: Research actual runtime values, package types, and usage patterns before replacing `any`/`unknown`
+
+**Decision 2: Verification Before Removal**
+- **Rationale**: Dead code removal must not break working systems
+- **Implementation**: Use knip for detection, then verify with manual analysis and tests before removal
+
+**Decision 3: Parallel Subagent Execution**
+- **Rationale**: 8 independent workstreams can proceed simultaneously
+- **Implementation**: Each dimension has a dedicated subagent with clear scope
+
+**Decision 4: Critical Assessment Required**
+- **Rationale**: Each subagent must deeply understand current state before changing
+- **Implementation**: Every subagent produces a critical assessment document before implementing
+
+**Decision 5: High Confidence Only**
+- **Rationale**: Low-confidence changes risk introducing bugs
+- **Implementation**: Only implement recommendations with clear evidence and low risk
+
+## Risks / Trade-offs
+
+**Risk: Removing code that appears unused but is dynamically loaded**
+- **Mitigation**: Manual verification beyond static analysis; test execution verification
+
+**Risk: Type replacements break runtime behavior**
+- **Mitigation**: Research actual values; use runtime checks if needed
+
+**Risk: Circular dependency fixes require architectural changes**
+- **Mitigation**: Document current state; propose minimal fixes; avoid major refactors
+
+**Risk: Defensive programming removal exposes hidden bugs**
+- **Mitigation**: Replace error-hiding with explicit error handling only where needed
+
+**Risk: Scope creep across 8 dimensions**
+- **Mitigation**: Strict boundaries per subagent; time-box each dimension
+
+## Migration Plan
+
+No user-facing migration needed. Internal changes only.
+
+Deployment steps:
+1. Execute all 8 subagents in parallel for research phase
+2. Review all critical assessments
+3. Implement high-confidence changes per dimension
+4. Run full test suite after each dimension completes
+5. Merge incrementally by dimension to limit blast radius
+
+## Open Questions
+
+1. Should we establish permanent tooling (knip, madge) in CI?
+2. What's the policy for `any` types that are truly unavoidable?
+3. Should we create a style guide to prevent future AI slop?