@tdk-landscape/tdk-cli-core 1.3.44 → 1.3.48

package/openspec/changes/archive/2026-04-28-rename-domain-to-stack-service-to-resource/design.md

@@ -0,0 +1,114 @@
+## Context
+
+The codebase currently has terminology inconsistencies that have evolved over time:
+
+1. **"domain" vs "stack"**: The manifest schema originally used `domain` to group related services, but this has been migrated to `stack`. Currently, code uses fallback patterns like `manifest.get('stack') or manifest.get('domain')` to support both, creating confusion about which is canonical.
+
+2. **"service" vs "resource"**: The architecture has shifted from thinking in terms of "services" (business-oriented) to "resources" (deployment-oriented Tilt resources). Function names like `get_app_resources()` exist alongside variable names like `svc` and `service`, and docstrings refer to "services" while the code handles "resources".
+
+3. **Cache keys**: The discovery cache uses `domain_configs` which doesn't align with the `stack` terminology.
+
+4. **Autogenerated files**: Files like `product_autogenerated_domains_index.star` use old terminology.
+
+These inconsistencies make the codebase harder to understand, especially for new developers. Standardizing on "stack" (for logical grouping) and "resource" (for deployable units) will provide clarity.
+
+## Goals / Non-Goals
+
+**Goals:**
+- Replace all `domain` manifest field access with `stack` (remove fallbacks)
+- Rename `domain_configs` cache key to `stack_configs`
+- Update all docstrings and comments from "service" to "resource"
+- Rename variables from `svc`, `service` to `resource`
+- Rename functions like `_render_product_domains_index()` to `_render_product_stacks_index()`
+- Update autogenerated file naming from `domains` to `stacks`
+- Ensure no functional changes - purely terminology refactoring
+
+**Non-Goals:**
+- Changing manifest file structure (the JSON schema)
+- Changing the actual behavior of any function
+- Adding new features or capabilities
+- Removing support for legacy manifest formats in the loader/parser
+- Renaming the `app_resources` cache key (widely used, high risk)
+
+## Decisions
+
+### Decision 1: Keep `app_resources` Cache Key
+**Rationale**: The `app_resources` key is used extensively across the codebase (50+ references). Changing it would touch too many files and create high risk of merge conflicts. The term "app resources" is acceptable since it describes the collection of resources for an app.
+
+**Alternatives considered**:
+- Rename to `resources` - Rejected due to high touchpoint count and risk
+- Keep as-is - Accepted as "app resources" is descriptive enough
+
+### Decision 2: Remove `domain` Fallback Patterns
+**Rationale**: Patterns like `manifest.get('stack') or manifest.get('domain')` exist to support legacy manifests. However, all current manifests should have migrated to `stack`. Removing the fallback simplifies code and establishes `stack` as the canonical field.
+
+**Migration approach**:
+```starlark
+# Before:
+stack = manifest.get('stack') or manifest.get('domain') or extract_stack_from_path(path)
+
+# After:
+stack = manifest.get('stack', extract_stack_from_path(path))
+```
+
+### Decision 3: Update Variable Names Incrementally
+**Rationale**: Variables like `svc`, `service` should become `resource`. However, in loops where context is clear (e.g., `for svc in resources`), shorter names are acceptable. Focus on function parameters and docstrings first.
+
+**Priority order**:
+1. Function parameter names
+2. Docstrings and comments
+3. Variable names in outer scope
+4. Loop variables (lower priority)
+
+### Decision 4: File Renaming for Autogenerated Files
+**Rationale**: Autogenerated files like `product_autogenerated_domains_index.star` should be renamed to use `stacks`. This requires updating both the file generation code and any `load()` statements that reference these files.
+
+## Risks / Trade-offs
+
+**Risk**: Breaking external code that reads `domain` from manifests
+- **Mitigation**: This is a **BREAKING** change as noted. External code must migrate to `stack` field.
+
+**Risk**: Inadvertent functional changes during bulk renaming
+- **Mitigation**: Each task will be focused on a specific file or small group. Tests must pass after each batch.
+
+**Risk**: Merge conflicts with ongoing development
+- **Mitigation**: Tasks are organized by directory to minimize conflict surface area. Complete quickly.
+
+**Risk**: Missing some instances of old terminology
+- **Mitigation**: Final verification task will grep for remaining `domain`, `svc`, `service` patterns.
+
+**Risk**: Variable name collisions after renaming
+- **Mitigation**: Use `resource` not `res` (too short). In nested contexts, use descriptive names like `app_resource`.
+
+## Migration Plan
+
+1. **Phase 1: Discovery System** (Tasks 1-40)
+   - Update `/discovery/` directory files
+   - Rename `domain_configs` to `stack_configs`
+   - Update manifest access patterns
+   - Update docstrings
+
+2. **Phase 2: Engine Topologies Tilt** (Tasks 41-100)
+   - Update deprecated system files
+   - Update generator files
+   - Update resource orchestration
+
+3. **Phase 3: Engine Topologies Platform** (Tasks 101-130)
+   - Update platform-level files
+   - Update Docker, networking, compose files
+
+4. **Phase 4: Autogenerated File Naming** (Tasks 131-140)
+   - Rename autogenerated file references
+   - Update file generation code
+
+5. **Phase 5: Verification** (Tasks 141-150)
+   - Run full test suite
+   - Grep for remaining `domain` references
+   - Grep for remaining `service` vs `resource` inconsistencies
+   - Verify no `manifest.get('domain')` patterns remain
+
+## Open Questions
+
+- Should we keep `app_resources` as-is or rename to `resources`? (Decision: keep as-is for now)
+- Should we update function names like `get_app_resources()`? (Decision: lower priority, focus on internals first)
+- How to handle `svc` in tight loops where context is clear? (Decision: focus on function params and docstrings first)

package/openspec/changes/archive/2026-04-28-rename-domain-to-stack-service-to-resource/proposal.md

@@ -0,0 +1,32 @@
+## Why
+
+The codebase currently uses inconsistent terminology: "domain" vs "stack" and "service" vs "resource" are used interchangeably, causing confusion. The manifest schema has migrated from `domain` to `stack` as the preferred field, and the architecture has shifted from "services" to "resources" as the core abstraction. Standardizing on "stack" (for grouping/organizing) and "resource" (for individual deployable units) will clarify the mental model and reduce cognitive overhead for developers working across 174+ .star files.
+
+## What Changes
+
+- **BREAKING** Rename all `domain` references to `stack` in manifest field access patterns (`manifest.get('domain')` → `manifest.get('stack')`)
+- **BREAKING** Rename `domain_configs` cache key to `stack_configs`
+- **BREAKING** Rename `_render_product_domains_index()` function to `_render_product_stacks_index()`
+- **BREAKING** Update all function docstrings and comments from "service" to "resource" terminology
+- **BREAKING** Rename variables like `svc` to `resource`, `service` to `resource` throughout
+- Remove fallback patterns like `manifest.get('stack') or manifest.get('domain')` and use only `stack`
+- Update autogenerated file names from `domains` to `stacks`
+
+## Capabilities
+
+### New Capabilities
+- `stack-terminology-standard`: Standardize all grouping/organization terminology to "stack"
+- `resource-terminology-standard`: Standardize all deployable unit terminology to "resource"
+- `manifest-field-migration`: Remove deprecated `domain` field support from manifest access patterns
+
+### Modified Capabilities
+<!-- No existing spec requirements are changing - this is terminology refactoring -->
+
+## Impact
+
+- **Affected Files**: 50+ .star files across `/discovery/`, `/engine/topologies/tilt/`, `/engine/topologies/platform/`
+- **Function Count**: 200+ function names, variables, and docstrings will be updated
+- **Dependencies**: Any external code accessing `domain` field in manifests will need to use `stack`
+- **Breaking Changes**: **BREAKING** - Manifest field access changes, function renames, cache key renames
+- **Risk Level**: High - extensive terminology changes across many files
+- **Testing Required**: Full test suite to verify no functional regressions

package/openspec/changes/archive/2026-04-28-rename-domain-to-stack-service-to-resource/specs/manifest-field-migration/spec.md

@@ -0,0 +1,20 @@
+## ADDED Requirements
+
+### Requirement: Manifest field migration from domain to stack
+All manifest field access patterns SHALL remove fallback support for the deprecated `domain` field.
+
+#### Scenario: No domain field fallback
+- **WHEN** code retrieves the stack field from a manifest
+- **THEN** it SHALL NOT use fallback patterns like `manifest.get('stack') or manifest.get('domain')`
+
+#### Scenario: Stack field with default only
+- **WHEN** a default value is needed for the stack field
+- **THEN** code SHALL use `manifest.get('stack', default_value)` and NOT check for domain
+
+#### Scenario: Domain field references removed
+- **WHEN** searching the codebase for domain field access
+- **THEN** no `manifest.get('domain')` patterns SHALL exist except in legacy parser code
+
+#### Scenario: Filtering uses stack field only
+- **WHEN** filtering manifests by logical group
+- **THEN** code SHALL filter by `stack` field only and NOT check `domain` as fallback

package/openspec/changes/archive/2026-04-28-rename-domain-to-stack-service-to-resource/specs/resource-terminology-standard/spec.md

@@ -0,0 +1,20 @@
+## ADDED Requirements
+
+### Requirement: Resource terminology standardization
+All references to deployable units SHALL use the term "resource" instead of "service".
+
+#### Scenario: Function parameters use resource terminology
+- **WHEN** a function accepts a deployable unit as a parameter
+- **THEN** the parameter name SHALL be `resource` or `resource_dict` and NOT `service` or `svc`
+
+#### Scenario: Docstrings use resource terminology
+- **WHEN** a function docstring describes a deployable unit
+- **THEN** it SHALL use the term "resource" and NOT "service"
+
+#### Scenario: Variable names use resource terminology
+- **WHEN** a variable holds a deployable unit
+- **THEN** the variable name SHALL be `resource` and NOT `svc` or `service`
+
+#### Scenario: Comments use resource terminology
+- **WHEN** code comments describe deployable units
+- **THEN** they SHALL use the term "resource" and NOT "service"

package/openspec/changes/archive/2026-04-28-rename-domain-to-stack-service-to-resource/specs/stack-terminology-standard/spec.md

@@ -0,0 +1,20 @@
+## ADDED Requirements
+
+### Requirement: Stack terminology standardization
+All references to logical grouping of resources SHALL use the term "stack" instead of "domain".
+
+#### Scenario: Manifest field access uses stack
+- **WHEN** code accesses the grouping field from a manifest
+- **THEN** it SHALL use `manifest.get('stack')` and NOT `manifest.get('domain')`
+
+#### Scenario: Cache keys use stack terminology
+- **WHEN** the discovery cache stores configuration for logical groups
+- **THEN** the cache key SHALL be named `stack_configs` and NOT `domain_configs`
+
+#### Scenario: Autogenerated files use stack naming
+- **WHEN** autogenerated index files are created for logical groups
+- **THEN** the filenames SHALL contain `stacks` and NOT `domains`
+
+#### Scenario: Function names use stack terminology
+- **WHEN** a function generates an index of logical groups
+- **THEN** the function name SHALL include `stacks` and NOT `domains`

package/openspec/changes/archive/2026-04-28-rename-domain-to-stack-service-to-resource/tasks.md

@@ -0,0 +1,194 @@
+## 1. Discovery Directory - Core Registry and Cache
+
+- [x] 1.1 Rename `domain_configs` to `stack_configs` in `discovery/registry.star` cache
+- [x] 1.2 Update `_render_product_domains_index()` to `_render_product_stacks_index()` in `discovery/registry.star`
+- [x] 1.3 Update all docstrings in `discovery/registry.star` from "service" to "resource"
+- [x] 1.4 Update variable names in `discovery/registry.star` from `svc` to `resource`
+- [x] 1.5 Update variable names in `discovery/registry.star` from `service` to `resource` (function params)
+- [x] 1.6 Rename `domain` references in `discovery/discovery_orchestrator.star` manifest access
+- [x] 1.7 Update docstrings in `discovery/discovery_orchestrator.star` from "service" to "resource"
+- [x] 1.8 Update variable names in `discovery/discovery_orchestrator.star` from `svc` to `resource`
+- [x] 1.9 Rename `domain` references in `discovery/incremental_discovery.star` manifest access
+- [x] 1.10 Update docstrings in `discovery/incremental_discovery.star` from "service" to "resource"
+
+## 2. Discovery Directory - Manifest and Loading
+
+- [x] 2.1 Rename `domain` references in `discovery/manifest/loading.star` to `stack`
+- [x] 2.2 Update docstrings in `discovery/manifest/loading.star` from "service" to "resource"
+- [x] 2.3 Rename `domain` references in `discovery/manifest/normalize.star` to `stack`
+- [x] 2.4 Update docstrings in `discovery/manifest/normalize.star` from "service" to "resource"
+- [x] 2.5 Rename `domain` references in `discovery/manifest/validation.star` to `stack`
+- [x] 2.6 Update docstrings in `discovery/manifest/validation.star` from "service" to "resource"
+- [x] 2.7 Rename `domain` references in `discovery/config.star` to `stack`
+- [x] 2.8 Update docstrings in `discovery/config.star` from "service" to "resource"
+- [x] 2.9 Rename `domain` references in `discovery/constants.star` to `stack`
+- [x] 2.10 Update docstrings in `discovery/constants.star` from "service" to "resource"
+
+## 3. Discovery Directory - Utilities and Validation
+
+- [x] 3.1 Rename `domain` references in `discovery/validation.star` to `stack`
+- [x] 3.2 Update docstrings in `discovery/validation.star` from "service" to "resource"
+- [x] 3.3 Rename `domain` references in `discovery/filtering.star` to `stack`
+- [x] 3.4 Update variable names in `discovery/filtering.star` from `svc` to `resource`
+- [x] 3.5 Rename `domain` references in `discovery/indexing.star` to `stack`
+- [x] 3.6 Update docstrings in `discovery/indexing.star` from "service" to "resource"
+- [x] 3.7 Rename `domain` references in `discovery/deterministic.star` to `stack`
+- [x] 3.8 Update variable names in `discovery/deterministic.star` from `svc` to `resource`
+- [x] 3.9 Rename `domain` references in `discovery/resource_snapshot.star` to `stack`
+- [x] 3.10 Update docstrings in `discovery/resource_snapshot.star` from "service" to "resource"
+
+## 4. Engine Topologies Tilt - Discovery (Deprecated System)
+
+- [x] 4.1 Rename `domain` references in `engine/topologies/tilt/discovery/registry.star` to `stack`
+- [x] 4.2 Update docstrings in `engine/topologies/tilt/discovery/registry.star` from "service" to "resource"
+- [x] 4.3 Rename `domain` references in `engine/topologies/tilt/discovery/discovery_orchestrator.star` to `stack`
+- [x] 4.4 Update docstrings in `engine/topologies/tilt/discovery/discovery_orchestrator.star` from "service" to "resource"
+- [x] 4.5 Rename `domain` references in `engine/topologies/tilt/discovery/incremental_discovery.star` to `stack`
+- [x] 4.6 Update docstrings in `engine/topologies/tilt/discovery/incremental_discovery.star` from "service" to "resource"
+- [x] 4.7 Rename `domain` references in `engine/topologies/tilt/discovery/manifest/loading.star` to `stack`
+- [x] 4.8 Update docstrings in `engine/topologies/tilt/discovery/manifest/loading.star` from "service" to "resource"
+- [x] 4.9 Rename `domain` references in `engine/topologies/tilt/discovery/manifest/normalize.star` to `stack`
+- [x] 4.10 Update docstrings in `engine/topologies/tilt/discovery/manifest/normalize.star` from "service" to "resource"
+
+## 5. Engine Topologies Tilt - Manifest Files
+
+- [x] 5.1 Rename `domain` references in `engine/topologies/tilt/discovery/manifest/validation.star` to `stack`
+- [x] 5.2 Update docstrings in `engine/topologies/tilt/discovery/manifest/validation.star` from "service" to "resource"
+- [x] 5.3 Rename `domain` references in `engine/topologies/tilt/manifest/parser.star` to `stack`
+- [x] 5.4 Update docstrings in `engine/topologies/tilt/manifest/parser.star` from "service" to "resource"
+- [x] 5.5 Rename `domain` references in `engine/topologies/tilt/manifest/loader.star` to `stack`
+- [x] 5.6 Update docstrings in `engine/topologies/tilt/manifest/loader.star` from "service" to "resource"
+- [x] 5.7 Rename `domain` references in `engine/topologies/tilt/manifest/mapper.star` to `stack`
+- [x] 5.8 Update docstrings in `engine/topologies/tilt/manifest/mapper.star` from "service" to "resource"
+- [x] 5.9 Rename `domain` references in `engine/topologies/tilt/manifest/integration.star` to `stack`
+- [x] 5.10 Update docstrings in `engine/topologies/tilt/manifest/integration.star` from "service" to "resource"
+
+## 6. Engine Topologies Tilt - Generators Vite
+
+- [x] 6.1 Rename `domain` references in `engine/topologies/tilt/generators/vite/backend.star` to `stack`
+- [x] 6.2 Update docstrings in `engine/topologies/tilt/generators/vite/backend.star` from "service" to "resource"
+- [x] 6.3 Rename `domain` references in `engine/topologies/tilt/generators/vite/frontend.star` to `stack`
+- [x] 6.4 Update docstrings in `engine/topologies/tilt/generators/vite/frontend.star` from "service" to "resource"
+- [x] 6.5 Rename `domain` references in `engine/topologies/tilt/generators/vite/library.star` to `stack`
+- [x] 6.6 Update docstrings in `engine/topologies/tilt/generators/vite/library.star` from "service" to "resource"
+- [x] 6.7 Rename `domain` references in `engine/topologies/tilt/generators/vite/sdk.star` to `stack`
+- [x] 6.8 Update docstrings in `engine/topologies/tilt/generators/vite/sdk.star` from "service" to "resource"
+- [x] 6.9 Rename `domain` references in `engine/topologies/tilt/generators/vite/generators.star` to `stack`
+- [x] 6.10 Update docstrings in `engine/topologies/tilt/generators/vite/generators.star` from "service" to "resource"
+
+## 7. Engine Topologies Tilt - Generators Docker
+
+- [x] 7.1 Rename `domain` references in `engine/topologies/tilt/generators/docker/frontend.star` to `stack` (file doesn't exist - moved to platform/docker/)
+- [x] 7.2 Update docstrings in `engine/topologies/tilt/generators/docker/frontend.star` from "service" to "resource" (file doesn't exist)
+- [x] 7.3 Rename `domain` references in `engine/topologies/tilt/generators/docker/backend.star` to `stack` (file doesn't exist - moved to platform/docker/)
+- [x] 7.4 Update docstrings in `engine/topologies/tilt/generators/docker/backend.star` from "service" to "resource" (file doesn't exist)
+- [x] 7.5 Rename `domain` references in `engine/topologies/tilt/generators/docker/compose.star` to `stack` (file doesn't exist - moved to platform/docker/compose/)
+- [x] 7.6 Update docstrings in `engine/topologies/tilt/generators/docker/compose.star` from "service" to "resource" (file doesn't exist)
+- [x] 7.7 Rename `domain` references in `engine/topologies/tilt/generators/validators.star` to `stack`
+- [x] 7.8 Update docstrings in `engine/topologies/tilt/generators/validators.star` from "service" to "resource"
+- [x] 7.9 Rename `domain` references in `engine/topologies/tilt/generators/database_provisioner.star` to `stack`
+- [x] 7.10 Update docstrings in `engine/topologies/tilt/generators/database_provisioner.star` from "service" to "resource"
+
+## 8. Engine Topologies Tilt - More Generators
+
+- [x] 8.1 Rename `domain` references in `engine/topologies/tilt/generators/nginx_conf.star` to `stack`
+- [x] 8.2 Update docstrings in `engine/topologies/tilt/generators/nginx_conf.star` from "service" to "resource"
+- [x] 8.3 Rename `domain` references in `engine/topologies/tilt/generators/npmrc.star` to `stack`
+- [x] 8.4 Update docstrings in `engine/topologies/tilt/generators/npmrc.star` from "service" to "resource"
+- [x] 8.5 Rename `domain` references in `engine/topologies/tilt/generators/env.star` to `stack` (file doesn't exist)
+- [x] 8.6 Update docstrings in `engine/topologies/tilt/generators/env.star` from "service" to "resource" (file doesn't exist)
+- [x] 8.7 Rename `domain` references in `engine/topologies/tilt/generators/tsconfig.star` to `stack`
+- [x] 8.8 Update docstrings in `engine/topologies/tilt/generators/tsconfig.star` from "service" to "resource"
+- [x] 8.9 Rename `domain` references in `engine/topologies/tilt/generators/dependency_manifest.star` to `stack`
+- [x] 8.10 Update docstrings in `engine/topologies/tilt/generators/dependency_manifest.star` from "service" to "resource"
+
+## 9. Engine Topologies Tilt - Infisical Generators
+
+- [x] 9.1 Rename `domain` references in `engine/topologies/tilt/generators/infisical/path_manager.star` to `stack`
+- [x] 9.2 Update docstrings in `engine/topologies/tilt/generators/infisical/path_manager.star` from "service" to "resource"
+- [x] 9.3 Rename `domain` references in `engine/topologies/tilt/generators/infisical/sync.star` to `stack` (file doesn't exist)
+- [x] 9.4 Update docstrings in `engine/topologies/tilt/generators/infisical/sync.star` from "service" to "resource" (file doesn't exist)
+- [x] 9.5 Rename `domain` references in `engine/topologies/tilt/generators/infisical/star_to_json.star` to `stack` (file doesn't exist)
+- [x] 9.6 Update docstrings in `engine/topologies/tilt/generators/infisical/star_to_json.star` from "service" to "resource" (file doesn't exist)
+- [x] 9.7 Rename `domain` references in `engine/topologies/tilt/generators/agents_md.star` to `stack`
+- [x] 9.8 Update docstrings in `engine/topologies/tilt/generators/agents_md.star` from "service" to "resource"
+- [x] 9.9 Rename `domain` references in `engine/topologies/tilt/generators/c4_diagram.star` to `stack`
+- [x] 9.10 Update docstrings in `engine/topologies/tilt/generators/c4_diagram.star` from "service" to "resource"
+
+## 10. Engine Topologies Tilt - Resource Orchestration
+
+- [x] 10.1 Rename `domain` references in `engine/topologies/tilt/resources/orchestrator/apply_compose_resource_registration.star` to `stack`
+- [x] 10.2 Update variable names in `engine/topologies/tilt/resources/orchestrator/apply_compose_resource_registration.star` from `svc` to `resource`
+- [x] 10.3 Rename `domain` references in `engine/topologies/tilt/resources/orchestrator/apply_manifest_orchestration.star` to `stack`
+- [x] 10.4 Update variable names in `engine/topologies/tilt/resources/orchestrator/apply_manifest_orchestration.star` from `svc` to `resource`
+- [x] 10.5 Rename `domain` references in `engine/topologies/tilt/resources/orchestrator/apply_migrator_orchestration.star` to `stack`
+- [x] 10.6 Update variable names in `engine/topologies/tilt/resources/orchestrator/apply_migrator_orchestration.star` from `svc` to `resource`
+- [x] 10.7 Rename `domain` references in `engine/topologies/tilt/resources/orchestrator/generators/frontend.star` to `stack`
+- [x] 10.8 Update variable names in `engine/topologies/tilt/resources/orchestrator/generators/frontend.star` from `svc` to `resource`
+- [x] 10.9 Rename `domain` references in `engine/topologies/tilt/resources/orchestrator/generators/env.star` to `stack`
+- [x] 10.10 Update variable names in `engine/topologies/tilt/resources/orchestrator/generators/env.star` from `svc` to `resource`
+
+## 11. Engine Topologies Tilt - Resource Definition Files
+
+- [x] 11.1 Rename `domain` references in `engine/topologies/tilt/resources/libs_resource_definition.star` to `stack`
+- [x] 11.2 Update variable names in `engine/topologies/tilt/resources/libs_resource_definition.star` from `svc` to `resource`
+- [x] 11.3 Rename `domain` references in `engine/topologies/tilt/resources/libs_tsconfig.star` to `stack`
+- [x] 11.4 Update variable names in `engine/topologies/tilt/resources/libs_tsconfig.star` from `svc` to `resource`
+- [x] 11.5 Rename `domain` references in `engine/topologies/tilt/resources/libs_setup.star` to `stack`
+- [x] 11.6 Update variable names in `engine/topologies/tilt/resources/libs_setup.star` from `svc` to `resource`
+- [x] 11.7 Rename `domain` references in `engine/topologies/tilt/resources/infra-loader.star` to `stack`
+- [x] 11.8 Update variable names in `engine/topologies/tilt/resources/infra-loader.star` from `svc` to `resource`
+- [x] 11.9 Rename `domain` references in `engine/topologies/tilt/resources/frontend_resource.star` to `stack` (file doesn't exist)
+- [x] 11.10 Update variable names in `engine/topologies/tilt/resources/frontend_resource.star` from `svc` to `resource` (file doesn't exist)
+
+## 12. Engine Topologies Tilt - More Resource Files
+
+- [x] 12.1 Rename `domain` references in `engine/topologies/tilt/resources/backend_resource.star` to `stack` (file doesn't exist)
+- [x] 12.2 Update variable names in `engine/topologies/tilt/resources/backend_resource.star` from `svc` to `resource` (file doesn't exist)
+- [x] 12.3 Rename `domain` references in `engine/topologies/tilt/resources/database_resource.star` to `stack` (file doesn't exist)
+- [x] 12.4 Update variable names in `engine/topologies/tilt/resources/database_resource.star` from `svc` to `resource` (file doesn't exist)
+- [x] 12.5 Rename `domain` references in `engine/topologies/tilt/resources/infra_resource.star` to `stack` (file doesn't exist)
+- [x] 12.6 Update variable names in `engine/topologies/tilt/resources/infra_resource.star` from `svc` to `resource` (file doesn't exist)
+- [x] 12.7 Rename `domain` references in `engine/topologies/tilt/resources/proxy_resource.star` to `stack` (file doesn't exist)
+- [x] 12.8 Update variable names in `engine/topologies/tilt/resources/proxy_resource.star` from `svc` to `resource` (file doesn't exist)
+- [x] 12.9 Rename `domain` references in `engine/topologies/tilt/resources/migration_resource.star` to `stack` (file doesn't exist)
+- [x] 12.10 Update variable names in `engine/topologies/tilt/resources/migration_resource.star` from `svc` to `resource` (file doesn't exist)
+
+## 13. Engine Topologies Platform - Docker and Compose
+
+- [x] 13.1 Rename `domain` references in `engine/topologies/platform/docker/compose/compose.star` to `stack`
+- [x] 13.2 Update docstrings in `engine/topologies/platform/docker/compose/compose.star` from "service" to "resource"
+- [x] 13.3 Rename `domain` references in `engine/topologies/platform/docker/layers.star` to `stack` (file doesn't exist)
+- [x] 13.4 Update docstrings in `engine/topologies/platform/docker/layers.star` from "service" to "resource" (file doesn't exist)
+- [x] 13.5 Rename `domain` references in `engine/topologies/platform/docker/networking/traefik.star` to `stack`
+- [x] 13.6 Update docstrings in `engine/topologies/platform/docker/networking/traefik.star` from "service" to "resource"
+- [x] 13.7 Rename `domain` references in `engine/topologies/platform/docker/networking/traefik_helpers.star` to `stack`
+- [x] 13.8 Update docstrings in `engine/topologies/platform/docker/networking/traefik_helpers.star` from "service" to "resource"
+- [x] 13.9 Rename `domain` references in `engine/topologies/platform/docker/constants.star` to `stack`
+- [x] 13.10 Update docstrings in `engine/topologies/platform/docker/constants.star` from "service" to "resource"
+
+## 14. Engine Topologies Platform - Security and Proxy
+
+- [x] 14.1 Rename `domain` references in `engine/topologies/platform/security/secrets.star` to `stack`
+- [x] 14.2 Update docstrings in `engine/topologies/platform/security/secrets.star` from "service" to "resource"
+- [x] 14.3 Rename `domain` references in `engine/topologies/platform/security/infisical.star` to `stack` (file doesn't exist)
+- [x] 14.4 Update docstrings in `engine/topologies/platform/security/infisical.star` from "service" to "resource" (file doesn't exist)
+- [x] 14.5 Rename `domain` references in `engine/topologies/platform/proxy/caddy.star` to `stack` (file doesn't exist)
+- [x] 14.6 Update docstrings in `engine/topologies/platform/proxy/caddy.star` from "service" to "resource" (file doesn't exist)
+- [x] 14.7 Rename `domain` references in `engine/topologies/platform/proxy/nginx.star` to `stack` (file doesn't exist)
+- [x] 14.8 Update docstrings in `engine/topologies/platform/proxy/nginx.star` from "service" to "resource" (file doesn't exist)
+- [x] 14.9 Rename `domain` references in `engine/topologies/platform/state/persistence.star` to `stack` (file doesn't exist)
+- [x] 14.10 Update docstrings in `engine/topologies/platform/state/persistence.star` from "service" to "resource" (file doesn't exist)
+
+## 15. Autogenerated Files and Final Verification
+
+- [x] 15.1 Update autogenerated file naming in `discovery/registry.star` from `domains` to `stacks`
+- [x] 15.2 Update autogenerated file naming in `engine/topologies/tilt/discovery/registry.star` from `domains` to `stacks`
+- [x] 15.3 Update all `load()` statements that reference domain-named files to stack-named files
+- [x] 15.4 Run test suite to verify all terminology changes work correctly
+- [x] 15.5 Grep for remaining `manifest.get('domain')` patterns - should be 0
+- [x] 15.6 Grep for remaining `domain_configs` references - should be 0
+- [x] 15.7 Grep for remaining `svc` variables that should be `resource` - verified minimal
+- [x] 15.8 Grep for remaining `service` docstrings that should say `resource` - verified 0
+- [x] 15.9 Verify `app_resources` cache key is intentionally kept (per design decision)
+- [x] 15.10 Final review: All domain→stack and service→resource migrations complete

package/openspec/changes/archive/2026-04-28-star-files-parameter-fixes/.openspec.yaml

@@ -0,0 +1,2 @@
+schema: spec-driven
+created: 2026-04-28

package/openspec/changes/archive/2026-04-28-star-files-parameter-fixes/design.md

@@ -0,0 +1,111 @@
+## Context
+
+The codebase currently has 174 .star files with 774 function definitions across multiple directories. Through analysis, we've identified several parameter inconsistency issues:
+
+1. **Write Function Parameter Naming**: Functions use `write_fn`, `write_file_fn`, and `write_file_if_changed_fn` interchangeably for the same concept
+2. **Parameter Ordering**: Some functions have `write_fn` at the end, others have it earlier in the parameter list
+3. **Missing Documentation**: Most functions lack parameter documentation explaining expected types and purposes
+4. **Naming Divergence**: The primary `/discovery/` system and deprecated `/engine/topologies/tilt/discovery/` system use different naming conventions (e.g., `register_new_service` vs `register_new_resource`)
+5. **Optional Parameter Patterns**: Inconsistent use of `write_fn=None` pattern for dependency injection
+
+These inconsistencies make the codebase harder to navigate, maintain, and extend. This refactoring aims to establish clear conventions without changing any functional behavior.
+
+## Goals / Non-Goals
+
+**Goals:**
+- Standardize all write function parameter names to `write_fn`
+- Ensure optional parameters consistently appear at the end of parameter lists
+- Add parameter documentation (docstring-style comments) to all functions
+- Align function names between duplicate discovery systems where they diverge
+- Maintain 100% backward compatibility in behavior (no functional changes)
+- Enable parallel execution of all 100 subtasks
+
+**Non-Goals:**
+- Changing function logic or behavior
+- Adding new features or capabilities
+- Removing deprecated files (they are kept for backward compatibility)
+- Renaming functions unless they have divergent names between duplicate systems
+- Adding runtime type checking (only documentation)
+
+## Decisions
+
+### Decision 1: Standardize on `write_fn` Parameter Name
+**Rationale**: The name `write_fn` is concise, clear, and already used in the majority of functions. It's shorter than `write_file_if_changed_fn` without losing clarity.
+
+**Alternatives considered**:
+- `write_file_fn` - More explicit but redundant since context makes it clear
+- `write_file_if_changed_fn` - Too verbose for frequent use
+- Keep all variations - Rejected as it perpetuates inconsistency
+
+### Decision 2: Optional Parameters at End of Signature
+**Rationale**: Following Python/Starlark conventions, parameters with default values should come after required parameters. This makes function calls more readable and prevents positional argument errors.
+
+**Pattern to enforce**:
+```starlark
+def function_name(required1, required2, optional1=None, optional2=True):
+```
+
+### Decision 3: Docstring Format for Starlark
+**Rationale**: Starlark doesn't have a formal docstring standard like Python. We'll use a consistent comment-based format:
+
+```starlark
+def function_name(param1, param2, write_fn=None):
+    """
+    Brief description of function.
+    
+    Args:
+        param1: Description of param1 (type)
+        param2: Description of param2 (type)
+        write_fn: Optional write function for dependency injection (callable)
+    
+    Returns:
+        Description of return value (type)
+    """
+```
+
+### Decision 4: Parallel Task Execution
+**Rationale**: Since these are independent refactoring tasks across different files, they can be executed in parallel. Each task focuses on a specific file or small group of related files.
+
+**Task organization**:
+- Group 1-40: `/discovery/` directory (primary system)
+- Group 41-80: `/engine/topologies/tilt/` directory (deprecated system)
+- Group 81-95: `/engine/topologies/platform/` directory
+- Group 96-100: `/specs/` directory and cross-cutting concerns
+
+## Risks / Trade-offs
+
+**Risk**: Breaking changes for external callers using keyword arguments
+- **Mitigation**: This is a **BREAKING** change as noted in proposal. External code will need to update parameter names. We'll document all changed parameter names in the tasks.
+
+**Risk**: Inadvertent functional changes during refactoring
+- **Mitigation**: Each task includes verification step to confirm no behavior changes. All existing tests must pass.
+
+**Risk**: Merge conflicts with ongoing development
+- **Mitigation**: Short timeline for completion. Tasks are small and focused, minimizing conflict window.
+
+**Risk**: Deprecated system modifications may seem wasteful
+- **Mitigation**: Keeping deprecated system consistent reduces cognitive load when comparing or potentially migrating between systems.
+
+## Migration Plan
+
+1. **Phase 1: Analysis** (completed)
+   - Catalog all 174 .star files and 774 functions
+   - Identify specific parameter inconsistencies
+
+2. **Phase 2: Implementation** (current)
+   - Execute 100 parallel subtasks to fix parameter issues
+   - Each task updates specific files with standardized patterns
+
+3. **Phase 3: Verification**
+   - Run full test suite
+   - Verify no functional changes
+   - Check for any missed inconsistencies
+
+4. **Phase 4: Documentation**
+   - Update any developer documentation with new conventions
+   - Add parameter naming conventions to coding standards
+
+## Open Questions
+
+- Should we add a linting rule to prevent future parameter naming inconsistencies?
+- Should we create a style guide document for Starlark conventions?

package/openspec/changes/archive/2026-04-28-star-files-parameter-fixes/proposal.md

@@ -0,0 +1,33 @@
+## Why
+
+The codebase contains 174 .star files with 774 function definitions that have inconsistent parameter naming, ordering, and documentation. This inconsistency creates cognitive overhead for developers, makes the code harder to maintain, and increases the risk of bugs when functions are called with incorrect arguments. Standardizing function parameters across all star files will improve code readability, reduce maintenance burden, and establish clear conventions for future development.
+
+## What Changes
+
+- **Standardize write function parameter naming**: Unify all variations (`write_fn`, `write_file_fn`, `write_file_if_changed_fn`) to a consistent `write_fn` parameter name across all generator functions
+- **Fix parameter ordering**: Ensure optional parameters with defaults (especially `write_fn=None`) consistently appear at the end of parameter lists
+- **Add missing parameter documentation**: Add docstring-style comments for all function parameters explaining their purpose and types
+- **Normalize function naming between duplicate systems**: Align function names between `/discovery/` (primary) and `/engine/topologies/tilt/discovery/` (deprecated) where they diverge (e.g., `register_new_service` vs `register_new_resource`)
+- **Standardize optional parameter patterns**: Ensure all file-writing functions use consistent `write_fn=None` pattern for dependency injection
+- **Add type hints where missing**: Document expected parameter types (string, dict, bool, function, etc.) in function signatures
+
+## Capabilities
+
+### New Capabilities
+- `parameter-naming-consistency`: Standardize all write function parameter names to `write_fn`
+- `parameter-ordering-standard`: Ensure consistent parameter ordering with optional params last
+- `parameter-documentation`: Add docstring documentation for all function parameters
+- `function-naming-alignment`: Align function names between duplicate discovery systems
+- `optional-parameter-patterns`: Standardize `write_fn=None` pattern across all generators
+
+### Modified Capabilities
+<!-- No existing spec requirements are changing - this is purely refactoring for consistency -->
+
+## Impact
+
+- **Affected Files**: 174 .star files across `/discovery/`, `/engine/topologies/tilt/`, `/engine/topologies/platform/`, and `/specs/` directories
+- **Function Count**: 774 function definitions will be reviewed and standardized
+- **Dependencies**: No external dependencies affected - this is internal refactoring
+- **Breaking Changes**: **BREAKING** - Any external code calling these functions with keyword arguments will need to update parameter names
+- **Risk Level**: Medium - extensive changes across many files, but purely refactoring with no behavioral changes
+- **Testing Required**: All existing tests must pass; no functional changes expected

package/openspec/changes/archive/2026-04-28-star-files-parameter-fixes/specs/function-naming-alignment/spec.md

@@ -0,0 +1,12 @@
+## ADDED Requirements
+
+### Requirement: Function naming alignment between duplicate systems
+Functions in the primary `/discovery/` system and deprecated `/engine/topologies/tilt/discovery/` system SHALL use consistent naming where they serve identical purposes.
+
+#### Scenario: Function names match between systems
+- **WHEN** two functions in duplicate systems perform the same operation
+- **THEN** they SHALL have identical names
+
+#### Scenario: Divergent names are aligned
+- **WHEN** a function in the primary system is named `register_new_service` and the equivalent in the deprecated system is named `register_new_resource`
+- **THEN** the deprecated system function SHALL be renamed to match the primary system naming convention

package/openspec/changes/archive/2026-04-28-star-files-parameter-fixes/specs/optional-parameter-patterns/spec.md

@@ -0,0 +1,18 @@
+## ADDED Requirements
+
+### Requirement: Consistent optional write function parameter pattern
+All file-writing functions SHALL use the `write_fn=None` pattern for optional write function injection.
+
+#### Scenario: Write function parameter has None default
+- **WHEN** a function accepts an optional write function parameter
+- **THEN** the parameter SHALL have a default value of `None`
+
+#### Scenario: Write function parameter is optional
+- **WHEN** a generator function does not require an external write function
+- **THEN** the `write_fn` parameter SHALL be optional with `None` default, allowing the function to use an internal default implementation
+
+#### Scenario: Write function conditional usage
+- **WHEN** a function receives `write_fn=None`
+- **THEN** the function SHALL use its internal default write implementation
+- **AND** **WHEN** a callable is passed to `write_fn`
+- **THEN** the function SHALL use the provided callable instead

package/openspec/changes/archive/2026-04-28-star-files-parameter-fixes/specs/parameter-documentation/spec.md

@@ -0,0 +1,16 @@
+## ADDED Requirements
+
+### Requirement: Function parameter documentation
+All function parameters SHALL be documented with their purpose and expected type.
+
+#### Scenario: Parameter has documentation comment
+- **WHEN** a function defines parameters
+- **THEN** each parameter SHALL have a docstring-style comment describing its purpose and type
+
+#### Scenario: Parameter documentation includes type information
+- **WHEN** parameter documentation is added
+- **THEN** the documentation SHALL indicate the expected type (string, dict, bool, callable, etc.)
+
+#### Scenario: Optional parameter documentation notes default
+- **WHEN** a parameter has a default value
+- **THEN** the documentation SHALL indicate the default value and that the parameter is optional

package/openspec/changes/archive/2026-04-28-star-files-parameter-fixes/specs/parameter-naming-consistency/spec.md

@@ -0,0 +1,12 @@
+## ADDED Requirements
+
+### Requirement: Write function parameter naming consistency
+All functions that accept a file-writing callback parameter SHALL use the parameter name `write_fn` exclusively.
+
+#### Scenario: Function uses write_fn parameter
+- **WHEN** a generator function accepts a file-writing callback
+- **THEN** the parameter SHALL be named `write_fn` and NOT `write_file_fn`, `write_file_if_changed_fn`, or other variations
+
+#### Scenario: Inconsistent parameter names are corrected
+- **WHEN** a function uses `write_file_fn` or `write_file_if_changed_fn` as parameter names
+- **THEN** the parameter name SHALL be changed to `write_fn`