@tdk-landscape/tdk-cli-core 1.3.15 → 1.3.22

package/engine/topologies/tilt/manifest/tests/test_integration.star

@@ -0,0 +1,276 @@
+# =============================================================================
+# 📋 MANIFEST MODULE - INTEGRATION TESTS (Phase 4)
+# =============================================================================
+# Path: .tilt/topologies/tilt/manifest/tests/test_integration.star
+# Purpose: Integration tests for discovery system integration
+# Status: Phase 4 of manifest system refactoring
+# =============================================================================
+
+load("../__init__.star", "Manifest")
+load("../integration.star", "ManifestIntegration")
+
+# =============================================================================
+# TEST FRAMEWORK
+# =============================================================================
+
+test_results = {
+    'passed': 0,
+    'failed': 0,
+    'errors': [],
+}
+
+def assert_true(condition, message="Assertion failed"):
+    """Assert that condition is true."""
+    if not condition:
+        test_results['failed'] += 1
+        test_results['errors'].append("FAIL: " + message)
+    else:
+        test_results['passed'] += 1
+
+def assert_equal(expected, actual, message="Values not equal"):
+    """Assert that expected equals actual."""
+    if expected != actual:
+        test_results['failed'] += 1
+        test_results['errors'].append(
+            "FAIL: {} - expected '{}', got '{}'".format(message, expected, actual)
+        )
+    else:
+        test_results['passed'] += 1
+
+def assert_not_none(value, message="Value is None"):
+    """Assert that value is not None."""
+    if value == None:
+        test_results['failed'] += 1
+        test_results['errors'].append("FAIL: " + message)
+    else:
+        test_results['passed'] += 1
+
+# =============================================================================
+# TEST SUITE: Integration Functions
+# =============================================================================
+
+def _test_integration_functions():
+    """Test integration functions are accessible."""
+    print("🔍 Testing integration functions...")
+    
+    # Test via facade
+    assert_not_none(Manifest.load_and_validate_integration, "load_and_validate_integration should be accessible")
+    assert_not_none(Manifest.load_all_integration, "load_all_integration should be accessible")
+    assert_not_none(Manifest.convert_to_resource, "convert_to_resource should be accessible")
+    assert_not_none(Manifest.get_validation_summary, "get_validation_summary should be accessible")
+    assert_not_none(Manifest.check_port_conflicts, "check_port_conflicts should be accessible")
+    assert_not_none(Manifest.check_dependencies_valid, "check_dependencies_valid should be accessible")
+    
+    # Test via integration module
+    assert_not_none(ManifestIntegration.load_and_validate, "ManifestIntegration.load_and_validate should exist")
+    assert_not_none(ManifestIntegration.load_all, "ManifestIntegration.load_all should exist")
+    
+    print("✅ Integration functions accessible\n")
+
+# =============================================================================
+# TEST SUITE: Convert to Resource
+# =============================================================================
+
+def _test_convert_to_resource():
+    """Test manifest to resource conversion."""
+    print("🔍 Testing convert_to_resource...")
+    
+    # Test backend conversion
+    backend_manifest = {
+        'appName': 'user-management-backend',
+        'appType': 'backend',
+        'stack': 'user',
+        'port': 4000,
+        'syncs': ['src', 'prisma'],
+        '_resource_path': 'services/product/user/user-management-backend',
+        '_manifest': {'runtime': 'bun'},
+    }
+    
+    resource = Manifest.convert_to_resource(backend_manifest)
+    
+    assert_equal('user-management-backend', resource['name'], "Should preserve name")
+    assert_equal(4000, resource['port'], "Should preserve port")
+    assert_equal('user', resource['stack'], "Should preserve stack")
+    assert_true('frontend' not in resource or not resource['frontend'], "Should not mark as frontend")
+    assert_equal('services/product/user/user-management-backend', resource['_resource_path'], "Should preserve service path")
+    
+    # Test frontend conversion
+    frontend_manifest = {
+        'appName': 'user-management-frontend',
+        'appType': 'frontend',
+        'stack': 'user',
+        'port': 3000,
+        'backendName': 'user-management-backend',
+        '_resource_path': 'services/product/user/user-management-frontend',
+    }
+    
+    resource = Manifest.convert_to_resource(frontend_manifest)
+    
+    assert_equal('user-management-frontend', resource['name'], "Should preserve name")
+    assert_true(resource.get('frontend', False), "Should mark as frontend")
+    assert_equal('user-management-backend', resource['backendName'], "Should preserve backendName")
+    
+    print("✅ Convert to resource tests complete\n")
+
+# =============================================================================
+# TEST SUITE: Validation Summary
+# =============================================================================
+
+def _test_validation_summary():
+    """Test validation summary generation."""
+    print("🔍 Testing validation summary...")
+    
+    manifests = [
+        {
+            'appName': 'valid-service',
+            'appType': 'backend',
+            'stack': 'user',
+            'port': 4000,
+        },
+        {
+            'appName': 'valid-frontend',
+            'appType': 'frontend',
+            'stack': 'user',
+            'port': 3000,
+            'backendName': 'valid-service',
+        },
+    ]
+    
+    summary = Manifest.get_validation_summary(manifests)
+    
+    assert_equal(2, summary['total'], "Should count total manifests")
+    assert_true('valid' in summary, "Should have valid count")
+    assert_true('invalid' in summary, "Should have invalid count")
+    assert_true('by_severity' in summary, "Should have severity breakdown")
+    
+    print("✅ Validation summary tests complete\n")
+
+# =============================================================================
+# TEST SUITE: Port Conflicts
+# =============================================================================
+
+def _test_port_conflicts():
+    """Test port conflict detection."""
+    print("🔍 Testing port conflict detection...")
+    
+    # No conflicts
+    no_conflict = [
+        {'appName': 'service-1', 'port': 4000},
+        {'appName': 'service-2', 'port': 4001},
+        {'appName': 'service-3', 'port': 4002},
+    ]
+    
+    conflicts = Manifest.check_port_conflicts(no_conflict)
+    assert_equal(0, len(conflicts), "Should find no conflicts for unique ports")
+    
+    # With conflicts
+    with_conflict = [
+        {'appName': 'service-1', 'port': 4000},
+        {'appName': 'service-2', 'port': 4000},  # Conflict!
+        {'appName': 'service-3', 'port': 4001},
+    ]
+    
+    conflicts = Manifest.check_port_conflicts(with_conflict)
+    assert_true(len(conflicts) > 0, "Should find port conflicts")
+    
+    print("✅ Port conflict tests complete\n")
+
+# =============================================================================
+# TEST SUITE: Dependency Validation
+# =============================================================================
+
+def _test_dependency_validation():
+    """Test dependency validation across services."""
+    print("🔍 Testing dependency validation...")
+    
+    manifests = [
+        {
+            'appName': 'identity-backend',
+            'appType': 'backend',
+            'stack': 'identity',
+            'port': 4004,
+        },
+        {
+            'appName': 'user-backend',
+            'appType': 'backend',
+            'stack': 'user',
+            'port': 4000,
+            'dependsOn': ['identity-backend'],  # Valid
+        },
+        {
+            'appName': 'user-frontend',
+            'appType': 'frontend',
+            'stack': 'user',
+            'port': 3000,
+            'backendName': 'user-backend',  # Valid
+        },
+        {
+            'appName': 'bad-service',
+            'appType': 'backend',
+            'stack': 'user',
+            'port': 4001,
+            'dependsOn': ['nonexistent-service'],  # Invalid
+        },
+    ]
+    
+    errors = Manifest.check_dependencies_valid(manifests)
+    
+    # Should find at least one error for nonexistent dependency
+    assert_true(len(errors) > 0, "Should find dependency issues")
+    
+    print("✅ Dependency validation tests complete\n")
+
+# =============================================================================
+# TEST SUITE: Feature Flag
+# =============================================================================
+
+def _test_feature_flag():
+    """Test the feature flag system."""
+    print("🔍 Testing feature flag...")
+    
+    # Check if flag is accessible
+    use_new = ManifestIntegration.use_new_system()
+    assert_true(use_new != None, "Feature flag should return boolean")
+    
+    print("✅ Feature flag tests complete\n")
+
+# =============================================================================
+# MAIN
+# =============================================================================
+
+def run_tests():
+    """Run all Phase 4 integration tests."""
+    print("\n" + "="*70)
+    print("📋 MANIFEST MODULE - PHASE 4 INTEGRATION TESTS")
+    print("="*70 + "\n")
+    
+    # Run all test suites
+    _test_integration_functions()
+    _test_convert_to_resource()
+    _test_validation_summary()
+    _test_port_conflicts()
+    _test_dependency_validation()
+    _test_feature_flag()
+    
+    # Print results
+    print("\n" + "="*70)
+    print("📊 TEST RESULTS")
+    print("="*70)
+    print("✅ Passed: {}".format(test_results['passed']))
+    print("❌ Failed: {}".format(test_results['failed']))
+    
+    if test_results['errors']:
+        print("\n📝 ERRORS:")
+        for error in test_results['errors']:
+            print("   " + error)
+    else:
+        print("\n🎉 All Phase 4 integration tests passed!")
+    
+    print("="*70 + "\n")
+    
+    return test_results['failed'] == 0
+
+# Export test runner
+TestIntegration = struct(
+    run=run_tests,
+)

package/engine/topologies/tilt/manifest/tests/test_loader_parser.star

@@ -0,0 +1,397 @@
+# =============================================================================
+# 📋 MANIFEST MODULE - INTEGRATION TESTS (Phase 2)
+# =============================================================================
+# Path: .tilt/topologies/tilt/manifest/tests/test_loader_parser.star
+# Purpose: Integration tests for loader and parser modules
+# Status: Phase 2 of manifest system refactoring
+# =============================================================================
+
+load("../__init__.star", "Manifest")
+load("../loader.star", "ManifestLoader")
+load("../parser.star", "ManifestParser")
+
+# =============================================================================
+# TEST FRAMEWORK
+# =============================================================================
+
+test_results = {
+    'passed': 0,
+    'failed': 0,
+    'errors': [],
+}
+
+def assert_true(condition, message="Assertion failed"):
+    """Assert that condition is true."""
+    if not condition:
+        test_results['failed'] += 1
+        test_results['errors'].append("FAIL: " + message)
+    else:
+        test_results['passed'] += 1
+
+def assert_equal(expected, actual, message="Values not equal"):
+    """Assert that expected equals actual."""
+    if expected != actual:
+        test_results['failed'] += 1
+        test_results['errors'].append(
+            "FAIL: {} - expected '{}', got '{}'".format(message, expected, actual)
+        )
+    else:
+        test_results['passed'] += 1
+
+def assert_not_none(value, message="Value is None"):
+    """Assert that value is not None."""
+    if value == None:
+        test_results['failed'] += 1
+        test_results['errors'].append("FAIL: " + message)
+    else:
+        test_results['passed'] += 1
+
+def assert_in(value, collection, message="Value not in collection"):
+    """Assert that value is in collection."""
+    found = False
+    for item in collection:
+        if item == value:
+            found = True
+            break
+    
+    if not found:
+        test_results['failed'] += 1
+        test_results['errors'].append(
+            "FAIL: {} - '{}' not in collection".format(message, value)
+        )
+    else:
+        test_results['passed'] += 1
+
+# =============================================================================
+# TEST SUITE: Loader Module
+# =============================================================================
+
+def _test_loader_functions():
+    """Test loader functions."""
+    print("🔍 Testing loader module...")
+    
+    # Test that loader functions are accessible via facade
+    assert_not_none(Manifest.load_from_file, "load_from_file should be accessible")
+    assert_not_none(Manifest.load_from_path, "load_from_path should be accessible")
+    assert_not_none(Manifest.load_all, "load_all should be accessible")
+    assert_not_none(Manifest.clear_cache, "clear_cache should be accessible")
+    assert_not_none(Manifest.get_cache_stats, "get_cache_stats should be accessible")
+    assert_not_none(Manifest.is_cached, "is_cached should be accessible")
+    assert_not_none(Manifest.get_manifest_path, "get_manifest_path should be accessible")
+    
+    # Test get_manifest_path
+    path = Manifest.get_manifest_path("services/product/user/user-management-backend")
+    assert_true(
+        path.endswith("service.json"),
+        "get_manifest_path should include manifest filename"
+    )
+    
+    # Test cache functions
+    Manifest.clear_cache()
+    stats = Manifest.get_cache_stats()
+    assert_equal(0, stats['entries'], "Cache should be empty after clear")
+    
+    print("✅ Loader module tests complete\n")
+
+# =============================================================================
+# TEST SUITE: Parser Module
+# =============================================================================
+
+def _test_parser_functions():
+    """Test parser functions."""
+    print("🔍 Testing parser module...")
+    
+    # Test that parser functions are accessible via facade
+    assert_not_none(Manifest.parse, "parse should be accessible")
+    assert_not_none(Manifest.normalize, "normalize should be accessible")
+    assert_not_none(Manifest.get_normalized, "get_normalized should be accessible")
+    assert_not_none(Manifest.extract_resource_path, "extract_resource_path should be accessible")
+    assert_not_none(Manifest.extract_stack, "extract_stack should be accessible")
+    assert_not_none(Manifest.parse_traefik, "parse_traefik should be accessible")
+    assert_not_none(Manifest.merge_manifests, "merge_manifests should be accessible")
+    assert_not_none(Manifest.get_description, "get_description should be accessible")
+    
+    print("✅ Parser module tests complete\n")
+
+# =============================================================================
+# TEST SUITE: Parse and Normalize
+# =============================================================================
+
+def _test_parse_and_normalize():
+    """Test parsing and normalization together."""
+    print("🔍 Testing parse and normalize integration...")
+    
+    # Test valid JSON parsing
+    valid_json = '''
+    {
+        "appName": "test-service",
+        "appType": "backend",
+        "stack": "user",
+        "port": 4001
+    }
+    '''
+    
+    result = Manifest.parse(valid_json)
+    assert_not_none(result.manifest, "Should parse valid JSON")
+    assert_equal(None, result.error, "Should have no error for valid JSON")
+    
+    # Test normalization
+    normalized = Manifest.normalize(result.manifest, "services/product/user/test-service")
+    assert_not_none(normalized, "Should normalize manifest")
+    assert_equal("test-service", normalized['appName'], "Should preserve appName")
+    assert_equal("backend", normalized['appType'], "Should preserve appType")
+    assert_equal("user", normalized['stack'], "Should preserve stack")
+    assert_equal(4001, normalized['port'], "Should preserve port")
+    
+    # Test defaults are applied
+    assert_equal(1, normalized['replicas'], "Should apply default replicas")
+    assert_equal(3000, normalized['internalPort'], "Should apply default internalPort")
+    assert_equal("bun", normalized['runtime'], "Should apply default runtime")
+    assert_not_none(normalized['syncs'], "Should compute default syncs")
+    assert_not_none(normalized['traefik'], "Should create traefik config")
+    
+    # Test _normalized flag is set
+    assert_equal(True, normalized.get('_normalized'), "Should set _normalized flag")
+    
+    print("✅ Parse and normalize tests complete\n")
+
+# =============================================================================
+# TEST SUITE: Domain Extraction
+# =============================================================================
+
+def _test_stack_extraction():
+    """Test stack extraction from resource paths."""
+    print("🔍 Testing stack extraction...")
+    
+    # Standard paths
+    stack = Manifest.extract_stack("services/product/user/user-management-backend")
+    assert_equal("user", stack, "Should extract user stack")
+    
+    stack = Manifest.extract_stack("services/product/order/order-management-backend")
+    assert_equal("order", stack, "Should extract order stack")
+    
+    stack = Manifest.extract_stack("services/product/identity/identity-management-backend")
+    assert_equal("identity", stack, "Should extract identity stack")
+    
+    # Special case: order-planner
+    stack = Manifest.extract_stack("services/product/order-planner/order-planner-backend")
+    assert_equal("order-planner", stack, "Should extract order-planner stack")
+    
+    # Special case: profile -> identity
+    stack = Manifest.extract_stack("services/product/profile/profile-management-backend")
+    assert_equal("identity", stack, "Should map profile to identity stack")
+    
+    print("✅ Stack extraction tests complete\n")
+
+# =============================================================================
+# TEST SUITE: Frontend Manifest Normalization
+# =============================================================================
+
+def _test_frontend_normalization():
+    """Test normalization for frontend manifests."""
+    print("🔍 Testing frontend normalization...")
+    
+    frontend_json = '''
+    {
+        "appName": "user-management-frontend",
+        "appType": "frontend",
+        "stack": "user",
+        "port": 3000,
+        "backendName": "user-management-backend"
+    }
+    '''
+    
+    result = Manifest.parse(frontend_json)
+    normalized = Manifest.normalize(result.manifest, "services/product/user/user-management-frontend")
+    
+    assert_equal("frontend", normalized['appType'], "Should preserve frontend appType")
+    assert_equal("user-management-backend", normalized['backendName'], "Should preserve backendName")
+    
+    # Test backendName auto-computation
+    frontend_json_no_backend = '''
+    {
+        "appName": "test-frontend",
+        "appType": "frontend",
+        "stack": "user",
+        "port": 3001
+    }
+    '''
+    
+    result2 = Manifest.parse(frontend_json_no_backend)
+    normalized2 = Manifest.normalize(result2.manifest, "services/product/user/test-frontend")
+    assert_equal("test-backend", normalized2['backendName'], "Should auto-compute backendName")
+    
+    print("✅ Frontend normalization tests complete\n")
+
+# =============================================================================
+# TEST SUITE: Traefik Configuration
+# =============================================================================
+
+def _test_traefik_config():
+    """Test Traefik configuration parsing."""
+    print("🔍 Testing Traefik configuration...")
+    
+    # Backend with explicit traefik config
+    backend_json = '''
+    {
+        "appName": "user-management-backend",
+        "appType": "backend",
+        "stack": "user",
+        "port": 4000,
+        "traefik": {
+            "pathPrefix": "/api/v1/users",
+            "priority": 200
+        }
+    }
+    '''
+    
+    result = Manifest.parse(backend_json)
+    normalized = Manifest.normalize(result.manifest, "services/product/user/user-management-backend")
+    
+    assert_equal("/api/v1/users", normalized['traefik']['pathPrefix'], "Should preserve pathPrefix")
+    assert_equal(200, normalized['traefik']['priority'], "Should preserve priority")
+    
+    # Test auto-generated pathPrefix
+    backend_json_no_traefik = '''
+    {
+        "appName": "test-management-backend",
+        "appType": "backend",
+        "stack": "user",
+        "port": 4001
+    }
+    '''
+    
+    result2 = Manifest.parse(backend_json_no_traefik)
+    normalized2 = Manifest.normalize(result2.manifest, "services/product/user/test-management-backend")
+    
+    assert_not_none(normalized2['traefik']['pathPrefix'], "Should auto-generate pathPrefix")
+    assert_not_none(normalized2['traefik']['priority'], "Should set default priority")
+    
+    print("✅ Traefik configuration tests complete\n")
+
+# =============================================================================
+# TEST SUITE: Manifest Merging
+# =============================================================================
+
+def _test_manifest_merging():
+    """Test manifest merging functionality."""
+    print("🔍 Testing manifest merging...")
+    
+    base = {
+        'appName': 'test-service',
+        'appType': 'backend',
+        'port': 4000,
+        'features': ['nats'],
+        'envVars': {
+            'SHARED_VAR': 'base_value',
+        },
+    }
+    
+    overlay = {
+        'port': 4001,  # Override
+        'features': ['prisma'],  # Override
+        'envVars': {
+            'SHARED_VAR': 'overlay_value',  # Override
+            'NEW_VAR': 'new_value',  # Add
+        },
+    }
+    
+    merged = Manifest.merge_manifests(base, overlay)
+    
+    assert_equal('test-service', merged['appName'], "Should preserve base appName")
+    assert_equal(4001, merged['port'], "Should overlay port")
+    assert_equal(['prisma'], merged['features'], "Should overlay features")
+    assert_equal('overlay_value', merged['envVars']['SHARED_VAR'], "Should overlay nested env var")
+    assert_equal('new_value', merged['envVars']['NEW_VAR'], "Should add new env var")
+    
+    print("✅ Manifest merging tests complete\n")
+
+# =============================================================================
+# TEST SUITE: Get Normalized Convenience Function
+# =============================================================================
+
+def _test_get_normalized():
+    """Test the get_normalized convenience function."""
+    print("🔍 Testing get_normalized...")
+    
+    json_content = '''
+    {
+        "appName": "test-service",
+        "appType": "backend",
+        "stack": "user",
+        "port": 4001
+    }
+    '''
+    
+    result = Manifest.get_normalized(json_content, "services/product/user/test-service")
+    
+    assert_not_none(result.manifest, "Should return normalized manifest")
+    assert_equal(None, result.error, "Should have no error")
+    assert_equal("test-service", result.manifest['appName'], "Should have correct appName")
+    assert_equal("backend", result.manifest['appType'], "Should have correct appType")
+    assert_equal(True, result.manifest.get('_normalized'), "Should be marked as normalized")
+    
+    print("✅ Get normalized tests complete\n")
+
+# =============================================================================
+# TEST SUITE: Service Description
+# =============================================================================
+
+def _test_resource_description():
+    """Test service description generation."""
+    print("🔍 Testing service description...")
+    
+    manifest = {
+        'appName': 'user-management-backend',
+        'appType': 'backend',
+        'stack': 'user',
+    }
+    
+    desc = Manifest.get_description(manifest)
+    assert_equal("user/backend/user-management-backend", desc, "Should generate correct description")
+    
+    print("✅ Service description tests complete\n")
+
+# =============================================================================
+# MAIN
+# =============================================================================
+
+def run_tests():
+    """Run all Phase 2 integration tests."""
+    print("\n" + "="*70)
+    print("📋 MANIFEST MODULE - PHASE 2 INTEGRATION TESTS")
+    print("="*70 + "\n")
+    
+    # Run all test suites
+    _test_loader_functions()
+    _test_parser_functions()
+    _test_parse_and_normalize()
+    _test_domain_extraction()
+    _test_frontend_normalization()
+    _test_traefik_config()
+    _test_manifest_merging()
+    _test_get_normalized()
+    _test_resource_description()
+    
+    # Print results
+    print("\n" + "="*70)
+    print("📊 TEST RESULTS")
+    print("="*70)
+    print("✅ Passed: {}".format(test_results['passed']))
+    print("❌ Failed: {}".format(test_results['failed']))
+    
+    if test_results['errors']:
+        print("\n📝 ERRORS:")
+        for error in test_results['errors']:
+            print("   " + error)
+    else:
+        print("\n🎉 All Phase 2 integration tests passed!")
+    
+    print("="*70 + "\n")
+    
+    return test_results['failed'] == 0
+
+# Export test runner
+TestLoaderParser = struct(
+    run=run_tests,
+)