@tdk-landscape/tdk-cli-core 1.3.125 → 1.3.126

package/CHANGELOG.md

@@ -4,6 +4,11 @@ Notable changes to the `tdk` CLI. Versions match [npm](https://www.npmjs.com/pac
 
 ## Unreleased
 
+## 1.3.126 (2026-10-08)
+
+- Security: fixes [GHSA-phgf-pww4-7jxc](https://github.com/tdk-landscape/tdk-cli-core/security/advisories/GHSA-phgf-pww4-7jxc) (all earlier versions). A line break in a `service.json` value was written into the generated Docker Compose file and could add keys such as `privileged: true` to a service when you ran `tdk up` or `tilt up` on a repository you did not write. `tdk` and the Tilt engine now refuse any `service.json` string key or value that contains a line break (including U+0085, U+2028 and U+2029) or another control character, and `healthCheckPath`, `traefik.host`, `traefik.pathPrefix`, `traefik.healthCheck`, `nats.queueGroup`, `databaseName`, `stack` and `image` must also match a pattern. `smoke` is exempt. `tdk up` and `tdk config regenerate` stop with an error that names the field and does not print the value, and `tilt up` stops the same way. Upgrade, and check `service.json` files from repositories you did not write.
+- `tdk up`, `tdk status` and `tdk ui` now treat a container as ready only once its Docker health check passes. Tilt reports a running container as ready even while its health check is starting or failing, so a Postgres that never accepted connections counted as up and its dependents looked ready. A health check that is still starting now counts as starting (`waiting for postgres` on dependents), and a failing one makes `tdk up` stop with `✗ postgres failed: container is running, but its health check is failing`, the services it blocks, and how many dependents are not ready. Containers without a health check (BYO images) are unchanged. Part of #683.
+
 ## 1.3.125 (2026-10-08)
 
 - `tdk upgrade` no longer falls back to installing from the repository's moving GitHub default branch when the npm or Bun registry install fails. It reports the original install error, exits non-zero and prints the published-package command (`npm install -g @tdk-landscape/tdk-cli-core@latest` or `bun install -g @tdk-landscape/tdk-cli-core@latest`). npm `EACCES`/`EPERM` failures also point at npm's global-prefix docs and the official installer. Fixes #702.

package/README.md

@@ -111,6 +111,7 @@ Set `TDK_DEBUG=1` before running `tdk up --verbose` to include Starlark debug lo
 ## Docs
 
 - [CLI command cheat sheet](cli/README.md#cheat-sheet)
+- [Mega cheat sheet: every command and flag](docs/cheat-sheet.md)
 - [Documentation index](docs/README.md)
 - [Pilot TDK on a real repository](docs/adopt-tdk.md)
 - [FAQ for agencies and multi-client teams](docs/faq-teams.md)

package/cli/dist/generator/template-engine.js

@@ -7,7 +7,7 @@ import { writeTextFileAtomic } from "../utils/atomic-write.js";
 import { writeTextFile } from "../utils/file-helpers.js";
 import { assertTdkGeneratedPath } from "../utils/generated-paths.js";
 import { DEFAULT_ALWAYS_ENABLED_INFRA } from "../utils/project-config-defaults.js";
-import { validateServiceManifestFile } from "../utils/service-manifest.js";
+import { generatedFieldErrorsForFile, validateServiceManifestFile, } from "../utils/service-manifest.js";
 import { discoverResourcesFromRoot, discoverServiceManifestPaths } from "../utils/services.js";
 import { isStackFeatureEnabledInStacks } from "../utils/stack-features.js";
 import { hasSablierLicense, hasVerdaccioLicense } from "./extension-fetch.js";
@@ -412,6 +412,12 @@ function ensureRootWorkspaceManifest(projectRoot, projectConfig) {
 }
 export async function generateMasterConfigs(projectRoot, options = {}) {
     const projectConfig = readProjectConfig(projectRoot);
+    // Refuse before writing anything: a service.json value with a line break or YAML syntax would add keys to the generated compose
+    // file (GHSA-phgf-pww4-7jxc).
+    const unsafeFields = discoverServiceManifestPaths(projectRoot).flatMap((manifestPath) => generatedFieldErrorsForFile(manifestPath, path.relative(projectRoot, manifestPath).split(path.sep).join("/")));
+    if (unsafeFields.length > 0) {
+        throw new Error(`Refusing to generate config from unsafe service.json values:\n${unsafeFields.map((error) => `  ${error}`).join("\n")}`);
+    }
     await warnIfSablierUnlicensed(projectRoot);
     if (ensureRootWorkspaceManifest(projectRoot, projectConfig)) {
         console.log("✓ Generated: package.json (workspace root)");

package/cli/dist/utils/doctor-runtime.js

@@ -8,7 +8,7 @@ import { findProjectRoot } from "./paths.js";
 import { isApiServiceType } from "./resource-kind.js";
 import { getProjectName } from "./service-urls.js";
 import { discoverResources, discoverResourcesFromRoot } from "./services.js";
-import { isTiltResourcePending } from "./tilt-resource-state.js";
+import { effectiveRuntimeStatus, isTiltResourcePending, UNHEALTHY_CONTAINER_MESSAGE, } from "./tilt-resource-state.js";
 import { findOnPath } from "./which.js";
 const EXEC_TIMEOUT_MS = 10_000;
 const REGISTRY_PROBE_TIMEOUT_MS = 3_000;
@@ -104,8 +104,11 @@ export function parseTiltResourceFailures(jsonText, deferredNames = new Set()) {
     for (const item of items) {
         const name = item.metadata?.name ?? "unknown";
         const updateStatus = item.status?.updateStatus ?? "";
-        const runtimeStatus = item.status?.runtimeStatus ?? "";
-        const error = (item.status?.buildHistory?.[0]?.error ?? "").trim();
+        const runtimeStatus = effectiveRuntimeStatus(item.status);
+        const unhealthy = runtimeStatus === "error" && item.status?.runtimeStatus === "ok";
+        // A failed build's own error is the cause to show; the health message only fills in when there is none.
+        const buildError = (item.status?.buildHistory?.[0]?.error ?? "").trim();
+        const error = buildError || (unhealthy ? UNHEALTHY_CONTAINER_MESSAGE : "");
         if (updateStatus === "error" || runtimeStatus === "error") {
             failures.push({
                 name,

package/cli/dist/utils/service-manifest.js

@@ -50,6 +50,122 @@ const KNOWN_SERVICE_FIELDS = new Set([
     "traefik",
     "type",
 ]);
+/**
+ * String fields written into the generated Docker Compose, Traefik and NATS config as they are. A newline or YAML syntax in one of
+ * them adds keys to the generated service (GHSA-phgf-pww4-7jxc), so each must match its pattern. Empty values are treated as unset.
+ * `tilt up` reads service.json without this CLI, so engine/topologies/tilt/manifest/parser.star enforces the same rules.
+ */
+const GENERATED_STRING_FIELDS = [
+    { path: ["healthCheckPath"], pattern: /^\/[a-z0-9/-]*$/, expected: "a path such as /health" },
+    {
+        path: ["traefik", "host"],
+        pattern: /^[A-Za-z0-9.-]+$/,
+        expected: "a hostname such as shop.backend.myproject.local",
+    },
+    {
+        path: ["traefik", "pathPrefix"],
+        pattern: /^\/[a-z0-9/-]*$/,
+        expected: "a path such as /api/v1/shop-management",
+    },
+    {
+        path: ["traefik", "healthCheck"],
+        pattern: /^\/[a-z0-9/-]*$/,
+        expected: "a path such as /health",
+    },
+    {
+        path: ["nats", "queueGroup"],
+        pattern: /^[A-Za-z0-9_.-]+$/,
+        expected: "letters, digits, '_', '.' or '-'",
+    },
+    { path: ["databaseName"], pattern: /^[A-Za-z0-9_-]+$/, expected: "letters, digits, '_' or '-'" },
+    { path: ["stack"], pattern: /^[A-Za-z0-9_-]+$/, expected: "letters, digits, '_' or '-'" },
+    {
+        path: ["image"],
+        pattern: /^[A-Za-z0-9._/:@-]+$/,
+        expected: "an image reference such as ghcr.io/acme/app:1.0",
+    },
+];
+/**
+ * Errors for generated-output fields whose values could change the generated YAML. The value itself is not echoed, because it may
+ * contain the newline that makes it dangerous.
+ */
+export function validateGeneratedStringFields(manifest, displayPath) {
+    const errors = [];
+    const reportedFields = new Set();
+    for (const { path, pattern, expected } of GENERATED_STRING_FIELDS) {
+        let value = manifest;
+        for (const key of path) {
+            value =
+                value && typeof value === "object" && !Array.isArray(value)
+                    ? value[key]
+                    : undefined;
+        }
+        if (value === undefined || value === null || value === "")
+            continue;
+        const field = `${displayPath}.${path.join(".")}`;
+        if (typeof value !== "string" || !pattern.test(value))
+            reportedFields.add(field);
+        if (typeof value !== "string") {
+            errors.push(`${field}: expected a string`);
+        }
+        else if (!pattern.test(value)) {
+            errors.push(`${field}: must be ${expected} (no spaces, line breaks or YAML syntax)`);
+        }
+    }
+    for (const [field, message] of lineBreakErrors(manifest, displayPath)) {
+        if (!reportedFields.has(field))
+            errors.push(`${field}: ${message}`);
+    }
+    return errors;
+}
+/** Line breaks (including the Unicode ones YAML 1.1 honours) and other control characters. */
+function hasLineBreakOrControl(text) {
+    for (let index = 0; index < text.length; index++) {
+        const code = text.charCodeAt(index);
+        if (code < 0x20 || code === 0x7f || code === 0x85 || code === 0x2028 || code === 0x2029) {
+            return true;
+        }
+    }
+    return false;
+}
+/**
+ * Many more service.json values than GENERATED_STRING_FIELDS reach the generated YAML (port, appName, dockerfile, buildContext,
+ * basePath, envVars, ...). A key can only be added through a line break, so no string key or value may contain one. `smoke` is
+ * skipped: the CLI sends it over HTTP and it is never written into generated config.
+ */
+function lineBreakErrors(manifest, displayPath) {
+    const errors = [];
+    const pending = Object.entries(manifest)
+        .filter(([key]) => key !== "smoke")
+        .map(([key, value]) => [value, `${displayPath}.${key}`]);
+    for (const key of Object.keys(manifest)) {
+        if (hasLineBreakOrControl(key))
+            errors.push([displayPath, "a key contains a line break"]);
+    }
+    while (pending.length > 0) {
+        const [value, field] = pending.pop();
+        if (typeof value === "string") {
+            if (hasLineBreakOrControl(value)) {
+                errors.push([field, "must not contain line breaks or control characters"]);
+            }
+        }
+        else if (Array.isArray(value)) {
+            for (const [index, item] of value.entries())
+                pending.push([item, `${field}[${index}]`]);
+        }
+        else if (value && typeof value === "object") {
+            for (const [key, item] of Object.entries(value)) {
+                if (hasLineBreakOrControl(key)) {
+                    errors.push([field, "a key contains a line break"]);
+                }
+                else {
+                    pending.push([item, `${field}.${key}`]);
+                }
+            }
+        }
+    }
+    return errors.sort(([a], [b]) => a.localeCompare(b));
+}
 const SERVICE_ROUTE_PATH_FIELDS = ["apiPath", "basePath"];
 export function getInvalidServiceRoutePathFields(value) {
     if (!value || typeof value !== "object" || Array.isArray(value))
@@ -85,6 +201,7 @@ export function validateServiceManifest(value, displayPath) {
     if (liveReload !== undefined && typeof liveReload !== "boolean") {
         errors.push(`${displayPath}.dev.liveReload: expected true or false`);
     }
+    errors.push(...validateGeneratedStringFields(manifest, displayPath));
     if ("smoke" in manifest) {
         for (const message of validateSmoke(manifest.smoke))
             errors.push(`${displayPath}.${message}`);
@@ -102,6 +219,23 @@ export function validateServiceManifest(value, displayPath) {
     }
     return { errors, warnings, manifest };
 }
+/**
+ * Generated-output errors for one service.json. A file that cannot be read or parsed returns none here, because
+ * validateServiceManifestFile reports that case.
+ */
+export function generatedFieldErrorsForFile(filePath, displayPath) {
+    if (!existsSync(filePath))
+        return [];
+    try {
+        const parsed = JSON.parse(readFileSync(filePath, "utf-8"));
+        if (!parsed || typeof parsed !== "object" || Array.isArray(parsed))
+            return [];
+        return validateGeneratedStringFields(parsed, displayPath);
+    }
+    catch {
+        return [];
+    }
+}
 export function validateServiceManifestFile(filePath, displayPath) {
     if (!existsSync(filePath)) {
         return { errors: [`${displayPath}: file is missing`], warnings: [] };

package/cli/dist/utils/service-runtime-state.js

@@ -1,5 +1,5 @@
 import { buildStartupReport, transitiveDependencies } from "./startup-report.js";
-import { isTiltResourcePending } from "./tilt-resource-state.js";
+import { effectiveRuntimeStatus, isTiltResourcePending } from "./tilt-resource-state.js";
 import { onlyEnabledResources } from "./up-readiness.js";
 /**
  * The one answer to "is this service ready?" for `tdk status` and `tdk ui`, from Tilt's resources and the `dependsOn`
@@ -32,7 +32,7 @@ export function deriveServiceStates(jsonText, dependsOn, deferred = new Set()) {
             direct.set(name, { status: "pending" });
         }
         else if (deferred.has(name) &&
-            isTiltResourcePending(item.status?.updateStatus ?? "", item.status?.runtimeStatus ?? "")) {
+            isTiltResourcePending(item.status?.updateStatus ?? "", effectiveRuntimeStatus(item.status))) {
             direct.set(name, { status: "unknown", reason: "starts on its first request" });
         }
         else {

package/cli/dist/utils/services.js

@@ -5,7 +5,7 @@ import { AUTOGENERATED_FILE_PATTERNS, SKIP_DIRECTORIES } from "./constants.js";
 import { errorFactories } from "./errors.js";
 import { formatCount } from "./formatting.js";
 import { findProjectRoot } from "./paths.js";
-import { getInvalidServiceRoutePathFields, validateServiceManifest } from "./service-manifest.js";
+import { getInvalidServiceRoutePathFields, validateGeneratedStringFields, validateServiceManifest, } from "./service-manifest.js";
 import { deriveStackStatus } from "./stack-status.js";
 import { includes } from "./validation.js";
 const RESOURCE_JSON_FILENAME = "service.json";
@@ -83,6 +83,9 @@ function parseResource(serviceJsonPath) {
     if (invalidRoutePathFields.length > 0) {
         throw new InvalidServiceJsonError(invalidRoutePathFields.map((field) => `${field}: expected a string`).join("; "));
     }
+    const unsafeFields = validateGeneratedStringFields(parsed, serviceJsonPath);
+    if (unsafeFields.length > 0)
+        throw new InvalidServiceJsonError(unsafeFields.join("; "));
     const parsedConfig = parsed;
     for (const warning of validateServiceManifest(parsed, serviceJsonPath).warnings) {
         // The warning names the file and field and says what is wrong (unknown, deprecated, ignored), so do not prefix it.

package/cli/dist/utils/startup-report.js

@@ -1,6 +1,6 @@
 import { parseTiltResourceFailures, summarizeTiltBuildError } from "./doctor-runtime.js";
 import { portConflictFix } from "./port-conflict-fix.js";
-import { isTiltResourcePending } from "./tilt-resource-state.js";
+import { effectiveRuntimeStatus, isTiltResourcePending } from "./tilt-resource-state.js";
 import { onlyEnabledResources } from "./up-readiness.js";
 export function transitiveDependencies(name, dependsOn) {
     const seen = new Set();
@@ -16,7 +16,7 @@ export function transitiveDependencies(name, dependsOn) {
     return seen;
 }
 function isPending(item) {
-    return isTiltResourcePending(item.status?.updateStatus ?? "", item.status?.runtimeStatus ?? "");
+    return isTiltResourcePending(item.status?.updateStatus ?? "", effectiveRuntimeStatus(item.status));
 }
 export function buildStartupReport(jsonText, dependsOn, deferred = new Set()) {
     const enabledJson = onlyEnabledResources(jsonText);
@@ -33,15 +33,14 @@ export function buildStartupReport(jsonText, dependsOn, deferred = new Set()) {
     const starting = [];
     for (const item of items) {
         const name = item.metadata?.name ?? "unknown";
-        if (name === "(Tiltfile)" || failedNames.has(name) || deferred.has(name) || !isPending(item)) {
+        if (name === "(Tiltfile)" || failedNames.has(name) || deferred.has(name))
             continue;
-        }
         const because = [...transitiveDependencies(name, dependsOn)]
             .filter((dep) => failedNames.has(dep))
             .sort();
         if (because.length > 0)
             blocked.push({ name, because });
-        else
+        else if (isPending(item))
             starting.push(name);
     }
     return { failed, blocked, starting };
@@ -66,7 +65,12 @@ export function formatStartupReport(report, timedOut) {
         lines.push(`${timedOut ? "Timed out waiting for" : "Still starting:"} ${report.starting.join(", ")}`);
     }
     if (lines.length > 0) {
-        lines.push("The environment is not ready. Tilt is still running; inspect it or run: tdk down");
+        const causes = [...new Set(report.blocked.flatMap((entry) => entry.because))].sort();
+        const count = report.blocked.length;
+        const summary = count > 0
+            ? `: ${causes.join(", ")} failed, so ${count} dependent ${count === 1 ? "service is" : "services are"} not ready`
+            : "";
+        lines.push(`The environment is not ready${summary}. Tilt is still running; inspect it or run: tdk down`);
     }
     return lines;
 }

package/cli/dist/utils/tilt-resource-state.js

@@ -9,4 +9,23 @@ export function isTiltResourcePending(updateStatus, runtimeStatus) {
         runtimeStatus === "pending" ||
         runtimeStatus === "none");
 }
+/** What a Tilt failure says when the container runs but Docker reports its health check as failing. */
+export const UNHEALTHY_CONTAINER_MESSAGE = "container is running, but its health check is failing";
+/**
+ * Tilt's runtime status, corrected for Docker health. Tilt reports a running compose container as `ok` even while its
+ * health check is still `starting` or has turned `unhealthy` (Tilt 0.37), so a Postgres that never accepts connections
+ * would read as ready. Health `starting` is pending and `unhealthy` is an error; a container without a health check
+ * keeps Tilt's status.
+ */
+export function effectiveRuntimeStatus(status) {
+    const runtimeStatus = status?.runtimeStatus ?? "";
+    if (runtimeStatus !== "ok")
+        return runtimeStatus;
+    const health = status?.composeResourceInfo?.healthStatus;
+    if (health === "unhealthy")
+        return "error";
+    if (health === "starting")
+        return "pending";
+    return runtimeStatus;
+}
 //# sourceMappingURL=tilt-resource-state.js.map

package/cli/package.json

@@ -1,7 +1,7 @@
 {
   "name": "tdk-cli-internal",
   "private": true,
-  "version": "1.3.125",
+  "version": "1.3.126",
   "description": "TDK CLI — start services on your laptop.",
   "keywords": [
     "tdk",

package/discovery/manifest/loading.star

@@ -8,6 +8,7 @@
 # Priority: service.json → synthesize from path
 # =============================================================================
 
+load('../../engine/topologies/tilt/manifest/parser.star', 'generated_string_error')
 load('../../engine/topologies/tilt/manifest/constants.star',
      'MANIFEST_DEFAULTS',
      'DEFAULT_SYNCS',
@@ -100,6 +101,10 @@ def load_manifest(resource_path, persist_to_disk=False):
     
     if content and str(content).strip():
         manifest = decode_json(content)
+        # Refuse service.json values that would add keys to generated config (GHSA-phgf-pww4-7jxc)
+        unsafe_field_error = generated_string_error(manifest, manifest_full_path) if type(manifest) == "dict" else None
+        if unsafe_field_error:
+            fail(unsafe_field_error)
         manifest_source = 'service.json'
         manifest_path = manifest_full_path
     else:

package/discovery/manifest/normalize.star

@@ -5,6 +5,7 @@
 # Purpose: Normalize manifests and provide helper accessors
 # =============================================================================
 
+load('../../engine/topologies/tilt/manifest/parser.star', 'generated_string_error')
 load('./constants.star', 'MANIFEST_DEFAULTS', 'MANIFEST_FILENAME')
 load('./loading.star', 'apply_manifest_defaults', 'check_prisma_folder', 'get_default_syncs_for_type')
 load('./validation.star', 'validate_manifest')
@@ -56,6 +57,11 @@ def _load_and_normalize(manifest_path, warn_only=True):
             print("   ⚠️  Invalid JSON in manifest: " + manifest_path)
             return None
         fail("Invalid JSON in manifest: " + manifest_path)
+
+    # Refuse service.json values that would add keys to generated config (GHSA-phgf-pww4-7jxc)
+    unsafe_field_error = generated_string_error(manifest, manifest_path) if type(manifest) == "dict" else None
+    if unsafe_field_error:
+        fail(unsafe_field_error)
     
     # Validate
     issues = validate_manifest(manifest)

package/engine/topologies/tilt/manifest/loader.star

@@ -19,6 +19,7 @@ DEFAULTS = {}
 # === END INLINED CONSTANTS ===
 
 
+load("./parser.star", "generated_string_error")
 load("./constants.star",
     "MANIFEST_FILENAME",
     "MANIFEST_DEFAULTS",
@@ -63,6 +64,12 @@ def load_from_file(path):
     
     if manifest == None:
         return struct(manifest=None, error="Invalid manifest: " + path)
+
+    # Refuse service.json values that would add keys to generated config (GHSA-phgf-pww4-7jxc). Every Tilt discovery path loads service.json here.
+    if type(manifest) == "dict":
+        unsafe_field_error = generated_string_error(manifest, path)
+        if unsafe_field_error:
+            fail(unsafe_field_error)
     
     # An `mcp` resource is a Model Context Protocol server: an HTTP service on Bun that is built, routed and health-checked
     # exactly like a backend. Every backend code path keys off appType == 'backend', so normalise here, once, at the single

package/engine/topologies/tilt/manifest/parser.star

@@ -73,24 +73,106 @@ def parse(content, path=""):
         warnings=warnings,
     )
 
+# Characters allowed in the string fields that are written into generated Compose, Traefik and NATS config as they are. A line break
+# or YAML syntax in one of them adds keys to the generated service (GHSA-phgf-pww4-7jxc). Keep in step with GENERATED_STRING_FIELDS
+# in cli/src/utils/service-manifest.ts.
+_ALPHANUM = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"
+_PATH_CHARS = "abcdefghijklmnopqrstuvwxyz0123456789/-"
+_GENERATED_STRING_RULES = [
+    # (field path, allowed characters, required first character or "")
+    (['healthCheckPath'], _PATH_CHARS, '/'),
+    (['traefik', 'host'], _ALPHANUM + '.-', ''),
+    (['traefik', 'pathPrefix'], _PATH_CHARS, '/'),
+    (['traefik', 'healthCheck'], _PATH_CHARS, '/'),
+    (['nats', 'queueGroup'], _ALPHANUM + '_.-', ''),
+    (['databaseName'], _ALPHANUM + '_-', ''),
+    (['stack'], _ALPHANUM + '_-', ''),
+    (['image'], _ALPHANUM + '._/:@-', ''),
+]
+
+def generated_string_error(manifest, resource_path=""):
+    """
+    Return an error message if a value that is written into generated config has unsafe characters, else None.
+
+    The value is not echoed, because it may contain the line break that makes it dangerous.
+    """
+    for keys, allowed, first in _GENERATED_STRING_RULES:
+        value = manifest
+        for key in keys:
+            value = value.get(key) if type(value) == "dict" else None
+        if value == None or value == "":
+            continue
+        field = '.'.join(keys)
+        where = " in " + resource_path if resource_path else ""
+        if type(value) != "string":
+            return "MANIFEST ERROR: '{}' must be a string{}".format(field, where)
+        if first and not value.startswith(first):
+            return "MANIFEST ERROR: '{}' must start with '{}'{}".format(field, first, where)
+        for c in value.elems():
+            if c not in allowed:
+                return "MANIFEST ERROR: '{}' has characters that are not allowed (no spaces, line breaks or YAML syntax){}".format(field, where)
+    return _line_break_error(manifest, resource_path)
+
+# Line breaks (including the Unicode ones YAML 1.1 honours) and other control characters.
+_LINE_BREAK_OR_CONTROL = [chr(i) for i in range(32)] + [chr(127), "\u0085", "
", "
"]
+
+def _has_line_break(text):
+    for bad in _LINE_BREAK_OR_CONTROL:
+        if bad in text:
+            return True
+    return False
+
+def _line_break_error(manifest, resource_path):
+    """
+    Many more values than _GENERATED_STRING_RULES reach generated config (port, appName, dockerfile, buildContext, basePath, envVars,
+    ...). A key can only be added through a line break, so no string key or value may contain one. `smoke` is skipped: it is never
+    written into generated config. Keep in step with lineBreakErrors in cli/src/utils/service-manifest.ts.
+    """
+    where = " in " + resource_path if resource_path else ""
+    pending = [(value, key) for key, value in manifest.items() if key != 'smoke']
+    for key in manifest.keys():
+        if type(key) == "string" and _has_line_break(key):
+            return "MANIFEST ERROR: a key contains a line break{}".format(where)
+    # Starlark has no recursion or while loops; a service.json never nests anywhere near this many values.
+    for _ in range(100000):
+        if not pending:
+            return None
+        value, field = pending.pop()
+        if type(value) == "string":
+            if _has_line_break(value):
+                return "MANIFEST ERROR: '{}' must not contain line breaks or control characters{}".format(field, where)
+        elif type(value) == "list":
+            for index, item in enumerate(value):
+                pending.append((item, "{}[{}]".format(field, index)))
+        elif type(value) == "dict":
+            for key, item in value.items():
+                if type(key) == "string" and _has_line_break(key):
+                    return "MANIFEST ERROR: a key in '{}' contains a line break{}".format(field, where)
+                pending.append((item, "{}.{}".format(field, key)))
+    return "MANIFEST ERROR: service.json is nested too deeply{}".format(where)
+
 def normalize(manifest, resource_path=""):
     """
     Normalize manifest with default values and computed fields.
-    
+
     Args:
         manifest: Raw parsed manifest dict
         resource_path: Resource directory path for context
-    
+
     Returns:
         Normalized manifest dict with all fields populated
     """
     normalized = {}
     warnings = []
-    
+
     # Copy all existing fields
     for key, value in manifest.items():
         normalized[key] = value
 
+    unsafe_field_error = generated_string_error(normalized, resource_path)
+    if unsafe_field_error:
+        fail(unsafe_field_error)
+
     # 1. Apply defaults for missing fields
     for field, default_value in MANIFEST_DEFAULTS.items():
         if field not in normalized or normalized[field] == None:
@@ -391,6 +473,7 @@ def get_resource_type_description(manifest):
 ManifestParser = struct(
     parse=parse,
     normalize=normalize,
+    generated_string_error=generated_string_error,
     extract_resource_path=extract_resource_path,
     extract_stack=extract_stack_from_path,
     parse_traefik=parse_traefik_config,

package/engine/topologies/tilt/manifest/tests/test_loader_parser.star

@@ -306,6 +306,67 @@ def _test_manifest_merging():
     
     print("✅ Manifest merging tests complete\n")
 
+# =============================================================================
+# TEST SUITE: Values written into generated config (GHSA-phgf-pww4-7jxc)
+# =============================================================================
+
+def _test_generated_string_fields():
+    """A line break or YAML syntax in a field that reaches generated compose output must be rejected."""
+    base = {'appName': 'api', 'stack': 'shop', 'traefik': {'pathPrefix': '/api/v1/shop-management'}}
+
+    assert_equal(None, ManifestParser.generated_string_error(base), "Clean manifest has no generated-field error")
+
+    safe = {
+        'appName': 'api',
+        'stack': 'shop-1',
+        'healthCheckPath': '/api/v1/health',
+        'databaseName': 'TDK_shop',
+        'image': 'ghcr.io/acme/app:1.0',
+        'traefik': {'host': 'shop.backend.my-project.local', 'pathPrefix': '/api/v1/shop', 'healthCheck': '/health'},
+        'nats': {'queueGroup': 'shop_backend_svc'},
+    }
+    assert_equal(None, ManifestParser.generated_string_error(safe), "Safe values are accepted")
+
+    hostile = [
+        {'healthCheckPath': '/health\n    privileged: true'},
+        {'healthCheckPath': '/health"'},
+        {'traefik': {'host': 'a.local\n    privileged: true', 'pathPrefix': '/api'}},
+        {'traefik': {'pathPrefix': '/api/v1/x\n    network_mode: host'}},
+        {'traefik': {'pathPrefix': '/api', 'healthCheck': '/h\n    volumes: []'}},
+        {'traefik': {'pathPrefix': '/api'}, 'nats': {'queueGroup': 'g: true'}},
+        {'traefik': {'pathPrefix': '/api'}, 'databaseName': 'TDK_x\n  privileged: true'},
+        {'traefik': {'pathPrefix': '/api'}, 'stack': 'shop # comment'},
+        {'traefik': {'pathPrefix': '/api'}, 'image': 'app\n    privileged: true'},
+        {'traefik': {'pathPrefix': '/api'}, 'healthCheckPath': 'health'},
+        {'traefik': {'pathPrefix': '/api'}, 'healthCheckPath': 42},
+    ]
+    for manifest in hostile:
+        assert_not_none(ManifestParser.generated_string_error(manifest), "Rejects unsafe value: " + str(manifest))
+
+    # The message names the field and never echoes the value
+    message = ManifestParser.generated_string_error(hostile[0], 'services/shop/api')
+    assert_true("healthCheckPath" in message, "Error names the field")
+    assert_true("\n" not in message, "Error does not echo the value")
+
+    # Fields outside the allowlist also reach generated config, so a line break anywhere is refused
+    clean = {'appName': 'api', 'stack': 'shop', 'traefik': {'pathPrefix': '/api'}}
+    line_breaks = [
+        {'port': '4000\n    privileged: true'},
+        {'appName': 'api\n    privileged: true'},
+        {'dockerfile': 'Dockerfile\r    privileged: true'},
+        {'buildContext': 'src\u2028privileged: true'},
+        {'envVars': [{'name': 'A', 'value': 'v\n    privileged: true'}]},
+        {'params': {'a\n    privileged': 'x'}},
+    ]
+    for extra in line_breaks:
+        manifest = dict(clean)
+        manifest.update(extra)
+        assert_not_none(ManifestParser.generated_string_error(manifest), "Rejects a line break: " + repr(extra))
+
+    smoke = dict(clean)
+    smoke['smoke'] = {'via': '/api', 'create': {'body': '{\n}'}}
+    assert_equal(None, ManifestParser.generated_string_error(smoke), "smoke is never written into generated config")
+
 # =============================================================================
 # TEST SUITE: Get Normalized Convenience Function
 # =============================================================================
@@ -366,12 +427,13 @@ def run_tests():
     _test_loader_functions()
     _test_parser_functions()
     _test_parse_and_normalize()
-    _test_domain_extraction()
+    _test_stack_extraction()
     _test_frontend_normalization()
     _test_traefik_config()
     _test_manifest_merging()
     _test_get_normalized()
     _test_resource_description()
+    _test_generated_string_fields()
     
     # Print results
     print("\n" + "="*70)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tdk-landscape/tdk-cli-core",
-  "version": "1.3.125",
+  "version": "1.3.126",
   "description": "TDK CLI — start services on your laptop.",
   "homepage": "https://tdk-landscape.github.io/tdk-website",
   "repository": {