@tbrandenburg/node-red-agents 0.3.5 → 0.3.7

package/nodes/agent/agent.js

@@ -250,6 +250,14 @@ module.exports = function (RED) {
               timedOut: result.timedOut,
               durationMs: result.durationMs,
               sessionID: result.sessionID,
+              // Raw error object from the adapter (e.g. opencode's full
+              // {"type":"error"} payload, or pi's failing assistant
+              // message) when the run failed -- the `done(err)` string
+              // below only carries a single summarized message/name, so
+              // anything needing the fuller detail (extra fields the
+              // adapter didn't fold into errorMessage) should wire a
+              // Debug node to output 1 and inspect this field.
+              errorDetail: result.errorDetail,
             },
           });
           send([resultMsg, null]);

package/nodes/agent/lib/agents/opencode.js

@@ -119,11 +119,25 @@ class OpenCodeAdapter extends AgentAdapter {
       .trim();
 
     if (errorEvent) {
+      const errDetail = errorEvent.error || {};
       const message =
-        (errorEvent.error &&
-          ((errorEvent.error.data && errorEvent.error.data.message) || errorEvent.error.name)) ||
-        "opencode reported an error";
-      return { payload, sessionID, status: "failed", errorMessage: message };
+        (errDetail.data && errDetail.data.message) || errDetail.name || "opencode reported an error";
+      // The JSON error event only carries opencode's own top-level
+      // message/name -- append name (if distinct) and any stderr output
+      // opencode wrote alongside it, since both would otherwise be
+      // silently dropped here (unlike the exitCode!==0 branch below,
+      // which already surfaces stderr).
+      const extras = [];
+      if (errDetail.name && errDetail.name !== message) extras.push(errDetail.name);
+      if (stderr && String(stderr).trim()) extras.push(String(stderr).trim());
+      const errorMessage = extras.length ? `${message} (${extras.join("; ")})` : message;
+      return {
+        payload,
+        sessionID,
+        status: "failed",
+        errorMessage,
+        errorDetail: errDetail,
+      };
     }
     if (signal) {
       return {

package/nodes/agent/lib/agents/pi.js

@@ -186,9 +186,10 @@ class PiAdapter extends AgentAdapter {
 
     let payload = "";
     let errorMessage;
+    let lastAssistant;
 
     if (agentEnd && Array.isArray(agentEnd.messages)) {
-      const lastAssistant = [...agentEnd.messages].reverse().find((m) => m.role === "assistant");
+      lastAssistant = [...agentEnd.messages].reverse().find((m) => m.role === "assistant");
       if (lastAssistant) {
         if (lastAssistant.stopReason === "error") {
           // pi does NOT set a non-zero exit code for a model/API
@@ -207,7 +208,17 @@ class PiAdapter extends AgentAdapter {
     }
 
     if (errorMessage) {
-      return { payload, sessionID, status: "failed", errorMessage };
+      // Same rationale as the opencode adapter: stderr is otherwise
+      // silently dropped for this branch (it's only appended in the
+      // exitCode!==0 branch below).
+      const extra = stderr && String(stderr).trim() ? ` (${String(stderr).trim()})` : "";
+      return {
+        payload,
+        sessionID,
+        status: "failed",
+        errorMessage: `${errorMessage}${extra}`,
+        errorDetail: lastAssistant,
+      };
     }
     if (signal) {
       return {

package/nodes/gh/README.md

@@ -49,7 +49,23 @@ configuration for that message.
 
 A non-zero exit code, a timeout, or a missing `gh` executable all go through
 `done(error)` (catchable with a Catch node) instead of producing an output
-message.
+message. Every such error carries an `err.errorType` string so flows can
+branch on it without regex-matching gh's (locale/version dependent) human
+-readable stderr text themselves:
+
+| `errorType`        | When                                                                          |
+| ------------------- | ------------------------------------------------------------------------------ |
+| `auth`              | Not logged in / bad credentials (stderr mentions `gh auth login`, etc.)       |
+| `rate-limit`        | GitHub API (primary or secondary) rate limit exceeded                        |
+| `feature-disabled`  | Repo has issues/PRs/projects disabled (e.g. this ticket's original report)    |
+| `not-found`         | Repository/resource doesn't exist or can't be resolved                       |
+| `permission`        | 403 / insufficient permissions                                               |
+| `network`           | Network failure or timeout talking to GitHub                                 |
+| `not-installed`     | `gh` executable not found on `PATH` (spawn `ENOENT`)                          |
+| `spawn-failed`      | The child process could not be started for another reason                    |
+| `timeout`           | The command exceeded the configured Timeout and was killed                   |
+| `killed`            | The command was killed by a signal other than the node's own timeout         |
+| `unknown`           | Non-zero exit whose stderr didn't match any known pattern                    |
 
 ## Example
 

package/nodes/gh/gh.js

@@ -38,6 +38,27 @@ function validateCommand(command) {
   return null;
 }
 
+// Classifies a gh stderr message into a stable, machine-checkable category so
+// downstream flows can branch on `err.errorType` instead of regex-matching
+// the (locale/version dependent) human-readable message themselves. Order
+// matters: more specific patterns are checked before generic ones.
+const ERROR_TYPE_PATTERNS = [
+  [/not logged into|to authenticate|gh auth login|authentication required|bad credentials/i, "auth"],
+  [/api rate limit exceeded|secondary rate limit/i, "rate-limit"],
+  [/has disabled issues|has disabled pull requests|has disabled projects/i, "feature-disabled"],
+  [/could not resolve to a repository|repository not found|404/i, "not-found"],
+  [/403|resource not accessible|must have admin rights|permission/i, "permission"],
+  [/network|timed out|econnreset|enotfound/i, "network"],
+];
+
+function classifyGhError(stderr) {
+  if (!stderr) return "unknown";
+  for (const [pattern, type] of ERROR_TYPE_PATTERNS) {
+    if (pattern.test(stderr)) return type;
+  }
+  return "unknown";
+}
+
 // Resolves an "args" value (from config or msg.gh.args) into a string[].
 // Strings are tokenized (quote-aware, no shell evaluation); arrays are used
 // as-is (each element coerced to a string); anything else is rejected.
@@ -172,6 +193,7 @@ module.exports = function (RED) {
         const wrapped = new Error("gh: " + message);
         wrapped.command = command;
         wrapped.args = args;
+        wrapped.errorType = err && err.code === "ENOENT" ? "not-installed" : "spawn-failed";
         done(wrapped);
       });
 
@@ -188,19 +210,23 @@ module.exports = function (RED) {
           err.args = args;
           err.signal = signal;
           err.timedOut = timedOut;
+          err.errorType = timedOut ? "timeout" : "killed";
           done(err);
           return;
         }
 
         if (code !== 0) {
-          node.status({ fill: "red", shape: "dot", text: "exit " + code });
+          const trimmedStderr = stderr.trim();
+          const errorType = classifyGhError(trimmedStderr);
+          node.status({ fill: "red", shape: "dot", text: errorType + " (exit " + code + ")" });
           const err = new Error(
-            "gh: command failed (exit " + code + ")" + (stderr.trim() ? ": " + stderr.trim() : ""),
+            "gh: command failed (exit " + code + ")" + (trimmedStderr ? ": " + trimmedStderr : ""),
           );
           err.command = command;
           err.args = args;
           err.exitCode = code;
-          err.stderr = stderr.trim();
+          err.stderr = trimmedStderr;
+          err.errorType = errorType;
           done(err);
           return;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tbrandenburg/node-red-agents",
-  "version": "0.3.5",
+  "version": "0.3.7",
   "description": "Node-RED nodes for running coding agents (opencode, pi) and GitHub CLI operations from flows.",
   "keywords": [
     "node-red",