@taskforcehq/taskforce 0.3.327 → 0.3.329

package/dist/server/routes/syncV3LocalCaptureRoutes.js

@@ -96,7 +96,14 @@ function parseEnvelope(raw) {
     };
     if (operation.domain === 'task' && operation.mutationKind === 'metadata-update') {
         const saveSource = payload.saveSource;
-        assertExactKeys(payload, saveSource === undefined ? ['patch'] : ['patch', 'saveSource'], 'operation.payload');
+        const expectedDetailRevision = payload.expectedDetailRevision === undefined
+            ? undefined
+            : requireId(payload.expectedDetailRevision, 'operation.payload.expectedDetailRevision');
+        assertExactKeys(payload, [
+            'patch',
+            ...(saveSource === undefined ? [] : ['saveSource']),
+            ...(expectedDetailRevision === undefined ? [] : ['expectedDetailRevision']),
+        ], 'operation.payload');
         if (saveSource !== undefined && saveSource !== 'manual' && saveSource !== 'autosave') {
             throw new LocalCaptureRequestError('operation.payload.saveSource must be manual or autosave.');
         }
@@ -106,6 +113,7 @@ function parseEnvelope(raw) {
             mutationKind: 'metadata-update',
             patch: requireRecord(payload.patch, 'operation.payload.patch'),
             ...(saveSource ? { saveSource } : {}),
+            ...(expectedDetailRevision ? { expectedDetailRevision } : {}),
         };
     }
     if (operation.domain === 'task' && operation.mutationKind === 'create') {
@@ -170,11 +178,27 @@ function parseEnvelope(raw) {
         };
     }
     if (operation.domain === 'task' && operation.mutationKind === 'set-status') {
+        const expectedDetailRevision = payload.expectedDetailRevision === undefined
+            ? undefined
+            : requireId(payload.expectedDetailRevision, 'operation.payload.expectedDetailRevision');
+        assertExactKeys(payload, [
+            'status',
+            'assigneeIntent',
+            'canceledReason',
+            'metadataPatch',
+            ...(expectedDetailRevision === undefined ? [] : ['expectedDetailRevision']),
+        ], 'operation.payload');
         return {
             ...common,
             domain: 'task',
             mutationKind: 'set-status',
-            payload: validateDurableTaskStatusMutationPayload(payload),
+            payload: validateDurableTaskStatusMutationPayload({
+                status: payload.status,
+                assigneeIntent: payload.assigneeIntent,
+                canceledReason: payload.canceledReason,
+                metadataPatch: payload.metadataPatch,
+            }),
+            ...(expectedDetailRevision ? { expectedDetailRevision } : {}),
         };
     }
     if (operation.domain === 'task-comments' && operation.mutationKind === 'append') {
@@ -203,7 +227,8 @@ function parseEnvelope(raw) {
         return { ...common, domain: 'task-checklist', mutationKind: 'replace', items };
     }
     if (operation.domain === 'task-attachment-links' && operation.mutationKind === 'replace') {
-        assertExactKeys(payload, ['links'], 'operation.payload');
+        const hasCardCoverAssetId = Object.prototype.hasOwnProperty.call(payload, 'cardCoverAssetId');
+        assertExactKeys(payload, hasCardCoverAssetId ? ['links', 'cardCoverAssetId'] : ['links'], 'operation.payload');
         let links;
         try {
             links = validateWorkspaceSyncV3TaskAttachmentLinksPayload({ taskId: common.entityId, links: payload.links }).links;
@@ -211,7 +236,21 @@ function parseEnvelope(raw) {
         catch (error) {
             throw new LocalCaptureRequestError(error instanceof Error ? error.message : 'operation.payload.links is invalid.');
         }
-        return { ...common, domain: 'task-attachment-links', mutationKind: 'replace', links };
+        if (hasCardCoverAssetId && payload.cardCoverAssetId !== null
+            && (typeof payload.cardCoverAssetId !== 'string' || !payload.cardCoverAssetId.trim())) {
+            throw new LocalCaptureRequestError('operation.payload.cardCoverAssetId must be a non-empty string or null.');
+        }
+        return {
+            ...common,
+            domain: 'task-attachment-links',
+            mutationKind: 'replace',
+            links,
+            ...(hasCardCoverAssetId ? {
+                cardCoverAssetId: payload.cardCoverAssetId === null
+                    ? null
+                    : String(payload.cardCoverAssetId).trim(),
+            } : {}),
+        };
     }
     if (operation.domain === 'initiative') {
         const base = {
@@ -701,6 +740,9 @@ export function registerWorkspaceSyncV3LocalCaptureRoutes(input) {
                                                 identity,
                                                 taskId: envelope.entityId,
                                                 links: envelope.links,
+                                                ...(Object.prototype.hasOwnProperty.call(envelope, 'cardCoverAssetId')
+                                                    ? { cardCoverAssetId: envelope.cardCoverAssetId ?? null }
+                                                    : {}),
                                                 now: acceptedAt,
                                                 actorRef: 'user',
                                                 onPostCommitError: input.onPostCommitError,
@@ -713,6 +755,7 @@ export function registerWorkspaceSyncV3LocalCaptureRoutes(input) {
                                                     taskId: envelope.entityId,
                                                     patch: envelope.patch,
                                                     saveSource: envelope.saveSource,
+                                                    expectedDetailRevision: envelope.expectedDetailRevision,
                                                     now: acceptedAt,
                                                     actorRef: 'user',
                                                     onPostCommitError: input.onPostCommitError,
@@ -768,6 +811,7 @@ export function registerWorkspaceSyncV3LocalCaptureRoutes(input) {
                                                                     identity,
                                                                     taskId: envelope.entityId,
                                                                     payload: envelope.payload,
+                                                                    expectedDetailRevision: envelope.expectedDetailRevision,
                                                                     now: acceptedAt,
                                                                     actorRef: 'user',
                                                                     onPostCommitError: input.onPostCommitError,

package/dist/server/routes/syncV3LocalFeedApplyRoutes.d.ts

@@ -1,5 +1,6 @@
 import type { SyncAddRoute, SyncRouteAuthConfig, SyncRouteCore } from './syncRouteTypes.js';
 import type { LocalSyncCoordinatorRouteServices } from '../../sync/coordinator/localSyncCoordinatorRouteServices.js';
+export declare function revisionConflictDetails(error: unknown): Record<string, unknown> | undefined;
 export declare function isWorkspaceSyncV3LocalFeedApplyEnabled(env?: NodeJS.ProcessEnv): boolean;
 export declare function isWorkspaceSyncV3CombinedLocalFeedApplyEnabled(env?: NodeJS.ProcessEnv): boolean;
 export declare function registerWorkspaceSyncV3LocalFeedApplyRoutes(input: {

package/dist/server/routes/syncV3LocalFeedApplyRoutes.js

@@ -8,6 +8,7 @@ import { resolveCombinedFeedCapability, resolveRequestedCombinedFeedCoverage } f
 import { parseJsonBody } from './primitives.js';
 import { applyWorkspaceSyncV3TaskCommentAuditPage, readWorkspaceSyncV3TaskCommentAuditCursor, readWorkspaceSyncV3TaskCommentAuditState, } from '../../sync/v3/workspaceSyncV3TaskCommentAudit.js';
 import { createLocalSyncBrowserApplyPermitTransactionHooks, parseLocalSyncBrowserApplyPermitContext, } from '../../sync/coordinator/localSyncBrowserApplyPermitContext.js';
+import { WorkspaceSyncRevisionConflictError } from '../../sync/v3/syncDurabilityStore.js';
 const ROUTE_PATH = '/api/taskforce/sync/v3/local/feed';
 const TASK_COMMENT_AUDIT_PATH = '/api/taskforce/sync/v3/local/task-comment-audit';
 const MAX_BODY_BYTES = 8 * 1024 * 1024;
@@ -15,6 +16,29 @@ function writeJson(res, statusCode, body) {
     res.writeHead(statusCode, { 'Content-Type': 'application/json', 'Cache-Control': 'no-store' });
     res.end(JSON.stringify(body));
 }
+export function revisionConflictDetails(error) {
+    if (!(error instanceof WorkspaceSyncRevisionConflictError) || !error.details)
+        return undefined;
+    const details = error.details;
+    const coordinates = (value) => {
+        if (!value || typeof value !== 'object' || Array.isArray(value))
+            return undefined;
+        const source = value;
+        const sequence = source.sequence ?? source.lastSequence;
+        return {
+            sequence: sequence == null ? null : String(sequence),
+            entityRevision: source.entityRevision == null ? null : String(source.entityRevision),
+            lifecycleRevision: source.lifecycleRevision == null ? null : String(source.lifecycleRevision),
+        };
+    };
+    return {
+        domain: String(details.domain || ''),
+        entityId: String(details.entityId || ''),
+        reason: String(details.reason || ''),
+        ...(coordinates(details.incoming) ? { incoming: coordinates(details.incoming) } : {}),
+        ...(coordinates(details.current) ? { current: coordinates(details.current) } : {}),
+    };
+}
 function workspaceFromUrl(req) {
     try {
         return String(new URL(req.url || ROUTE_PATH, 'http://localhost').searchParams.get('workspaceId') || '').trim();
@@ -481,12 +505,14 @@ export function registerWorkspaceSyncV3LocalFeedApplyRoutes(input) {
         catch (error) {
             const causeCode = String(error?.code || '').trim();
             const causeAssetId = String(error?.assetId || '').trim();
+            const causeDetails = revisionConflictDetails(error);
             writeJson(res, 409, {
                 success: false,
                 code: 'WORKSPACE_SYNC_V3_LOCAL_FEED_APPLY_REJECTED',
                 error: String(error?.message || error),
                 ...(causeCode ? { causeCode } : {}),
                 ...(causeAssetId ? { causeAssetId } : {}),
+                ...(causeDetails ? { causeDetails } : {}),
             });
         }
     });

package/dist/server/routes/syncV3OperationRoutes.js

@@ -157,9 +157,13 @@ export function parseWorkspaceSyncV3OperationEnvelope(body) {
     const payload = requireObject(operation.payload, 'operation.payload');
     if (operation.domain === 'task' && operation.mutationKind === 'metadata-update') {
         const saveSource = payload.saveSource;
+        const expectedDetailRevision = payload.expectedDetailRevision === undefined
+            ? undefined
+            : requireId(payload.expectedDetailRevision, 'operation.payload.expectedDetailRevision');
         assertExactKeys(payload, [
             'patch',
             ...(saveSource === undefined ? [] : ['saveSource']),
+            ...(expectedDetailRevision === undefined ? [] : ['expectedDetailRevision']),
             ...(payload.originActor === undefined ? [] : ['originActor']),
         ], 'operation.payload');
         if (saveSource !== undefined && saveSource !== 'manual' && saveSource !== 'autosave') {
@@ -173,6 +177,7 @@ export function parseWorkspaceSyncV3OperationEnvelope(body) {
                 payload: {
                     patch: requireObject(payload.patch, 'operation.payload.patch'),
                     ...(saveSource ? { saveSource } : {}),
+                    ...(expectedDetailRevision ? { expectedDetailRevision } : {}),
                     ...(originActor ? { originActor } : {}),
                 },
             } };
@@ -364,6 +369,7 @@ export function parseWorkspaceSyncV3OperationEnvelope(body) {
             ...baseKeys,
             ...(payload.workflowAssignment === undefined ? [] : ['workflowAssignment']),
             ...(payload.originActor === undefined ? [] : ['originActor']),
+            ...(payload.expectedDetailRevision === undefined ? [] : ['expectedDetailRevision']),
         ], 'operation.payload');
         const normalizedPayload = validateDurableTaskStatusMutationPayload({
             status: payload.status,
@@ -382,12 +388,16 @@ export function parseWorkspaceSyncV3OperationEnvelope(body) {
         const originActor = payload.originActor === undefined
             ? undefined
             : requireOriginActor(payload.originActor);
+        const expectedDetailRevision = payload.expectedDetailRevision === undefined
+            ? undefined
+            : requireId(payload.expectedDetailRevision, 'operation.payload.expectedDetailRevision');
         return { ...common, operation: {
                 domain: 'task', entityId, mutationKind: 'set-status', baseEntityRevision, baseLifecycleRevision,
                 payload: {
                     ...normalizedPayload,
                     ...(workflowAssignment ? { workflowAssignment } : {}),
                     ...(originActor ? { originActor } : {}),
+                    ...(expectedDetailRevision ? { expectedDetailRevision } : {}),
                 },
             } };
     }
@@ -471,7 +481,11 @@ export function parseWorkspaceSyncV3OperationEnvelope(body) {
         if (baseLifecycleRevision !== '0') {
             throw new SyncV3RequestError('Task attachment-link lifecycle revision must be 0.');
         }
-        assertExactKeys(payload, payload.originActor === undefined ? ['links'] : ['links', 'originActor'], 'operation.payload');
+        assertExactKeys(payload, [
+            'links',
+            ...(payload.cardCoverAssetId === undefined ? [] : ['cardCoverAssetId']),
+            ...(payload.originActor === undefined ? [] : ['originActor']),
+        ], 'operation.payload');
         let links;
         try {
             links = validateWorkspaceSyncV3TaskAttachmentLinksPayload({ taskId: entityId, links: payload.links }).links;
@@ -482,10 +496,21 @@ export function parseWorkspaceSyncV3OperationEnvelope(body) {
         const originActor = payload.originActor === undefined
             ? undefined
             : requireOriginActor(payload.originActor);
+        const cardCoverAssetId = payload.cardCoverAssetId === undefined
+            ? undefined
+            : payload.cardCoverAssetId === null
+                ? null
+                : typeof payload.cardCoverAssetId === 'string' && payload.cardCoverAssetId.trim()
+                    ? payload.cardCoverAssetId.trim()
+                    : (() => { throw new SyncV3RequestError('operation.payload.cardCoverAssetId must be a string or null.'); })();
         return { ...common, operation: {
                 domain: 'task-attachment-links', entityId, mutationKind: 'replace', baseEntityRevision,
                 baseLifecycleRevision: '0',
-                payload: { links, ...(originActor ? { originActor } : {}) },
+                payload: {
+                    links,
+                    ...(cardCoverAssetId !== undefined ? { cardCoverAssetId } : {}),
+                    ...(originActor ? { originActor } : {}),
+                },
             } };
     }
     if (operation.domain === 'entity-event'