@taskforcehq/taskforce 0.3.327 → 0.3.328

package/dist/core/types.d.ts

@@ -104,7 +104,7 @@ export interface ScheduleBoardResult {
         }>;
     };
 }
-export type RealtimeMutationEntityType = 'task' | 'taxonomy' | 'document-metadata';
+export type RealtimeMutationEntityType = 'task' | 'initiative' | 'workstream' | 'taxonomy' | 'document-metadata';
 export interface RealtimeMutationEvent {
     eventId: string;
     workspaceId: string;
@@ -141,6 +141,7 @@ export interface TaskforceConfig {
     storagePath?: string;
     tenantId?: string;
     runtimeMode?: RuntimeMode;
+    initializationMode?: 'standard' | 'cloud-read-worker';
     database?: {
         provider?: DatabaseProvider;
         connectionString?: string;

package/dist/documentReviews/DocumentReviewCommentStore.d.ts

@@ -28,7 +28,18 @@ export declare class DocumentReviewCommentStore {
         threadStatusUpdatedAt?: string | null;
         resolvedAt?: string | null;
         resolvedByActorId?: string | null;
+        idempotencyKey?: string | null;
+        idempotencyFingerprint?: string | null;
+        idempotencyActorScope?: string | null;
     }): DocumentReviewCommentSyncRecord;
+    getByIdempotencyKey(input: {
+        workspaceId: string;
+        actorScope: string;
+        idempotencyKey: string;
+    }): {
+        comment: DocumentReviewCommentSyncRecord;
+        fingerprint: string;
+    } | null;
     get(commentIdRaw: string, workspaceIdRaw: string, options?: {
         includeDeleted?: boolean;
     }): DocumentReviewCommentSyncRecord | null;

package/dist/documentReviews/DocumentReviewCommentStore.js

@@ -149,16 +149,49 @@ export class DocumentReviewCommentStore {
                 thread_status_updated_at,
                 resolved_at,
                 resolved_by_actor_id,
+                idempotency_key,
+                idempotency_fingerprint,
+                idempotency_actor_scope,
                 order_index,
                 created_at,
                 updated_at,
                 deleted_at
-            ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+            ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+            ${normalizeNullable(input.idempotencyKey)
+            ? 'ON CONFLICT (tenant_id, workspace_id, idempotency_actor_scope, idempotency_key) DO NOTHING'
+            : ''}
         `).run(id, sessionId, this.tenantId, workspaceId, normalizeId(input.body), input.anchor ? JSON.stringify(input.anchor) : null, normalizeNullable(input.authorActorId), normalizeNullable(input.updatedByActorId ?? input.authorActorId), normalizeNullable(input.deletedByActorId), parentCommentId, parentCommentId
             ? null
-            : (input.threadStatus === 'resolved' ? 'resolved' : 'open'), parentCommentId ? null : (normalizeNullable(input.threadStatusUpdatedAt) || updatedAt), parentCommentId ? null : normalizeNullable(input.resolvedAt), parentCommentId ? null : normalizeNullable(input.resolvedByActorId), normalizePositiveInteger(input.order) ?? 0, createdAt, updatedAt, normalizeNullable(input.deletedAt));
+            : (input.threadStatus === 'resolved' ? 'resolved' : 'open'), parentCommentId ? null : (normalizeNullable(input.threadStatusUpdatedAt) || updatedAt), parentCommentId ? null : normalizeNullable(input.resolvedAt), parentCommentId ? null : normalizeNullable(input.resolvedByActorId), normalizeNullable(input.idempotencyKey), normalizeNullable(input.idempotencyFingerprint), normalizeId(input.idempotencyActorScope), normalizePositiveInteger(input.order) ?? 0, createdAt, updatedAt, normalizeNullable(input.deletedAt));
+        if (normalizeNullable(input.idempotencyKey)) {
+            const replay = this.getByIdempotencyKey({
+                workspaceId,
+                actorScope: normalizeId(input.idempotencyActorScope),
+                idempotencyKey: normalizeId(input.idempotencyKey),
+            });
+            if (replay)
+                return replay.comment;
+        }
         return this.get(id, workspaceId, { includeDeleted: true });
     }
+    getByIdempotencyKey(input) {
+        const workspaceId = normalizeWorkspaceId(input.workspaceId);
+        const row = this.db.prepare(`
+            SELECT *
+            FROM document_review_comments
+            WHERE tenant_id = ?
+              AND workspace_id = ?
+              AND idempotency_actor_scope = ?
+              AND idempotency_key = ?
+            LIMIT 1
+        `).get(this.tenantId, workspaceId, normalizeId(input.actorScope), normalizeId(input.idempotencyKey));
+        if (!row)
+            return null;
+        return {
+            comment: mapRow(row),
+            fingerprint: normalizeId(row.idempotency_fingerprint),
+        };
+    }
     get(commentIdRaw, workspaceIdRaw, options) {
         const commentId = normalizeId(commentIdRaw);
         const workspaceId = normalizeWorkspaceId(workspaceIdRaw);

package/dist/documentReviews/service.d.ts

@@ -49,6 +49,8 @@ export declare function addDocumentReviewCommentService(deps: DocumentReviewServ
     body: string;
     anchor?: DocumentReviewAnchor | null;
     actorId?: string | null;
+    idempotencyKey?: string | null;
+    commentId?: string | null;
 }): DocumentReviewSession;
 export declare function addDocumentReviewReplyService(deps: DocumentReviewServiceDeps, input: {
     workspaceId?: string | null;
@@ -56,6 +58,8 @@ export declare function addDocumentReviewReplyService(deps: DocumentReviewServic
     parentCommentId: string;
     body: string;
     actorId?: string | null;
+    idempotencyKey?: string | null;
+    commentId?: string | null;
 }): DocumentReviewSession;
 export declare function updateDocumentReviewThreadStatusService(deps: DocumentReviewServiceDeps, input: {
     workspaceId?: string | null;

package/dist/documentReviews/service.js

@@ -1,9 +1,50 @@
+import { createHash } from 'node:crypto';
 function normalizeId(value) {
     return String(value || '').trim();
 }
 function normalizeCommentBody(value) {
     return String(value || '').trim();
 }
+function normalizeIdempotencyKey(value) {
+    if (value === undefined || value === null)
+        return null;
+    const key = String(value).trim();
+    if (!key || key.length > 128)
+        return null;
+    return key;
+}
+function documentReviewCommentFingerprint(input) {
+    return createHash('sha256').update(JSON.stringify(input)).digest('hex');
+}
+function resolveDocumentReviewCommentReplay(deps, input) {
+    if (!input.idempotencyKey)
+        return null;
+    const existing = deps.commentStore.getByIdempotencyKey({
+        workspaceId: input.workspaceId,
+        actorScope: input.actorScope,
+        idempotencyKey: input.idempotencyKey,
+    });
+    const synchronizedCommentId = normalizeId(input.commentId);
+    const synchronizedComment = !existing && synchronizedCommentId
+        ? deps.commentStore.get(synchronizedCommentId, input.workspaceId, { includeDeleted: true })
+        : null;
+    const replayComment = existing?.comment || synchronizedComment;
+    const replayFingerprint = existing?.fingerprint || (synchronizedComment
+        ? documentReviewCommentFingerprint({
+            sessionId: synchronizedComment.sessionId,
+            parentCommentId: synchronizedComment.parentCommentId,
+            body: normalizeCommentBody(synchronizedComment.body),
+            anchor: normalizeAnchorInput(synchronizedComment.anchor),
+            actorScope: normalizeId(synchronizedComment.authorActorId) || 'anonymous',
+        })
+        : null);
+    if (!replayComment)
+        return null;
+    if (replayFingerprint !== input.fingerprint || replayComment.deletedAt) {
+        throw deps.createRuleError('idempotencyKey is already assigned to a different document review comment.', 409, 'DOCUMENT_REVIEW_IDEMPOTENCY_CONFLICT');
+    }
+    return replayComment;
+}
 function normalizeStatus(value) {
     return String(value || '').trim().toLowerCase() === 'resolved' ? 'resolved' : 'open';
 }
@@ -194,46 +235,74 @@ export function updateDocumentReviewSessionService(deps, input) {
 }
 export function addDocumentReviewCommentService(deps, input) {
     const workspaceId = deps.normalizeWorkspaceId(input.workspaceId);
-    const existing = deps.sessionStore.get(input.sessionId, workspaceId);
-    if (!existing)
-        throw deps.createRuleError('Document review session not found.', 404, 'DOCUMENT_REVIEW_SESSION_NOT_FOUND');
-    getRequiredDocumentAsset(deps, workspaceId, existing.assetId);
-    if (existing.status === 'resolved') {
-        throw deps.createRuleError('Reopen this review before adding comments.', 409, 'DOCUMENT_REVIEW_RESOLVED');
-    }
-    const body = normalizeCommentBody(input.body);
-    if (!body)
-        throw deps.createRuleError('Comment body is required.', 400, 'DOCUMENT_REVIEW_COMMENT_REQUIRED');
-    const anchorError = validateDocumentReviewAnchorInput(input.anchor);
-    if (anchorError)
-        throw deps.createRuleError(anchorError, 400, 'DOCUMENT_REVIEW_ANCHOR_INVALID');
-    const now = new Date().toISOString();
-    deps.commentStore.create({
-        id: deps.generateEntityId('document-review-comment'),
-        sessionId: existing.id,
-        workspaceId,
-        order: nextCommentOrder(deps.commentStore.listForSession(existing.id, workspaceId, { includeDeleted: true })),
-        body,
-        anchor: normalizeAnchorInput(input.anchor),
-        authorActorId: normalizeId(input.actorId) || null,
-        updatedByActorId: normalizeId(input.actorId) || null,
-        deletedByActorId: null,
-        parentCommentId: null,
-        threadStatus: 'open',
-        threadStatusUpdatedAt: now,
-        resolvedAt: null,
-        resolvedByActorId: null,
-        createdAt: now,
-        updatedAt: now,
-        deletedAt: null,
-    });
-    const updated = deps.sessionStore.update({
-        id: existing.id,
-        workspaceId,
-        updatedByActorId: normalizeId(input.actorId) || null,
-        updatedAt: now,
+    return inTransaction(deps, () => {
+        const existing = deps.sessionStore.get(input.sessionId, workspaceId);
+        if (!existing)
+            throw deps.createRuleError('Document review session not found.', 404, 'DOCUMENT_REVIEW_SESSION_NOT_FOUND');
+        getRequiredDocumentAsset(deps, workspaceId, existing.assetId);
+        const body = normalizeCommentBody(input.body);
+        if (!body)
+            throw deps.createRuleError('Comment body is required.', 400, 'DOCUMENT_REVIEW_COMMENT_REQUIRED');
+        const anchorError = validateDocumentReviewAnchorInput(input.anchor);
+        if (anchorError)
+            throw deps.createRuleError(anchorError, 400, 'DOCUMENT_REVIEW_ANCHOR_INVALID');
+        const anchor = normalizeAnchorInput(input.anchor);
+        const actorScope = normalizeId(input.actorId) || 'anonymous';
+        const idempotencyKey = normalizeIdempotencyKey(input.idempotencyKey);
+        const commentId = normalizeId(input.commentId) || null;
+        if (input.idempotencyKey != null && !idempotencyKey) {
+            throw deps.createRuleError('idempotencyKey must contain 1 to 128 characters.', 400, 'DOCUMENT_REVIEW_IDEMPOTENCY_KEY_INVALID');
+        }
+        const fingerprint = documentReviewCommentFingerprint({
+            sessionId: existing.id, parentCommentId: null, body, anchor, actorScope,
+        });
+        const replay = resolveDocumentReviewCommentReplay(deps, {
+            workspaceId, idempotencyKey, commentId, actorScope, fingerprint,
+        });
+        if (replay)
+            return hydrateSession(deps, existing);
+        if (existing.status === 'resolved') {
+            throw deps.createRuleError('Reopen this review before adding comments.', 409, 'DOCUMENT_REVIEW_RESOLVED');
+        }
+        const now = new Date().toISOString();
+        const createdCommentId = commentId || deps.generateEntityId('document-review-comment');
+        const created = deps.commentStore.create({
+            id: createdCommentId,
+            sessionId: existing.id,
+            workspaceId,
+            order: nextCommentOrder(deps.commentStore.listForSession(existing.id, workspaceId, { includeDeleted: true })),
+            body,
+            anchor,
+            authorActorId: normalizeId(input.actorId) || null,
+            updatedByActorId: normalizeId(input.actorId) || null,
+            deletedByActorId: null,
+            parentCommentId: null,
+            threadStatus: 'open',
+            threadStatusUpdatedAt: now,
+            resolvedAt: null,
+            resolvedByActorId: null,
+            createdAt: now,
+            updatedAt: now,
+            deletedAt: null,
+            idempotencyKey,
+            idempotencyFingerprint: idempotencyKey ? fingerprint : null,
+            idempotencyActorScope: idempotencyKey ? actorScope : '',
+        });
+        if (created.id !== createdCommentId) {
+            const concurrentReplay = resolveDocumentReviewCommentReplay(deps, {
+                workspaceId, idempotencyKey, commentId: createdCommentId, actorScope, fingerprint,
+            });
+            if (concurrentReplay)
+                return hydrateSession(deps, existing);
+        }
+        const updated = deps.sessionStore.update({
+            id: existing.id,
+            workspaceId,
+            updatedByActorId: normalizeId(input.actorId) || null,
+            updatedAt: now,
+        });
+        return hydrateSession(deps, updated);
     });
-    return hydrateSession(deps, updated);
 }
 export function addDocumentReviewReplyService(deps, input) {
     const workspaceId = deps.normalizeWorkspaceId(input.workspaceId);
@@ -242,24 +311,40 @@ export function addDocumentReviewReplyService(deps, input) {
         if (!session)
             throw deps.createRuleError('Document review session not found.', 404, 'DOCUMENT_REVIEW_SESSION_NOT_FOUND');
         getRequiredDocumentAsset(deps, workspaceId, session.assetId);
+        const body = normalizeCommentBody(input.body);
+        if (!body)
+            throw deps.createRuleError('Reply body is required.', 400, 'DOCUMENT_REVIEW_COMMENT_REQUIRED');
+        const actorId = normalizeId(input.actorId) || null;
+        const actorScope = actorId || 'anonymous';
+        const parentCommentId = normalizeId(input.parentCommentId);
+        const idempotencyKey = normalizeIdempotencyKey(input.idempotencyKey);
+        const commentId = normalizeId(input.commentId) || null;
+        if (input.idempotencyKey != null && !idempotencyKey) {
+            throw deps.createRuleError('idempotencyKey must contain 1 to 128 characters.', 400, 'DOCUMENT_REVIEW_IDEMPOTENCY_KEY_INVALID');
+        }
+        const fingerprint = documentReviewCommentFingerprint({
+            sessionId: session.id, parentCommentId, body, anchor: null, actorScope,
+        });
+        const replay = resolveDocumentReviewCommentReplay(deps, {
+            workspaceId, idempotencyKey, commentId, actorScope, fingerprint,
+        });
+        if (replay)
+            return hydrateSession(deps, session);
         if (session.status === 'resolved') {
             throw deps.createRuleError('Reopen this review before replying.', 409, 'DOCUMENT_REVIEW_RESOLVED');
         }
         const comments = deps.commentStore.listForSession(session.id, workspaceId, { includeDeleted: true });
-        const root = comments.find((comment) => comment.id === normalizeId(input.parentCommentId) && !comment.deletedAt);
+        const root = comments.find((comment) => comment.id === parentCommentId && !comment.deletedAt);
         if (!root || root.parentCommentId) {
             throw deps.createRuleError('Document review thread not found.', 404, 'DOCUMENT_REVIEW_THREAD_NOT_FOUND');
         }
         if (root.threadStatus === 'resolved') {
             throw deps.createRuleError('Reopen this thread before replying.', 409, 'DOCUMENT_REVIEW_THREAD_RESOLVED');
         }
-        const body = normalizeCommentBody(input.body);
-        if (!body)
-            throw deps.createRuleError('Reply body is required.', 400, 'DOCUMENT_REVIEW_COMMENT_REQUIRED');
-        const actorId = normalizeId(input.actorId) || null;
         const now = new Date().toISOString();
-        deps.commentStore.create({
-            id: deps.generateEntityId('document-review-comment'),
+        const createdCommentId = commentId || deps.generateEntityId('document-review-comment');
+        const created = deps.commentStore.create({
+            id: createdCommentId,
             sessionId: session.id,
             workspaceId,
             parentCommentId: root.id,
@@ -276,7 +361,17 @@ export function addDocumentReviewReplyService(deps, input) {
             createdAt: now,
             updatedAt: now,
             deletedAt: null,
+            idempotencyKey,
+            idempotencyFingerprint: idempotencyKey ? fingerprint : null,
+            idempotencyActorScope: idempotencyKey ? actorScope : '',
         });
+        if (created.id !== createdCommentId) {
+            const concurrentReplay = resolveDocumentReviewCommentReplay(deps, {
+                workspaceId, idempotencyKey, commentId: createdCommentId, actorScope, fingerprint,
+            });
+            if (concurrentReplay)
+                return hydrateSession(deps, session);
+        }
         const updated = deps.sessionStore.update({
             id: session.id,
             workspaceId,

package/dist/hooks/tasks/useTaskFormActions.d.ts

@@ -22,11 +22,14 @@ interface UseTaskFormActionsInput {
     editingTaskId: string | null;
     fetchTasks: (isSilent?: boolean) => Promise<void>;
     formTaxonomies: Record<string, string | number | string[] | number[]>;
+    getAttachmentsDraft?: () => Array<string | AttachmentItem>;
     getDescriptionDraft?: () => string;
     getPreferredCategoryValue: (categories: CategoryConfig[]) => string;
     getTitleDraft?: () => string;
+    awaitPendingDescriptionImageUpload?: () => Promise<void>;
     mergeTaskFromServer: (task: unknown) => void;
     onTaskCreated?: (task: TaskItem) => void;
+    onTaskCreateAccepted?: (task: TaskItem) => Promise<void> | void;
     workstreamInput: string;
     priority: number | string;
     pushNotice: (message: string, tone?: 'success' | 'error' | 'info') => void;

package/dist/hooks/tasks/useTaskFormActions.js

@@ -4,13 +4,18 @@ import { normalizeTaskFromApi } from '../../utils/taskNormalization.js';
 import { createCloudTaskHttpMutationClient, fetchTaskHttpMutation, isConclusiveTaskHttpResponse, } from './taskHttpMutation.js';
 import { canonicalWorkspaceSyncJson } from '../../sync/v3/canonicalWorkspaceSyncJson.js';
 export function useTaskFormActions(input) {
-    const { activeCategories, activeTab, apiEndpoint, assignee, attachments, attachmentsDirty, category, checklistItems, comments, complexity, description, dueDate, createTaskDurably, durableTaskHttpRootActivationEnabled = false, workspaceId, taskHttpMutationClient, updateTask, editingTaskId, fetchTasks, formTaxonomies, getDescriptionDraft: getDescriptionDraftInput, getPreferredCategoryValue, getTitleDraft: getTitleDraftInput, mergeTaskFromServer, onTaskCreated, workstreamInput, priority, pushNotice, queueWorkspaceSyncFromAuthoritativeTaskState, relationshipTasks, supplementalTasks = [], resetForm, resolveWorkstreamIdInput, scheduledDate, setActiveTab, setAttachmentsDirty, setComments, setError, setLastUsedCategory, setLoading, setNewCommentText, status, title, taxonomies, textDraftOccupied, type } = input;
+    const { activeCategories, activeTab, apiEndpoint, assignee, attachments, attachmentsDirty, category, checklistItems, comments, complexity, description, dueDate, createTaskDurably, durableTaskHttpRootActivationEnabled = false, workspaceId, taskHttpMutationClient, updateTask, editingTaskId, fetchTasks, formTaxonomies, getAttachmentsDraft: getAttachmentsDraftInput, getDescriptionDraft: getDescriptionDraftInput, getPreferredCategoryValue, getTitleDraft: getTitleDraftInput, awaitPendingDescriptionImageUpload: awaitPendingDescriptionImageUploadInput, mergeTaskFromServer, onTaskCreated, onTaskCreateAccepted, workstreamInput, priority, pushNotice, queueWorkspaceSyncFromAuthoritativeTaskState, relationshipTasks, supplementalTasks = [], resetForm, resolveWorkstreamIdInput, scheduledDate, setActiveTab, setAttachmentsDirty, setComments, setError, setLastUsedCategory, setLoading, setNewCommentText, status, title, taxonomies, textDraftOccupied, type } = input;
     const getTitleDraft = getTitleDraftInput || (() => title);
     const getDescriptionDraft = getDescriptionDraftInput || (() => description);
+    const getAttachmentsDraft = getAttachmentsDraftInput || (() => attachments);
     const getTitleDraftRef = useRef(getTitleDraft);
     const getDescriptionDraftRef = useRef(getDescriptionDraft);
+    const getAttachmentsDraftRef = useRef(getAttachmentsDraft);
+    const awaitPendingDescriptionImageUploadRef = useRef(awaitPendingDescriptionImageUploadInput);
     getTitleDraftRef.current = getTitleDraft;
     getDescriptionDraftRef.current = getDescriptionDraft;
+    getAttachmentsDraftRef.current = getAttachmentsDraft;
+    awaitPendingDescriptionImageUploadRef.current = awaitPendingDescriptionImageUploadInput;
     const readTextDraft = useCallback(() => ({
         title: getTitleDraftRef.current(),
         description: getDescriptionDraftRef.current(),
@@ -48,7 +53,7 @@ export function useTaskFormActions(input) {
         }
         createDraftOccupiedRef.current = createDraftOccupied;
     }, [createDraftOccupied, createTaskDurably, workspaceId]);
-    const buildTaskDraftSignature = useCallback((textDraft = readTextDraft()) => JSON.stringify({
+    const buildTaskDraftSignature = useCallback((textDraft = readTextDraft(), attachmentDraft = getAttachmentsDraftRef.current()) => JSON.stringify({
         title: textDraft.title.trim(),
         description: textDraft.description,
         category: typeof category === 'string'
@@ -64,11 +69,10 @@ export function useTaskFormActions(input) {
         checklistItems,
         comments,
         taxonomies: formTaxonomies,
-        attachments,
+        attachments: attachmentDraft,
     }), [
         activeCategories,
         assignee,
-        attachments,
         category,
         checklistItems,
         comments,
@@ -123,9 +127,23 @@ export function useTaskFormActions(input) {
     const saveTask = useCallback(async (options) => {
         const quiet = options?.quiet ?? false;
         const source = options?.source ?? 'manual';
+        if (!editingTaskId && source === 'manual') {
+            try {
+                await awaitPendingDescriptionImageUploadRef.current?.();
+            }
+            catch (error) {
+                console.error('Description image upload did not settle before task creation.', error);
+                const message = 'Wait for the Description image upload to finish, then try again.';
+                setError(message);
+                if (!quiet)
+                    pushNotice(message, 'error');
+                return false;
+            }
+        }
         const textDraft = options?.textDraft ?? readTextDraft();
         const draftTitle = textDraft.title;
         const draftDescription = textDraft.description;
+        const draftAttachments = getAttachmentsDraftRef.current();
         if (!editingTaskId) {
             createdTaskRef.current = null;
         }
@@ -218,7 +236,7 @@ export function useTaskFormActions(input) {
             if (!editingTaskId)
                 body.comments = comments;
             if (!editingTaskId || attachmentsDirty) {
-                body.attachments = attachments;
+                body.attachments = draftAttachments;
             }
             if (editingTaskId && Object.keys(body).length > 0) {
                 body.saveSource = source;
@@ -383,7 +401,6 @@ export function useTaskFormActions(input) {
         activeCategories,
         apiEndpoint,
         assignee,
-        attachments,
         attachmentsDirty,
         category,
         checklistItems,
@@ -424,6 +441,15 @@ export function useTaskFormActions(input) {
             suppressNextCreateSuccessNoticeRef.current = false;
             if (activeTab === 'add' && !editingTaskId) {
                 const createdTask = createdTaskRef.current;
+                if (createdTask && onTaskCreateAccepted) {
+                    try {
+                        await onTaskCreateAccepted(createdTask);
+                    }
+                    catch (error) {
+                        console.warn('Task create draft upload promotion failed.', error);
+                        pushNotice('Task created successfully. Temporary image cleanup will retry automatically.', 'info');
+                    }
+                }
                 if (createdTask && onTaskCreated) {
                     onTaskCreated(createdTask);
                     return;
@@ -433,7 +459,7 @@ export function useTaskFormActions(input) {
                 await fetchTasks();
             }
         }
-    }, [activeTab, editingTaskId, fetchTasks, onTaskCreated, pushNotice, resetForm, saveTask, setActiveTab]);
+    }, [activeTab, editingTaskId, fetchTasks, onTaskCreateAccepted, onTaskCreated, pushNotice, resetForm, saveTask, setActiveTab]);
     useEffect(() => {
         clearAutoSaveTimer();
         queuedAutoSaveRef.current = null;