@taskforcehq/taskforce 0.3.306 → 0.3.308

package/dist/server/routes/tasks.js

@@ -60,6 +60,8 @@ import { getRouteTimingNow, logSlowBootstrapRoute, requestBootstrapTraceId, requ
 import { listBuiltInCustomTaxonomyLibraryPacks } from '../../shared/customTaxonomyLibrary.js';
 import { listBuiltInTaxonomyLibraryPacks } from '../../shared/taxonomyLibrary.js';
 import { shouldUseProvisionalTaskReferences } from '../../utils/taskReferences.js';
+// === SECTION: Module dependency interface ===
+const UI_STATE_MAX_JSON_BODY_BYTES = 50 * 1024 * 1024;
 function createUiStateRequestId() {
     return `ui-${Date.now().toString(36)}-${Math.random().toString(36).slice(2, 8)}`;
 }
@@ -237,8 +239,9 @@ export function registerTaskRoutes(deps) {
         const requestId = createUiStateRequestId();
         const startedAt = Date.now();
         attachUiStateDebugHeaders(res, requestId);
-        const body = await parseJsonBody(req);
+        let body = {};
         try {
+            body = await parseJsonBody(req, UI_STATE_MAX_JSON_BODY_BYTES);
             const requestedWorkspaceId = String(body?.workspaceId || '').trim();
             let workspaceId = requestWorkspaceId(req);
             if (requestedWorkspaceId && requestRuntimeMode(req) === 'local') {
@@ -555,7 +558,7 @@ export function registerTaskRoutes(deps) {
         const body = await parseJsonBody(req);
         try {
             const workspaceId = requestWorkspaceId(req);
-            const initiative = core.createInitiative(body || {}, workspaceId);
+            const initiative = core.createInitiative(body || {}, workspaceId, { actorRef: 'user' });
             res.writeHead(201, { 'Content-Type': 'application/json' });
             res.end(JSON.stringify(initiative));
         }
@@ -587,7 +590,7 @@ export function registerTaskRoutes(deps) {
         const body = await parseJsonBody(req);
         try {
             const workspaceId = requestWorkspaceId(req);
-            const updated = core.updateInitiative(params.id, body || {}, workspaceId);
+            const updated = core.updateInitiative(params.id, body || {}, workspaceId, { actorRef: 'user' });
             res.writeHead(200, { 'Content-Type': 'application/json' });
             res.end(JSON.stringify(updated));
         }
@@ -603,7 +606,7 @@ export function registerTaskRoutes(deps) {
             return;
         try {
             const workspaceId = requestWorkspaceId(req);
-            const archived = core.archiveInitiative(params.id, workspaceId);
+            const archived = core.archiveInitiative(params.id, workspaceId, { actorRef: 'user' });
             res.writeHead(200, { 'Content-Type': 'application/json' });
             res.end(JSON.stringify(archived));
         }
@@ -619,7 +622,7 @@ export function registerTaskRoutes(deps) {
             return;
         try {
             const workspaceId = requestWorkspaceId(req);
-            const restored = core.unarchiveInitiative(params.id, workspaceId);
+            const restored = core.unarchiveInitiative(params.id, workspaceId, { actorRef: 'user' });
             res.writeHead(200, { 'Content-Type': 'application/json' });
             res.end(JSON.stringify(restored));
         }
@@ -646,7 +649,7 @@ export function registerTaskRoutes(deps) {
         const body = await parseJsonBody(req);
         try {
             const workspaceId = requestWorkspaceId(req);
-            const workstream = core.createWorkstream(body || {}, workspaceId);
+            const workstream = core.createWorkstream(body || {}, workspaceId, { actorRef: 'user' });
             res.writeHead(201, { 'Content-Type': 'application/json' });
             res.end(JSON.stringify(workstream));
         }
@@ -678,7 +681,7 @@ export function registerTaskRoutes(deps) {
         const body = await parseJsonBody(req);
         try {
             const workspaceId = requestWorkspaceId(req);
-            const updated = core.updateWorkstream(params.id, body || {}, workspaceId);
+            const updated = core.updateWorkstream(params.id, body || {}, workspaceId, { actorRef: 'user' });
             res.writeHead(200, { 'Content-Type': 'application/json' });
             res.end(JSON.stringify(updated));
         }
@@ -694,7 +697,7 @@ export function registerTaskRoutes(deps) {
             return;
         try {
             const workspaceId = requestWorkspaceId(req);
-            const archived = core.archiveWorkstream(params.id, workspaceId);
+            const archived = core.archiveWorkstream(params.id, workspaceId, { actorRef: 'user' });
             res.writeHead(200, { 'Content-Type': 'application/json' });
             res.end(JSON.stringify(archived));
         }
@@ -710,7 +713,7 @@ export function registerTaskRoutes(deps) {
             return;
         try {
             const workspaceId = requestWorkspaceId(req);
-            const restored = core.unarchiveWorkstream(params.id, workspaceId);
+            const restored = core.unarchiveWorkstream(params.id, workspaceId, { actorRef: 'user' });
             res.writeHead(200, { 'Content-Type': 'application/json' });
             res.end(JSON.stringify(restored));
         }

package/dist/server/routes.js

@@ -111,13 +111,14 @@ function resolveErrorStatusCode(error, fallback = 400) {
     }
     return fallback;
 }
-function writeMcpHttpError(res, statusCode, message) {
+function writeMcpHttpError(res, statusCode, message, data) {
     res.writeHead(statusCode, { 'Content-Type': 'application/json' });
     res.end(JSON.stringify({
         jsonrpc: '2.0',
         error: {
             code: -32000,
             message,
+            ...(data ? { data } : {}),
         },
         id: null,
     }));
@@ -522,7 +523,10 @@ export function createRoutes(core, context = {}) {
         const primaryLink = canonicalAsset?.assetId
             ? workspaceAssetStore?.listLinksForAsset(canonicalAsset.assetId, inferWorkspaceIdFromStoragePath(normalizedStorageKey)).find((entry) => !entry.deletedAt && (!opts?.taskId || entry.taskId === opts.taskId))
             : null;
+        const isExplicitTaskAttachment = typeof opts?.taskId === 'string' && opts.taskId.trim().length > 0;
         const timestamp = String(opts?.timestamp
+            || primaryLink?.updatedAt
+            || (isExplicitTaskAttachment ? new Date().toISOString() : null)
             || canonicalAsset?.updatedAt
             || canonicalAsset?.createdAt
             || new Date().toISOString()).trim() || new Date().toISOString();
@@ -567,6 +571,45 @@ export function createRoutes(core, context = {}) {
             taskId
         };
     };
+    const taskHasAttachmentForAsset = (task, asset) => {
+        if (!task || !Array.isArray(task.attachments))
+            return false;
+        const canonicalDocumentPath = `/api/taskforce/documents/${encodeURIComponent(asset.assetId)}/content`;
+        const contextPath = `/api/taskforce/context/${encodeURIComponent(asset.storageKey)}`;
+        return task.attachments.some((attachment) => {
+            if (typeof attachment === 'string') {
+                return attachment === canonicalDocumentPath
+                    || attachment === contextPath
+                    || attachment === asset.storageKey;
+            }
+            if (!attachment || typeof attachment !== 'object')
+                return false;
+            return attachment.assetId === asset.assetId
+                || attachment.fsPath === asset.storageKey
+                || attachment.path === canonicalDocumentPath
+                || attachment.path === contextPath;
+        });
+    };
+    const recordTaskAttachmentActivity = (input) => {
+        const afterTask = core.getTask(input.taskId, input.workspaceId);
+        if (!taskHasAttachmentForAsset(afterTask, input.asset))
+            return;
+        core.recordTaskEvent({
+            taskId: input.taskId,
+            workspaceId: input.workspaceId,
+            action: 'task-attachments-changed',
+            actor: 'user',
+            createdAt: input.createdAt || new Date().toISOString(),
+            details: {
+                changes: {
+                    attachments: {
+                        from: input.beforeTask.attachments || [],
+                        to: afterTask?.attachments || [],
+                    },
+                },
+            },
+        });
+    };
     const sanitizeDownloadFilename = (nameRaw, fallback = 'download') => {
         const normalized = String(nameRaw || '').trim()
             .replace(/[\\/:*?"<>|]/g, '-')
@@ -660,6 +703,8 @@ export function createRoutes(core, context = {}) {
                 purgeAfter: null
             });
             const taskId = String(params.taskId || inferTaskIdFromStoragePath(params.relativeToStorage) || '').trim();
+            const taskBeforeLink = taskId ? core.getTask(taskId, workspaceId) : null;
+            const wasAttachedBefore = taskHasAttachmentForAsset(taskBeforeLink, asset);
             if (taskId) {
                 workspaceAssetStore.upsertLink({
                     workspaceId,
@@ -669,6 +714,15 @@ export function createRoutes(core, context = {}) {
                     displayName: null,
                     deletedAt: null
                 });
+                if (taskBeforeLink && !wasAttachedBefore) {
+                    recordTaskAttachmentActivity({
+                        taskId,
+                        workspaceId,
+                        asset,
+                        beforeTask: taskBeforeLink,
+                        createdAt: asset.updatedAt,
+                    });
+                }
             }
             core.notifyDocumentMetadataMutation(workspaceId, [params.relativeToStorage], 'upsert');
         }
@@ -1146,6 +1200,8 @@ export function createRoutes(core, context = {}) {
                 authenticatedViaOAuth: oauthAuth || null,
                 userId: null,
                 ...bootstrap,
+                aiProfileToken: bootstrap.aiProfileToken || oauthAuth?.aiProfileToken || null,
+                aiProfileName: bootstrap.aiProfileName || oauthAuth?.aiProfileName || null,
             };
         }
         core.addMcpAuditLog({
@@ -1385,6 +1441,7 @@ export function createRoutes(core, context = {}) {
             return;
         }
         const authScopes = auth.authenticatedViaToken?.scopes || auth.authenticatedViaOAuth?.scopes || [];
+        const requestId = String(req.headers['x-request-id'] || req.headers['x-railway-request-id'] || '').trim() || randomUUID();
         const deniedToolName = findDeniedCloudMcpToolName(body, authScopes);
         if (deniedToolName) {
             core.addMcpAuditLog({
@@ -1394,7 +1451,7 @@ export function createRoutes(core, context = {}) {
                 tokenId: auth.authenticatedViaToken?.tokenId || auth.authenticatedViaOAuth?.grantId || null,
                 toolName: deniedToolName,
                 details: {
-                    requestId: String(req.headers['x-request-id'] || req.headers['x-railway-request-id'] || '').trim() || randomUUID(),
+                    requestId,
                     ip: req.socket?.remoteAddress || null,
                     userAgent: requestHeader(req, 'user-agent', '') || null,
                     outcome: 'deny',
@@ -1408,11 +1465,13 @@ export function createRoutes(core, context = {}) {
         if (!applyCloudMcpWriteRateLimit(req, res, auth, body)) {
             return;
         }
+        let runtime = null;
         try {
-            const runtime = createTaskforceMcpServer({
+            runtime = createTaskforceMcpServer({
                 projectRoot: core.getPaths().projectRoot,
                 tenantId: core.getTenantId(),
                 workspaceId: auth.workspaceId,
+                core: core,
                 serverName: 'taskforce-cloud',
                 logStartup: false,
                 runtimeMode: 'cloud',
@@ -1420,7 +1479,7 @@ export function createRoutes(core, context = {}) {
                     req,
                     auth,
                     requestHeader,
-                    requestId: String(req.headers['x-request-id'] || req.headers['x-railway-request-id'] || '').trim() || randomUUID(),
+                    requestId,
                     authScopes,
                 }),
             });
@@ -1435,13 +1494,29 @@ export function createRoutes(core, context = {}) {
             }
             await transport.handleRequest(req, res, body);
             recordCloudMcpCredentialUsage(req, auth.authenticatedViaToken, auth.authenticatedViaOAuth);
-            await transport.close().catch(() => undefined);
-            await runtime.server.close().catch(() => undefined);
         }
         catch (error) {
-            console.error('[Taskforce MCP] Cloud transport request failed:', error);
+            console.error('[Taskforce MCP] Cloud transport request failed:', {
+                requestId,
+                kind: 'tool_transport_failure',
+                message: error instanceof Error ? error.message : String(error),
+            });
             if (!res.headersSent) {
-                writeMcpHttpError(res, 500, 'Internal server error');
+                writeMcpHttpError(res, 500, 'MCP transport failure.', {
+                    kind: 'tool_transport_failure',
+                    retryable: true,
+                    requestId,
+                });
+            }
+        }
+        finally {
+            if (runtime) {
+                try {
+                    await runtime.server.close();
+                }
+                catch (closeError) {
+                    console.warn('[Taskforce MCP] Cloud transport cleanup failed:', closeError);
+                }
             }
         }
     };
@@ -1531,6 +1606,10 @@ export function createRoutes(core, context = {}) {
         resolveAdminRequestActor,
         resolveEffectiveObjectStorageConfig,
         getObjectStorageClient,
+        workspaceAssetStore,
+        ensureWithinDir,
+        markAssetDeleted,
+        appendStorageTelemetry,
     });
     registerWorkspaceRoutes({
         addRoute,