@taskforcehq/taskforce 0.3.304 → 0.3.305

package/dist/compat/workspaceSyncCompat.js

@@ -4,6 +4,10 @@ function normalizeTimestamp(value) {
     const normalized = String(value || '').trim();
     return normalized.length > 0 ? normalized : null;
 }
+function normalizeSetupIntent(value) {
+    const normalized = String(value || '').trim().toLowerCase();
+    return normalized === 'attach-cloud-import' ? 'attach-cloud-import' : null;
+}
 function resolveLegacyPhase(input, base) {
     const enabled = Boolean(input.enabled ?? input.cloudSyncEnabled);
     if (!enabled)
@@ -46,6 +50,7 @@ export function normalizeWorkspaceSyncStateCompat(rawState) {
         version: 2,
         enabled: Boolean(state.enabled ?? state.cloudSyncEnabled),
         phase: 'idle',
+        setupIntent: normalizeSetupIntent(state.setupIntent),
         pullCursor: normalizeTimestamp(state.pullCursor),
         lastPullAt: normalizeTimestamp(state.lastPullAt),
         lastPushAt: normalizeTimestamp(state.lastPushAt),
@@ -67,6 +72,7 @@ export function normalizeWorkspaceSyncStateCompat(rawState) {
     const changed = currentVersion !== 2
         || Boolean(state.enabled ?? state.cloudSyncEnabled) !== normalized.enabled
         || String(state.phase || '').trim() !== normalized.phase
+        || normalizeSetupIntent(state.setupIntent) !== normalized.setupIntent
         || normalizeTimestamp(state.pullCursor) !== normalized.pullCursor
         || normalizeTimestamp(state.lastPullAt) !== normalized.lastPullAt
         || normalizeTimestamp(state.lastPushAt) !== normalized.lastPushAt

package/dist/components/features/DocumentIndex.d.ts

@@ -1,4 +1,4 @@
-import { type DocMeta } from './DocumentWorkspace';
+import { type DocMeta } from './documentWorkspaceModel';
 interface Props {
     documents: DocMeta[];
     selectedDocId: string | null;

package/dist/components/features/DocumentIndex.js

@@ -2,7 +2,7 @@ import { jsx as _jsx, jsxs as _jsxs, Fragment as _Fragment } from "react/jsx-run
 import { Search, RefreshCw, FileText, ClipboardList, Eye, BookOpen, File } from 'lucide-react';
 import styles from '../../Taskforce.module.css';
 import indexStyles from './DocumentIndex.module.css';
-import { getEffectiveAttachmentState } from './DocumentWorkspace';
+import { getEffectiveAttachmentState } from './documentWorkspaceModel';
 import { getReadableDocumentName } from '../../utils/documentNames';
 function DocTypeIcon({ docType }) {
     switch (docType) {

package/dist/components/features/DocumentViewer.d.ts

@@ -1,4 +1,4 @@
-import { type DocMeta } from './DocumentWorkspace';
+import { type DocMeta } from './documentWorkspaceModel';
 export declare function buildPrintDocumentHtml(markdown: string): string;
 export declare function schedulePrintCleanup(cleanup: () => void): number;
 interface Props {

package/dist/components/features/DocumentViewer.js

@@ -8,7 +8,7 @@ import { Printer, Link, Download, Clock, HardDrive, Tag, Pencil, X, Save, Eye, S
 import styles from '../../Taskforce.module.css';
 import viewerStyles from './DocumentViewer.module.css';
 import taskFormStyles from '../task/TaskForm.module.css';
-import { getEffectiveAttachmentState } from './DocumentWorkspace';
+import { getEffectiveAttachmentState } from './documentWorkspaceModel';
 import { DocumentGenerateModal } from './DocumentGenerateModal';
 import { fetchTaskforceApi, resolveTaskforceApiUrl } from '../../utils/taskforceApiClient';
 import { getDocumentDownloadName, getReadableDocumentName } from '../../utils/documentNames';
@@ -522,6 +522,7 @@ export function DocumentViewer({ doc, taskTitle, apiBaseUrl = '', onSaved, onDel
     const [reviewTitleDraft, setReviewTitleDraft] = useState('');
     const [editingCommentId, setEditingCommentId] = useState(null);
     const [editingCommentDraft, setEditingCommentDraft] = useState('');
+    const [showReviewSidebar, setShowReviewSidebar] = useState(true);
     // Edit mode state
     const [editMode, setEditMode] = useState(false);
     const [draft, setDraft] = useState('');
@@ -534,7 +535,7 @@ export function DocumentViewer({ doc, taskTitle, apiBaseUrl = '', onSaved, onDel
     const [renameValue, setRenameValue] = useState(readableName);
     const isEditable = doc.editable !== false;
     const attachmentState = getEffectiveAttachmentState(doc);
-    const canDelete = attachmentState === 'unattached' && !!doc.assetId;
+    const canDelete = !!doc.assetId;
     const isDirty = editMode && draft !== (content ?? '');
     const textareaRef = useRef(null);
     const renameInputRef = useRef(null);
@@ -913,13 +914,20 @@ export function DocumentViewer({ doc, taskTitle, apiBaseUrl = '', onSaved, onDel
     const handleDelete = useCallback(async () => {
         if (!doc.assetId || deleting)
             return;
-        if (!window.confirm(`Permanently delete "${readableName}" from storage?`))
+        const isAttached = attachmentState === 'attached';
+        const linkedTaskCount = Math.max(0, Number(doc.attachmentCount || 0));
+        const confirmationMessage = isAttached
+            ? `Delete "${readableName}" everywhere?\n\nThis will remove it from ${linkedTaskCount} linked task${linkedTaskCount === 1 ? '' : 's'} and soft-delete the document across sync.`
+            : `Permanently delete "${readableName}" from storage?`;
+        if (!window.confirm(confirmationMessage))
             return;
         setDeleting(true);
         try {
             const res = await fetchTaskforceApi(`/api/taskforce/documents/${encodeURIComponent(doc.assetId)}`, {
                 method: 'DELETE',
                 credentials: 'include',
+                headers: { 'Content-Type': 'application/json' },
+                body: JSON.stringify(isAttached ? { forceDetach: true } : {}),
             }, apiBaseUrl);
             const data = await res.json().catch(() => ({}));
             if (!res.ok)
@@ -932,7 +940,7 @@ export function DocumentViewer({ doc, taskTitle, apiBaseUrl = '', onSaved, onDel
         finally {
             setDeleting(false);
         }
-    }, [apiBaseUrl, deleting, doc.assetId, onDeleted, readableName]);
+    }, [apiBaseUrl, attachmentState, deleting, doc.assetId, doc.attachmentCount, onDeleted, readableName]);
     const handleToggleReviewStatus = useCallback(async () => {
         if (!activeReviewSession || reviewBusy)
             return;
@@ -992,7 +1000,7 @@ export function DocumentViewer({ doc, taskTitle, apiBaseUrl = '', onSaved, onDel
     }, [activeReviewSession, apiBaseUrl, reviewBusy, reviewTitleDraft]);
     const previewContent = editMode ? draft : (content ?? '');
     const handleCaptureReviewAnchor = useCallback(() => {
-        if (editMode)
+        if (editMode || !showReviewSidebar)
             return;
         const selection = typeof window.getSelection === 'function' ? window.getSelection() : null;
         const selectedText = selection?.toString().replace(/\s+/g, ' ').trim() || '';
@@ -1011,7 +1019,16 @@ export function DocumentViewer({ doc, taskTitle, apiBaseUrl = '', onSaved, onDel
         if (!anchor)
             return;
         setPendingReviewAnchor(anchor);
-    }, [editMode]);
+    }, [editMode, showReviewSidebar]);
+    const handleToggleReviewSidebar = useCallback(() => {
+        setShowReviewSidebar((current) => {
+            const nextValue = !current;
+            if (!nextValue) {
+                setPendingReviewAnchor(null);
+            }
+            return nextValue;
+        });
+    }, []);
     const handleAddReviewComment = useCallback(async () => {
         const body = reviewDraft.trim();
         if (!body || reviewBusy)
@@ -1210,10 +1227,16 @@ export function DocumentViewer({ doc, taskTitle, apiBaseUrl = '', onSaved, onDel
                                         return;
                                     setRenameValue(readableName);
                                     setRenaming(true);
-                                }, children: readableName })), taskTitle && (_jsx("span", { className: viewerStyles.metaTaskName, title: `From task: ${taskTitle}`, children: taskTitle })), attachmentState === 'unattached' && (_jsx("span", { className: viewerStyles.statusBadge, children: "Unattached" })), doc.updatedAt && (_jsxs("span", { className: viewerStyles.metaDate, title: formatDate(doc.updatedAt), children: [_jsx(Clock, { size: 11 }), formatDate(doc.updatedAt)] })), _jsxs("span", { className: viewerStyles.metaSize, children: [_jsx(HardDrive, { size: 11 }), formatBytes(doc.sizeBytes)] }), documentReferenceLabel && (_jsx(ReferenceBadgeButton, { label: documentReferenceLabel, copied: copiedReference, onClick: () => { void handleCopyReference(); }, title: "Copy document reference" })), saveStatus.type === 'saved' && (_jsxs("span", { className: `${viewerStyles.saveStatus} ${viewerStyles.saveStatusSaved}`, children: [_jsx(CheckCircle, { size: 11 }), "Saved"] })), saveStatus.type === 'error' && (_jsxs("span", { className: `${viewerStyles.saveStatus} ${viewerStyles.saveStatusError}`, title: saveStatus.message, children: [_jsx(AlertCircle, { size: 11 }), saveStatus.message || 'Save failed'] })), isDirty && saveStatus.type !== 'saving' && (_jsx("span", { className: viewerStyles.unsaved, children: "Unsaved changes" }))] }), _jsx("div", { className: viewerStyles.actions, children: editMode ? (_jsxs(_Fragment, { children: [_jsxs("div", { className: viewerStyles.layoutToggle, children: [_jsx("button", { className: `${viewerStyles.layoutBtn} ${layout === 'editor' ? viewerStyles.layoutBtnActive : ''}`, onClick: () => setLayout('editor'), title: "Editor only", children: _jsx(Pencil, { size: 12 }) }), _jsx("button", { className: `${viewerStyles.layoutBtn} ${layout === 'split' ? viewerStyles.layoutBtnActive : ''}`, onClick: () => setLayout('split'), title: "Split view", children: _jsx(SplitSquareHorizontal, { size: 12 }) }), _jsx("button", { className: `${viewerStyles.layoutBtn} ${layout === 'preview' ? viewerStyles.layoutBtnActive : ''}`, onClick: () => setLayout('preview'), title: "Preview only", children: _jsx(Eye, { size: 12 }) })] }), _jsxs("button", { className: viewerStyles.actionBtn, onClick: handleCancelEdit, title: "Discard changes", children: [_jsx(X, { size: 13 }), "Cancel"] }), _jsxs("button", { className: `${viewerStyles.actionBtn} ${viewerStyles.saveBtn}`, onClick: handleSave, disabled: saveStatus.type === 'saving' || !isDirty, title: "Save (Ctrl+S)", children: [_jsx(Save, { size: 13 }), saveStatus.type === 'saving' ? 'Saving…' : 'Save'] })] })) : (_jsxs(_Fragment, { children: [doc.assetId && (_jsxs("button", { className: viewerStyles.actionBtn, onClick: () => setRenaming((prev) => !prev), title: "Rename document", children: [_jsx(Pencil, { size: 13 }), renaming ? 'Close Rename' : 'Rename'] })), isEditable && (_jsxs("button", { className: `${viewerStyles.actionBtn} ${viewerStyles.editBtn}`, onClick: handleEnterEdit, title: "Edit document", children: [_jsx(Pencil, { size: 13 }), "Edit"] })), _jsxs("button", { className: viewerStyles.actionBtn, onClick: handleCopyLink, title: "Copy link", children: [_jsx(Link, { size: 13 }), copied ? 'Copied!' : 'Copy link'] }), _jsxs("button", { className: viewerStyles.actionBtn, onClick: handleDownload, title: "Download .md", children: [_jsx(Download, { size: 13 }), "Download"] }), _jsxs("button", { className: viewerStyles.actionBtn, onClick: handlePrint, title: "Print", children: [_jsx(Printer, { size: 13 }), "Print"] }), _jsxs("button", { className: viewerStyles.actionBtn, onClick: () => setMonochromeMode((prev) => !prev), title: "Toggle black and white style", children: [_jsx(Eye, { size: 13 }), monochromeMode ? 'Color' : 'B/W'] }), enableTaskGeneration && doc.docType === 'implementation-plan' && !editMode && (_jsxs("button", { className: `${viewerStyles.actionBtn} ${viewerStyles.generateBtn}`, onClick: () => setShowGenModal(true), title: "Generate tasks from this plan", children: [_jsx(Zap, { size: 13 }), "Generate Tasks"] })), canDelete && (_jsxs("button", { className: `${viewerStyles.actionBtn} ${viewerStyles.dangerBtn}`, onClick: () => { void handleDelete(); }, disabled: deleting, title: "Permanently delete this unattached document", children: [_jsx(Trash2, { size: 13 }), deleting ? 'Deleting…' : 'Delete Permanently'] }))] })) })] }), loadingContent && (_jsx("div", { className: viewerStyles.viewerState, children: "Loading\u2026" })), !loadingContent && loadError && (_jsx("div", { className: viewerStyles.viewerStateError, children: loadError })), !loadingContent && !loadError && (editMode ? (_jsxs("div", { className: `${viewerStyles.editorArea} ${EDITOR_LAYOUT_CLASS[layout]}`, children: [(layout === 'editor' || layout === 'split') && (_jsxs("div", { className: viewerStyles.editorPane, children: [_jsx("div", { className: viewerStyles.editorPaneLabel, children: "Markdown" }), _jsx("textarea", { ref: textareaRef, className: `${viewerStyles.editorTextarea} tf-scrollbar`, value: draft, onScroll: () => syncPaneScroll('editor'), onChange: e => {
+                                }, children: readableName })), taskTitle && (_jsx("span", { className: viewerStyles.metaTaskName, title: `From task: ${taskTitle}`, children: taskTitle })), attachmentState === 'unattached' && (_jsx("span", { className: viewerStyles.statusBadge, children: "Unattached" })), doc.updatedAt && (_jsxs("span", { className: viewerStyles.metaDate, title: formatDate(doc.updatedAt), children: [_jsx(Clock, { size: 11 }), formatDate(doc.updatedAt)] })), _jsxs("span", { className: viewerStyles.metaSize, children: [_jsx(HardDrive, { size: 11 }), formatBytes(doc.sizeBytes)] }), documentReferenceLabel && (_jsx(ReferenceBadgeButton, { label: documentReferenceLabel, copied: copiedReference, onClick: () => { void handleCopyReference(); }, title: "Copy document reference" })), saveStatus.type === 'saved' && (_jsxs("span", { className: `${viewerStyles.saveStatus} ${viewerStyles.saveStatusSaved}`, children: [_jsx(CheckCircle, { size: 11 }), "Saved"] })), saveStatus.type === 'error' && (_jsxs("span", { className: `${viewerStyles.saveStatus} ${viewerStyles.saveStatusError}`, title: saveStatus.message, children: [_jsx(AlertCircle, { size: 11 }), saveStatus.message || 'Save failed'] })), isDirty && saveStatus.type !== 'saving' && (_jsx("span", { className: viewerStyles.unsaved, children: "Unsaved changes" }))] }), _jsx("div", { className: viewerStyles.actions, children: editMode ? (_jsxs(_Fragment, { children: [_jsxs("div", { className: viewerStyles.layoutToggle, children: [_jsx("button", { className: `${viewerStyles.layoutBtn} ${layout === 'editor' ? viewerStyles.layoutBtnActive : ''}`, onClick: () => setLayout('editor'), title: "Editor only", children: _jsx(Pencil, { size: 12 }) }), _jsx("button", { className: `${viewerStyles.layoutBtn} ${layout === 'split' ? viewerStyles.layoutBtnActive : ''}`, onClick: () => setLayout('split'), title: "Split view", children: _jsx(SplitSquareHorizontal, { size: 12 }) }), _jsx("button", { className: `${viewerStyles.layoutBtn} ${layout === 'preview' ? viewerStyles.layoutBtnActive : ''}`, onClick: () => setLayout('preview'), title: "Preview only", children: _jsx(Eye, { size: 12 }) })] }), _jsxs("button", { className: viewerStyles.actionBtn, onClick: handleCancelEdit, title: "Discard changes", children: [_jsx(X, { size: 13 }), "Cancel"] }), _jsxs("button", { className: `${viewerStyles.actionBtn} ${viewerStyles.saveBtn}`, onClick: handleSave, disabled: saveStatus.type === 'saving' || !isDirty, title: "Save (Ctrl+S)", children: [_jsx(Save, { size: 13 }), saveStatus.type === 'saving' ? 'Saving…' : 'Save'] })] })) : (_jsxs(_Fragment, { children: [doc.assetId && (_jsxs("button", { className: viewerStyles.actionBtn, onClick: () => setRenaming((prev) => !prev), title: "Rename document", children: [_jsx(Pencil, { size: 13 }), renaming ? 'Close Rename' : 'Rename'] })), isEditable && (_jsxs("button", { className: `${viewerStyles.actionBtn} ${viewerStyles.editBtn}`, onClick: handleEnterEdit, title: "Edit document", children: [_jsx(Pencil, { size: 13 }), "Edit"] })), _jsxs("button", { className: viewerStyles.actionBtn, onClick: handleToggleReviewSidebar, title: showReviewSidebar ? 'Hide review and comments' : 'Show review and comments', children: [_jsx(MessageSquareText, { size: 13 }), showReviewSidebar ? 'Hide Review' : 'Show Review'] }), _jsxs("button", { className: viewerStyles.actionBtn, onClick: handleCopyLink, title: "Copy link", children: [_jsx(Link, { size: 13 }), copied ? 'Copied!' : 'Copy link'] }), _jsxs("button", { className: viewerStyles.actionBtn, onClick: handleDownload, title: "Download .md", children: [_jsx(Download, { size: 13 }), "Download"] }), _jsxs("button", { className: viewerStyles.actionBtn, onClick: handlePrint, title: "Print", children: [_jsx(Printer, { size: 13 }), "Print"] }), _jsxs("button", { className: viewerStyles.actionBtn, onClick: () => setMonochromeMode((prev) => !prev), title: "Toggle black and white style", children: [_jsx(Eye, { size: 13 }), monochromeMode ? 'Color' : 'B/W'] }), enableTaskGeneration && doc.docType === 'implementation-plan' && !editMode && (_jsxs("button", { className: `${viewerStyles.actionBtn} ${viewerStyles.generateBtn}`, onClick: () => setShowGenModal(true), title: "Generate tasks from this plan", children: [_jsx(Zap, { size: 13 }), "Generate Tasks"] })), canDelete && (_jsxs("button", { className: `${viewerStyles.actionBtn} ${viewerStyles.dangerBtn}`, onClick: () => { void handleDelete(); }, disabled: deleting, title: attachmentState === 'attached'
+                                        ? 'Remove this document from linked tasks and delete it'
+                                        : 'Permanently delete this unattached document', children: [_jsx(Trash2, { size: 13 }), deleting
+                                            ? 'Deleting…'
+                                            : attachmentState === 'attached'
+                                                ? 'Delete & Unlink'
+                                                : 'Delete Permanently'] }))] })) })] }), loadingContent && (_jsx("div", { className: viewerStyles.viewerState, children: "Loading\u2026" })), !loadingContent && loadError && (_jsx("div", { className: viewerStyles.viewerStateError, children: loadError })), !loadingContent && !loadError && (editMode ? (_jsxs("div", { className: `${viewerStyles.editorArea} ${EDITOR_LAYOUT_CLASS[layout]}`, children: [(layout === 'editor' || layout === 'split') && (_jsxs("div", { className: viewerStyles.editorPane, children: [_jsx("div", { className: viewerStyles.editorPaneLabel, children: "Markdown" }), _jsx("textarea", { ref: textareaRef, className: `${viewerStyles.editorTextarea} tf-scrollbar`, value: draft, onScroll: () => syncPaneScroll('editor'), onChange: e => {
                                     setDraft(e.target.value);
                                     setSaveStatus(prev => prev.type === 'saving' ? prev : { type: 'idle' });
-                                }, spellCheck: true, placeholder: "Write markdown here\u2026" })] })), (layout === 'preview' || layout === 'split') && (_jsxs("div", { className: viewerStyles.previewPane, children: [_jsx("div", { className: viewerStyles.editorPaneLabel, children: "Preview" }), _jsx("div", { ref: previewScrollRef, className: `${styles.docMarkdown} ${viewerStyles.markdownSurface}`, "data-testid": "doc-preview-scroll", onScroll: () => syncPaneScroll('preview'), children: _jsx(Markdown, { remarkPlugins: [remarkGfm], rehypePlugins: [rehypeSanitize], components: markdownComponents, children: previewContent }) })] }))] })) : (_jsxs("div", { className: viewerStyles.viewerBody, children: [_jsx("div", { className: `${viewerStyles.viewerContent} ${viewerStyles.viewerMain} tf-scrollbar`, children: _jsx("div", { ref: markdownContainerRef, className: `${styles.docMarkdown} ${viewerStyles.markdownSurface}`, onMouseUp: handleCaptureReviewAnchor, children: _jsx(Markdown, { remarkPlugins: [remarkGfm], rehypePlugins: [rehypeSanitize], components: markdownComponents, children: previewContent }) }) }), _jsx("aside", { className: viewerStyles.reviewRail, children: _jsxs("section", { className: viewerStyles.reviewSection, "aria-label": "Review and comments", children: [_jsxs("div", { className: viewerStyles.reviewHeader, children: [_jsxs("div", { children: [_jsxs("div", { className: viewerStyles.reviewTitle, children: [_jsx(MessageSquareText, { size: 14 }), "Review & Comments"] }), _jsx("p", { className: viewerStyles.reviewSubtitle, children: "Comments stay attached to this document review session." })] }), _jsxs("div", { className: viewerStyles.reviewControls, children: [reviewSessions.length > 1 && (_jsx("select", { className: `${styles.select} ${viewerStyles.reviewSelect}`, value: activeReviewSession?.id || '', onChange: (event) => setSelectedReviewSessionId(event.target.value || null), "aria-label": "Select review session", children: reviewSessions.map((session) => (_jsx("option", { value: session.id, children: session.title?.trim() || 'Untitled review' }, session.id))) })), _jsxs("button", { type: "button", className: viewerStyles.actionBtn, onClick: () => { void createReviewSession(); }, disabled: reviewBusy || !doc.assetId, children: [_jsx(MessageSquareText, { size: 13 }), "Start Review"] }), activeReviewSession && (_jsxs("button", { type: "button", className: viewerStyles.actionBtn, onClick: () => { void handleToggleReviewStatus(); }, disabled: reviewBusy, children: [activeReviewSession.status === 'resolved' ? _jsx(RotateCcw, { size: 13 }) : _jsx(CheckCheck, { size: 13 }), activeReviewSession.status === 'resolved' ? 'Reopen' : 'Resolve'] }))] })] }), activeReviewSession && (_jsxs("div", { className: viewerStyles.reviewSessionMeta, children: [_jsx("span", { className: `${viewerStyles.statusBadge} ${activeReviewSession.status === 'resolved' ? viewerStyles.reviewStatusResolved : ''}`, children: activeReviewSession.status === 'resolved' ? 'Resolved' : 'Open' }), editingReviewTitle ? (_jsxs("div", { className: viewerStyles.reviewTitleEditRow, children: [_jsx("input", { type: "text", className: styles.input, value: reviewTitleDraft, onChange: (event) => setReviewTitleDraft(event.target.value), placeholder: "Untitled review" }), _jsx("button", { type: "button", className: styles.secondaryHeaderBtn, onClick: () => { void handleSaveReviewTitle(); }, disabled: reviewBusy, children: "Save Title" })] })) : (_jsx("span", { className: viewerStyles.reviewSessionLabel, children: activeReviewSession.title?.trim() || 'Untitled review' })), _jsxs("span", { className: viewerStyles.reviewSessionTimestamp, children: ["Updated ", formatReviewTimestamp(activeReviewSession.updatedAt)] }), !editingReviewTitle && (_jsxs("button", { type: "button", className: viewerStyles.actionBtn, onClick: () => setEditingReviewTitle(true), disabled: reviewBusy, children: [_jsx(Pencil, { size: 13 }), "Rename Review"] }))] })), reviewError && (_jsx("div", { className: viewerStyles.viewerStateError, children: reviewError })), _jsxs("div", { className: taskFormStyles.commentPanel, children: [_jsxs("div", { className: taskFormStyles.commentThread, children: [loadingReviews && (_jsx("div", { className: taskFormStyles.emptyComments, children: "Loading review comments\u2026" })), !loadingReviews && !activeReviewSession && (_jsx("div", { className: taskFormStyles.emptyComments, children: "Start a review to collect comments for this document." })), !loadingReviews && activeReviewSession && activeReviewSession.comments.length === 0 && (_jsx("div", { className: taskFormStyles.emptyComments, children: "No comments yet. Add the first review note for this document." })), !loadingReviews && activeReviewSession && activeReviewSession.comments.map((comment) => {
+                                }, spellCheck: true, placeholder: "Write markdown here\u2026" })] })), (layout === 'preview' || layout === 'split') && (_jsxs("div", { className: viewerStyles.previewPane, children: [_jsx("div", { className: viewerStyles.editorPaneLabel, children: "Preview" }), _jsx("div", { ref: previewScrollRef, className: `${styles.docMarkdown} ${viewerStyles.markdownSurface}`, "data-testid": "doc-preview-scroll", onScroll: () => syncPaneScroll('preview'), children: _jsx(Markdown, { remarkPlugins: [remarkGfm], rehypePlugins: [rehypeSanitize], components: markdownComponents, children: previewContent }) })] }))] })) : (_jsxs("div", { className: `${viewerStyles.viewerBody} ${!showReviewSidebar ? viewerStyles.viewerBodyFullWidth : ''}`, children: [_jsx("div", { className: `${viewerStyles.viewerContent} ${viewerStyles.viewerMain} tf-scrollbar`, children: _jsx("div", { ref: markdownContainerRef, className: `${styles.docMarkdown} ${viewerStyles.markdownSurface}`, onMouseUp: showReviewSidebar ? handleCaptureReviewAnchor : undefined, children: _jsx(Markdown, { remarkPlugins: [remarkGfm], rehypePlugins: [rehypeSanitize], components: markdownComponents, children: previewContent }) }) }), showReviewSidebar && (_jsx("aside", { className: viewerStyles.reviewRail, children: _jsxs("section", { className: viewerStyles.reviewSection, "aria-label": "Review and comments", children: [_jsxs("div", { className: viewerStyles.reviewHeader, children: [_jsxs("div", { children: [_jsxs("div", { className: viewerStyles.reviewTitle, children: [_jsx(MessageSquareText, { size: 14 }), "Review & Comments"] }), _jsx("p", { className: viewerStyles.reviewSubtitle, children: "Comments stay attached to this document review session." })] }), _jsxs("div", { className: viewerStyles.reviewControls, children: [reviewSessions.length > 1 && (_jsx("select", { className: `${styles.select} ${viewerStyles.reviewSelect}`, value: activeReviewSession?.id || '', onChange: (event) => setSelectedReviewSessionId(event.target.value || null), "aria-label": "Select review session", children: reviewSessions.map((session) => (_jsx("option", { value: session.id, children: session.title?.trim() || 'Untitled review' }, session.id))) })), _jsxs("button", { type: "button", className: viewerStyles.actionBtn, onClick: () => { void createReviewSession(); }, disabled: reviewBusy || !doc.assetId, children: [_jsx(MessageSquareText, { size: 13 }), "Start Review"] }), activeReviewSession && (_jsxs("button", { type: "button", className: viewerStyles.actionBtn, onClick: () => { void handleToggleReviewStatus(); }, disabled: reviewBusy, children: [activeReviewSession.status === 'resolved' ? _jsx(RotateCcw, { size: 13 }) : _jsx(CheckCheck, { size: 13 }), activeReviewSession.status === 'resolved' ? 'Reopen' : 'Resolve'] }))] })] }), activeReviewSession && (_jsxs("div", { className: viewerStyles.reviewSessionMeta, children: [_jsx("span", { className: `${viewerStyles.statusBadge} ${activeReviewSession.status === 'resolved' ? viewerStyles.reviewStatusResolved : ''}`, children: activeReviewSession.status === 'resolved' ? 'Resolved' : 'Open' }), editingReviewTitle ? (_jsxs("div", { className: viewerStyles.reviewTitleEditRow, children: [_jsx("input", { type: "text", className: styles.input, value: reviewTitleDraft, onChange: (event) => setReviewTitleDraft(event.target.value), placeholder: "Untitled review" }), _jsx("button", { type: "button", className: styles.secondaryHeaderBtn, onClick: () => { void handleSaveReviewTitle(); }, disabled: reviewBusy, children: "Save Title" })] })) : (_jsx("span", { className: viewerStyles.reviewSessionLabel, children: activeReviewSession.title?.trim() || 'Untitled review' })), _jsxs("span", { className: viewerStyles.reviewSessionTimestamp, children: ["Updated ", formatReviewTimestamp(activeReviewSession.updatedAt)] }), !editingReviewTitle && (_jsxs("button", { type: "button", className: viewerStyles.actionBtn, onClick: () => setEditingReviewTitle(true), disabled: reviewBusy, children: [_jsx(Pencil, { size: 13 }), "Rename Review"] }))] })), reviewError && (_jsx("div", { className: viewerStyles.viewerStateError, children: reviewError })), _jsxs("div", { className: taskFormStyles.commentPanel, children: [_jsxs("div", { className: taskFormStyles.commentThread, children: [loadingReviews && (_jsx("div", { className: taskFormStyles.emptyComments, children: "Loading review comments\u2026" })), !loadingReviews && !activeReviewSession && (_jsx("div", { className: taskFormStyles.emptyComments, children: "Start a review to collect comments for this document." })), !loadingReviews && activeReviewSession && activeReviewSession.comments.length === 0 && (_jsx("div", { className: taskFormStyles.emptyComments, children: "No comments yet. Add the first review note for this document." })), !loadingReviews && activeReviewSession && activeReviewSession.comments.map((comment) => {
                                                     const isAi = comment.authorActor?.kind === 'ai';
                                                     const anchorLabel = formatReviewAnchor(comment.anchor);
                                                     const ActorIcon = isAi ? Bot : User;
@@ -1231,5 +1254,5 @@ export function DocumentViewer({ doc, taskTitle, apiBaseUrl = '', onSaved, onDel
                                                                     event.preventDefault();
                                                                     void handleAddReviewComment();
                                                                 }
-                                                            } })] }), _jsx("button", { type: "button", className: taskFormStyles.sendCommentBtn, onClick: () => { void handleAddReviewComment(); }, disabled: reviewBusy || !reviewDraft.trim() || activeReviewSession?.status === 'resolved', "aria-label": "Send review comment", title: "Send review comment", children: _jsx(Send, { size: 15 }) })] })] })] }) })] }))), enableTaskGeneration && showGenModal && content !== null && (_jsx(DocumentGenerateModal, { content: content, docTitle: doc.title, apiBaseUrl: apiBaseUrl, onClose: () => setShowGenModal(false), onGenerated: (_count) => setShowGenModal(false) })), !editMode && (_jsx("div", { className: viewerStyles.printHint, children: "For the cleanest output, disable browser Headers and footers in the print dialog." }))] }));
+                                                            } })] }), _jsx("button", { type: "button", className: taskFormStyles.sendCommentBtn, onClick: () => { void handleAddReviewComment(); }, disabled: reviewBusy || !reviewDraft.trim() || activeReviewSession?.status === 'resolved', "aria-label": "Send review comment", title: "Send review comment", children: _jsx(Send, { size: 15 }) })] })] })] }) }))] }))), enableTaskGeneration && showGenModal && content !== null && (_jsx(DocumentGenerateModal, { content: content, docTitle: doc.title, apiBaseUrl: apiBaseUrl, onClose: () => setShowGenModal(false), onGenerated: (_count) => setShowGenModal(false) })), !editMode && (_jsx("div", { className: viewerStyles.printHint, children: "For the cleanest output, disable browser Headers and footers in the print dialog." }))] }));
 }

package/dist/components/features/DocumentWorkspace.d.ts

@@ -1,24 +1,8 @@
 import { type DocumentAttachmentFilter, type DocumentTypeFilter } from './documentWorkspaceFilters';
-export interface DocMeta {
-    id: string;
-    assetId?: string;
-    referenceNumber?: number | null;
-    referenceLabel?: string | null;
-    fsPath: string;
-    apiUrl: string;
-    taskId: string | null;
-    displayName: string;
-    originalFilename?: string | null;
-    title: string;
-    docType: 'implementation-plan' | 'review' | 'walkthrough' | 'planning' | 'other';
-    sizeBytes: number;
-    updatedAt: string | null;
-    editable?: boolean;
-    attachmentCount?: number;
-    attachmentState?: 'attached' | 'unattached' | 'standalone';
-}
+import type { DocMeta } from './documentWorkspaceModel';
 export type { DocumentAttachmentFilter, DocumentTypeFilter } from './documentWorkspaceFilters';
 export { DOCUMENT_TYPE_FILTER_OPTIONS, DOCUMENT_ATTACHMENT_FILTER_OPTIONS } from './documentWorkspaceFilters';
+export type { DocMeta } from './documentWorkspaceModel';
 interface Props {
     tasks: Array<{
         id: string;
@@ -30,11 +14,11 @@ interface Props {
     error: string | null;
     selectedDoc: DocMeta | null;
     searchQuery: string;
-    typeFilters: DocumentTypeFilter[];
-    attachmentFilters: DocumentAttachmentFilter[];
+    hasActiveFilters: boolean;
     onSearchChange: (value: string) => void;
     onSelectDoc: (doc: DocMeta | null) => void;
     onRefresh: () => Promise<void> | void;
+    onDeleteSelected: () => Promise<void> | void;
     enableTaskGeneration?: boolean;
 }
 interface ShellProps {
@@ -54,6 +38,5 @@ interface ShellProps {
     onRequestedDocHandled?: () => void;
     enableTaskGeneration?: boolean;
 }
-export declare function getEffectiveAttachmentState(doc: Pick<DocMeta, 'attachmentState' | 'attachmentCount' | 'taskId'>): 'attached' | 'unattached';
-export declare function DocumentWorkspace({ tasks, apiBaseUrl, documents, loading, error, selectedDoc, searchQuery, typeFilters, attachmentFilters, onSearchChange, onSelectDoc, onRefresh, enableTaskGeneration }: Props): import("react/jsx-runtime").JSX.Element;
+export declare function DocumentWorkspace({ tasks, apiBaseUrl, documents, loading, error, selectedDoc, searchQuery, hasActiveFilters, onSearchChange, onSelectDoc, onRefresh, onDeleteSelected, enableTaskGeneration }: Props): import("react/jsx-runtime").JSX.Element;
 export declare function DocumentWorkspaceShell({ tasks, runtimeMode, apiBaseUrl, cloudAuthBaseUrl, typeFilters: controlledTypeFilters, attachmentFilters: controlledAttachmentFilters, onTypeFiltersChange, onAttachmentFiltersChange, requestedDocPath, requestedDocAssetId, onRequestedDocHandled, enableTaskGeneration }: ShellProps): import("react/jsx-runtime").JSX.Element;

package/dist/components/features/DocumentWorkspace.js

@@ -1,168 +1,25 @@
 import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
-import { useState, useEffect, useCallback } from 'react';
 import styles from '../../Taskforce.module.css';
 import { DocumentIndex } from './DocumentIndex';
 import { DocumentViewer } from './DocumentViewer';
-import { fetchTaskforceApi } from '../../utils/taskforceApiClient';
-import { logDocumentManagerDebug, resolveDocumentManagerApiBase } from '../../utils/documentManagerApi';
-import { getReadableDocumentName } from '../../utils/documentNames';
-import { DOCUMENT_ATTACHMENT_FILTER_OPTIONS, DOCUMENT_TYPE_FILTER_OPTIONS, } from './documentWorkspaceFilters';
+import { useDocumentWorkspaceController } from './useDocumentWorkspaceController';
 export { DOCUMENT_TYPE_FILTER_OPTIONS, DOCUMENT_ATTACHMENT_FILTER_OPTIONS } from './documentWorkspaceFilters';
-function normalizeDocPath(value) {
-    let decoded = value;
-    try {
-        decoded = decodeURIComponent(value);
-    }
-    catch {
-        decoded = value;
-    }
-    const normalized = decoded
-        .trim()
-        .replace(/\\/g, '/')
-        .replace(/^\/+/, '')
-        .replace(/^\.\//, '')
-        .replace(/^\.taskforce\//, '');
-    return normalized;
-}
-function docPathMatches(candidate, requested) {
-    if (candidate === requested)
-        return true;
-    if (candidate.endsWith(`/${requested}`))
-        return true;
-    if (requested.endsWith(`/${candidate}`))
-        return true;
-    return false;
-}
-function extractAssetIdFromPath(value) {
-    const normalized = normalizeDocPath(String(value || ''));
-    if (!normalized)
-        return null;
-    const match = normalized.match(/(^|\/)(asset-[a-f0-9]{32})(?=[^/]*$)/i);
-    return match?.[2] ? match[2].toLowerCase() : null;
-}
-export function getEffectiveAttachmentState(doc) {
-    if (doc.attachmentState === 'attached' || doc.attachmentState === 'unattached') {
-        return doc.attachmentState;
-    }
-    const attachmentCount = typeof doc.attachmentCount === 'number' && Number.isFinite(doc.attachmentCount)
-        ? doc.attachmentCount
-        : 0;
-    if (attachmentCount > 0 || !!doc.taskId) {
-        return 'attached';
-    }
-    return 'unattached';
-}
-export function DocumentWorkspace({ tasks, apiBaseUrl = '', documents, loading, error, selectedDoc, searchQuery, typeFilters, attachmentFilters, onSearchChange, onSelectDoc, onRefresh, enableTaskGeneration = false }) {
-    const filteredDocs = documents.filter(doc => {
-        const readableName = getReadableDocumentName(doc);
-        const haystack = `${readableName} ${doc.originalFilename || ''}`.toLowerCase();
-        const matchesSearch = !searchQuery || haystack.includes(searchQuery.toLowerCase());
-        const matchesType = typeFilters.length === 0 || typeFilters.includes(doc.docType);
-        const attachmentState = getEffectiveAttachmentState(doc);
-        const matchesAttachment = attachmentFilters.length === 0 || attachmentFilters.includes(attachmentState);
-        return matchesSearch && matchesType && matchesAttachment;
-    });
-    const hasActiveFilters = searchQuery.trim().length > 0 || typeFilters.length > 0 || attachmentFilters.length > 0;
+export function DocumentWorkspace({ tasks, apiBaseUrl = '', documents, loading, error, selectedDoc, searchQuery, hasActiveFilters, onSearchChange, onSelectDoc, onRefresh, onDeleteSelected, enableTaskGeneration = false }) {
     const taskById = new Map(tasks.map(t => [t.id, t]));
-    return (_jsxs("div", { className: styles.docWorkspace, children: [_jsx("div", { className: styles.docIndexPanel, children: _jsx(DocumentIndex, { documents: filteredDocs, selectedDocId: selectedDoc?.id ?? null, loading: loading, error: error, searchQuery: searchQuery, onSearchChange: onSearchChange, onSelect: (doc) => onSelectDoc(doc), onRefresh: onRefresh, taskById: taskById, hasActiveFilters: hasActiveFilters }) }), _jsx("div", { className: styles.docViewerPanel, children: selectedDoc ? (_jsx(DocumentViewer, { doc: selectedDoc, taskTitle: selectedDoc.taskId ? (taskById.get(selectedDoc.taskId)?.title ?? null) : null, apiBaseUrl: apiBaseUrl, onSaved: (_updatedAt) => onRefresh(), onDeleted: () => {
-                        onSelectDoc(null);
-                        void onRefresh();
-                    }, enableTaskGeneration: enableTaskGeneration })) : !loading && (_jsx("div", { className: styles.docViewerEmpty, children: _jsx("p", { className: "tf-empty-copy", children: filteredDocs.length === 0 ? 'No documents match your current filters.' : 'Select a document to view it.' }) })) })] }));
+    return (_jsxs("div", { className: styles.docWorkspace, children: [_jsx("div", { className: styles.docIndexPanel, children: _jsx(DocumentIndex, { documents: documents, selectedDocId: selectedDoc?.id ?? null, loading: loading, error: error, searchQuery: searchQuery, onSearchChange: onSearchChange, onSelect: (doc) => onSelectDoc(doc), onRefresh: onRefresh, taskById: taskById, hasActiveFilters: hasActiveFilters }) }), _jsx("div", { className: styles.docViewerPanel, children: selectedDoc ? (_jsx(DocumentViewer, { doc: selectedDoc, taskTitle: selectedDoc.taskId ? (taskById.get(selectedDoc.taskId)?.title ?? null) : null, apiBaseUrl: apiBaseUrl, onSaved: (_updatedAt) => onRefresh(), onDeleted: () => void onDeleteSelected(), enableTaskGeneration: enableTaskGeneration })) : !loading && (_jsx("div", { className: styles.docViewerEmpty, children: _jsx("p", { className: "tf-empty-copy", children: documents.length === 0 ? 'No documents match your current filters.' : 'Select a document to view it.' }) })) })] }));
 }
 export function DocumentWorkspaceShell({ tasks, runtimeMode = 'local', apiBaseUrl = '', cloudAuthBaseUrl = '', typeFilters: controlledTypeFilters, attachmentFilters: controlledAttachmentFilters, onTypeFiltersChange, onAttachmentFiltersChange, requestedDocPath = null, requestedDocAssetId = null, onRequestedDocHandled, enableTaskGeneration = false }) {
-    const [documents, setDocuments] = useState([]);
-    const [loading, setLoading] = useState(true);
-    const [error, setError] = useState(null);
-    const [selectedDoc, setSelectedDoc] = useState(null);
-    const [searchQuery, setSearchQuery] = useState('');
-    const [internalTypeFilters, setInternalTypeFilters] = useState(() => DOCUMENT_TYPE_FILTER_OPTIONS.map((option) => option.value));
-    const [internalAttachmentFilters, setInternalAttachmentFilters] = useState(() => DOCUMENT_ATTACHMENT_FILTER_OPTIONS.map((option) => option.value));
-    const documentApiBaseUrl = resolveDocumentManagerApiBase({
+    const { documentApiBaseUrl, filteredDocs, loading, error, selectedDoc, searchQuery, hasActiveFilters, setSearchQuery, fetchDocuments, selectDoc, handleDeleteSelected, } = useDocumentWorkspaceController({
         runtimeMode,
         apiBaseUrl,
         cloudAuthBaseUrl,
+        typeFilters: controlledTypeFilters,
+        attachmentFilters: controlledAttachmentFilters,
+        onTypeFiltersChange,
+        onAttachmentFiltersChange,
+        requestedDocPath,
+        requestedDocAssetId,
+        onRequestedDocHandled,
     });
-    const typeFilters = controlledTypeFilters ?? internalTypeFilters;
-    const attachmentFilters = controlledAttachmentFilters ?? internalAttachmentFilters;
-    const handleTypeFiltersChange = onTypeFiltersChange ?? setInternalTypeFilters;
-    const handleAttachmentFiltersChange = onAttachmentFiltersChange ?? setInternalAttachmentFilters;
-    const fetchDocuments = useCallback(async () => {
-        setLoading(true);
-        setError(null);
-        try {
-            const res = await fetchTaskforceApi('/api/taskforce/documents', {
-                credentials: 'include',
-            }, documentApiBaseUrl);
-            if (!res.ok)
-                throw new Error(`Failed to load documents (${res.status})`);
-            const data = await res.json();
-            const nextDocuments = data.documents || [];
-            logDocumentManagerDebug('list.loaded', {
-                runtimeMode,
-                apiBaseUrl: documentApiBaseUrl || '(same-origin)',
-                count: Array.isArray(nextDocuments) ? nextDocuments.length : 0,
-            });
-            setDocuments(nextDocuments);
-        }
-        catch (e) {
-            setError(e?.message || 'Failed to load documents');
-            logDocumentManagerDebug('list.error', {
-                runtimeMode,
-                apiBaseUrl: documentApiBaseUrl || '(same-origin)',
-                message: e?.message || 'Failed to load documents',
-            });
-        }
-        finally {
-            setLoading(false);
-        }
-    }, [documentApiBaseUrl, runtimeMode]);
-    useEffect(() => {
-        fetchDocuments();
-    }, [fetchDocuments]);
-    // Auto-select first doc when list loads
-    useEffect(() => {
-        if (requestedDocPath || requestedDocAssetId)
-            return;
-        if (!selectedDoc && documents.length > 0) {
-            setSelectedDoc(documents[0]);
-        }
-    }, [documents, selectedDoc, requestedDocAssetId, requestedDocPath]);
-    useEffect(() => {
-        if ((!requestedDocPath && !requestedDocAssetId) || documents.length === 0)
-            return;
-        const requested = requestedDocPath ? normalizeDocPath(requestedDocPath) : '';
-        const requestedAssetId = String(requestedDocAssetId || '').trim().toLowerCase()
-            || extractAssetIdFromPath(requestedDocPath);
-        const matched = documents.find((doc) => {
-            const candidateAssetId = extractAssetIdFromPath(doc.fsPath) || String(doc.assetId || '').trim().toLowerCase() || null;
-            if (requestedAssetId && candidateAssetId && candidateAssetId === requestedAssetId)
-                return true;
-            if (!requested)
-                return false;
-            const candidate = normalizeDocPath(doc.fsPath);
-            return docPathMatches(candidate, requested);
-        });
-        if (matched) {
-            setSelectedDoc(matched);
-            onRequestedDocHandled?.();
-            return;
-        }
-    }, [requestedDocAssetId, requestedDocPath, documents, onRequestedDocHandled]);
-    useEffect(() => {
-        if ((requestedDocPath || requestedDocAssetId) && !selectedDoc)
-            return;
-        const filtered = documents.filter((doc) => {
-            const readableName = getReadableDocumentName(doc);
-            const haystack = `${readableName} ${doc.originalFilename || ''}`.toLowerCase();
-            const matchesSearch = !searchQuery || haystack.includes(searchQuery.toLowerCase());
-            const matchesType = typeFilters.length === 0 || typeFilters.includes(doc.docType);
-            const attachmentState = getEffectiveAttachmentState(doc);
-            const matchesAttachment = attachmentFilters.length === 0 || attachmentFilters.includes(attachmentState);
-            return matchesSearch && matchesType && matchesAttachment;
-        });
-        if (selectedDoc && filtered.some((doc) => doc.id === selectedDoc.id))
-            return;
-        setSelectedDoc(filtered[0] ?? null);
-    }, [attachmentFilters, documents, requestedDocAssetId, requestedDocPath, searchQuery, selectedDoc, typeFilters]);
-    return (_jsx(DocumentWorkspace, { tasks: tasks, apiBaseUrl: documentApiBaseUrl, documents: documents, loading: loading, error: error, selectedDoc: selectedDoc, searchQuery: searchQuery, typeFilters: typeFilters, attachmentFilters: attachmentFilters, onSearchChange: setSearchQuery, onSelectDoc: setSelectedDoc, onRefresh: fetchDocuments, enableTaskGeneration: enableTaskGeneration }));
+    return (_jsx(DocumentWorkspace, { tasks: tasks, apiBaseUrl: documentApiBaseUrl, documents: filteredDocs, loading: loading, error: error, selectedDoc: selectedDoc, searchQuery: searchQuery, hasActiveFilters: hasActiveFilters, onSearchChange: setSearchQuery, onSelectDoc: selectDoc, onRefresh: fetchDocuments, onDeleteSelected: handleDeleteSelected, enableTaskGeneration: enableTaskGeneration }));
 }