@taskforcehq/taskforce 0.3.303 → 0.3.305

package/dist/core/SignupMonetizationSettings.test.js

@@ -22,18 +22,23 @@ function openCore(projectRoot) {
         storagePath: path.join(projectRoot, '.taskforce'),
         tenantId: path.basename(projectRoot)
     });
-    core.upsertPlanCatalog({ planId: 'starter', displayName: 'Starter' });
+    core.upsertPlanCatalog({ planId: 'free', displayName: 'Free', status: 'active' });
+    core.updatePlanVersion({
+        planId: 'free',
+        versionNumber: 1,
+        seatLimit: 1
+    });
     core.updatePlanVersionFeatures({
-        planVersionId: 'starter-v1',
+        planVersionId: 'free-v1',
         features: [
             { featureKey: 'workspace.switching', access: 'enabled' }
         ]
     });
-    insertFreePriceMapping(core, 'starter-v1');
+    insertFreePriceMapping(core, 'free-v1');
     return core;
 }
 describe('TaskforceCore onboarding policy', () => {
-    it('defaults to require_plan_selection with no plan version', () => {
+    it('fails closed to require_plan_selection when no explicit onboarding policy is configured', () => {
         const projectRoot = makeProjectRoot();
         const core = openCore(projectRoot);
         try {
@@ -47,6 +52,36 @@ describe('TaskforceCore onboarding policy', () => {
             fs.rmSync(projectRoot, { recursive: true, force: true });
         }
     });
+    it('falls back to require_plan_selection when no free onboarding plan is available', () => {
+        const projectRoot = makeProjectRoot();
+        const core = new TaskforceCore({
+            projectRoot,
+            storagePath: path.join(projectRoot, '.taskforce'),
+            tenantId: path.basename(projectRoot)
+        });
+        core.upsertPlanCatalog({ planId: 'free', displayName: 'Free', status: 'active' });
+        core.updatePlanVersion({
+            planId: 'free',
+            versionNumber: 1,
+            seatLimit: 1
+        });
+        core.updatePlanVersionFeatures({
+            planVersionId: 'free-v1',
+            features: [
+                { featureKey: 'workspace.switching', access: 'enabled' }
+            ]
+        });
+        try {
+            expect(core.getOnboardingPolicy()).toEqual({
+                mode: 'require_plan_selection',
+                planVersionId: null
+            });
+        }
+        finally {
+            core.close();
+            fs.rmSync(projectRoot, { recursive: true, force: true });
+        }
+    });
     it('fails validation for auto_grant_free without a plan version id', () => {
         const projectRoot = makeProjectRoot();
         const core = openCore(projectRoot);
@@ -85,10 +120,10 @@ describe('TaskforceCore onboarding policy', () => {
         const projectRoot = makeProjectRoot();
         const core = openCore(projectRoot);
         try {
-            core.upsertPlanCatalog({ planId: 'starter', displayName: 'Starter', status: 'archived' });
+            core.upsertPlanCatalog({ planId: 'free', displayName: 'Free', status: 'archived' });
             expect(core.validateOnboardingPolicy({
                 mode: 'auto_grant_free',
-                planVersionId: 'starter-v1'
+                planVersionId: 'free-v1'
             })).toEqual(expect.objectContaining({
                 valid: false,
                 code: 'ONBOARDING_PLAN_NOT_ENABLED'
@@ -103,10 +138,10 @@ describe('TaskforceCore onboarding policy', () => {
         const projectRoot = makeProjectRoot();
         const core = openCore(projectRoot);
         try {
-            core.upsertPlanCatalog({ planId: 'collab', displayName: 'Collab', status: 'active' });
+            core.upsertPlanCatalog({ planId: 'team-5', displayName: 'Team 5', status: 'active' });
             expect(core.validateOnboardingPolicy({
                 mode: 'auto_grant_free',
-                planVersionId: 'collab-v1'
+                planVersionId: 'team-5-v1'
             })).toEqual(expect.objectContaining({
                 valid: false,
                 code: 'ONBOARDING_PLAN_MUST_BE_FREE'
@@ -131,6 +166,31 @@ describe('TaskforceCore onboarding policy', () => {
             fs.rmSync(projectRoot, { recursive: true, force: true });
         }
     });
+    it('requires plan selection during registration when no explicit onboarding policy is configured', () => {
+        const projectRoot = makeProjectRoot();
+        const core = openCore(projectRoot);
+        try {
+            const created = core.registerPasswordUser({
+                email: 'implicit-onboarding@example.com',
+                password: 'password123'
+            });
+            expect(created.planSelectionRequired).toBe(true);
+            expect(created.checkoutPending).toBe(false);
+            expect(core.getAccountEntitlement(created.userId)).toEqual(expect.objectContaining({
+                state: 'pending_plan_selection'
+            }));
+            expect(core.getAccountAccessStatus(created.userId)).toEqual(expect.objectContaining({
+                gate: 'plan_selection_required',
+                canAccessApp: false,
+                canAccessPlans: true,
+                planSelectionRequired: true
+            }));
+        }
+        finally {
+            core.close();
+            fs.rmSync(projectRoot, { recursive: true, force: true });
+        }
+    });
     it('allows backfill transitions to create pending plan selection entitlements', () => {
         const projectRoot = makeProjectRoot();
         const tenantId = path.basename(projectRoot);
@@ -156,7 +216,7 @@ describe('TaskforceCore onboarding policy', () => {
             `).run('pending-u1', tenantId, 'pending_plan_selection', now, now);
             core.transitionCanonicalCommercialState({
                 accountId: 'pending-u1',
-                planVersionId: 'starter-v1',
+                planVersionId: 'free-v1',
                 state: 'pending_plan_selection',
                 source: 'backfill',
                 updatedBy: 'backfill',
@@ -185,7 +245,7 @@ describe('TaskforceCore onboarding policy', () => {
         try {
             const now = new Date().toISOString();
             const checkoutExpiresAt = new Date(Date.now() + (60 * 60 * 1000)).toISOString();
-            core.upsertPlanCatalog({ planId: 'pro', displayName: 'Pro', status: 'active' });
+            core.upsertPlanCatalog({ planId: 'basic', displayName: 'Basic', status: 'active' });
             const db = core.getDatabaseAdapter();
             db.prepare(`
                 INSERT INTO users (id, tenant_id, email, display_name, auth_provider, external_auth_id, is_disabled, created_at, updated_at)
@@ -193,11 +253,11 @@ describe('TaskforceCore onboarding policy', () => {
             `).run('checkout-u1', tenantId, 'checkout@example.com', 'Checkout', 'token', 'checkout-u1', now, now);
             core.transitionCanonicalCommercialState({
                 accountId: 'checkout-u1',
-                planVersionId: 'pro-v1',
+                planVersionId: 'basic-v1',
                 state: 'checkout_pending',
                 source: 'checkout-start',
                 updatedBy: 'checkout-start',
-                billingMirrorPlanId: 'pro',
+                billingMirrorPlanId: 'basic',
                 effectiveAt: now,
                 effectiveUntil: checkoutExpiresAt,
                 createdAt: now,
@@ -223,7 +283,7 @@ describe('TaskforceCore onboarding policy', () => {
         try {
             const now = new Date().toISOString();
             const expiredAt = new Date(Date.now() - (60 * 1000)).toISOString();
-            core.upsertPlanCatalog({ planId: 'pro', displayName: 'Pro', status: 'active' });
+            core.upsertPlanCatalog({ planId: 'basic', displayName: 'Basic', status: 'active' });
             const db = core.getDatabaseAdapter();
             db.prepare(`
                 INSERT INTO users (id, tenant_id, email, display_name, auth_provider, external_auth_id, is_disabled, created_at, updated_at)
@@ -231,11 +291,11 @@ describe('TaskforceCore onboarding policy', () => {
             `).run('expired-checkout-u1', tenantId, 'expired@example.com', 'Expired Checkout', 'token', 'expired-checkout-u1', now, now);
             core.transitionCanonicalCommercialState({
                 accountId: 'expired-checkout-u1',
-                planVersionId: 'pro-v1',
+                planVersionId: 'basic-v1',
                 state: 'checkout_pending',
                 source: 'checkout-start',
                 updatedBy: 'checkout-start',
-                billingMirrorPlanId: 'pro',
+                billingMirrorPlanId: 'basic',
                 effectiveAt: now,
                 effectiveUntil: expiredAt,
                 createdAt: now,