@taskcluster/client-web 100.4.0 → 100.5.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@taskcluster/client-web",
-  "version": "100.4.0",
+  "version": "100.5.0",
   "main": "src/index.js",
   "author": "Eli Perelman <eli@eliperelman.com>",
   "license": "MPL-2.0",
@@ -9,31 +9,23 @@
     "src"
   ],
   "scripts": {
-    "lint": "eslint src/*.js test/*.js",
-    "test": "NODE_OPTIONS='--openssl-legacy-provider --network-family-autoselection=false' karma start --single-run"
+    "lint": "biome check",
+    "lint:fix": "biome check --write",
+    "format": "biome format --write",
+    "test": "vitest run"
   },
   "devDependencies": {
-    "@babel/core": "^7.29.7",
-    "chai": "^6.2.2",
-    "chai-as-promised": "^8.0.2",
-    "crypto-js": "^4.2.0",
-    "eslint": "^10.3.0",
-    "karma": "^6.4.4",
-    "karma-cli": "^2.0.0",
-    "karma-coverage": "^2.2.1",
-    "karma-firefox-launcher": "^2.1.3",
-    "karma-mocha": "^2.0.1",
-    "karma-mocha-reporter": "^2.2.5",
-    "karma-sourcemap-loader": "^0.4.0",
-    "karma-webpack": "^4.0.2",
-    "query-string": "^7.0.0",
-    "webpack": "^4.47.0",
-    "webpack-cli": "^7.0.2"
+    "@biomejs/biome": "^2.4.15",
+    "@vitest/browser": "^4.1.9",
+    "@vitest/browser-playwright": "^4.1.9",
+    "playwright": "1.60.0",
+    "vite-plugin-node-polyfills": "^0.28.0",
+    "vitest": "^4.1.9"
   },
   "dependencies": {
     "crypto-js": "^4.2.0",
     "hawk": "^9.0.2",
-    "query-string": "^7.0.0",
+    "query-string": "^9.0.0",
     "taskcluster-lib-urls": "^13.0.2"
   },
   "publishConfig": {

package/src/Client.js

@@ -1,5 +1,5 @@
 import { withRootUrl } from 'taskcluster-lib-urls';
-import { stringify } from 'query-string';
+import queryString from 'query-string';
 import hawk from 'hawk';
 import fetch from './fetch';
 
@@ -28,17 +28,12 @@ export default class Client {
       throw new Error('Missing required option "rootUrl"');
     }
 
-    if (
-      this.options.randomizationFactor < 0 ||
-      this.options.randomizationFactor >= 1
-    ) {
+    if (this.options.randomizationFactor < 0 || this.options.randomizationFactor >= 1) {
       throw new Error('options.randomizationFactor must be between 0 and 1');
     }
 
     if (this.options.accessToken) {
-      throw new Error(
-        'options.accessToken is no longer supported; use options.credentials',
-      );
+      throw new Error('options.accessToken is no longer supported; use options.credentials');
     }
 
     const { reference } = options;
@@ -59,8 +54,7 @@ export default class Client {
       if (reference.entries) {
         reference.entries.forEach(entry => {
           if (entry.type === 'function') {
-            // eslint-disable-next-line func-names
-            this[entry.name] = function(...args) {
+            this[entry.name] = function (...args) {
               this.validate(entry, args);
 
               return this.request(entry, args);
@@ -70,8 +64,7 @@ export default class Client {
           }
 
           if (entry.type === 'topic-exchange') {
-            // eslint-disable-next-line func-names
-            this[entry.name] = function(pattern) {
+            this[entry.name] = function (pattern) {
               return this.normalizePattern(entry, pattern);
             };
           }
@@ -90,7 +83,6 @@ export default class Client {
     return input ? args.length + 1 : args.length;
   }
 
-  /* eslint-disable consistent-return */
   buildExtraData(credentials) {
     if (!credentials) {
       return;
@@ -108,8 +100,7 @@ export default class Client {
     // If there is a certificate we have temporary credentials, and we
     // must provide the certificate
     if (certificate) {
-      extra.certificate =
-        typeof certificate === 'string' ? JSON.parse(certificate) : certificate;
+      extra.certificate = typeof certificate === 'string' ? JSON.parse(certificate) : certificate;
     }
 
     // If set of authorized scopes is provided, we'll restrict the request
@@ -123,7 +114,6 @@ export default class Client {
       return window.btoa(JSON.stringify(extra));
     }
   }
-  /* eslint-enable consistent-return */
 
   buildEndpoint(entry, args) {
     return entry.route.replace(/<([^<>]+)>/g, (text, arg) => {
@@ -138,9 +128,7 @@ export default class Client {
       const type = typeof param;
 
       if (type !== 'string' && type !== 'number') {
-        throw new Error(
-          `URL parameter \`${arg}\` expected a string but was provided type "${type}"`,
-        );
+        throw new Error(`URL parameter \`${arg}\` expected a string but was provided type "${type}"`);
       }
 
       return encodeURIComponent(param);
@@ -155,10 +143,10 @@ export default class Client {
     // Find the method
     const { entry } = method;
 
+    // TODO: use optional chaining once this package is no longer parsed by webpack 4
+    // biome-ignore lint/complexity/useOptionalChain: optional chaining is not supported by webpack 4
     if (!entry || entry.type !== 'function') {
-      throw new Error(
-        'Method in buildUrl must be an API method from the same object',
-      );
+      throw new Error('Method in buildUrl must be an API method from the same object');
     }
 
     // Get the query string options taken
@@ -166,13 +154,9 @@ export default class Client {
     const supportsOptions = optionKeys.length !== 0;
     const arity = entry.args.length;
 
-    if (
-      args.length !== arity &&
-      (!supportsOptions || args.length !== arity + 1)
-    ) {
+    if (args.length !== arity && (!supportsOptions || args.length !== arity + 1)) {
       throw new Error(
-        `Method \`${entry.name}.buildUrl\` expected ${arity +
-          1} argument(s) but received ${args.length + 1}`,
+        `Method \`${entry.name}.buildUrl\` expected ${arity + 1} argument(s) but received ${args.length + 1}`
       );
     }
 
@@ -181,22 +165,18 @@ export default class Client {
     if (args[arity]) {
       Object.keys(args[arity]).forEach(key => {
         if (!optionKeys.includes(key)) {
-          throw new Error(
-            `Method \`${entry.name}\` expected options ${optionKeys.join(
-              ', ',
-            )} but received ${key}`,
-          );
+          throw new Error(`Method \`${entry.name}\` expected options ${optionKeys.join(', ')} but received ${key}`);
         }
       });
     }
 
-    const queryArgs = args[arity] && stringify(args[arity]);
+    const queryArgs = args[arity] && queryString.stringify(args[arity]);
     const query = queryArgs ? `?${queryArgs}` : '';
 
     return withRootUrl(this.options.rootUrl).api(
       this.options.serviceName,
       this.options.serviceVersion,
-      `${endpoint}${query}`,
+      `${endpoint}${query}`
     );
   }
 
@@ -238,7 +218,6 @@ export default class Client {
       const options = args.pop();
 
       if (options.expiration) {
-        // eslint-disable-next-line prefer-destructuring
         expiration = options.expiration;
       }
 
@@ -260,9 +239,7 @@ export default class Client {
     }
 
     if (!accessToken) {
-      throw new Error(
-        'buildSignedUrl missing required credentials accessToken',
-      );
+      throw new Error('buildSignedUrl missing required credentials accessToken');
     }
 
     const bewit = hawk.uri.getBewit(url, {
@@ -275,9 +252,7 @@ export default class Client {
       ext: this.buildExtraData(credentials),
     });
 
-    return url.includes('?')
-      ? `${url}&bewit=${bewit}`
-      : `${url}?bewit=${bewit}`;
+    return url.includes('?') ? `${url}&bewit=${bewit}` : `${url}?bewit=${bewit}`;
   }
 
   validate(entry, args = []) {
@@ -285,15 +260,8 @@ export default class Client {
     const queryOptions = entry.query || [];
     const arity = args.length;
 
-    if (
-      arity !== expectedArity &&
-      (queryOptions.length === 0 || arity !== expectedArity + 1)
-    ) {
-      throw new Error(
-        `${
-          entry.name
-        } expected ${expectedArity} arguments but only received ${arity}`,
-      );
+    if (arity !== expectedArity && (queryOptions.length === 0 || arity !== expectedArity + 1)) {
+      throw new Error(`${entry.name} expected ${expectedArity} arguments but only received ${arity}`);
     }
 
     Object.keys(args[expectedArity] || {}).forEach(key => {
@@ -322,9 +290,7 @@ export default class Client {
         if (typeof value === 'string') {
           if (value.includes('.') && !key.multipleWords) {
             throw new Error(
-              `routingKeyPattern "${value}" for ${
-                key.name
-              } cannot contain dots since it does not hold multiple words`,
+              `routingKeyPattern "${value}" for ${key.name} cannot contain dots since it does not hold multiple words`
             );
           }
 
@@ -332,9 +298,7 @@ export default class Client {
         }
 
         if (value != null) {
-          throw new Error(
-            `routingKey value "${value}" is not a valid pattern for ${key.name}`,
-          );
+          throw new Error(`routingKey value "${value}" is not a valid pattern for ${key.name}`);
         }
 
         return key.multipleWords ? '#' : '*';
@@ -351,13 +315,11 @@ export default class Client {
   async request(entry, args) {
     const expectedArity = this.getMethodExpectedArity(entry);
     const endpoint = this.buildEndpoint(entry, args);
-    const query = args[expectedArity]
-      ? `?${stringify(args[expectedArity])}`
-      : '';
+    const query = args[expectedArity] ? `?${queryString.stringify(args[expectedArity])}` : '';
     const url = withRootUrl(this.options.rootUrl).api(
       this.options.serviceName,
       this.options.serviceVersion,
-      `${endpoint}${query}`,
+      `${endpoint}${query}`
     );
     const options = { method: entry.method };
     const credentials = this.options.credentialAgent
@@ -377,7 +339,7 @@ export default class Client {
   }
 }
 
-Client.create = (reference) =>
+Client.create = reference =>
   class extends Client {
     constructor(options) {
       super({ ...options, reference });