@taphubhq/sdk-core 0.23.2 → 0.23.4

package/dist/index.cjs

@@ -1402,6 +1402,9 @@ function mapWireConfig(raw) {
 function mapWireIdealConfig(raw) {
   const p = raw;
   return {
+    // bid-260612 guard ①: carry the producer's pairId so consumers can reject cross-pair
+    // suggestions. Undefined when talking to a producer that predates the field.
+    pairId: p.pairId,
     cellSizeValue: p.cellSizeValue,
     currentPrice: p.currentPrice,
     reason: p.reason ?? "volatility_shift"
@@ -1636,15 +1639,15 @@ function normaliseMeResponse(body) {
   };
 }
 function normaliseCurrencies(body) {
-  if (!Array.isArray(body)) {
+  if (!body || !Array.isArray(body.listEnabledCurrencies)) {
     throw new TaphubServerError("Invalid response from server", {
       code: "InvalidResponse"
     });
   }
-  return body.map((entry) => ({
+  return body.listEnabledCurrencies.map((entry) => ({
     code: entry.code,
     unit: entry.unit,
-    unitSymbol: entry.unit_symbol
+    unitSymbol: entry.unitSymbol
   }));
 }
 function normaliseWalletNode(node) {
@@ -1700,6 +1703,9 @@ function normaliseUserPnL(node) {
 // src/modules/user/queries.ts
 var ME_QUERY = "query Me { me { id username wallet_address balance is_demo } }";
 var MY_WALLETS_QUERY = "query MyWallets { myWallets { id amount currency isEnable } }";
+var LIST_ENABLED_CURRENCIES_QUERY = `query ListEnabledCurrencies($input: ListEnabledCurrenciesInput!) {
+  listEnabledCurrencies(input: $input) { code unit unitSymbol }
+}`;
 var MY_WALLET_BY_CURRENCY_QUERY = "query MyWalletByCurrency($currency: String!) { myWalletByCurrency(currency: $currency) { id amount currency isEnable } }";
 var USER_PNL_QUERY = `query UserPnL($period: String) {
   userPnL(period: $period) {
@@ -1709,12 +1715,10 @@ var USER_PNL_QUERY = `query UserPnL($period: String) {
 
 // src/modules/user/index.ts
 var UserModule = class {
-  #rest;
   #graphql;
   #graphqlUser;
   #currencies = null;
   constructor(deps) {
-    this.#rest = deps.rest;
     this.#graphql = deps.graphql;
     this.#graphqlUser = deps.graphqlUser;
   }
@@ -1756,7 +1760,10 @@ var UserModule = class {
     return this.#currencies;
   }
   async refreshCurrencies() {
-    const body = await this.#rest.post("/currency/list-enable");
+    const body = await this.#graphqlUser.request(
+      LIST_ENABLED_CURRENCIES_QUERY,
+      { input: {} }
+    );
     const currencies = normaliseCurrencies(body);
     this.#currencies = currencies;
     return currencies;
@@ -1932,23 +1939,28 @@ var NetworkQualityMonitor = class {
   mqttDisconnectedAt = null;
   committedNetwork = "good";
   committedBackend = "ok";
+  // The last snapshot we emitted, used to decide whether the next recompute is
+  // worth emitting. Seeded with the initial default so the first real change
+  // (e.g. first backend5xx, first ping) emits against the true starting state.
+  lastEmitted;
   tickHandle = null;
   onlineListener = null;
   offlineListener = null;
   disposed = false;
   constructor(opts) {
     this.bus = opts.bus;
+    this.lastEmitted = this.snapshot();
     this.attachBrowserListeners();
     this.startTick();
   }
-  addSample(sample, prevMqttConnectedOverride) {
+  addSample(sample) {
     if (this.disposed) return;
     const bucket = this.buckets[sample.source];
     bucket.push(sample);
     if (bucket.length > WINDOW_MAX_SAMPLES_PER_SOURCE) {
       bucket.shift();
     }
-    this.recompute(prevMqttConnectedOverride);
+    this.recompute();
   }
   seedFromConnection(seed) {
     const rtt = this.resolveSeedRtt(seed);
@@ -1961,24 +1973,19 @@ var NetworkQualityMonitor = class {
     });
   }
   notifyMqttConnect(rttMs) {
-    const prevMqttConnected = this.mqttConnected;
     this.mqttConnected = true;
     this.mqttDisconnectedAt = null;
-    this.addSample(
-      {
-        ts: this.now(),
-        rtt: rttMs,
-        source: "mqtt",
-        reason: "ok"
-      },
-      prevMqttConnected
-    );
+    this.addSample({
+      ts: this.now(),
+      rtt: rttMs,
+      source: "mqtt",
+      reason: "connect"
+    });
   }
   notifyMqttDisconnect() {
-    const prevMqttConnected = this.mqttConnected;
     this.mqttConnected = false;
     this.mqttDisconnectedAt = this.now();
-    this.recompute(prevMqttConnected);
+    this.recompute();
   }
   notifyMqttPing(rttMs) {
     this.smoother.add(rttMs);
@@ -2002,7 +2009,6 @@ var NetworkQualityMonitor = class {
     return this.snapshot();
   }
   reset() {
-    const prev = this.snapshot();
     for (const key of Object.keys(this.buckets)) {
       this.buckets[key] = [];
     }
@@ -2011,10 +2017,7 @@ var NetworkQualityMonitor = class {
     this.mqttDisconnectedAt = null;
     this.committedNetwork = "good";
     this.committedBackend = "ok";
-    const current = this.snapshot();
-    if (prev.network !== current.network || prev.backend !== current.backend) {
-      this.bus.emit("network:change", { previous: prev, current });
-    }
+    this.emitIfChanged(this.snapshot());
   }
   tick() {
     this.pruneWindow();
@@ -2069,9 +2072,8 @@ var NetworkQualityMonitor = class {
       this.buckets[key] = this.buckets[key].filter((s) => s.ts >= cutoff);
     }
   }
-  recompute(prevMqttConnectedOverride) {
+  recompute() {
     this.pruneWindow();
-    const prev = this.snapshot();
     const allSamples = this.allHttpAndMqttSamples();
     const realSamples = allSamples.filter((s) => s.source !== "connection");
     const useConnection = realSamples.length < COLD_START_REAL_SAMPLE_THRESHOLD;
@@ -2095,12 +2097,26 @@ var NetworkQualityMonitor = class {
       this.smoother.releaseOffline();
       nextNetwork = this.smoother.level;
     }
-    const prevMqttConnected = prevMqttConnectedOverride ?? prev.mqttConnected;
-    const changed = nextNetwork !== this.committedNetwork || backend !== this.committedBackend || this.mqttConnected !== prevMqttConnected;
     this.committedNetwork = nextNetwork;
     this.committedBackend = backend;
+    this.emitIfChanged(this.snapshot());
+  }
+  // Emits network:change when any *displayed* field of the snapshot moves. This
+  // is compared against the last emitted snapshot (not a snapshot taken at the
+  // top of recompute): notifyMqttPing feeds the smoother BEFORE recompute, so a
+  // same-call snapshot would already carry the new rtt and the change would be
+  // invisible (the original "rtt label freezes on a stable connection" bug).
+  //
+  // Trigger fields: network, backend, mqttConnected, rtt, jitter. rtt/jitter are
+  // bounded by the MQTT ping cadence (~keepalive), so this cannot spam. lossRate
+  // and samplesInWindow are deliberately excluded — they move on every HTTP
+  // sample (request-volume driven) and are diagnostics only; consumers that show
+  // them poll getCurrent().
+  emitIfChanged(current) {
+    const prev = this.lastEmitted;
+    this.lastEmitted = current;
+    const changed = current.network !== prev.network || current.backend !== prev.backend || current.mqttConnected !== prev.mqttConnected || current.rtt !== prev.rtt || current.jitter !== prev.jitter;
     if (changed) {
-      const current = this.snapshot();
       this.bus.emit("network:change", { previous: prev, current });
     }
   }
@@ -2740,7 +2756,6 @@ var TaphubClient = class {
       onRequest: graphqlProbe
     });
     this.user = new UserModule({
-      rest: this.#rest,
       graphql: this.#graphql,
       graphqlUser: this.#graphqlUser
     });

package/dist/index.d.mts

@@ -35,7 +35,7 @@ interface TaphubClientConfig {
 }
 
 type SignalSource = 'graphql' | 'rest' | 'mqtt' | 'browser' | 'connection';
-type SampleReason = 'ok' | 'network' | 'timeout' | 'offline' | 'backend5xx' | 'backend4xx' | 'gqlError';
+type SampleReason = 'ok' | 'connect' | 'network' | 'timeout' | 'offline' | 'backend5xx' | 'backend4xx' | 'gqlError';
 type Sample = {
     ts: number;
     rtt: number;
@@ -838,6 +838,12 @@ interface MqttConfigEvent {
     acceptableBids: number[];
 }
 interface MqttIdealConfigEvent {
+    /**
+     * game_pairs.id (e.g. "grid-ETH-USD") the suggestion was computed for. Optional for
+     * backward compat with producers predating bid-260612; when present, a consumer drops
+     * suggestions whose pairId does not match the pair it is currently viewing (guard ①).
+     */
+    pairId?: string;
     cellSizeValue: number;
     currentPrice: number;
     reason: string;
@@ -992,7 +998,6 @@ interface UserPnL {
 }
 
 interface UserModuleDeps {
-    rest: RestTransport;
     graphql: GraphQLTransport;
     graphqlUser: GraphQLTransport;
 }
@@ -1039,6 +1044,7 @@ declare class NetworkQualityMonitor {
     private mqttDisconnectedAt;
     private committedNetwork;
     private committedBackend;
+    private lastEmitted;
     private tickHandle;
     private onlineListener;
     private offlineListener;
@@ -1046,7 +1052,7 @@ declare class NetworkQualityMonitor {
     constructor(opts: {
         bus: TaphubEventBus<EventMapWithNetwork>;
     });
-    addSample(sample: Sample, prevMqttConnectedOverride?: boolean): void;
+    addSample(sample: Sample): void;
     seedFromConnection(seed: ConnectionSeed): void;
     notifyMqttConnect(rttMs: number): void;
     notifyMqttDisconnect(): void;
@@ -1062,6 +1068,7 @@ declare class NetworkQualityMonitor {
     private detachBrowserListeners;
     private pruneWindow;
     private recompute;
+    private emitIfChanged;
     private deriveMetricsFrom;
     private isHardOffline;
     private allHttpAndMqttSamples;

package/dist/index.d.ts

@@ -35,7 +35,7 @@ interface TaphubClientConfig {
 }
 
 type SignalSource = 'graphql' | 'rest' | 'mqtt' | 'browser' | 'connection';
-type SampleReason = 'ok' | 'network' | 'timeout' | 'offline' | 'backend5xx' | 'backend4xx' | 'gqlError';
+type SampleReason = 'ok' | 'connect' | 'network' | 'timeout' | 'offline' | 'backend5xx' | 'backend4xx' | 'gqlError';
 type Sample = {
     ts: number;
     rtt: number;
@@ -838,6 +838,12 @@ interface MqttConfigEvent {
     acceptableBids: number[];
 }
 interface MqttIdealConfigEvent {
+    /**
+     * game_pairs.id (e.g. "grid-ETH-USD") the suggestion was computed for. Optional for
+     * backward compat with producers predating bid-260612; when present, a consumer drops
+     * suggestions whose pairId does not match the pair it is currently viewing (guard ①).
+     */
+    pairId?: string;
     cellSizeValue: number;
     currentPrice: number;
     reason: string;
@@ -992,7 +998,6 @@ interface UserPnL {
 }
 
 interface UserModuleDeps {
-    rest: RestTransport;
     graphql: GraphQLTransport;
     graphqlUser: GraphQLTransport;
 }
@@ -1039,6 +1044,7 @@ declare class NetworkQualityMonitor {
     private mqttDisconnectedAt;
     private committedNetwork;
     private committedBackend;
+    private lastEmitted;
     private tickHandle;
     private onlineListener;
     private offlineListener;
@@ -1046,7 +1052,7 @@ declare class NetworkQualityMonitor {
     constructor(opts: {
         bus: TaphubEventBus<EventMapWithNetwork>;
     });
-    addSample(sample: Sample, prevMqttConnectedOverride?: boolean): void;
+    addSample(sample: Sample): void;
     seedFromConnection(seed: ConnectionSeed): void;
     notifyMqttConnect(rttMs: number): void;
     notifyMqttDisconnect(): void;
@@ -1062,6 +1068,7 @@ declare class NetworkQualityMonitor {
     private detachBrowserListeners;
     private pruneWindow;
     private recompute;
+    private emitIfChanged;
     private deriveMetricsFrom;
     private isHardOffline;
     private allHttpAndMqttSamples;

package/dist/index.js

@@ -1337,6 +1337,9 @@ function mapWireConfig(raw) {
 function mapWireIdealConfig(raw) {
   const p = raw;
   return {
+    // bid-260612 guard ①: carry the producer's pairId so consumers can reject cross-pair
+    // suggestions. Undefined when talking to a producer that predates the field.
+    pairId: p.pairId,
     cellSizeValue: p.cellSizeValue,
     currentPrice: p.currentPrice,
     reason: p.reason ?? "volatility_shift"
@@ -1571,15 +1574,15 @@ function normaliseMeResponse(body) {
   };
 }
 function normaliseCurrencies(body) {
-  if (!Array.isArray(body)) {
+  if (!body || !Array.isArray(body.listEnabledCurrencies)) {
     throw new TaphubServerError("Invalid response from server", {
       code: "InvalidResponse"
     });
   }
-  return body.map((entry) => ({
+  return body.listEnabledCurrencies.map((entry) => ({
     code: entry.code,
     unit: entry.unit,
-    unitSymbol: entry.unit_symbol
+    unitSymbol: entry.unitSymbol
   }));
 }
 function normaliseWalletNode(node) {
@@ -1635,6 +1638,9 @@ function normaliseUserPnL(node) {
 // src/modules/user/queries.ts
 var ME_QUERY = "query Me { me { id username wallet_address balance is_demo } }";
 var MY_WALLETS_QUERY = "query MyWallets { myWallets { id amount currency isEnable } }";
+var LIST_ENABLED_CURRENCIES_QUERY = `query ListEnabledCurrencies($input: ListEnabledCurrenciesInput!) {
+  listEnabledCurrencies(input: $input) { code unit unitSymbol }
+}`;
 var MY_WALLET_BY_CURRENCY_QUERY = "query MyWalletByCurrency($currency: String!) { myWalletByCurrency(currency: $currency) { id amount currency isEnable } }";
 var USER_PNL_QUERY = `query UserPnL($period: String) {
   userPnL(period: $period) {
@@ -1644,12 +1650,10 @@ var USER_PNL_QUERY = `query UserPnL($period: String) {
 
 // src/modules/user/index.ts
 var UserModule = class {
-  #rest;
   #graphql;
   #graphqlUser;
   #currencies = null;
   constructor(deps) {
-    this.#rest = deps.rest;
     this.#graphql = deps.graphql;
     this.#graphqlUser = deps.graphqlUser;
   }
@@ -1691,7 +1695,10 @@ var UserModule = class {
     return this.#currencies;
   }
   async refreshCurrencies() {
-    const body = await this.#rest.post("/currency/list-enable");
+    const body = await this.#graphqlUser.request(
+      LIST_ENABLED_CURRENCIES_QUERY,
+      { input: {} }
+    );
     const currencies = normaliseCurrencies(body);
     this.#currencies = currencies;
     return currencies;
@@ -1867,23 +1874,28 @@ var NetworkQualityMonitor = class {
   mqttDisconnectedAt = null;
   committedNetwork = "good";
   committedBackend = "ok";
+  // The last snapshot we emitted, used to decide whether the next recompute is
+  // worth emitting. Seeded with the initial default so the first real change
+  // (e.g. first backend5xx, first ping) emits against the true starting state.
+  lastEmitted;
   tickHandle = null;
   onlineListener = null;
   offlineListener = null;
   disposed = false;
   constructor(opts) {
     this.bus = opts.bus;
+    this.lastEmitted = this.snapshot();
     this.attachBrowserListeners();
     this.startTick();
   }
-  addSample(sample, prevMqttConnectedOverride) {
+  addSample(sample) {
     if (this.disposed) return;
     const bucket = this.buckets[sample.source];
     bucket.push(sample);
     if (bucket.length > WINDOW_MAX_SAMPLES_PER_SOURCE) {
       bucket.shift();
     }
-    this.recompute(prevMqttConnectedOverride);
+    this.recompute();
   }
   seedFromConnection(seed) {
     const rtt = this.resolveSeedRtt(seed);
@@ -1896,24 +1908,19 @@ var NetworkQualityMonitor = class {
     });
   }
   notifyMqttConnect(rttMs) {
-    const prevMqttConnected = this.mqttConnected;
     this.mqttConnected = true;
     this.mqttDisconnectedAt = null;
-    this.addSample(
-      {
-        ts: this.now(),
-        rtt: rttMs,
-        source: "mqtt",
-        reason: "ok"
-      },
-      prevMqttConnected
-    );
+    this.addSample({
+      ts: this.now(),
+      rtt: rttMs,
+      source: "mqtt",
+      reason: "connect"
+    });
   }
   notifyMqttDisconnect() {
-    const prevMqttConnected = this.mqttConnected;
     this.mqttConnected = false;
     this.mqttDisconnectedAt = this.now();
-    this.recompute(prevMqttConnected);
+    this.recompute();
   }
   notifyMqttPing(rttMs) {
     this.smoother.add(rttMs);
@@ -1937,7 +1944,6 @@ var NetworkQualityMonitor = class {
     return this.snapshot();
   }
   reset() {
-    const prev = this.snapshot();
     for (const key of Object.keys(this.buckets)) {
       this.buckets[key] = [];
     }
@@ -1946,10 +1952,7 @@ var NetworkQualityMonitor = class {
     this.mqttDisconnectedAt = null;
     this.committedNetwork = "good";
     this.committedBackend = "ok";
-    const current = this.snapshot();
-    if (prev.network !== current.network || prev.backend !== current.backend) {
-      this.bus.emit("network:change", { previous: prev, current });
-    }
+    this.emitIfChanged(this.snapshot());
   }
   tick() {
     this.pruneWindow();
@@ -2004,9 +2007,8 @@ var NetworkQualityMonitor = class {
       this.buckets[key] = this.buckets[key].filter((s) => s.ts >= cutoff);
     }
   }
-  recompute(prevMqttConnectedOverride) {
+  recompute() {
     this.pruneWindow();
-    const prev = this.snapshot();
     const allSamples = this.allHttpAndMqttSamples();
     const realSamples = allSamples.filter((s) => s.source !== "connection");
     const useConnection = realSamples.length < COLD_START_REAL_SAMPLE_THRESHOLD;
@@ -2030,12 +2032,26 @@ var NetworkQualityMonitor = class {
       this.smoother.releaseOffline();
       nextNetwork = this.smoother.level;
     }
-    const prevMqttConnected = prevMqttConnectedOverride ?? prev.mqttConnected;
-    const changed = nextNetwork !== this.committedNetwork || backend !== this.committedBackend || this.mqttConnected !== prevMqttConnected;
     this.committedNetwork = nextNetwork;
     this.committedBackend = backend;
+    this.emitIfChanged(this.snapshot());
+  }
+  // Emits network:change when any *displayed* field of the snapshot moves. This
+  // is compared against the last emitted snapshot (not a snapshot taken at the
+  // top of recompute): notifyMqttPing feeds the smoother BEFORE recompute, so a
+  // same-call snapshot would already carry the new rtt and the change would be
+  // invisible (the original "rtt label freezes on a stable connection" bug).
+  //
+  // Trigger fields: network, backend, mqttConnected, rtt, jitter. rtt/jitter are
+  // bounded by the MQTT ping cadence (~keepalive), so this cannot spam. lossRate
+  // and samplesInWindow are deliberately excluded — they move on every HTTP
+  // sample (request-volume driven) and are diagnostics only; consumers that show
+  // them poll getCurrent().
+  emitIfChanged(current) {
+    const prev = this.lastEmitted;
+    this.lastEmitted = current;
+    const changed = current.network !== prev.network || current.backend !== prev.backend || current.mqttConnected !== prev.mqttConnected || current.rtt !== prev.rtt || current.jitter !== prev.jitter;
     if (changed) {
-      const current = this.snapshot();
       this.bus.emit("network:change", { previous: prev, current });
     }
   }
@@ -2675,7 +2691,6 @@ var TaphubClient = class {
       onRequest: graphqlProbe
     });
     this.user = new UserModule({
-      rest: this.#rest,
       graphql: this.#graphql,
       graphqlUser: this.#graphqlUser
     });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@taphubhq/sdk-core",
-  "version": "0.23.2",
+  "version": "0.23.4",
   "description": "Core SDK for building on the TabHub platform",
   "license": "MIT",
   "main": "./dist/index.cjs",