@tapcart/mobile-components 0.16.0 → 0.16.2

package/dist/components/hooks/use-nosto-recommendation.test.js

@@ -14,13 +14,13 @@ import { useProducts } from "./use-products";
 jest.mock("./use-products", () => ({
     useProducts: jest.fn(),
 }));
-// Mock fetch for GraphQL queries
+// Mock fetch for GraphQL queries. `newSession` is intentionally NOT handled:
+// after TICKET-5763 nothing may ever mint a session, so a newSession request
+// would be a bug — fail loudly if one is ever issued.
 global.fetch = jest.fn((url, options) => {
     const body = JSON.parse(options === null || options === void 0 ? void 0 : options.body);
     if (body.query.includes("newSession")) {
-        return Promise.resolve({
-            json: () => Promise.resolve({ data: { newSession: "mockSessionId" } }),
-        });
+        return Promise.reject(new Error("newSession must never be called (TICKET-5763)"));
     }
     if (body.query.includes("GetFrontPageRecommendations")) {
         return Promise.resolve({
@@ -93,6 +93,31 @@ global.fetch = jest.fn((url, options) => {
     }
     return Promise.reject(new Error("Unknown query"));
 });
+// Asserts the invariant that must hold for EVERY test: no request ever asks
+// Nosto to mint a new session.
+const expectNoNewSessionCall = () => {
+    const calls = global.fetch.mock.calls;
+    const mintedSession = calls.some(([, options]) => {
+        const raw = options === null || options === void 0 ? void 0 : options.body;
+        return typeof raw === "string" && raw.includes("newSession");
+    });
+    expect(mintedSession).toBe(false);
+};
+const setCidCookie = (value) => {
+    document.cookie = `2c.cId=${value}`;
+};
+const clearCookies = () => {
+    document.cookie = "2c.cId=; expires=Thu, 01 Jan 1970 00:00:00 GMT";
+};
+const recentSession = (sessionId) => ({
+    sessionId,
+    lastSessionEventTimestamp: Date.now(),
+});
+const flush = () => __awaiter(void 0, void 0, void 0, function* () {
+    yield act(() => __awaiter(void 0, void 0, void 0, function* () {
+        yield new Promise((resolve) => setTimeout(resolve, 0));
+    }));
+});
 describe("useNostoRecommendations", () => {
     const mockIntegrations = [
         {
@@ -104,233 +129,218 @@ describe("useNostoRecommendations", () => {
     const mockBaseURL = "http://mockbaseurl.com";
     beforeEach(() => {
         jest.clearAllMocks();
+        clearCookies();
         useProducts.mockReturnValue({
             products: [{ id: "1", name: "Product 1" }],
             isLoading: false,
             error: null,
         });
     });
-    it("should return front page recommendations if productIds is empty and slotId is provided", () => __awaiter(void 0, void 0, void 0, function* () {
-        const slotId = "mockSlotId";
-        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, slotId, "US", undefined, undefined, undefined));
-        // Initial state check
+    afterEach(() => {
+        // Invariant across every path: never mint a Nosto session.
+        expectNoNewSessionCall();
+        clearCookies();
+    });
+    it("uses the passed-in session for front page recommendations", () => __awaiter(void 0, void 0, void 0, function* () {
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "mockSlotId", "US", undefined, undefined, undefined, undefined, undefined, recentSession("passed-session")));
         expect(result.current.isLoading).toBe(true);
-        // Wait for all promises with act
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Check final state
+        yield flush();
         expect(result.current.isLoading).toBe(false);
         expect(result.current.error).toBe(null);
+        // Native session was used -> personalization surfaced as "session".
+        expect(result.current.personalization).toBe("session");
         expect(useProducts).toHaveBeenCalledWith({
             productIds: ["front-page-id-1"],
             baseURL: mockBaseURL,
             productHandles: [],
-            queryVariables: {
-                appId: undefined,
-                country: "US",
-            },
+            queryVariables: { appId: undefined, country: "US" },
             mock: false,
         });
     }));
-    it("should return best sellers recommendations if productIds is empty and slotId is not provided", () => __awaiter(void 0, void 0, void 0, function* () {
-        const slotId = "";
-        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, slotId, "US", undefined, undefined));
-        // Initial state check
+    it("falls back to the 2c.cId cookie when no session is passed (front page)", () => __awaiter(void 0, void 0, void 0, function* () {
+        setCidCookie("cookie-cid");
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "mockSlotId", "US"));
         expect(result.current.isLoading).toBe(true);
-        // Wait for all promises with act
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Check final state
+        yield flush();
         expect(result.current.isLoading).toBe(false);
-        expect(result.current.error).toBe(null);
+        // Cookie-derived session resolves, so the personalized front page query runs.
+        expect(result.current.personalization).toBe("cookie");
         expect(useProducts).toHaveBeenCalledWith({
-            productIds: ["best-seller-1"],
+            productIds: ["front-page-id-1"],
             baseURL: mockBaseURL,
             productHandles: [],
-            queryVariables: {
-                appId: undefined,
-                country: "US",
-            },
+            queryVariables: { appId: undefined, country: "US" },
             mock: false,
         });
     }));
-    it("should return best sellers recommendations if productIds is not empty, Best Sellers is the recommendation type and slotId is not provided", () => __awaiter(void 0, void 0, void 0, function* () {
-        const slotId = "";
-        const productIds = ["mockProductId"];
-        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, slotId, "US", NostoRecommendationsType.BEST_SELLERS, productIds));
-        // Initial state check
+    it("falls back to bestSellers on the front page when there is no session and no cookie", () => __awaiter(void 0, void 0, void 0, function* () {
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "mockSlotId", "US"));
         expect(result.current.isLoading).toBe(true);
-        // Wait for all promises with act
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Check final state
+        yield flush();
         expect(result.current.isLoading).toBe(false);
-        expect(result.current.error).toBe(null);
+        // No identity available -> personalization "none".
+        expect(result.current.personalization).toBe("none");
+        // No session-based query fired; bestSellers fallback engaged.
         expect(useProducts).toHaveBeenCalledWith({
             productIds: ["best-seller-1"],
             baseURL: mockBaseURL,
             productHandles: [],
-            queryVariables: {
-                appId: undefined,
-                country: "US",
-            },
+            queryVariables: { appId: undefined, country: "US" },
             mock: false,
         });
     }));
-    it("should return default front page recommendations if slotId is provided but layoutType is not", () => __awaiter(void 0, void 0, void 0, function* () {
-        const slotId = "mockSlotId";
-        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, slotId, "US"));
-        // Initial state check
+    it("upgrades from bestSellers to personalized once a late 2c.cId cookie appears", () => __awaiter(void 0, void 0, void 0, function* () {
+        // The WebView Nosto SDK mints the cookie asynchronously, so a carousel can
+        // mount before it exists. The bounded poll must pick up the late cookie and
+        // re-resolve from the bestSellers fallback to the personalized front page.
+        jest.useFakeTimers();
+        try {
+            const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "mockSlotId", "US"));
+            // No cookie at mount -> "none" + bestSellers fallback.
+            yield act(() => __awaiter(void 0, void 0, void 0, function* () {
+                yield jest.advanceTimersByTimeAsync(0);
+            }));
+            expect(result.current.personalization).toBe("none");
+            expect(useProducts).toHaveBeenLastCalledWith(expect.objectContaining({ productIds: ["best-seller-1"] }));
+            // Cookie minted after mount; the 250ms poll picks it up and refetches.
+            setCidCookie("late-cookie-cid");
+            yield act(() => __awaiter(void 0, void 0, void 0, function* () {
+                yield jest.advanceTimersByTimeAsync(250);
+            }));
+            expect(result.current.personalization).toBe("cookie");
+            expect(useProducts).toHaveBeenLastCalledWith(expect.objectContaining({ productIds: ["front-page-id-1"] }));
+        }
+        finally {
+            jest.useRealTimers();
+        }
+    }));
+    it("returns best sellers when productIds is empty and slotId is not provided", () => __awaiter(void 0, void 0, void 0, function* () {
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US"));
         expect(result.current.isLoading).toBe(true);
-        // Wait for all promises with act
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Check final state
+        yield flush();
         expect(result.current.isLoading).toBe(false);
         expect(result.current.error).toBe(null);
         expect(useProducts).toHaveBeenCalledWith({
-            productIds: ["front-page-id-1"],
+            productIds: ["best-seller-1"],
             baseURL: mockBaseURL,
             productHandles: [],
-            queryVariables: {
-                appId: undefined,
-                country: "US",
-            },
+            queryVariables: { appId: undefined, country: "US" },
             mock: false,
         });
     }));
-    it("should return the correct recommendations for best sellers", () => __awaiter(void 0, void 0, void 0, function* () {
-        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.BEST_SELLERS, undefined, undefined));
-        // Initial state check
+    it("returns best sellers when BEST_SELLERS type and productIds are provided but no slotId", () => __awaiter(void 0, void 0, void 0, function* () {
+        // Stable reference so the hook's effect deps don't change across renders.
+        const productIds = ["mockProductId"];
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.BEST_SELLERS, productIds));
         expect(result.current.isLoading).toBe(true);
-        // Wait for all promises with act
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Check final state
+        yield flush();
         expect(result.current.isLoading).toBe(false);
-        expect(result.current.error).toBe(null);
         expect(useProducts).toHaveBeenCalledWith({
             productIds: ["best-seller-1"],
             baseURL: mockBaseURL,
             productHandles: [],
-            queryVariables: {
-                appId: undefined,
-                country: "US",
-            },
+            queryVariables: { appId: undefined, country: "US" },
             mock: false,
         });
     }));
-    it("should return the related recommendations when only productIds and a recommendation type are provided on a non-home layout", () => __awaiter(void 0, void 0, void 0, function* () {
+    it("returns product page recommendations when a session, productIds and slotId are provided", () => __awaiter(void 0, void 0, void 0, function* () {
         const productIds = ["mockProductId"];
-        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.VIEWED_TOGETHER, productIds, undefined));
-        // Initial state check
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "mockSlotId", "US", NostoRecommendationsType.VIEWED_TOGETHER, productIds, undefined, undefined, undefined, recentSession("passed-session")));
         expect(result.current.isLoading).toBe(true);
-        // Wait for all promises with act
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Check final state
+        yield flush();
+        expect(result.current.isLoading).toBe(false);
+        expect(useProducts).toHaveBeenCalledWith({
+            productIds: ["product-page-id-1"],
+            baseURL: mockBaseURL,
+            productHandles: [],
+            queryVariables: { appId: undefined, country: "US" },
+            mock: false,
+        });
+    }));
+    it("returns the related products PDP fallback (no slotId, non-category type)", () => __awaiter(void 0, void 0, void 0, function* () {
+        const productIds = ["mockProductId"];
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.VIEWED_TOGETHER, productIds));
+        expect(result.current.isLoading).toBe(true);
+        yield flush();
         expect(result.current.isLoading).toBe(false);
-        expect(result.current.error).toBe(null);
         expect(useProducts).toHaveBeenCalledWith({
             productIds: ["related-1"],
             baseURL: mockBaseURL,
             productHandles: [],
-            queryVariables: {
-                appId: undefined,
-                country: "US",
-            },
+            queryVariables: { appId: undefined, country: "US" },
             mock: false,
         });
     }));
-    it("should return the correct recommendations when productIds and slotIds are provided", () => __awaiter(void 0, void 0, void 0, function* () {
-        const slotId = "mockSlotId";
+    it("returns the category PDP fallback when a session is available and type is VIEWED_CATEGORY", () => __awaiter(void 0, void 0, void 0, function* () {
         const productIds = ["mockProductId"];
-        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, slotId, "US", NostoRecommendationsType.VIEWED_TOGETHER, productIds, undefined));
-        // Initial state check
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.VIEWED_CATEGORY, productIds, undefined, undefined, undefined, recentSession("passed-session")));
         expect(result.current.isLoading).toBe(true);
-        // Wait for all promises with act
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Check final state
+        yield flush();
         expect(result.current.isLoading).toBe(false);
-        expect(result.current.error).toBe(null);
         expect(useProducts).toHaveBeenCalledWith({
-            productIds: ["product-page-id-1"],
+            productIds: ["category-page-id-1"],
             baseURL: mockBaseURL,
             productHandles: [],
-            queryVariables: {
-                appId: undefined,
-                country: "US",
-            },
+            queryVariables: { appId: undefined, country: "US" },
             mock: false,
         });
     }));
-    it("should return the related products fallback recommendations when productIds are provided and no slotId and a type other than viewed_category and best_sellers is provided", () => __awaiter(void 0, void 0, void 0, function* () {
+    it("falls back to bestSellers for a VIEWED_CATEGORY PDP when there is no session", () => __awaiter(void 0, void 0, void 0, function* () {
         const productIds = ["mockProductId"];
-        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.VIEWED_TOGETHER, productIds, undefined));
-        // Initial state check
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.VIEWED_CATEGORY, productIds));
         expect(result.current.isLoading).toBe(true);
-        // Wait for all promises with act
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Check final state
+        yield flush();
         expect(result.current.isLoading).toBe(false);
-        expect(result.current.error).toBe(null);
         expect(useProducts).toHaveBeenCalledWith({
-            productIds: ["related-1"],
+            productIds: ["best-seller-1"],
             baseURL: mockBaseURL,
             productHandles: [],
-            queryVariables: {
-                appId: undefined,
-                country: "US",
-            },
+            queryVariables: { appId: undefined, country: "US" },
             mock: false,
         });
     }));
-    it("should return the category fallback recommendations when no slotId, productIds are provided and a recommendation type of viewed_category is provided", () => __awaiter(void 0, void 0, void 0, function* () {
+    it("serves bestSellers (not an error) for a VIEWED_CATEGORY PDP when the cId cookie is malformed", () => __awaiter(void 0, void 0, void 0, function* () {
+        // A bad percent-encoding makes decodeURIComponent throw; the shared reader
+        // must return null (never the raw value) so this routes into the designed
+        // bestSellers fallback instead of escaping into the hook's error state.
+        document.cookie = "2c.cId=%";
         const productIds = ["mockProductId"];
-        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.VIEWED_CATEGORY, productIds, undefined));
-        // Initial state check
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.VIEWED_CATEGORY, productIds));
         expect(result.current.isLoading).toBe(true);
-        // Wait for all promises with act
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Check final state
+        yield flush();
         expect(result.current.isLoading).toBe(false);
         expect(result.current.error).toBe(null);
+        expect(result.current.personalization).toBe("none");
         expect(useProducts).toHaveBeenCalledWith({
-            productIds: ["category-page-id-1"],
+            productIds: ["best-seller-1"],
             baseURL: mockBaseURL,
             productHandles: [],
-            queryVariables: {
-                appId: undefined,
-                country: "US",
-            },
+            queryVariables: { appId: undefined, country: "US" },
             mock: false,
         });
     }));
-    it("should handle loading state", () => __awaiter(void 0, void 0, void 0, function* () {
+    it("defaults to best sellers if productIds are empty but a non-BestSellers type is used", () => __awaiter(void 0, void 0, void 0, function* () {
+        const productIds = [];
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.VIEWED_TOGETHER, productIds));
+        expect(result.current.isLoading).toBe(true);
+        yield flush();
+        expect(result.current.isLoading).toBe(false);
+        expect(useProducts).toHaveBeenCalledWith({
+            productIds: ["best-seller-1"],
+            baseURL: mockBaseURL,
+            productHandles: [],
+            queryVariables: { appId: undefined, country: "US" },
+            mock: false,
+        });
+    }));
+    it("handles loading state", () => __awaiter(void 0, void 0, void 0, function* () {
         const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US"));
-        // Check initial loading state
         expect(result.current.isLoading).toBe(true);
-        // Wait for all state updates to complete
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Verify loading has finished
+        yield flush();
         expect(result.current.isLoading).toBe(false);
         expect(result.current.error).toBe(null);
     }));
-    it("should handle error state", () => __awaiter(void 0, void 0, void 0, function* () {
+    it("handles error state", () => __awaiter(void 0, void 0, void 0, function* () {
         const mockError = () => "Failed to fetch products";
         useProducts.mockReturnValue({
             products: [],
@@ -338,58 +348,45 @@ describe("useNostoRecommendations", () => {
             error: mockError,
         });
         const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL));
-        // Initial state check
         expect(result.current.isLoading).toBe(true);
-        // Wait for all promises and state updates to resolve
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Verify final error state
+        yield flush();
         expect(result.current.isLoading).toBe(false);
         expect(result.current.error).toBe(mockError);
         expect(result.current.recommendations).toEqual([]);
     }));
-    it("should default to best sellers if productIds are empty but a recommendation type other than Best Sellers is used", () => __awaiter(void 0, void 0, void 0, function* () {
-        const productIds = [];
-        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.VIEWED_TOGETHER, productIds, undefined));
-        // Initial state check
+    it("returns an empty array if skip is true", () => __awaiter(void 0, void 0, void 0, function* () {
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.BEST_SELLERS, undefined, true));
         expect(result.current.isLoading).toBe(true);
-        // Wait for all promises with act
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Check final state
+        yield flush();
         expect(result.current.isLoading).toBe(false);
-        expect(result.current.error).toBe(null);
         expect(useProducts).toHaveBeenCalledWith({
-            productIds: ["best-seller-1"],
+            productIds: [],
             baseURL: mockBaseURL,
             productHandles: [],
-            queryVariables: {
-                appId: undefined,
-                country: "US",
-            },
+            queryVariables: { appId: undefined, country: "US" },
             mock: false,
         });
+        // skip must short-circuit before any Nosto request and before any
+        // bestSellers fallback resolves — the empty-productIds call above always
+        // matches on first render, so these guard against a broken skip.
+        expect(global.fetch).not.toHaveBeenCalled();
+        expect(useProducts).not.toHaveBeenCalledWith(expect.objectContaining({ productIds: ["best-seller-1"] }));
     }));
-    it("should return an empty array if skip is true", () => __awaiter(void 0, void 0, void 0, function* () {
-        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "", "US", NostoRecommendationsType.BEST_SELLERS, undefined, true));
-        // Initial state check
+    it("ignores an expired session and falls back without minting a new one", () => __awaiter(void 0, void 0, void 0, function* () {
+        const staleSession = {
+            sessionId: "stale-session",
+            lastSessionEventTimestamp: Date.now() - 60 * 60 * 1000, // 1h ago
+        };
+        const { result } = renderHook(() => useNostoRecommendations(mockIntegrations, mockBaseURL, "mockSlotId", "US", undefined, undefined, undefined, undefined, undefined, staleSession));
         expect(result.current.isLoading).toBe(true);
-        // Wait for all promises with act
-        yield act(() => __awaiter(void 0, void 0, void 0, function* () {
-            yield new Promise((resolve) => setTimeout(resolve, 0));
-        }));
-        // Check final state
+        yield flush();
         expect(result.current.isLoading).toBe(false);
+        // Expired session is dropped by the hook -> null sessionId -> bestSellers.
         expect(useProducts).toHaveBeenCalledWith({
-            productIds: [],
+            productIds: ["best-seller-1"],
             baseURL: mockBaseURL,
             productHandles: [],
-            queryVariables: {
-                appId: undefined,
-                country: "US",
-            },
+            queryVariables: { appId: undefined, country: "US" },
             mock: false,
         });
     }));

package/dist/components/hooks/use-order-details.d.ts

@@ -9,6 +9,29 @@ type UseOrderDetailsProps = {
 type UseProductsReturn = {
     orderDetails: Record<string, any>;
 };
+/**
+ * Effective (post-edit) quantity for an order line item, correct across BOTH
+ * Shopify order APIs the app consumes:
+ *
+ *  - Storefront API exposes `currentQuantity` (ordered minus removed); it is 0
+ *    for a line removed via Order Editing. Authoritative when present.
+ *  - New Customer Account API has NO `currentQuantity`. There the only
+ *    per-line signal is `refundableQuantity` (= quantity − refunded), which is
+ *    also driven down to the post-edit count by an Order Editing removal
+ *    (verified against real prod data: a removed line has refundableQuantity 0
+ *    with no refund record). We trust it ONLY when the order was `edited` AND
+ *    has no refund activity — because a refund/return ALSO lowers
+ *    `refundableQuantity`, and `edited` is sticky, so on an edited-then-refunded
+ *    order we cannot tell an edit-removal from a return. In that case we fall
+ *    back to the ordered `quantity` (show the item) rather than risk hiding a
+ *    line the customer actually bought / returned, or blanking a fully-refunded
+ *    order. Trade-off: an item removed via an edit that DID issue a refund is
+ *    not hidden (needs a per-line signal the API doesn't expose).
+ *
+ * Exported so blocks (PurchaseOverview, OrderHistory, OrderStatus) that build
+ * their own order objects from raw `customer.orders` share one implementation.
+ */
+export declare const getEffectiveLineQuantity: (order: Record<string, any>, lineItem: Record<string, any>) => number;
 export declare const transformOrderDetails: (order: Record<string, any>) => {
     orderDetails: Record<string, any>;
     checkoutData: Record<string, any>;

package/dist/components/hooks/use-order-details.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"use-order-details.d.ts","sourceRoot":"","sources":["../../../components/hooks/use-order-details.ts"],"names":[],"mappings":"AAKA,KAAK,oBAAoB,GAAG;IAC1B,SAAS,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAA;IAC9B,MAAM,EAAE,MAAM,CAAA;IACd,KAAK,EAAE,MAAM,CAAA;IACb,QAAQ,EAAE,MAAM,CAAA;IAChB,OAAO,EAAE,MAAM,CAAA;IACf,IAAI,CAAC,EAAE,OAAO,CAAA;CACf,CAAA;AAED,KAAK,iBAAiB,GAAG;IACvB,YAAY,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAA;CAClC,CAAA;AA0LD,eAAO,MAAM,qBAAqB,UACzB,OAAO,MAAM,EAAE,GAAG,CAAC;kBACT,OAAO,MAAM,EAAE,GAAG,CAAC;kBAAgB,OAAO,MAAM,EAAE,GAAG,CAAC;CAmOxE,CAAA;AAED,wBAAgB,eAAe,CAAC,EAC9B,SAAS,EACT,MAAM,EACN,KAAK,EACL,QAAQ,EACR,OAAO,EACP,IAAY,GACb,EAAE,oBAAoB,GAAG,iBAAiB,CAiE1C"}
+{"version":3,"file":"use-order-details.d.ts","sourceRoot":"","sources":["../../../components/hooks/use-order-details.ts"],"names":[],"mappings":"AAKA,KAAK,oBAAoB,GAAG;IAC1B,SAAS,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAA;IAC9B,MAAM,EAAE,MAAM,CAAA;IACd,KAAK,EAAE,MAAM,CAAA;IACb,QAAQ,EAAE,MAAM,CAAA;IAChB,OAAO,EAAE,MAAM,CAAA;IACf,IAAI,CAAC,EAAE,OAAO,CAAA;CACf,CAAA;AAED,KAAK,iBAAiB,GAAG;IACvB,YAAY,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAA;CAClC,CAAA;AAwMD;;;;;;;;;;;;;;;;;;;;;GAqBG;AACH,eAAO,MAAM,wBAAwB,UAC5B,OAAO,MAAM,EAAE,GAAG,CAAC,YAChB,OAAO,MAAM,EAAE,GAAG,CAAC,KAC5B,MAUF,CAAA;AAED,eAAO,MAAM,qBAAqB,UACzB,OAAO,MAAM,EAAE,GAAG,CAAC;kBACT,OAAO,MAAM,EAAE,GAAG,CAAC;kBAAgB,OAAO,MAAM,EAAE,GAAG,CAAC;CAoOxE,CAAA;AAED,wBAAgB,eAAe,CAAC,EAC9B,SAAS,EACT,MAAM,EACN,KAAK,EACL,QAAQ,EACR,OAAO,EACP,IAAY,GACb,EAAE,oBAAoB,GAAG,iBAAiB,CAiE1C"}

package/dist/components/hooks/use-order-details.js

@@ -138,6 +138,54 @@ const updateLineDetails = (line, product) => {
     line.sellingPlan = (_k = (_j = product.sellingPlanAllocation) === null || _j === void 0 ? void 0 : _j.sellingPlan) === null || _k === void 0 ? void 0 : _k.name;
     line.variantName = (_l = product.variant) === null || _l === void 0 ? void 0 : _l.title;
 };
+/**
+ * True when an order has any refund/return activity. Used to keep the
+ * Customer-Account-API `refundableQuantity` heuristic (below) away from orders
+ * whose `refundableQuantity` was lowered by a refund rather than an order edit.
+ */
+const hasRefundActivity = (order) => {
+    var _a, _b, _c;
+    if (Array.isArray(order === null || order === void 0 ? void 0 : order.refunds) && order.refunds.length > 0)
+        return true;
+    const refunded = (_c = (_b = (_a = order === null || order === void 0 ? void 0 : order.totalRefunded) === null || _a === void 0 ? void 0 : _a.amount) !== null && _b !== void 0 ? _b : order === null || order === void 0 ? void 0 : order.totalRefunded) !== null && _c !== void 0 ? _c : order === null || order === void 0 ? void 0 : order.totalRefund;
+    if (refunded != null && parseFloat(String(refunded)) > 0)
+        return true;
+    const status = String((order === null || order === void 0 ? void 0 : order.financialStatus) || "").toUpperCase();
+    return status.includes("REFUND"); // REFUNDED / PARTIALLY_REFUNDED
+};
+/**
+ * Effective (post-edit) quantity for an order line item, correct across BOTH
+ * Shopify order APIs the app consumes:
+ *
+ *  - Storefront API exposes `currentQuantity` (ordered minus removed); it is 0
+ *    for a line removed via Order Editing. Authoritative when present.
+ *  - New Customer Account API has NO `currentQuantity`. There the only
+ *    per-line signal is `refundableQuantity` (= quantity − refunded), which is
+ *    also driven down to the post-edit count by an Order Editing removal
+ *    (verified against real prod data: a removed line has refundableQuantity 0
+ *    with no refund record). We trust it ONLY when the order was `edited` AND
+ *    has no refund activity — because a refund/return ALSO lowers
+ *    `refundableQuantity`, and `edited` is sticky, so on an edited-then-refunded
+ *    order we cannot tell an edit-removal from a return. In that case we fall
+ *    back to the ordered `quantity` (show the item) rather than risk hiding a
+ *    line the customer actually bought / returned, or blanking a fully-refunded
+ *    order. Trade-off: an item removed via an edit that DID issue a refund is
+ *    not hidden (needs a per-line signal the API doesn't expose).
+ *
+ * Exported so blocks (PurchaseOverview, OrderHistory, OrderStatus) that build
+ * their own order objects from raw `customer.orders` share one implementation.
+ */
+export const getEffectiveLineQuantity = (order, lineItem) => {
+    var _a;
+    if (lineItem.currentQuantity != null)
+        return lineItem.currentQuantity;
+    if ((order === null || order === void 0 ? void 0 : order.edited) === true &&
+        lineItem.refundableQuantity != null &&
+        !hasRefundActivity(order)) {
+        return lineItem.refundableQuantity;
+    }
+    return (_a = lineItem.quantity) !== null && _a !== void 0 ? _a : 1;
+};
 export const transformOrderDetails = (order) => {
     var _a;
     // Helper function to safely parse amounts
@@ -148,12 +196,12 @@ export const transformOrderDetails = (order) => {
             return parseFloat(amount) || 0;
         return 0;
     };
-    // Shopify Order Editing sets currentQuantity to 0 for removed/refunded
-    // line items — those must not be shown to the customer
-    const activeLineItems = (order.lineItems || []).filter((lineItem) => { var _a, _b; return ((_b = (_a = lineItem.currentQuantity) !== null && _a !== void 0 ? _a : lineItem.quantity) !== null && _b !== void 0 ? _b : 1) > 0; });
+    const effectiveQuantity = (lineItem) => getEffectiveLineQuantity(order, lineItem);
+    // Line items removed via Order Editing must not be shown to the customer
+    const activeLineItems = (order.lineItems || []).filter((lineItem) => effectiveQuantity(lineItem) > 0);
     // Transform line items to cart lines
     const cartLines = activeLineItems.map((lineItem) => {
-        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p;
         const variant = lineItem.variant || {};
         const product = variant.product || {};
         return {
@@ -188,13 +236,13 @@ export const transformOrderDetails = (order) => {
             productId: ((_k = variant.product) === null || _k === void 0 ? void 0 : _k.id) || lineItem.productId,
             merchandiseId: variant.id || lineItem.merchandiseId,
             title: lineItem.title || product.title || "Unknown Product",
-            quantity: (_m = (_l = lineItem.currentQuantity) !== null && _l !== void 0 ? _l : lineItem.quantity) !== null && _m !== void 0 ? _m : 1,
+            quantity: effectiveQuantity(lineItem),
             uniqueId: crypto.randomUUID(),
             vendor: product.vendor || lineItem.vendor || "Unknown",
             compareAtPrice: {
-                amount: parseAmount(((_o = lineItem.originalTotalPrice) === null || _o === void 0 ? void 0 : _o.amount) || ((_p = lineItem.compareAtPrice) === null || _p === void 0 ? void 0 : _p.amount)),
-                currencyCode: ((_q = lineItem.originalTotalPrice) === null || _q === void 0 ? void 0 : _q.currencyCode) ||
-                    ((_r = lineItem.compareAtPrice) === null || _r === void 0 ? void 0 : _r.currencyCode) ||
+                amount: parseAmount(((_l = lineItem.originalTotalPrice) === null || _l === void 0 ? void 0 : _l.amount) || ((_m = lineItem.compareAtPrice) === null || _m === void 0 ? void 0 : _m.amount)),
+                currencyCode: ((_o = lineItem.originalTotalPrice) === null || _o === void 0 ? void 0 : _o.currencyCode) ||
+                    ((_p = lineItem.compareAtPrice) === null || _p === void 0 ? void 0 : _p.currencyCode) ||
                     order.currency ||
                     "USD",
             },
@@ -265,7 +313,7 @@ export const transformOrderDetails = (order) => {
         })),
         subtotalPrice: wrapMoney(subtotal, currencyCode),
         lineItems: activeLineItems.map((lineItem) => {
-            var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t, _u, _v;
+            var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t;
             const variant = lineItem.variant || {};
             const product = variant.product || {};
             const currencyCode = ((_a = lineItem.discountedTotalPrice) === null || _a === void 0 ? void 0 : _a.currencyCode) ||
@@ -315,9 +363,9 @@ export const transformOrderDetails = (order) => {
                         discountApplication: allocation.discountApplication || {},
                     });
                 }),
-                quantity: (_t = (_s = lineItem.currentQuantity) !== null && _s !== void 0 ? _s : lineItem.quantity) !== null && _t !== void 0 ? _t : 1,
+                quantity: effectiveQuantity(lineItem),
                 title: lineItem.title || product.title,
-                id: ((_u = variant.id) === null || _u === void 0 ? void 0 : _u.split("/").pop()) || ((_v = lineItem.variantId) === null || _v === void 0 ? void 0 : _v.split("/").pop()),
+                id: ((_s = variant.id) === null || _s === void 0 ? void 0 : _s.split("/").pop()) || ((_t = lineItem.variantId) === null || _t === void 0 ? void 0 : _t.split("/").pop()),
             };
         }),
         totalPrice: wrapMoney(total, currencyCode),