@tanstack/table-core 9.0.0-alpha.46 → 9.0.0-alpha.47

package/src/features/row-sorting/createSortedRowModel.ts

@@ -79,16 +79,11 @@ function _createSortedRowModel<
   })
 
   const sortData = (rows: Array<Row<TFeatures, TData>>) => {
-    // This will also perform a stable sorting using the row index
-    // if needed.
-    // Preserve prototype chain so methods like getValue() remain accessible
-    const sortedData = rows.map((row) => {
-      const cloned = Object.create(Object.getPrototypeOf(row))
-      return Object.assign(cloned, row)
-    })
+    const sortedData = rows.slice()
 
     sortedData.sort((rowA, rowB) => {
-      for (const sortEntry of availableSorting) {
+      for (let i = 0; i < availableSorting.length; i++) {
+        const sortEntry = availableSorting[i]!
         const columnInfo = columnInfoById[sortEntry.id]!
         const sortUndefined = columnInfo.sortUndefined
         const isDesc = sortEntry.desc
@@ -135,13 +130,21 @@ function _createSortedRowModel<
       return rowA.index - rowB.index
     })
 
-    // If there are sub-rows, sort them
-    sortedData.forEach((row) => {
-      sortedFlatRows.push(row)
+    // If there are sub-rows, sort them. Clone only rows that need mutation
+    // (i.e. have subRows) so we don't corrupt the source row model.
+    for (let i = 0; i < sortedData.length; i++) {
+      const row = sortedData[i]!
       if (row.subRows.length) {
-        row.subRows = sortData(row.subRows)
+        // Preserve prototype chain so methods like getValue() remain accessible
+        const cloned = Object.create(Object.getPrototypeOf(row))
+        Object.assign(cloned, row)
+        cloned.subRows = sortData(row.subRows)
+        sortedData[i] = cloned
+        sortedFlatRows.push(cloned)
+      } else {
+        sortedFlatRows.push(row)
       }
-    })
+    }
 
     return sortedData
   }

package/src/features/row-sorting/rowSortingFeature.utils.ts

@@ -90,8 +90,8 @@ export function column_getAutoSortFn<
 
   let isString = false
 
-  for (const row of firstRows) {
-    const value = row.getValue(column.id)
+  for (let i = 0; i < firstRows.length; i++) {
+    const value = firstRows[i]!.getValue(column.id)
 
     if (Object.prototype.toString.call(value) === '[object Date]') {
       sortFn = sortFns?.datetime

package/src/fns/aggregationFns.ts

@@ -1,4 +1,3 @@
-import { isNumberArray } from '../utils'
 import type { RowData } from '../types/type-utils'
 import type { TableFeatures } from '../types/TableFeatures'
 import type { Row } from '../types/Row'
@@ -153,17 +152,22 @@ export const aggregationFn_median: AggregationFn<any, any> = <
     return
   }
 
-  const values = leafRows.map((row) => row.getValue(columnId))
-  if (!isNumberArray(values)) {
-    return
+  const values: Array<number> = new Array(leafRows.length)
+  for (let i = 0; i < leafRows.length; i++) {
+    const v = leafRows[i]!.getValue(columnId)
+    if (typeof v !== 'number') return
+    values[i] = v
   }
+
   if (values.length === 1) {
     return values[0]
   }
 
   const mid = Math.floor(values.length / 2)
-  const nums = values.sort((a, b) => a - b)
-  return values.length % 2 !== 0 ? nums[mid] : (nums[mid - 1]! + nums[mid]!) / 2
+  values.sort((a, b) => a - b)
+  return values.length % 2 !== 0
+    ? values[mid]
+    : (values[mid - 1]! + values[mid]!) / 2
 }
 
 /**
@@ -176,7 +180,11 @@ export const aggregationFn_unique: AggregationFn<any, any> = <
   columnId: string,
   leafRows: Array<Row<any, any>>,
 ) => {
-  return Array.from(new Set(leafRows.map((d) => d.getValue(columnId))).values())
+  const set = new Set<unknown>()
+  for (let i = 0; i < leafRows.length; i++) {
+    set.add(leafRows[i]!.getValue(columnId))
+  }
+  return Array.from(set.values())
 }
 
 /**
@@ -189,7 +197,11 @@ export const aggregationFn_uniqueCount: AggregationFn<any, any> = <
   columnId: string,
   leafRows: Array<Row<any, any>>,
 ) => {
-  return new Set(leafRows.map((d) => d.getValue(columnId))).size
+  const set = new Set<unknown>()
+  for (let i = 0; i < leafRows.length; i++) {
+    set.add(leafRows[i]!.getValue(columnId))
+  }
+  return set.size
 }
 
 /**

package/src/store-reactivity-bindings.ts

@@ -20,6 +20,7 @@ export function storeReactivityBindings(): TableReactivityBindings {
   return {
     createOptionsStore: true,
     batch,
+    schedule: (fn) => queueMicrotask(fn),
     untrack: (fn) => fn(),
     createReadonlyAtom: (fn, options) => {
       return createAtom(() => fn(), {

package/src/utils.ts

@@ -32,8 +32,10 @@ export function cloneState<T>(value: T): T {
     }
 
     const copy: Record<string, unknown> = {}
+    const keys = Object.keys(value)
 
-    for (const key of Object.keys(value)) {
+    for (let i = 0; i < keys.length; i++) {
+      const key = keys[i]!
       copy[key] = cloneState((value as Record<string, unknown>)[key])
     }
 
@@ -43,11 +45,6 @@ export function cloneState<T>(value: T): T {
   return value
 }
 
-/**
- * A no-operation function used as a safe default callback.
- */
-export function noop() {}
-
 /**
  * Creates a table state updater for a single state slice.
  *
@@ -73,13 +70,6 @@ export function isFunction<T extends AnyFunction>(d: any): d is T {
   return d instanceof Function
 }
 
-/**
- * Returns whether a value is an array containing only numbers.
- */
-export function isNumberArray(d: any): d is Array<number> {
-  return Array.isArray(d) && d.every((val) => typeof val === 'number')
-}
-
 /**
  * Flattens a tree of nodes by recursively reading child nodes.
  *
@@ -106,29 +96,6 @@ export function flattenBy<TNode>(
   return flat
 }
 
-/**
- * Symbol used to attach internal memo metadata to wrapped functions.
- *
- * This is exported so diagnostics can recognize memoized functions without
- * depending on a string property name.
- */
-export const $internalMemoFnMeta = Symbol('memoFnMeta')
-export type MemoFnMeta = { originalArgsLength?: number }
-
-/**
- * @internal
- */
-function setMemoFnMeta(fn: Function, meta: MemoFnMeta) {
-  Object.defineProperty(fn, $internalMemoFnMeta, { value: meta })
-}
-
-/**
- * @internal
- */
-export function getMemoFnMeta(fn: any): MemoFnMeta | null {
-  return (typeof fn === 'function' && fn[$internalMemoFnMeta]) ?? null
-}
-
 interface MemoOptions<TDeps extends ReadonlyArray<any>, TDepArgs, TResult> {
   fn: (...args: NoInfer<TDeps>) => TResult
   memoDeps?: (depArgs?: TDepArgs) => [...TDeps] | undefined
@@ -159,10 +126,15 @@ export const memo = <TDeps extends ReadonlyArray<any>, TDepArgs, TResult>({
   const memoizedFn = (depArgs?: TDepArgs): TResult => {
     onBeforeCompare?.()
     const newDeps = memoDeps?.(depArgs)
-    const depsChanged =
-      !newDeps ||
-      newDeps.length !== deps?.length ||
-      newDeps.some((dep: any, index: number) => deps?.[index] !== dep)
+    let depsChanged = !newDeps || newDeps.length !== deps?.length
+    if (!depsChanged && newDeps) {
+      for (let i = 0; i < newDeps.length; i++) {
+        if (newDeps[i] !== deps![i]) {
+          depsChanged = true
+          break
+        }
+      }
+    }
     onAfterCompare?.(depsChanged)
 
     if (!depsChanged) {
@@ -178,8 +150,6 @@ export const memo = <TDeps extends ReadonlyArray<any>, TDepArgs, TResult>({
     return result
   }
 
-  setMemoFnMeta(memoizedFn, { originalArgsLength: fn.length })
-
   return memoizedFn
 }
 
@@ -283,6 +253,11 @@ export function tableMemo<
     console.groupEnd()
   }
 
+  const onAfterUpdateHandler = () => {
+    const { schedule, untrack } = table._reactivity
+    schedule(() => untrack(() => onAfterUpdate?.()))
+  }
+
   const debugOptions =
     process.env.NODE_ENV === 'development'
       ? {
@@ -313,12 +288,12 @@ export function tableMemo<
                 Math.round((endCalcTime - startCalcTime) * 100) / 100
               logTime(executionTime, true)
             }
-            queueMicrotask(() => onAfterUpdate?.())
+            onAfterUpdateHandler()
           },
         }
       : {
           onAfterUpdate: () => {
-            queueMicrotask(() => onAfterUpdate?.())
+            onAfterUpdateHandler()
           },
         }
 
@@ -440,8 +415,6 @@ export function assignPrototypeAPIs<
         return fn(this, ...args)
       }
     }
-
-    setMemoFnMeta(prototype[fnKey], { originalArgsLength: fn.length })
   }
 }