@tanstack/table-core 8.19.2 → 8.19.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tanstack/table-core",
-  "version": "8.19.2",
+  "version": "8.19.4",
   "description": "Headless UI for building powerful tables & datagrids for TS/JS.",
   "author": "Tanner Linsley",
   "license": "MIT",

package/src/utils/getFacetedMinMaxValues.ts

@@ -11,31 +11,22 @@ export function getFacetedMinMaxValues<TData extends RowData>(): (
       facetedRowModel => {
         if (!facetedRowModel) return undefined
 
-        const firstValue =
-          facetedRowModel.flatRows[0]?.getUniqueValues(columnId)
+        const uniqueValues = facetedRowModel.flatRows
+          .flatMap(flatRow => flatRow.getUniqueValues(columnId) ?? [])
+          .map(Number)
+          .filter(value => !Number.isNaN(value))
 
-        if (typeof firstValue === 'undefined') {
-          return undefined
-        }
-
-        let facetedMinMaxValues: [any, any] = [firstValue, firstValue]
-
-        for (let i = 0; i < facetedRowModel.flatRows.length; i++) {
-          const values =
-            facetedRowModel.flatRows[i]!.getUniqueValues<number>(columnId)
+        if (!uniqueValues.length) return
 
-          for (let j = 0; j < values.length; j++) {
-            const value = values[j]!
+        let facetedMinValue = uniqueValues[0]!
+        let facetedMaxValue = uniqueValues[uniqueValues.length - 1]!
 
-            if (value < facetedMinMaxValues[0]) {
-              facetedMinMaxValues[0] = value
-            } else if (value > facetedMinMaxValues[1]) {
-              facetedMinMaxValues[1] = value
-            }
-          }
+        for (const value of uniqueValues) {
+          if (value < facetedMinValue) facetedMinValue = value
+          else if (value > facetedMaxValue) facetedMaxValue = value
         }
 
-        return facetedMinMaxValues
+        return [facetedMinValue, facetedMaxValue]
       },
       getMemoOptions(table.options, 'debugTable', 'getFacetedMinMaxValues')
     )

package/src/utils/getGroupedRowModel.ts

@@ -1,6 +1,7 @@
 import { createRow } from '../core/row'
-import { Table, Row, RowModel, RowData } from '../types'
+import { Row, RowData, RowModel, Table } from '../types'
 import { flattenBy, getMemoOptions, memo } from '../utils'
+import { GroupingState } from '../features/ColumnGrouping'
 
 export function getGroupedRowModel<TData extends RowData>(): (
   table: Table<TData>
@@ -10,6 +11,10 @@ export function getGroupedRowModel<TData extends RowData>(): (
       () => [table.getState().grouping, table.getPreGroupedRowModel()],
       (grouping, rowModel) => {
         if (!rowModel.rows.length || !grouping.length) {
+          rowModel.rows.forEach(row => {
+            row.depth = 0
+            row.parentId = undefined
+          })
           return rowModel
         }
 
@@ -53,7 +58,7 @@ export function getGroupedRowModel<TData extends RowData>(): (
           // Group the rows together for this level
           const rowGroupsMap = groupBy(rows, columnId)
 
-          // Peform aggregations for each group
+          // Perform aggregations for each group
           const aggregatedGroupedRows = Array.from(rowGroupsMap.entries()).map(
             ([groupingValue, groupedRows], index) => {
               let id = `${columnId}:${groupingValue}`
@@ -62,6 +67,10 @@ export function getGroupedRowModel<TData extends RowData>(): (
               // First, Recurse to group sub rows before aggregation
               const subRows = groupUpRecursively(groupedRows, depth + 1, id)
 
+              subRows.forEach(subRow => {
+                subRow.parentId = id
+              })
+
               // Flatten the leaf rows of the rows in this group
               const leafRows = depth
                 ? flattenBy(groupedRows, row => row.subRows)