@tanstack/table-core 8.15.2 → 8.16.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tanstack/table-core",
-  "version": "8.15.2",
+  "version": "8.16.0",
   "description": "Headless UI for building powerful tables & datagrids for TS/JS.",
   "author": "Tanner Linsley",
   "license": "MIT",

package/src/features/ColumnGrouping.ts

@@ -283,11 +283,9 @@ export const ColumnGrouping: TableFeature = {
 
     column.getCanGroup = () => {
       return (
-        column.columnDef.enableGrouping ??
-        true ??
-        table.options.enableGrouping ??
-        true ??
-        !!column.accessorFn
+        (column.columnDef.enableGrouping ?? true) &&
+        (table.options.enableGrouping ?? true) &&
+        (!!column.accessorFn || !!column.columnDef.getGroupingValue)
       )
     }
 

package/src/features/RowSorting.ts

@@ -90,7 +90,7 @@ export interface SortingColumnDef<TData extends RowData> {
    * @link [API Docs](https://tanstack.com/table/v8/docs/api/features/sorting#sortundefined)
    * @link [Guide](https://tanstack.com/table/v8/docs/guide/sorting)
    */
-  sortUndefined?: false | -1 | 1
+  sortUndefined?: false | -1 | 1 | 'first' | 'last'
 }
 
 export interface SortingColumn<TData extends RowData> {

package/src/utils/getSortedRowModel.ts

@@ -25,7 +25,7 @@ export function getSortedRowModel<TData extends RowData>(): (
         const columnInfoById: Record<
           string,
           {
-            sortUndefined?: false | -1 | 1
+            sortUndefined?: false | -1 | 1 | 'first' | 'last'
             invertSorting?: boolean
             sortingFn: SortingFn<TData>
           }
@@ -51,12 +51,13 @@ export function getSortedRowModel<TData extends RowData>(): (
             for (let i = 0; i < availableSorting.length; i += 1) {
               const sortEntry = availableSorting[i]!
               const columnInfo = columnInfoById[sortEntry.id]!
+              const sortUndefined = columnInfo.sortUndefined
               const isDesc = sortEntry?.desc ?? false
 
               let sortInt = 0
 
               // All sorting ints should always return in ascending order
-              if (columnInfo.sortUndefined) {
+              if (sortUndefined) {
                 const aValue = rowA.getValue(sortEntry.id)
                 const bValue = rowB.getValue(sortEntry.id)
 
@@ -64,12 +65,14 @@ export function getSortedRowModel<TData extends RowData>(): (
                 const bUndefined = bValue === undefined
 
                 if (aUndefined || bUndefined) {
+                  if (sortUndefined === 'first') return aUndefined ? -1 : 1
+                  if (sortUndefined === 'last') return aUndefined ? 1 : -1
                   sortInt =
                     aUndefined && bUndefined
                       ? 0
                       : aUndefined
-                        ? columnInfo.sortUndefined
-                        : -columnInfo.sortUndefined
+                        ? sortUndefined
+                        : -sortUndefined
                 }
               }