@tanstack/table-core 8.0.0-alpha.87 → 8.0.0-alpha.88

package/package.json

@@ -1,13 +1,13 @@
 {
   "name": "@tanstack/table-core",
   "author": "Tanner Linsley",
-  "version": "8.0.0-alpha.87",
-  "description": "Hooks for building lightweight, fast and extendable datagrids for React",
+  "version": "8.0.0-alpha.88",
+  "description": "Headless UI for building powerful tables & datagrids for TS/JS.",
   "license": "MIT",
-  "homepage": "https://github.com/tanstack/react-table#readme",
+  "homepage": "https://github.com/tanstack/table#readme",
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/tanstack/react-table.git"
+    "url": "git+https://github.com/tanstack/table.git"
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"

package/src/core/cell.ts

@@ -19,8 +19,8 @@ export function createCell<TGenerics extends TableGenerics>(
     row,
     column,
     getValue: () => row.getValue(columnId),
-    renderCell: () =>
-      column.columnDef.cell
+    renderCell: () => {
+      return column.columnDef.cell
         ? instance._render(column.columnDef.cell, {
             instance,
             column,
@@ -28,7 +28,8 @@ export function createCell<TGenerics extends TableGenerics>(
             cell: cell as Cell<TGenerics>,
             getValue: cell.getValue,
           })
-        : null,
+        : null
+    },
   }
 
   instance._features.forEach(feature => {

package/src/core/column.ts

@@ -98,7 +98,6 @@ export function createColumn<TGenerics extends TableGenerics>(
   }
 
   let column: CoreColumn<TGenerics> = {
-    ...columnDef,
     id: `${id}`,
     accessorFn,
     parent: parent as any,

package/src/features/Expanding.ts

@@ -131,8 +131,12 @@ export const Expanding: TableFeature = {
         const expanded = instance.getState().expanded
 
         // If expanded is true, save some cycles and return true
-        if (expanded === true) {
-          return true
+        if (typeof expanded === 'boolean') {
+          return expanded === true
+        }
+
+        if (!Object.keys(expanded).length) {
+          return false
         }
 
         // If any row is not expanded, return false

package/src/features/Visibility.ts

@@ -112,15 +112,9 @@ export const Visibility: TableFeature = {
   ): VisibilityRow<TGenerics> => {
     return {
       _getAllVisibleCells: memo(
-        () => [
-          row
-            .getAllCells()
-            .filter(cell => cell.column.getIsVisible())
-            .map(d => d.id)
-            .join('_'),
-        ],
-        _ => {
-          return row.getAllCells().filter(cell => cell.column.getIsVisible())
+        () => [row.getAllCells(), instance.getState().columnVisibility],
+        cells => {
+          return cells.filter(cell => cell.column.getIsVisible())
         },
         {
           key:

package/src/index.ts

@@ -5,7 +5,6 @@ export * from './core/column'
 export * from './core/headers'
 export * from './core/row'
 export * from './features/ColumnSizing'
-export * from './features/ColumnSizing'
 export * from './features/Expanding'
 export * from './features/Filters'
 export * from './features/Grouping'
@@ -15,7 +14,6 @@ export * from './features/Pinning'
 export * from './features/RowSelection'
 export * from './features/Sorting'
 export * from './features/Visibility'
-export * from './features/Expanding'
 export * from './filterFns'
 export * from './sortingFns'
 export * from './aggregationFns'

package/src/utils/getCoreRowModel.ts

@@ -21,20 +21,14 @@ export function getCoreRowModel<TGenerics extends TableGenerics>(): (
           rowsById: {},
         }
 
-        let rows
-        let row
-        let originalRow
-
         const accessRows = (
           originalRows: TGenerics['Row'][],
           depth = 0,
           parent?: Row<TGenerics>
         ): Row<TGenerics>[] => {
-          rows = []
+          const rows = [] as Row<TGenerics>[]
 
           for (let i = 0; i < originalRows.length; i++) {
-            originalRow = originalRows[i]
-
             // This could be an expensive check at scale, so we should move it somewhere else, but where?
             // if (!id) {
             //   if (process.env.NODE_ENV !== 'production') {
@@ -43,10 +37,10 @@ export function getCoreRowModel<TGenerics extends TableGenerics>(): (
             // }
 
             // Make the row
-            row = createRow(
+            const row = createRow(
               instance,
-              instance._getRowId(originalRow, i, parent),
-              originalRow,
+              instance._getRowId(originalRows[i], i, parent),
+              originalRows[i],
               i,
               depth
             )
@@ -60,7 +54,10 @@ export function getCoreRowModel<TGenerics extends TableGenerics>(): (
 
             // Get the original subrows
             if (instance.options.getSubRows) {
-              row.originalSubRows = instance.options.getSubRows(originalRow, i)
+              row.originalSubRows = instance.options.getSubRows(
+                originalRows[i],
+                i
+              )
 
               // Then recursively access them
               if (row.originalSubRows?.length) {