@tanstack/table-core 8.0.0-alpha.64 → 8.0.0-alpha.65

package/src/features/Pagination.ts

@@ -184,7 +184,7 @@ export const Pagination: TableFeature = {
           return pageOptions
         },
         {
-          key: 'getPageOptions',
+          key: process.env.NODE_ENV === 'production' && 'getPageOptions',
           debug: () => instance.options.debugAll ?? instance.options.debugTable,
         }
       ),

package/src/features/Pinning.ts

@@ -110,7 +110,9 @@ export const Pinning: TableFeature = {
           return allCells.filter(d => !leftAndRight.includes(d.columnId))
         },
         {
-          key: 'row.getCenterVisibleCells',
+          key:
+            process.env.NODE_ENV === 'production' &&
+            'row.getCenterVisibleCells',
           debug: () => instance.options.debugAll ?? instance.options.debugRows,
         }
       ),
@@ -129,7 +131,8 @@ export const Pinning: TableFeature = {
           return cells
         },
         {
-          key: 'row.getLeftVisibleCells',
+          key:
+            process.env.NODE_ENV === 'production' && 'row.getLeftVisibleCells',
           debug: () => instance.options.debugAll ?? instance.options.debugRows,
         }
       ),
@@ -147,7 +150,8 @@ export const Pinning: TableFeature = {
           return cells
         },
         {
-          key: 'row.getRightVisibleCells',
+          key:
+            process.env.NODE_ENV === 'production' && 'row.getRightVisibleCells',
           debug: () => instance.options.debugAll ?? instance.options.debugRows,
         }
       ),
@@ -259,7 +263,7 @@ export const Pinning: TableFeature = {
             .filter(Boolean)
         },
         {
-          key: 'getLeftLeafColumns',
+          key: process.env.NODE_ENV === 'production' && 'getLeftLeafColumns',
           debug: () =>
             instance.options.debugAll ?? instance.options.debugColumns,
         }
@@ -276,7 +280,7 @@ export const Pinning: TableFeature = {
             .filter(Boolean)
         },
         {
-          key: 'getRightLeafColumns',
+          key: process.env.NODE_ENV === 'production' && 'getRightLeafColumns',
           debug: () =>
             instance.options.debugAll ?? instance.options.debugColumns,
         }
@@ -294,7 +298,7 @@ export const Pinning: TableFeature = {
           return allColumns.filter(d => !leftAndRight.includes(d.id))
         },
         {
-          key: 'getCenterLeafColumns',
+          key: process.env.NODE_ENV === 'production' && 'getCenterLeafColumns',
           debug: () =>
             instance.options.debugAll ?? instance.options.debugColumns,
         }

package/src/features/RowSelection.ts

@@ -239,7 +239,7 @@ export const RowSelection: TableFeature = {
           return selectRowsFn(instance, rowModel)
         },
         {
-          key: 'getSelectedRowModel',
+          key: process.env.NODE_ENV === 'production' && 'getSelectedRowModel',
           debug: () => instance.options.debugAll ?? instance.options.debugTable,
         }
       ),
@@ -247,7 +247,7 @@ export const RowSelection: TableFeature = {
       getFilteredSelectedRowModel: memo(
         () => [
           instance.getState().rowSelection,
-          instance.getGlobalFilteredRowModel(),
+          instance.getFilteredRowModel(),
         ],
         (rowSelection, rowModel) => {
           if (!Object.keys(rowSelection).length) {
@@ -261,7 +261,9 @@ export const RowSelection: TableFeature = {
           return selectRowsFn(instance, rowModel)
         },
         {
-          key: 'getFilteredSelectedRowModel',
+          key:
+            process.env.NODE_ENV === 'production' &&
+            'getFilteredSelectedRowModel',
           debug: () => instance.options.debugAll ?? instance.options.debugTable,
         }
       ),
@@ -280,7 +282,9 @@ export const RowSelection: TableFeature = {
           return selectRowsFn(instance, rowModel)
         },
         {
-          key: 'getGroupedSelectedRowModel',
+          key:
+            process.env.NODE_ENV === 'production' &&
+            'getGroupedSelectedRowModel',
           debug: () => instance.options.debugAll ?? instance.options.debugTable,
         }
       ),
@@ -366,8 +370,7 @@ export const RowSelection: TableFeature = {
       // },
 
       getIsAllRowsSelected: () => {
-        const preFilteredFlatRows =
-          instance.getPreGlobalFilteredRowModel().flatRows
+        const preFilteredFlatRows = instance.getPreFilteredRowModel().flatRows
         const { rowSelection } = instance.getState()
 
         let isAllRowsSelected = Boolean(

package/src/features/Sorting.ts

@@ -161,9 +161,7 @@ export const Sorting: TableFeature = {
 
     return {
       getColumnAutoSortingFn: columnId => {
-        const firstRows = instance
-          .getGlobalFilteredRowModel()
-          .flatRows.slice(100)
+        const firstRows = instance.getFilteredRowModel().flatRows.slice(100)
 
         let isString = false
 
@@ -190,7 +188,7 @@ export const Sorting: TableFeature = {
         return sortingFns.basic
       },
       getColumnAutoSortDir: columnId => {
-        const firstRow = instance.getGlobalFilteredRowModel().flatRows[0]
+        const firstRow = instance.getFilteredRowModel().flatRows[0]
 
         const value = firstRow?.values[columnId]
 
@@ -399,7 +397,7 @@ export const Sorting: TableFeature = {
         }
       },
 
-      getPreSortedRowModel: () => instance.getGlobalFilteredRowModel(),
+      getPreSortedRowModel: () => instance.getFilteredRowModel(),
       getSortedRowModel: () => {
         if (
           !instance._getSortedRowModel &&

package/src/features/Visibility.ts

@@ -121,7 +121,8 @@ export const Visibility: TableFeature = {
           return row.getAllCells().filter(cell => cell.column.getIsVisible())
         },
         {
-          key: 'row._getAllVisibleCells',
+          key:
+            process.env.NODE_ENV === 'production' && 'row._getAllVisibleCells',
           debug: () => instance.options.debugAll ?? instance.options.debugRows,
         }
       ),
@@ -133,7 +134,7 @@ export const Visibility: TableFeature = {
         ],
         (left, center, right) => [...left, ...center, ...right],
         {
-          key: 'row.getVisibleCells',
+          key: process.env.NODE_ENV === 'production' && 'row.getVisibleCells',
           debug: () => instance.options.debugAll ?? instance.options.debugRows,
         }
       ),

package/src/filterFns.ts

@@ -1,179 +1,95 @@
-import { TableGenerics, Row } from './types'
-
-export const filterFns = {
-  includesString,
-  includesStringSensitive,
-  equalsString,
-  equalsStringSensitive,
-  arrIncludes,
-  arrIncludesAll,
-  arrIncludesSome,
-  equals,
-  weakEquals,
-  betweenNumberRange,
-}
-
-export type BuiltInFilterFn = keyof typeof filterFns
-
-function includesString<TGenerics extends TableGenerics>(
-  rows: Row<TGenerics>[],
-  columnIds: string[],
-  filterValue: unknown
-) {
-  const search = String(filterValue).toLowerCase()
-
-  rows = rows.filter(row => {
-    return columnIds.some(id => {
-      return String(row.values[id]).toLowerCase().includes(search)
-    })
-  })
-  return rows
+import { FilterFn } from './features/Filters'
+
+const includesString: FilterFn<any> = (
+  row,
+  columnId: string,
+  filterValue: string
+) => {
+  const search = filterValue.toLowerCase()
+  return row.values[columnId].toLowerCase().includes(search)
 }
 
 includesString.autoRemove = (val: any) => testFalsey(val)
 
-function includesStringSensitive<TGenerics extends TableGenerics>(
-  rows: Row<TGenerics>[],
-  columnIds: string[],
-  filterValue: unknown
-) {
-  const search = String(filterValue)
-
-  rows = rows.filter(row => {
-    return columnIds.some(id => {
-      return String(row.values[id]).includes(search)
-    })
-  })
-  return rows
+const includesStringSensitive: FilterFn<any> = (
+  row,
+  columnId: string,
+  filterValue: string
+) => {
+  return row.values[columnId].includes(filterValue)
 }
 
 includesStringSensitive.autoRemove = (val: any) => testFalsey(val)
 
-function equalsString<TGenerics extends TableGenerics>(
-  rows: Row<TGenerics>[],
-  columnIds: string[],
-  filterValue: unknown
-) {
-  const search = String(filterValue).toLowerCase()
-
-  return rows.filter(row => {
-    return columnIds.some(id => {
-      const rowValue = row.values[id]
-      return rowValue !== undefined
-        ? String(rowValue).toLowerCase() === search
-        : true
-    })
-  })
+const equalsString: FilterFn<any> = (
+  row,
+  columnId: string,
+  filterValue: string
+) => {
+  return row.values[columnId].toLowerCase() === filterValue.toLowerCase()
 }
 
 equalsString.autoRemove = (val: any) => testFalsey(val)
 
-function equalsStringSensitive<TGenerics extends TableGenerics>(
-  rows: Row<TGenerics>[],
-  columnIds: string[],
+const arrIncludes: FilterFn<any> = (
+  row,
+  columnId: string,
   filterValue: unknown
-) {
-  const search = String(filterValue)
-  return rows.filter(row => {
-    return columnIds.some(id => {
-      const rowValue = row.values[id]
-      return rowValue !== undefined ? String(rowValue) === search : true
-    })
-  })
-}
-
-equalsStringSensitive.autoRemove = (val: any) => testFalsey(val)
-
-function arrIncludes<TGenerics extends TableGenerics>(
-  rows: Row<TGenerics>[],
-  columnIds: string[],
-  filterValue: unknown
-) {
-  return rows.filter(row => {
-    return columnIds.some(id => {
-      const rowValue = row.values[id]
-      return rowValue.includes(filterValue)
-    })
-  })
+) => {
+  return row.values[columnId].includes(filterValue)
 }
 
 arrIncludes.autoRemove = (val: any) => testFalsey(val) || !val?.length
 
-function arrIncludesAll<TGenerics extends TableGenerics>(
-  rows: Row<TGenerics>[],
-  columnIds: string[],
+const arrIncludesAll: FilterFn<any> = (
+  row,
+  columnId: string,
   filterValue: unknown[]
-) {
-  return rows.filter(row => {
-    return columnIds.some(id => {
-      const rowValue = row.values[id]
-      return (
-        rowValue &&
-        rowValue.length &&
-        filterValue.every(val => rowValue.includes(val))
-      )
-    })
-  })
+) => {
+  return !filterValue.some(val => !row.values[columnId].includes(val))
 }
 
 arrIncludesAll.autoRemove = (val: any) => testFalsey(val) || !val?.length
 
-function arrIncludesSome<TGenerics extends TableGenerics>(
-  rows: Row<TGenerics>[],
-  columnIds: string[],
+const arrIncludesSome: FilterFn<any> = (
+  row,
+  columnId: string,
   filterValue: unknown[]
-) {
-  return rows.filter(row => {
-    return columnIds.some(id => {
-      const rowValue = row.values[id]
-      return (
-        rowValue &&
-        rowValue.length &&
-        filterValue.some(val => rowValue.includes(val))
-      )
-    })
-  })
+) => {
+  return filterValue.some(val => row.values[columnId].includes(val))
 }
 
 arrIncludesSome.autoRemove = (val: any) => testFalsey(val) || !val?.length
 
-function equals<TGenerics extends TableGenerics>(
-  rows: Row<TGenerics>[],
-  columnIds: string[],
-  filterValue: unknown
-) {
-  return rows.filter(row => {
-    return columnIds.some(id => {
-      const rowValue = row.values[id]
-      return rowValue === filterValue
-    })
-  })
+const equals: FilterFn<any> = (row, columnId: string, filterValue: unknown) => {
+  return row.values[columnId] === filterValue
 }
 
 equals.autoRemove = (val: any) => testFalsey(val)
 
-function weakEquals<TGenerics extends TableGenerics>(
-  rows: Row<TGenerics>[],
-  columnIds: string[],
+const weakEquals: FilterFn<any> = (
+  row,
+  columnId: string,
   filterValue: unknown
-) {
-  return rows.filter(row => {
-    return columnIds.some(id => {
-      const rowValue = row.values[id]
-      // eslint-disable-next-line eqeqeq
-      return rowValue == filterValue
-    })
-  })
+) => {
+  return row.values[columnId] == filterValue
 }
 
 weakEquals.autoRemove = (val: any) => testFalsey(val)
 
-function betweenNumberRange<TGenerics extends TableGenerics>(
-  rows: Row<TGenerics>[],
-  columnIds: string[],
-  filterValue: [unknown, unknown]
-) {
-  let [unsafeMin, unsafeMax] = filterValue || []
+const inNumberRange: FilterFn<any> = (
+  row,
+  columnId: string,
+  filterValue: [number, number]
+) => {
+  let [min, max] = filterValue
+
+  const rowValue = row.values[columnId]
+  return rowValue >= min && rowValue <= max
+}
+
+inNumberRange.resolveFilterValue = (val: [any, any]) => {
+  let [unsafeMin, unsafeMax] = val
 
   let parsedMin =
     typeof unsafeMin !== 'number' ? parseFloat(unsafeMin as string) : unsafeMin
@@ -190,17 +106,28 @@ function betweenNumberRange<TGenerics extends TableGenerics>(
     max = temp
   }
 
-  return rows.filter(row => {
-    return columnIds.some(id => {
-      const rowValue = row.values[id]
-      return rowValue >= min && rowValue <= max
-    })
-  })
+  return [min, max] as const
 }
 
-betweenNumberRange.autoRemove = (val: any) =>
+inNumberRange.autoRemove = (val: any) =>
   testFalsey(val) || (testFalsey(val[0]) && testFalsey(val[1]))
 
+// Export
+
+export const filterFns = {
+  includesString,
+  includesStringSensitive,
+  equalsString,
+  arrIncludes,
+  arrIncludesAll,
+  arrIncludesSome,
+  equals,
+  weakEquals,
+  inNumberRange,
+}
+
+export type BuiltInFilterFn = keyof typeof filterFns
+
 // Utils
 
 function testFalsey(val: any) {

package/src/index.ts

@@ -17,8 +17,7 @@ export * from './features/Expanding'
 export * from './utils'
 export * from './utils/getCoreRowModelSync'
 export * from './utils/getCoreRowModelAsync'
-export * from './utils/getColumnFilteredRowModelSync'
-export * from './utils/getGlobalFilteredRowModelSync'
+export * from './utils/getFilteredRowModelSync'
 export * from './utils/getSortedRowModelSync'
 export * from './utils/getGroupedRowModel'
 export * from './utils/getExpandedRowModel'

package/src/types.ts

@@ -28,6 +28,7 @@ import {
   FiltersColumnDef,
   FiltersInstance,
   FiltersOptions,
+  FiltersRow,
   FiltersTableState,
 } from './features/Filters'
 import {
@@ -167,6 +168,7 @@ export type Row<TGenerics extends TableGenerics> = CoreRow<TGenerics> &
   CellsRow<TGenerics> &
   VisibilityRow<TGenerics> &
   ColumnPinningRow<TGenerics> &
+  FiltersRow<TGenerics> &
   GroupingRow &
   RowSelectionRow &
   ExpandedRow

package/src/utils/filterRowsUtils.ts

@@ -1,5 +1,29 @@
 import { TableGenerics, Row, RowModel, TableInstance } from '../types'
 
+export function filterRows<TGenerics extends TableGenerics>(
+  rows: Row<TGenerics>[],
+  columnIds: string[],
+  instance: TableInstance<TGenerics>
+) {
+  const filterRowImpl = (rowsToFilter: Row<TGenerics>[]) => {
+    // Horizontally filter rows through each column
+    return rowsToFilter.filter(row => {
+      for (let i = 0; i < columnIds.length; i++) {
+        if (row.columnFilterMap[columnIds[i]] === false) {
+          return false
+        }
+      }
+      return true
+    })
+  }
+
+  if (instance.options.filterFromLeafRows) {
+    return filterRowModelFromLeafs(rows, filterRowImpl, instance)
+  }
+
+  return filterRowModelFromRoot(rows, filterRowImpl, instance)
+}
+
 export function filterRowModelFromLeafs<TGenerics extends TableGenerics>(
   rowsToFilter: Row<TGenerics>[],
   filterRows: (

package/src/utils/getCoreRowModelAsync.ts

@@ -88,7 +88,7 @@ export function getCoreRowModelAsync<TGenerics extends TableGenerics>(opts?: {
         accessRows(data)
       },
       {
-        key: 'getRowModel',
+        key: process.env.NODE_ENV === 'production' && 'getRowModel',
         initialSync: opts?.initialSync,
         onProgress: progress => {
           instance.setState(old => ({ ...old, coreProgress: progress }))

package/src/utils/getCoreRowModelSync.ts

@@ -94,7 +94,7 @@ export function getCoreRowModelSync<TGenerics extends TableGenerics>(): (
         return { rows, flatRows, rowsById }
       },
       {
-        key: 'getRowModel',
+        key: process.env.NODE_ENV === 'production' && 'getRowModel',
         debug: () => instance.options.debugAll ?? instance.options.debugTable,
         onChange: () => {
           instance.queue(() => {

package/src/utils/getExpandedRowModel.ts

@@ -24,7 +24,7 @@ export function getExpandedRowModel<TGenerics extends TableGenerics>(): (
         return expandRows(rowModel, instance)
       },
       {
-        key: 'getExpandedRowModel',
+        key: process.env.NODE_ENV === 'production' && 'getExpandedRowModel',
         debug: () => instance.options.debugAll ?? instance.options.debugTable,
       }
     )

package/src/utils/getFilteredRowModelAsync.ts

@@ -0,0 +1,49 @@
+import { TableInstance, RowModel, TableGenerics, Row } from '../types'
+import { incrementalMemo } from '../utils'
+
+export function getFilteredRowModelAsync<
+  TGenerics extends TableGenerics
+>(opts?: {
+  initialSync?: boolean
+}): (instance: TableInstance<TGenerics>) => () => RowModel<TGenerics> {
+  return instance =>
+    incrementalMemo(
+      () => [
+        instance.getState().columnFilters,
+        instance.getPreFilteredRowModel(),
+      ],
+      (_sorting, rowModel): RowModel<TGenerics> => {
+        return {
+          rows: rowModel.rows.slice(),
+          flatRows: [],
+          rowsById: rowModel.rowsById,
+        }
+      },
+      (columnFilters, rowModel) => rowModelRef => scheduleTask => {
+        // TODO: Figure out how to do scheduled filtering
+        // The trick will be batching those tasks in a way
+        // that makes them fast. JS work loops don't tend to do well with
+        // a high number of tasks that do one thing. Instead, shoot for each
+        // task to have a few thousand opts (or whatever amount is generally
+        // fast for most devices).
+        throw new Error('')
+      },
+      {
+        key:
+          process.env.NODE_ENV === 'production' && 'getFilteredRowModelAsync',
+        initialSync: opts?.initialSync,
+        onProgress: progress => {
+          instance.setState(old => ({
+            ...old,
+            columnFiltersProgress: progress,
+          }))
+        },
+        debug: () => instance.options.debugAll ?? instance.options.debugTable,
+        onChange: () => {
+          instance.queue(() => {
+            instance._autoResetPageIndex()
+          })
+        },
+      }
+    )
+}