@tanstack/table-core 8.0.0-alpha.41 → 8.0.0-alpha.44

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@tanstack/table-core",
   "author": "Tanner Linsley",
-  "version": "8.0.0-alpha.41",
+  "version": "8.0.0-alpha.44",
   "description": "Hooks for building lightweight, fast and extendable datagrids for React",
   "license": "MIT",
   "homepage": "https://github.com/tanstack/react-table#readme",

package/src/core.ts

@@ -310,7 +310,8 @@ export function createTableInstance<TGenerics extends AnyGenerics>(
       return template
     },
 
-    getRowId: (_: TGenerics['Row'], index: number, parent?: Row<TGenerics>) =>
+    getRowId: (row: TGenerics['Row'], index: number, parent?: Row<TGenerics>) =>
+      instance.options.getRowId?.(row, index, parent) ??
       `${parent ? [parent.id, index].join('.') : index}`,
 
     getState: () => {

package/src/features/Filters.ts

@@ -89,7 +89,6 @@ export type FiltersOptions<TGenerics extends AnyGenerics> = {
   // Global
   globalFilterType?: FilterType<TGenerics>
   onGlobalFilterChange?: OnChangeFn<any>
-  enableGlobalFilters?: boolean
   autoResetGlobalFilter?: boolean
   enableGlobalFilter?: boolean
   getGlobalFilteredRowModel?: (

package/src/features/RowSelection.ts

@@ -591,7 +591,7 @@ export function selectRowsFn<TGenerics extends AnyGenerics>(
   const newSelectedRowsById: Record<string, Row<TGenerics>> = {}
 
   // Filters top level and nested rows
-  const recurseRows = (rows: Row<TGenerics>[], depth = 0) => {
+  const recurseRows = (rows: Row<TGenerics>[], depth = 0): Row<TGenerics>[] => {
     return rows
       .map(row => {
         const isSelected = isRowSelected(row, rowSelection, instance) === true

package/src/utils/getColumnFilteredRowModelAsync.ts

@@ -12,7 +12,10 @@ export function getColumnFilteredRowModelAsync<
 }): (instance: TableInstance<TGenerics>) => () => RowModel<TGenerics> {
   return instance =>
     incrementalMemo(
-      () => [instance.getState().columnFilters, instance.getCoreRowModel()],
+      () => [
+        instance.getState().columnFilters,
+        instance.getPreColumnFilteredRowModel(),
+      ],
       (_sorting, rowModel): RowModel<TGenerics> => {
         return {
           rows: rowModel.rows.slice(),

package/src/utils/getColumnFilteredRowModelSync.ts

@@ -10,10 +10,13 @@ export function getColumnFilteredRowModelSync<
 >(): (instance: TableInstance<TGenerics>) => () => RowModel<TGenerics> {
   return instance =>
     memo(
-      () => [instance.getState().columnFilters, instance.getCoreRowModel()],
+      () => [
+        instance.getState().columnFilters,
+        instance.getPreColumnFilteredRowModel(),
+      ],
       (columnFilters, rowModel) => {
         const columnFilteredRowModel: RowModel<TGenerics> = (() => {
-          if (!rowModel.rows.length || !columnFilters) {
+          if (!rowModel.rows.length || !columnFilters?.length) {
             return rowModel
           }
 

package/src/utils/getExpandedRowModel.ts

@@ -8,7 +8,7 @@ export function getExpandedRowModel<TGenerics extends AnyGenerics>(): (
     memo(
       () => [
         instance.getState().expanded,
-        instance.getGroupedRowModel(),
+        instance.getPreExpandedRowModel(),
         instance.options.paginateExpandedRows,
       ],
       (expanded, rowModel, paginateExpandedRows) => {

package/src/utils/getGlobalFilteredRowModelAsync.ts

@@ -12,7 +12,10 @@ export function getGlobalFilteredRowModelAsync<
 }): (instance: TableInstance<TGenerics>) => () => RowModel<TGenerics> {
   return instance =>
     incrementalMemo(
-      () => [instance.getState().globalFilter, instance.getCoreRowModel()],
+      () => [
+        instance.getState().globalFilter,
+        instance.getPreGlobalFilteredRowModel(),
+      ],
       (_globalFilter, rowModel): RowModel<TGenerics> => {
         return {
           rows: rowModel.rows.slice(),

package/src/utils/getGlobalFilteredRowModelSync.ts

@@ -10,7 +10,10 @@ export function getGlobalFilteredRowModelSync<
 >(): (instance: TableInstance<TGenerics>) => () => RowModel<TGenerics> {
   return instance =>
     memo(
-      () => [instance.getState().globalFilter, instance.getCoreRowModel()],
+      () => [
+        instance.getState().globalFilter,
+        instance.getPreGlobalFilteredRowModel(),
+      ],
       (globalFilter, rowModel) => {
         const globalFilteredRowModel: RowModel<TGenerics> = (() => {
           if (!rowModel.rows.length || !globalFilter) {

package/src/utils/getGroupedRowModel.ts

@@ -6,7 +6,7 @@ export function getGroupedRowModelSync<TGenerics extends AnyGenerics>(): (
 ) => () => RowModel<TGenerics> {
   return instance =>
     memo(
-      () => [instance.getState().grouping, instance.getSortedRowModel()],
+      () => [instance.getState().grouping, instance.getPreGroupedRowModel()],
       (grouping, rowModel) => {
         if (!rowModel.rows.length || !grouping.length) {
           return rowModel

package/src/utils/getPaginationRowModel.ts

@@ -7,7 +7,10 @@ export function getPaginationRowModel<TGenerics extends AnyGenerics>(opts?: {
 }): (instance: TableInstance<TGenerics>) => () => RowModel<TGenerics> {
   return instance =>
     memo(
-      () => [instance.getState().pagination, instance.getExpandedRowModel()],
+      () => [
+        instance.getState().pagination,
+        instance.getPrePaginationRowModel(),
+      ],
       (pagination, rowModel) => {
         if (!rowModel.rows.length) {
           return rowModel

package/src/utils/getSortedRowModelAsync.ts

@@ -7,7 +7,7 @@ export function getSortedRowModelSync<TGenerics extends AnyGenerics>(opts?: {
 }): (instance: TableInstance<TGenerics>) => () => RowModel<TGenerics> {
   return instance =>
     incrementalMemo(
-      () => [instance.getState().sorting, instance.getGlobalFilteredRowModel()],
+      () => [instance.getState().sorting, instance.getPreSortedRowModel()],
       (_sorting, rowModel): RowModel<TGenerics> => {
         return {
           rows: rowModel.rows.slice(),

package/src/utils/getSortedRowModelSync.ts

@@ -7,7 +7,7 @@ export function getSortedRowModelSync<TGenerics extends AnyGenerics>(): (
 ) => () => RowModel<TGenerics> {
   return instance =>
     memo(
-      () => [instance.getState().sorting, instance.getGlobalFilteredRowModel()],
+      () => [instance.getState().sorting, instance.getPreSortedRowModel()],
       (sorting, rowModel) => {
         if (!rowModel.rows.length || !sorting?.length) {
           return rowModel