@tanstack/query-core 4.29.1 → 4.29.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tanstack/query-core",
-  "version": "4.29.1",
+  "version": "4.29.7",
   "description": "The framework agnostic core that powers TanStack Query",
   "author": "tannerlinsley",
   "license": "MIT",

package/src/focusManager.ts

@@ -66,7 +66,7 @@ export class FocusManager extends Subscribable {
   }
 
   onFocus(): void {
-    this.listeners.forEach((listener) => {
+    this.listeners.forEach(({ listener }) => {
       listener()
     })
   }

package/src/mutationCache.ts

@@ -154,7 +154,7 @@ export class MutationCache extends Subscribable<MutationCacheListener> {
 
   notify(event: MutationCacheNotifyEvent) {
     notifyManager.batch(() => {
-      this.listeners.forEach((listener) => {
+      this.listeners.forEach(({ listener }) => {
         listener(event)
       })
     })

package/src/mutationObserver.ts

@@ -78,7 +78,7 @@ export class MutationObserver<
   }
 
   protected onUnsubscribe(): void {
-    if (!this.listeners.length) {
+    if (!this.hasListeners()) {
       this.currentMutation?.removeObserver(this)
     }
   }
@@ -197,7 +197,7 @@ export class MutationObserver<
 
       // Then trigger the listeners
       if (options.listeners) {
-        this.listeners.forEach((listener) => {
+        this.listeners.forEach(({ listener }) => {
           listener(this.currentResult)
         })
       }

package/src/onlineManager.ts

@@ -67,7 +67,7 @@ export class OnlineManager extends Subscribable {
   }
 
   onOnline(): void {
-    this.listeners.forEach((listener) => {
+    this.listeners.forEach(({ listener }) => {
       listener()
     })
   }

package/src/queriesObserver.ts

@@ -34,7 +34,7 @@ export class QueriesObserver extends Subscribable<QueriesObserverListener> {
   }
 
   protected onSubscribe(): void {
-    if (this.listeners.length === 1) {
+    if (this.listeners.size === 1) {
       this.observers.forEach((observer) => {
         observer.subscribe((result) => {
           this.onUpdate(observer, result)
@@ -44,13 +44,13 @@ export class QueriesObserver extends Subscribable<QueriesObserverListener> {
   }
 
   protected onUnsubscribe(): void {
-    if (!this.listeners.length) {
+    if (!this.listeners.size) {
       this.destroy()
     }
   }
 
   destroy(): void {
-    this.listeners = []
+    this.listeners = new Set()
     this.observers.forEach((observer) => {
       observer.destroy()
     })
@@ -209,7 +209,7 @@ export class QueriesObserver extends Subscribable<QueriesObserverListener> {
 
   private notify(): void {
     notifyManager.batch(() => {
-      this.listeners.forEach((listener) => {
+      this.listeners.forEach(({ listener }) => {
         listener(this.result)
       })
     })

package/src/query.ts

@@ -463,7 +463,7 @@ export class Query<
               `Query data cannot be undefined. Please make sure to return a value other than undefined from your query function. Affected query key: ${this.queryHash}`,
             )
           }
-          onError(new Error('undefined') as any)
+          onError(new Error(`${this.queryHash} data is undefined`) as any)
           return
         }
 

package/src/queryCache.ts

@@ -190,7 +190,7 @@ export class QueryCache extends Subscribable<QueryCacheListener> {
 
   notify(event: QueryCacheNotifyEvent) {
     notifyManager.batch(() => {
-      this.listeners.forEach((listener) => {
+      this.listeners.forEach(({ listener }) => {
         listener(event)
       })
     })

package/src/queryObserver.ts

@@ -100,7 +100,7 @@ export class QueryObserver<
   }
 
   protected onSubscribe(): void {
-    if (this.listeners.length === 1) {
+    if (this.listeners.size === 1) {
       this.currentQuery.addObserver(this)
 
       if (shouldFetchOnMount(this.currentQuery, this.options)) {
@@ -112,7 +112,7 @@ export class QueryObserver<
   }
 
   protected onUnsubscribe(): void {
-    if (!this.listeners.length) {
+    if (!this.hasListeners()) {
       this.destroy()
     }
   }
@@ -134,7 +134,7 @@ export class QueryObserver<
   }
 
   destroy(): void {
-    this.listeners = []
+    this.listeners = new Set()
     this.clearStaleTimeout()
     this.clearRefetchInterval()
     this.currentQuery.removeObserver(this)
@@ -691,7 +691,7 @@ export class QueryObserver<
 
       // Then trigger the listeners
       if (notifyOptions.listeners) {
-        this.listeners.forEach((listener) => {
+        this.listeners.forEach(({ listener }) => {
           listener(this.currentResult)
         })
       }

package/src/subscribable.ts

@@ -1,26 +1,27 @@
 type Listener = () => void
 
 export class Subscribable<TListener extends Function = Listener> {
-  protected listeners: TListener[]
+  protected listeners: Set<{ listener: TListener }>
 
   constructor() {
-    this.listeners = []
+    this.listeners = new Set()
     this.subscribe = this.subscribe.bind(this)
   }
 
   subscribe(listener: TListener): () => void {
-    this.listeners.push(listener as TListener)
+    const identity = { listener }
+    this.listeners.add(identity)
 
     this.onSubscribe()
 
     return () => {
-      this.listeners = this.listeners.filter((x) => x !== listener)
+      this.listeners.delete(identity)
       this.onUnsubscribe()
     }
   }
 
   hasListeners(): boolean {
-    return this.listeners.length > 0
+    return this.listeners.size > 0
   }
 
   protected onSubscribe(): void {

package/src/tests/query.test.tsx

@@ -817,7 +817,7 @@ describe('query', () => {
 
     await sleep(10)
 
-    const error = new Error('undefined')
+    const error = new Error(`${JSON.stringify(key)} data is undefined`)
 
     expect(observerResult).toMatchObject({
       isError: true,

package/src/types.ts

@@ -204,14 +204,20 @@ export interface QueryObserverOptions<
   notifyOnChangeProps?: Array<keyof InfiniteQueryObserverResult> | 'all'
   /**
    * This callback will fire any time the query successfully fetches new data.
+   *
+   * @deprecated This callback will be removed in the next major version.
    */
   onSuccess?: (data: TData) => void
   /**
    * This callback will fire if the query encounters an error and will be passed the error.
+   *
+   * @deprecated This callback will be removed in the next major version.
    */
   onError?: (err: TError) => void
   /**
    * This callback will fire any time the query is either successfully fetched or errors and be passed either the data or error.
+   *
+   * @deprecated This callback will be removed in the next major version.
    */
   onSettled?: (data: TData | undefined, error: TError | null) => void
   /**