@tanstack/query-core 4.24.3 → 4.24.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tanstack/query-core",
-  "version": "4.24.3",
+  "version": "4.24.4",
   "description": "The framework agnostic core that powers TanStack Query",
   "author": "tannerlinsley",
   "license": "MIT",

package/src/mutationCache.ts

@@ -79,7 +79,6 @@ export class MutationCache extends Subscribable<MutationCacheListener> {
 
   private mutations: Mutation<any, any, any, any>[]
   private mutationId: number
-  private resuming: Promise<void> | undefined
 
   constructor(config?: MutationCacheConfig) {
     super()
@@ -154,21 +153,13 @@ export class MutationCache extends Subscribable<MutationCacheListener> {
   }
 
   resumePausedMutations(): Promise<void> {
-    if (!this.resuming) {
-      const pausedMutations = this.mutations.filter((x) => x.state.isPaused)
-      this.resuming = notifyManager
-        .batch(() =>
-          pausedMutations.reduce(
-            (promise, mutation) =>
-              promise.then(() => mutation.continue().catch(noop)),
-            Promise.resolve(),
-          ),
-        )
-        .then(() => {
-          this.resuming = undefined
-        })
-    }
-
-    return this.resuming
+    const pausedMutations = this.mutations.filter((x) => x.state.isPaused)
+    return notifyManager.batch(() =>
+      pausedMutations.reduce(
+        (promise, mutation) =>
+          promise.then(() => mutation.continue().catch(noop)),
+        Promise.resolve(),
+      ),
+    )
   }
 }

package/src/tests/queryClient.test.tsx

@@ -8,9 +8,8 @@ import type {
   QueryFunction,
   QueryObserverOptions,
 } from '..'
-import { InfiniteQueryObserver, MutationObserver, QueryObserver } from '..'
+import { InfiniteQueryObserver, QueryObserver } from '..'
 import { focusManager, onlineManager } from '..'
-import { noop } from '../utils'
 
 describe('queryClient', () => {
   let queryClient: QueryClient
@@ -1469,83 +1468,6 @@ describe('queryClient', () => {
       onlineManager.setOnline(undefined)
     })
 
-    test('should resume paused mutations when coming online', async () => {
-      const consoleMock = jest.spyOn(console, 'error')
-      consoleMock.mockImplementation(() => undefined)
-      onlineManager.setOnline(false)
-
-      const observer1 = new MutationObserver(queryClient, {
-        mutationFn: async () => 1,
-      })
-
-      const observer2 = new MutationObserver(queryClient, {
-        mutationFn: async () => 2,
-      })
-      void observer1.mutate().catch(noop)
-      void observer2.mutate().catch(noop)
-
-      await waitFor(() => {
-        expect(observer1.getCurrentResult().isPaused).toBeTruthy()
-        expect(observer2.getCurrentResult().isPaused).toBeTruthy()
-      })
-
-      onlineManager.setOnline(true)
-
-      await waitFor(() => {
-        expect(observer1.getCurrentResult().status).toBe('success')
-        expect(observer1.getCurrentResult().status).toBe('success')
-      })
-
-      onlineManager.setOnline(undefined)
-    })
-
-    test('should resume paused mutations one after the other when invoked manually at the same time', async () => {
-      const consoleMock = jest.spyOn(console, 'error')
-      consoleMock.mockImplementation(() => undefined)
-      onlineManager.setOnline(false)
-
-      const orders: Array<string> = []
-
-      const observer1 = new MutationObserver(queryClient, {
-        mutationFn: async () => {
-          orders.push('1start')
-          await sleep(50)
-          orders.push('1end')
-          return 1
-        },
-      })
-
-      const observer2 = new MutationObserver(queryClient, {
-        mutationFn: async () => {
-          orders.push('2start')
-          await sleep(20)
-          orders.push('2end')
-          return 2
-        },
-      })
-      void observer1.mutate().catch(noop)
-      void observer2.mutate().catch(noop)
-
-      await waitFor(() => {
-        expect(observer1.getCurrentResult().isPaused).toBeTruthy()
-        expect(observer2.getCurrentResult().isPaused).toBeTruthy()
-      })
-
-      onlineManager.setOnline(undefined)
-      void queryClient.resumePausedMutations()
-      await sleep(5)
-      await queryClient.resumePausedMutations()
-
-      await waitFor(() => {
-        expect(observer1.getCurrentResult().status).toBe('success')
-        expect(observer2.getCurrentResult().status).toBe('success')
-      })
-
-      console.log('orders', orders)
-
-      expect(orders).toEqual(['1start', '1end', '2start', '2end'])
-    })
-
     test('should notify queryCache and mutationCache after multiple mounts and single unmount', async () => {
       const testClient = createQueryClient()
       testClient.mount()