@tangle-network/agent-app 0.45.59 → 0.45.61

package/dist/chat-routes/attachment-store.d.ts

@@ -50,13 +50,16 @@ export type ReadAttachmentFn = (scopeId: string, path: string) => Promise<Attach
  * routes create a unique path for each attempt, and the product adapter stores
  * this id with it. */
 export interface AttachmentWriteOwnership {
-    id: string;
-    path: string;
+    readonly id: string;
+    readonly path: string;
 }
 /** Public-safe outcome for a storage outage. Backend details belong in logs. */
 export declare const ATTACHMENT_STORAGE_FAILURE_MESSAGE = "Attachment storage is temporarily unavailable. Please try again.";
-/** Add an ownership id to a logical path and return an immutable store key.
- * Ownership ids are path-safe because the key is also returned to clients. */
+/** Stable client error code when compensating cleanup did not complete. */
+export declare const ATTACHMENT_ROLLBACK_FAILURE_CODE = "rollback_failed";
+/** Public-safe outcome when compensating cleanup did not complete. */
+export declare const ATTACHMENT_ROLLBACK_FAILURE_MESSAGE = "Attachment cleanup failed. Please try again.";
+/** Add a path-safe ownership id to a logical path and return an immutable store key. */
 export declare function immutableAttachmentPath(logicalPath: string, ownershipId: string): string;
 /** Compensation for one attachment write. The adapter MUST compare the stored
  * ownership id before deleting, so an older rollback cannot delete a newer

package/dist/chat-routes/index.js

@@ -1,6 +1,6 @@
 import {
   redactErrorMessage
-} from "../chunk-CDC5HFKL.js";
+} from "../chunk-MH74DY2I.js";
 import {
   createSandboxFileIndexRoute
 } from "../chunk-QY4BRKRJ.js";
@@ -2267,6 +2267,8 @@ function createUploadRoute(options) {
 
 // src/chat-routes/attachment-store.ts
 var ATTACHMENT_STORAGE_FAILURE_MESSAGE = "Attachment storage is temporarily unavailable. Please try again.";
+var ATTACHMENT_ROLLBACK_FAILURE_CODE = "rollback_failed";
+var ATTACHMENT_ROLLBACK_FAILURE_MESSAGE = "Attachment cleanup failed. Please try again.";
 function immutableAttachmentPath(logicalPath, ownershipId) {
   if (!/^[A-Za-z0-9_-]{1,128}$/.test(ownershipId)) {
     throw new Error("attachment ownership id must be a path-safe identifier");
@@ -2462,27 +2464,27 @@ function base64ToBytes(base64) {
   return bytes;
 }
 function parseDataUrl(url) {
-  const match = /^data:[^,]*,([\s\S]*)$/.exec(url);
+  const match = /^data:[^,]*,([\s\S]*)$/i.exec(url);
   if (!match) return null;
   return { base64: /;base64,/i.test(url), data: match[1] ?? "" };
 }
 function dataUrlMime(url) {
   if (!url) return void 0;
-  const match = /^data:([^;,]+)[;,]/.exec(url);
+  const match = /^data:([^;,]+)[;,]/i.exec(url);
   return match ? match[1] : void 0;
 }
 function basenameFromUrl(url) {
-  if (!url || url.startsWith("data:")) return void 0;
+  if (!url || /^data:/i.test(url)) return void 0;
   const withoutQuery = url.split(/[?#]/)[0] ?? url;
   const segments = withoutQuery.split("/").filter(Boolean);
   return segments[segments.length - 1] || void 0;
 }
 function resolveFileUrlPath(url) {
-  const withoutScheme = url.startsWith("file://") ? url.slice("file://".length) : url;
+  const withoutScheme = /^file:\/\//i.test(url) ? url.slice("file://".length) : url;
   try {
     return { succeeded: true, path: decodeURIComponent(withoutScheme) };
   } catch (err) {
-    return { succeeded: false, reason: `malformed file path: ${err instanceof Error ? err.message : String(err)}` };
+    return { succeeded: false, reason: `malformed file path: ${redactErrorMessage(err)}` };
   }
 }
 function oversizeReason(filename, actual, limit) {
@@ -2495,7 +2497,7 @@ function resolveDataUrlBytes(url, filename, maxBytes) {
   try {
     bytes = parsed.base64 ? base64ToBytes(parsed.data) : new TextEncoder().encode(decodeURIComponent(parsed.data));
   } catch (err) {
-    return { succeeded: false, reason: `failed to decode data URI: ${err instanceof Error ? err.message : String(err)}` };
+    return { succeeded: false, reason: `failed to decode data URI: ${redactErrorMessage(err)}` };
   }
   if (bytes.byteLength > maxBytes) {
     return { succeeded: false, reason: oversizeReason(filename, bytes.byteLength, maxBytes) };
@@ -2505,23 +2507,26 @@ function resolveDataUrlBytes(url, filename, maxBytes) {
 async function resolveSandboxFileBytes(input) {
   const stat = await statSandboxFileSize(input.box, input.path, { sessionId: input.sessionId });
   if (!stat.succeeded) {
-    return { succeeded: false, reason: `could not stat agent file: ${stat.error}` };
+    return { succeeded: false, reason: `could not stat agent file: ${redactErrorMessage(stat.error)}` };
   }
   if (stat.value > input.maxBytes) {
     return { succeeded: false, reason: oversizeReason(input.filename, stat.value, input.maxBytes) };
   }
   const read = await readSandboxBinaryBytes(input.box, input.path, stat.value, { sessionId: input.sessionId });
   if (!read.succeeded) {
-    return { succeeded: false, reason: `could not read agent file: ${read.error}` };
+    return { succeeded: false, reason: `could not read agent file: ${redactErrorMessage(read.error)}` };
   }
   return { succeeded: true, bytes: read.value.bytes };
 }
 async function resolveBytes(input) {
   const url = input.raw.url;
   if (!url) return { succeeded: false, reason: "the file part carries no url" };
-  if (url.startsWith("data:")) return resolveDataUrlBytes(url, input.filename, input.maxBytes);
-  const isSandboxPath = url.startsWith("file://") || url.startsWith("/");
-  if (!isSandboxPath) return { succeeded: false, reason: `unsupported file URL scheme: ${url}` };
+  if (/^data:/i.test(url)) return resolveDataUrlBytes(url, input.filename, input.maxBytes);
+  const isSandboxPath = /^file:\/\//i.test(url) || url.startsWith("/");
+  if (!isSandboxPath) {
+    const scheme = /^([A-Za-z][A-Za-z0-9+.-]*):/.exec(url)?.[1]?.toLowerCase() ?? "unknown";
+    return { succeeded: false, reason: `unsupported file URL scheme: ${scheme}` };
+  }
   if (!input.box) return { succeeded: false, reason: "no sandbox to read agent file" };
   const resolvedPath = resolveFileUrlPath(url);
   if (!resolvedPath.succeeded) return resolvedPath;
@@ -2545,7 +2550,13 @@ function defaultBuildAttachmentPath(args) {
 }
 function logPromotionStorageError(logger, message, fields) {
   try {
-    logger.error(message, fields);
+    const safeFields = Object.fromEntries(
+      Object.entries(fields).map(([key, value]) => [
+        key,
+        typeof value === "string" ? redactErrorMessage(value) : value
+      ])
+    );
+    logger.error(message, safeFields);
   } catch {
   }
 }
@@ -2589,11 +2600,21 @@ async function promoteAgentFilePart(options) {
     maxBytes
   });
   if (!resolved.succeeded) return { succeeded: false, filename, reason: resolved.reason };
-  const mediaType = options.raw.mediaType ?? options.raw.mime ?? dataUrlMime(options.raw.url) ?? sniffMime(filename);
-  const kind = attachmentKindForMime(mediaType);
-  const digest = await hash8(options.raw.id ?? options.raw.url ?? filename);
-  const date = now().toISOString().split("T")[0] ?? "";
-  const logicalPath = buildAttachmentPath({ filename, hash8: digest, date, mediaType, kind });
+  let mediaType;
+  let kind;
+  let logicalPath;
+  try {
+    mediaType = (options.raw.mediaType ?? options.raw.mime ?? dataUrlMime(options.raw.url) ?? sniffMime(filename)).toLowerCase();
+    kind = attachmentKindForMime(mediaType);
+    const digest = await hash8(options.raw.id ?? options.raw.url ?? filename);
+    const date = now().toISOString().split("T")[0] ?? "";
+    logicalPath = buildAttachmentPath({ filename, hash8: digest, date, mediaType, kind });
+  } catch (error) {
+    logPromotionStorageError(logger, "[promote-file-part] path planning failed", {
+      error: redactErrorMessage(error)
+    });
+    return { succeeded: false, filename, reason: ATTACHMENT_STORAGE_FAILURE_MESSAGE };
+  }
   if (!atomic) {
     let written2;
     try {
@@ -2649,7 +2670,7 @@ async function promoteAgentFilePart(options) {
     });
     return { succeeded: false, filename, reason: ATTACHMENT_STORAGE_FAILURE_MESSAGE };
   }
-  const ownership = { id: ownershipId, path };
+  const ownership = Object.freeze({ id: ownershipId, path });
   let written;
   try {
     written = await options.attachmentWriter.write(options.scopeId, path, resolved.bytes, {
@@ -2720,7 +2741,13 @@ async function promoteAgentFilePart(options) {
 // src/chat-routes/attachment-upload.ts
 function logAttachmentUploadError(logger, message, fields) {
   try {
-    logger.error(message, fields);
+    const safeFields = Object.fromEntries(
+      Object.entries(fields).map(([key, value]) => [
+        key,
+        typeof value === "string" ? redactErrorMessage(value) : value
+      ])
+    );
+    logger.error(message, safeFields);
   } catch {
   }
 }
@@ -2730,6 +2757,14 @@ function attachmentUploadError(status, code, message, path) {
     { status }
   );
 }
+function atomicAttachmentFailure(path, cleanupFailures = 0) {
+  return attachmentUploadError(
+    503,
+    cleanupFailures > 0 ? ATTACHMENT_ROLLBACK_FAILURE_CODE : "attachment_store_unavailable",
+    cleanupFailures > 0 ? ATTACHMENT_ROLLBACK_FAILURE_MESSAGE : ATTACHMENT_STORAGE_FAILURE_MESSAGE,
+    path
+  );
+}
 async function rollbackSuccessfulWrites(writes, scopeId, writer, logger) {
   let failures = 0;
   for (let index = writes.length - 1; index >= 0; index -= 1) {
@@ -2955,7 +2990,7 @@ function createAttachmentUploadRoute(options) {
       if (!ownershipId) {
         return attachmentUploadError(503, "attachment_store_unavailable", ATTACHMENT_STORAGE_FAILURE_MESSAGE, input.path);
       }
-      const ownership = { id: ownershipId, path: input.path };
+      const ownership = Object.freeze({ id: ownershipId, path: input.path });
       let written;
       try {
         written = await atomicWriter.write(auth.scopeId, input.path, input.bytes, {
@@ -2973,12 +3008,7 @@ function createAttachmentUploadRoute(options) {
           cleanupFailures,
           error: redactErrorMessage(error)
         });
-        return attachmentUploadError(
-          503,
-          "attachment_store_unavailable",
-          ATTACHMENT_STORAGE_FAILURE_MESSAGE,
-          input.path
-        );
+        return atomicAttachmentFailure(input.path, cleanupFailures);
       }
       const result = inspectAtomicAttachmentWriteResult(written, ownership);
       if (!result) {
@@ -2988,7 +3018,7 @@ function createAttachmentUploadRoute(options) {
           ownershipId: ownership.id,
           cleanupFailures
         });
-        return attachmentUploadError(503, "attachment_store_unavailable", ATTACHMENT_STORAGE_FAILURE_MESSAGE, input.path);
+        return atomicAttachmentFailure(input.path, cleanupFailures);
       }
       if (!result.ok) {
         const cleanupFailures = await rollbackSuccessfulWrites([
@@ -3005,12 +3035,7 @@ function createAttachmentUploadRoute(options) {
           cleanupFailures,
           error: redactErrorMessage(result.reason)
         });
-        return attachmentUploadError(
-          503,
-          "attachment_store_unavailable",
-          ATTACHMENT_STORAGE_FAILURE_MESSAGE,
-          input.path
-        );
+        return atomicAttachmentFailure(input.path, cleanupFailures);
       }
       successfulWrites.push({ path: input.path, ownership, receipt: result.receipt });
       uploaded.push({
@@ -3245,6 +3270,8 @@ export {
   ALLOWED_ATTACHMENT_SNIFFED_MIMES,
   ATTACHMENT_ACCEPT,
   ATTACHMENT_MAX_COUNT,
+  ATTACHMENT_ROLLBACK_FAILURE_CODE,
+  ATTACHMENT_ROLLBACK_FAILURE_MESSAGE,
   ATTACHMENT_STORAGE_FAILURE_MESSAGE,
   ChatTurnInputError,
   DEFAULT_MODEL_FIRST_RESPONSE_TIMEOUT_MS,