@tallyrelease/plugins 0.5.0 → 0.6.0-beta.12

package/dist/dart/plugin.d.ts

@@ -1,3 +1 @@
-export declare const dartPlugin: import("@tallyrelease/core").Plugin<{
-    buildOffset?: number | undefined;
-}>;
+export declare const dartPlugin: import("@tallyrelease/core").Plugin<Record<string, never>>;

package/dist/dart/plugin.js

@@ -1,18 +1,21 @@
-import { defaultUnitId, definePlugin, flutter } from "@tallyrelease/core";
+import { defaultUnitId, definePlugin } from "@tallyrelease/core";
 import { parse as parseYaml } from "yaml";
 import { z } from "zod";
 import { edgeBetween, unitsByPackage } from "../_kit/edges.js";
 import { joinRoot, rootOf } from "../_kit/paths.js";
-const optionsSchema = z.strictObject({
-    /** Added to the first-parent commit count for flutter build numbers. */
-    buildOffset: z.number().int().nonnegative().optional(),
-});
+import { BUILD, NUMBERS, PRERELEASE } from "../_kit/semver.js";
+const optionsSchema = z.strictObject({});
 const PUBSPEC = "pubspec.yaml";
+const MELOS = "melos.yaml";
 const DEP_FIELDS = [
     "dependencies",
     "dev_dependencies",
     "dependency_overrides",
 ];
+const VERSION = `${NUMBERS}${PRERELEASE}${BUILD}`;
+const EXACT = new RegExp(`^${VERSION}$`);
+/** An exact `name: version` entry; the groups are the indent, name, colon, quote and trailing text. */
+const PIN_LINE = new RegExp(`^([ \\t]+)([\\w.-]+)(:[ \\t]*)(["']?)${VERSION}\\4(?=\\s|$)(.*)$`);
 /** The top-level `version:` line; group 3 is the value without quotes. */
 const VERSION_LINE = /^(version:[ \t]*)(["']?)([^\s"'#]+)\2/m;
 const record = (value) => typeof value === "object" && value !== null
@@ -34,49 +37,95 @@ const readPubspec = (ctx, root) => {
 };
 /** Directories whose pubspecs are never units. */
 const SKIPPED = new Set(["build", "example"]);
-/** Roots of every `pubspec.yaml`, skipping dot, `build` and `example` directories. */
-const pubspecRoots = (ctx) => ctx.fs
-    .glob([PUBSPEC, `**/${PUBSPEC}`])
-    .filter((p) => p
-    .split("/")
-    .slice(0, -1)
-    .every((s) => !s.startsWith(".") && !SKIPPED.has(s)))
-    .map((p) => (p === PUBSPEC ? "." : rootOf(p, PUBSPEC)));
-/** A private app that depends on the Flutter SDK. */
-const isFlutterApp = (pubspec) => pubspec["publish_to"] === "none" &&
-    (record(record(pubspec["dependencies"])["flutter"])["sdk"] === "flutter" ||
-        record(pubspec["environment"])["flutter"] !== undefined);
+/** A root pubspec that only anchors a pub workspace or melos setup, without its own version. */
+const isWorkspaceRoot = (ctx) => {
+    const pubspec = readPubspec(ctx, ".");
+    return (pubspec !== undefined &&
+        pubspec["version"] === undefined &&
+        (pubspec["workspace"] !== undefined || ctx.fs.exists(MELOS)));
+};
+/** Roots of every `pubspec.yaml`, skipping dot, `build` and `example` directories and a workspace root. */
+const pubspecRoots = (ctx) => {
+    const skipRoot = isWorkspaceRoot(ctx);
+    return ctx.fs
+        .glob([PUBSPEC, `**/${PUBSPEC}`])
+        .filter((p) => p
+        .split("/")
+        .slice(0, -1)
+        .every((s) => !s.startsWith(".") && !SKIPPED.has(s)))
+        .map((p) => (p === PUBSPEC ? "." : rootOf(p, PUBSPEC)))
+        .filter((root) => !(skipRoot && root === "."));
+};
+/**
+ * Whether a dependency entry makes the dependent ship the dependency's code:
+ * `path:` maps and exact versions under `dependencies`. Undefined when the
+ * entry is no link to a unit.
+ */
+const pinnedLink = (field, spec) => {
+    if (spec === null) {
+        return false;
+    }
+    if (typeof spec === "string") {
+        return field === "dependencies" && EXACT.test(spec);
+    }
+    return typeof record(spec)["path"] === "string"
+        ? field === "dependencies"
+        : undefined;
+};
+/** Sets the exact version entries under top-level `dependencies:` that name a released package. */
+const rewritePins = (content, released) => {
+    let inDeps = false;
+    let indent;
+    return content.replace(/^.*$/gm, (line) => {
+        if (/^dependencies:\s*(#.*)?$/.test(line)) {
+            inDeps = true;
+            indent = undefined;
+            return line;
+        }
+        if (!inDeps || /^\s*(#.*)?$/.test(line)) {
+            return line;
+        }
+        if (!/^\s/.test(line)) {
+            inDeps = false;
+            return line;
+        }
+        const [, lead = "", name = "", colon = "", quote = "", rest = ""] = PIN_LINE.exec(line) ?? [];
+        const version = released.get(name);
+        indent ??= /^[ \t]*/.exec(line)?.[0];
+        if (version === undefined || lead !== indent) {
+            return line;
+        }
+        return `${lead}${name}${colon}${quote}${version}${quote}${rest}`;
+    });
+};
 export const dartPlugin = definePlugin({
     apiVersion: 1,
     name: "dart",
     options: optionsSchema,
-    schemes: { flutter },
     discover: (ctx) => pubspecRoots(ctx).map((root) => {
         const pubspec = readPubspec(ctx, root) ?? {};
         const packageName = pubspec["name"];
-        const { buildOffset } = ctx.options;
         return {
             id: defaultUnitId(root, ctx.repo.name),
             root,
             version: "file",
-            scheme: isFlutterApp(pubspec) ? "flutter" : "semver",
-            meta: {
-                ...(typeof packageName === "string" && { packageName }),
-                ...(buildOffset !== undefined && { buildOffset }),
-            },
+            meta: typeof packageName === "string" ? { packageName } : {},
         };
     }),
     edges: (ctx, units) => {
-        const byName = unitsByPackage(units, "dart");
+        const byName = unitsByPackage(units, "dart", (name, prior, unit) => {
+            ctx.log.warn(`package "${name}" is declared by "${prior.root}" and "${unit.root}"; using "${unit.root}"`);
+        });
         const edges = [];
         for (const to of byName.values()) {
             const pubspec = readPubspec(ctx, to.root) ?? {};
             for (const field of DEP_FIELDS) {
                 for (const [name, spec] of Object.entries(record(pubspec[field]))) {
-                    if (typeof record(spec)["path"] === "string") {
+                    const pinned = pinnedLink(field, spec);
+                    if (pinned !== undefined) {
                         edges.push(...edgeBetween(byName.get(name), to, {
                             reason: `${field}: ${name}`,
-                            pinned: false,
+                            pinned,
                         }));
                     }
                 }
@@ -88,11 +137,29 @@ export const dartPlugin = definePlugin({
         {
             path: joinRoot(unit.root, PUBSPEC),
             read: (content) => VERSION_LINE.exec(content)?.[3],
-            // A pubspec without a version line gets one after `name:`.
-            write: (content, next) => VERSION_LINE.test(content)
-                ? content.replace(VERSION_LINE, (_, key, quote) => `${key}${quote}${next}${quote}`)
-                : content.replace(/^name:.*$/m, (line) => `${line}\nversion: ${next}`),
+            write: (content, next, { units, versions }) => {
+                const released = new Map();
+                for (const u of units) {
+                    const name = u.meta["dart"]?.["packageName"];
+                    const version = versions.get(u.id);
+                    if (typeof name === "string" && version !== undefined) {
+                        released.set(name, version);
+                    }
+                }
+                // A pubspec without a version line gets one after `name:`.
+                const versioned = VERSION_LINE.test(content)
+                    ? content.replace(VERSION_LINE, (_, key, quote) => `${key}${quote}${next}${quote}`)
+                    : content.replace(/^name:.*$/m, (line) => `${line}${content.includes("\r\n") ? "\r\n" : "\n"}version: ${next}`);
+                return rewritePins(versioned, released);
+            },
         },
     ],
-    inputs: () => ({ global: ["pubspec.lock"] }),
+    inputs: (ctx) => ({
+        global: [
+            "pubspec.lock",
+            MELOS,
+            "analysis_options.yaml",
+            ...(isWorkspaceRoot(ctx) ? [PUBSPEC] : []),
+        ],
+    }),
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tallyrelease/plugins",
-  "version": "0.5.0",
+  "version": "0.6.0-beta.12",
   "description": "Built-in ecosystem plugins of tallyrelease",
   "repository": {
     "type": "git",
@@ -41,7 +41,7 @@
   },
   "prettier": "@abinnovision/prettier-config",
   "dependencies": {
-    "@tallyrelease/core": "^0.5.0",
+    "@tallyrelease/core": "^0.6.0-beta.12",
     "yaml": "^2.9.1",
     "zod": "^4.6.7"
   },