@talkpilot/core-db 1.3.8 → 1.3.11

package/src/municipal/muniIssues/muniIssues.types.ts

@@ -1,37 +1,37 @@
-import { ObjectId } from "mongodb";
-
-import { CityName } from "../utils/types";
-import { MUNI_ISSUE_SYNC_STATUSES } from "./muniIssues.constants";
-
-export type MuniIssueSyncStatus = (typeof MUNI_ISSUE_SYNC_STATUSES)[number];
-
-export type MuniIssueContent = {
-  issuerName: string;
-  issuerRole: string;
-  issueDescription: string;
-  desiredBehavior: string;
-};
-
-export type MuniIssueJira = {
-  key: string;
-  syncStatus: MuniIssueSyncStatus;
-};
-
-export type MuniIssue = {
-  _id: ObjectId;
-  callSid: string;
-  clientId: string;
-  cityName: CityName;
-  issueContent: MuniIssueContent;
-  jira: MuniIssueJira;
-  createdAt: Date;
-};
-
-// _id/createdAt are set on insert; jira.syncStatus defaults to "created"
-// because the issue is only stored after its Jira ticket exists (CP-1115).
-export type CreateMuniIssueInput = Omit<
-  MuniIssue,
-  "_id" | "createdAt" | "jira"
-> & {
-  jira: { key: string; syncStatus?: MuniIssueSyncStatus };
-};
+import { ObjectId } from "mongodb";
+
+import { CityName } from "../utils/types";
+import { MUNI_ISSUE_SYNC_STATUSES } from "./muniIssues.constants";
+
+export type MuniIssueSyncStatus = (typeof MUNI_ISSUE_SYNC_STATUSES)[number];
+
+export type MuniIssueContent = {
+  issuerName: string;
+  issuerRole: string;
+  issueDescription: string;
+  desiredBehavior: string;
+};
+
+export type MuniIssueJira = {
+  key: string;
+  syncStatus: MuniIssueSyncStatus;
+};
+
+export type MuniIssue = {
+  _id: ObjectId;
+  callSid: string;
+  clientId: string;
+  cityName: CityName;
+  issueContent: MuniIssueContent;
+  jira: MuniIssueJira;
+  createdAt: Date;
+};
+
+// _id/createdAt are set on insert; jira.syncStatus defaults to "created"
+// because the issue is only stored after its Jira ticket exists (CP-1115).
+export type CreateMuniIssueInput = Omit<
+  MuniIssue,
+  "_id" | "createdAt" | "jira"
+> & {
+  jira: { key: string; syncStatus?: MuniIssueSyncStatus };
+};

package/src/municipal/tickets/__tests__/tickets.getters.spec.ts

@@ -1,30 +1,30 @@
-import { findTicketsByCallSid } from "../tickets.getters";
-import { setDb } from "../../index";
-import { Db, Collection } from "mongodb";
-import { createTicket } from "../../../test-utils/factories";
-
-describe("tickets getters", () => {
-  let mockDb: Partial<Db>;
-  let mockCollection: Partial<Collection>;
-
-  beforeEach(() => {
-    const mockTicket = createTicket({ callSid: "123" });
-    mockCollection = {
-      find: jest.fn().mockReturnValue({
-        toArray: jest.fn().mockResolvedValue([mockTicket]),
-      }),
-    };
-    mockDb = {
-      collection: jest.fn().mockReturnValue(mockCollection),
-    };
-    setDb(mockDb as Db);
-  });
-
-  it("findTicketsByCallSid should return tickets for the given callSid", async () => {
-    const result = await findTicketsByCallSid("123");
-
-    expect(mockDb.collection).toHaveBeenCalledWith("tickets");
-    expect(mockCollection.find).toHaveBeenCalledWith({ callSid: "123" });
-    expect(result[0].callSid).toBe("123");
-  });
-});
+import { findTicketsByCallSid } from "../tickets.getters";
+import { setDb } from "../../index";
+import { Db, Collection } from "mongodb";
+import { createTicket } from "../../../test-utils/factories";
+
+describe("tickets getters", () => {
+  let mockDb: Partial<Db>;
+  let mockCollection: Partial<Collection>;
+
+  beforeEach(() => {
+    const mockTicket = createTicket({ callSid: "123" });
+    mockCollection = {
+      find: jest.fn().mockReturnValue({
+        toArray: jest.fn().mockResolvedValue([mockTicket]),
+      }),
+    };
+    mockDb = {
+      collection: jest.fn().mockReturnValue(mockCollection),
+    };
+    setDb(mockDb as Db);
+  });
+
+  it("findTicketsByCallSid should return tickets for the given callSid", async () => {
+    const result = await findTicketsByCallSid("123");
+
+    expect(mockDb.collection).toHaveBeenCalledWith("tickets");
+    expect(mockCollection.find).toHaveBeenCalledWith({ callSid: "123" });
+    expect(result[0].callSid).toBe("123");
+  });
+});

package/src/municipal/tickets/__tests__/tickets.statistics.spec.ts

@@ -1,68 +1,94 @@
-import {
-  findCallSidDraftTicketCountsByCity,
-  findCallSidTicketCountsByCity,
-  getTicketsCollection,
-  ticketStatsDateScopeFromYmd,
-} from "../../../index";
-import { createTicket } from "../../../test-utils/factories";
-
-const CITY = "tests" as const;
-const TZ = "Asia/Jerusalem";
-const mayScope = () => ticketStatsDateScopeFromYmd("2026-05-01", "2026-05-31", TZ);
-
-describe("tickets statistics getters", () => {
-  it("should scope callSid lookups to the provided createdAt range", async () => {
-    await getTicketsCollection().insertMany([
-      createTicket({
-        cityName: CITY,
-        callSid: "CA-in-range",
-        createdAt: new Date("2026-05-15T10:00:00.000Z"),
-        updatedAt: new Date("2026-05-15T10:00:00.000Z"),
-      }),
-      createTicket({
-        cityName: CITY,
-        callSid: "CA-out-of-range",
-        createdAt: new Date("2024-01-01T10:00:00.000Z"),
-        updatedAt: new Date("2024-01-01T10:00:00.000Z"),
-      }),
-    ]);
-    expect(await findCallSidTicketCountsByCity(CITY, mayScope())).toEqual(new Map([["CA-in-range", 1]]));
-  });
-
-  it("should treat whitespace-only event_subject_id as draft", async () => {
-    await getTicketsCollection().insertMany([
-      createTicket({
-        cityName: CITY,
-        callSid: "CA-draft-whitespace",
-        createdAt: new Date("2026-05-15T10:00:00.000Z"),
-        updatedAt: new Date("2026-05-15T10:00:00.000Z"),
-        externalCallFields: { event_subject_id: "  \t  " },
-      }),
-      createTicket({
-        cityName: CITY,
-        callSid: "CA-not-draft",
-        createdAt: new Date("2026-05-16T10:00:00.000Z"),
-        updatedAt: new Date("2026-05-16T10:00:00.000Z"),
-        externalCallFields: { event_subject_id: "100" },
-      }),
-    ]);
-    expect(await findCallSidDraftTicketCountsByCity(CITY, mayScope())).toEqual(new Map([["CA-draft-whitespace", 1]]));
-  });
-    it("should count multiple tickets on the same callSid", async () => {
-    await getTicketsCollection().insertMany([
-      createTicket({
-        cityName: CITY,
-        callSid: "CA-multi",
-        createdAt: new Date("2026-05-15T10:00:00.000Z"),
-        updatedAt: new Date("2026-05-15T10:00:00.000Z"),
-      }),
-      createTicket({
-        cityName: CITY,
-        callSid: "CA-multi",
-        createdAt: new Date("2026-05-15T11:00:00.000Z"),
-        updatedAt: new Date("2026-05-15T11:00:00.000Z"),
-      }),
-    ]);
-    expect(await findCallSidTicketCountsByCity(CITY, mayScope())).toEqual(new Map([["CA-multi", 2]]));
-  });
-});
+import {
+  findCallSidDraftTicketCountsByCity,
+  findCallSidTicketCountsByCity,
+  getTicketsCollection,
+  ticketStatsDateScopeFromYmd,
+} from "../../../index";
+import { createTicket } from "../../../test-utils/factories";
+
+const CITY = "tests" as const;
+const TZ = "Asia/Jerusalem";
+const mayScope = () => ticketStatsDateScopeFromYmd("2026-05-01", "2026-05-31", TZ);
+
+describe("tickets statistics getters", () => {
+  it("should scope callSid lookups to the provided createdAt range", async () => {
+    await getTicketsCollection().insertMany([
+      createTicket({
+        cityName: CITY,
+        callSid: "CA-in-range",
+        createdAt: new Date("2026-05-15T10:00:00.000Z"),
+        updatedAt: new Date("2026-05-15T10:00:00.000Z"),
+      }),
+      createTicket({
+        cityName: CITY,
+        callSid: "CA-out-of-range",
+        createdAt: new Date("2024-01-01T10:00:00.000Z"),
+        updatedAt: new Date("2024-01-01T10:00:00.000Z"),
+      }),
+    ]);
+    expect(await findCallSidTicketCountsByCity(CITY, mayScope())).toEqual(new Map([["CA-in-range", 1]]));
+  });
+
+  it("should treat whitespace-only event_subject_id as draft for legacy tickets", async () => {
+    await getTicketsCollection().insertMany([
+      createTicket({
+        cityName: CITY,
+        callSid: "CA-draft-whitespace",
+        createdAt: new Date("2026-05-15T10:00:00.000Z"),
+        updatedAt: new Date("2026-05-15T10:00:00.000Z"),
+        externalCallFields: { event_subject_id: "  \t  " },
+      }),
+      createTicket({
+        cityName: CITY,
+        callSid: "CA-not-draft",
+        createdAt: new Date("2026-05-16T10:00:00.000Z"),
+        updatedAt: new Date("2026-05-16T10:00:00.000Z"),
+        externalCallFields: { event_subject_id: "100" },
+      }),
+    ]);
+    expect(await findCallSidDraftTicketCountsByCity(CITY, mayScope())).toEqual(
+      new Map([["CA-draft-whitespace", 1]]),
+    );
+  });
+
+  it("should use isDraft when set, overriding legacy heuristics", async () => {
+    await getTicketsCollection().insertMany([
+      createTicket({
+        cityName: CITY,
+        callSid: "CA-explicit-draft",
+        isDraft: true,
+        createdAt: new Date("2026-05-15T10:00:00.000Z"),
+        updatedAt: new Date("2026-05-15T10:00:00.000Z"),
+        externalCallFields: { event_subject_id: "100" },
+      }),
+      createTicket({
+        cityName: CITY,
+        callSid: "CA-explicit-not-draft",
+        isDraft: false,
+        createdAt: new Date("2026-05-16T10:00:00.000Z"),
+        updatedAt: new Date("2026-05-16T10:00:00.000Z"),
+        externalCallFields: {},
+      }),
+    ]);
+    expect(await findCallSidDraftTicketCountsByCity(CITY, mayScope())).toEqual(
+      new Map([["CA-explicit-draft", 1]]),
+    );
+  });
+    it("should count multiple tickets on the same callSid", async () => {
+    await getTicketsCollection().insertMany([
+      createTicket({
+        cityName: CITY,
+        callSid: "CA-multi",
+        createdAt: new Date("2026-05-15T10:00:00.000Z"),
+        updatedAt: new Date("2026-05-15T10:00:00.000Z"),
+      }),
+      createTicket({
+        cityName: CITY,
+        callSid: "CA-multi",
+        createdAt: new Date("2026-05-15T11:00:00.000Z"),
+        updatedAt: new Date("2026-05-15T11:00:00.000Z"),
+      }),
+    ]);
+    expect(await findCallSidTicketCountsByCity(CITY, mayScope())).toEqual(new Map([["CA-multi", 2]]));
+  });
+});

package/src/municipal/tickets/index.ts

@@ -1,3 +1,3 @@
-export * from "./tickets.getters";
-export * from "./tickets.statistics.getters";
-export type { Ticket, TicketDoc, SubjectItem, TicketStatsDateScope, TicketSubjectRow } from "./tickets.types";
+export * from "./tickets.getters";
+export * from "./tickets.statistics.getters";
+export type { Ticket, TicketDoc, SubjectItem, TicketStatsDateScope, TicketSubjectRow } from "./tickets.types";

package/src/municipal/tickets/tickets.constants.ts

@@ -1,8 +1,8 @@
-/** Label used when a ticket has no resolvable department/subject. */
-export const UNCLASSIFIED = "ללא מחלקה";
-
-/** Max execution time (ms) for ticket statistics aggregations. */
-export const STATS_MAX_TIME_MS = 30_000;
-
-/** Default look-back window (days) for ticket statistics date ranges. */
-export const DEFAULT_LOOKBACK_DAYS = 30;
+/** Label used when a ticket has no resolvable department/subject. */
+export const UNCLASSIFIED = "ללא מחלקה";
+
+/** Max execution time (ms) for ticket statistics aggregations. */
+export const STATS_MAX_TIME_MS = 30_000;
+
+/** Default look-back window (days) for ticket statistics date ranges. */
+export const DEFAULT_LOOKBACK_DAYS = 30;

package/src/municipal/tickets/tickets.getters.ts

@@ -1,121 +1,121 @@
-import { CityName, getDb, ObjectId, Ticket } from "../index";
-import { Collection, Filter, ObjectId as MongoObjectId } from "mongodb";
-
-/**
- * Generate a new ticket ID as a string
- * @returns A new ObjectId as a string
- */
-export const generateTicketId = (): string => {
-  return new ObjectId().toString();
-};
-
-export const getTicketsCollection = (): Collection<Ticket> => {
-  return getDb().collection<Ticket>("tickets");
-};
-
-export const findTickets = async (
-  filter: Filter<Ticket> = {},
-): Promise<Ticket[]> => {
-  return await getTicketsCollection().find(filter).toArray();
-};
-
-export const findTicketsByCallSid = async (
-  callSid: string,
-): Promise<Ticket[]> => {
-  return await getTicketsCollection().find({ callSid }).toArray();
-};
-
-export const getTicketById = async (
-  ticketId: string,
-): Promise<Ticket | null> => {
-  const ticket = await getTicketsCollection().findOne({
-    _id: new ObjectId(ticketId),
-  });
-  return ticket ? ticket : null;
-};
-
-export const createTicket = async (
-  ticketData: Omit<Ticket, "_id" | "createdAt" | "updatedAt">,
-  ticketId?: string,
-): Promise<MongoObjectId> => {
-  const ticket: Ticket = {
-    _id: ticketId ? new ObjectId(ticketId) : new ObjectId(),
-    ...ticketData,
-    createdAt: new Date(),
-    updatedAt: new Date(),
-  };
-  const { insertedId } = await getTicketsCollection().insertOne(ticket);
-  return insertedId;
-};
-
-export const updateTicket = async (
-  ticketId: string,
-  data: Partial<Omit<Ticket, "_id" | "createdAt" | "updatedAt">>,
-): Promise<Ticket | null> => {
-  const result = await getTicketsCollection().findOneAndUpdate(
-    { _id: new ObjectId(ticketId) },
-    { $set: { ...data, updatedAt: new Date() } },
-    { returnDocument: "after" },
-  );
-  return result || null;
-};
-
-export const deleteTicket = async (ticketId: string): Promise<boolean> => {
-  const result = await getTicketsCollection().deleteOne({
-    _id: new ObjectId(ticketId),
-  });
-  return result.deletedCount > 0;
-};
-
-export const findTicketByQuery = async (query: Partial<Ticket>) => {
-  return await getTicketsCollection().findOne(query);
-};
-/**
- * Update ticket files by external call number
- */
-export const updateTicketFilesByCallNumber = async (params: {
-  cityName: CityName;
-  callNumber: string;
-  image1?: string;
-  image2?: string;
-  image3?: string;
-}): Promise<boolean> => {
-  const { cityName, callNumber, image1, image2, image3 } = params;
-
-  const update: any = {};
-  if (image1) update["externalCallFields.image1"] = image1;
-  if (image2) update["externalCallFields.image2"] = image2;
-  if (image3) update["externalCallFields.image3"] = image3;
-
-  const result = await getTicketsCollection().updateOne(
-    {
-      cityName: cityName,
-      "externalCallFields.call_number": callNumber,
-    },
-    {
-      $set: {
-        ...update,
-        updatedAt: new Date(),
-      },
-    },
-  );
-
-  return result.matchedCount > 0;
-};
-
-/**
- * Remove guestJwt from ticket by external call number
- */
-export const clearGuestJwtByCallNumber = async (params: {
-  cityName: CityName;
-  callNumber: string;
-}): Promise<boolean> => {
-  const { cityName, callNumber } = params;
-
-  const result = await getTicketsCollection().updateOne(
-    { cityName, "externalCallFields.call_number": callNumber },
-    { $unset: { guestJwt: "" }, $set: { updatedAt: new Date() } },
-  );
-
-  return result.matchedCount > 0;
-};
+import { CityName, getDb, ObjectId, Ticket } from "../index";
+import { Collection, Filter, ObjectId as MongoObjectId } from "mongodb";
+
+/**
+ * Generate a new ticket ID as a string
+ * @returns A new ObjectId as a string
+ */
+export const generateTicketId = (): string => {
+  return new ObjectId().toString();
+};
+
+export const getTicketsCollection = (): Collection<Ticket> => {
+  return getDb().collection<Ticket>("tickets");
+};
+
+export const findTickets = async (
+  filter: Filter<Ticket> = {},
+): Promise<Ticket[]> => {
+  return await getTicketsCollection().find(filter).toArray();
+};
+
+export const findTicketsByCallSid = async (
+  callSid: string,
+): Promise<Ticket[]> => {
+  return await getTicketsCollection().find({ callSid }).toArray();
+};
+
+export const getTicketById = async (
+  ticketId: string,
+): Promise<Ticket | null> => {
+  const ticket = await getTicketsCollection().findOne({
+    _id: new ObjectId(ticketId),
+  });
+  return ticket ? ticket : null;
+};
+
+export const createTicket = async (
+  ticketData: Omit<Ticket, "_id" | "createdAt" | "updatedAt">,
+  ticketId?: string,
+): Promise<MongoObjectId> => {
+  const ticket: Ticket = {
+    _id: ticketId ? new ObjectId(ticketId) : new ObjectId(),
+    ...ticketData,
+    createdAt: new Date(),
+    updatedAt: new Date(),
+  };
+  const { insertedId } = await getTicketsCollection().insertOne(ticket);
+  return insertedId;
+};
+
+export const updateTicket = async (
+  ticketId: string,
+  data: Partial<Omit<Ticket, "_id" | "createdAt" | "updatedAt">>,
+): Promise<Ticket | null> => {
+  const result = await getTicketsCollection().findOneAndUpdate(
+    { _id: new ObjectId(ticketId) },
+    { $set: { ...data, updatedAt: new Date() } },
+    { returnDocument: "after" },
+  );
+  return result || null;
+};
+
+export const deleteTicket = async (ticketId: string): Promise<boolean> => {
+  const result = await getTicketsCollection().deleteOne({
+    _id: new ObjectId(ticketId),
+  });
+  return result.deletedCount > 0;
+};
+
+export const findTicketByQuery = async (query: Partial<Ticket>) => {
+  return await getTicketsCollection().findOne(query);
+};
+/**
+ * Update ticket files by external call number
+ */
+export const updateTicketFilesByCallNumber = async (params: {
+  cityName: CityName;
+  callNumber: string;
+  image1?: string;
+  image2?: string;
+  image3?: string;
+}): Promise<boolean> => {
+  const { cityName, callNumber, image1, image2, image3 } = params;
+
+  const update: any = {};
+  if (image1) update["externalCallFields.image1"] = image1;
+  if (image2) update["externalCallFields.image2"] = image2;
+  if (image3) update["externalCallFields.image3"] = image3;
+
+  const result = await getTicketsCollection().updateOne(
+    {
+      cityName: cityName,
+      "externalCallFields.call_number": callNumber,
+    },
+    {
+      $set: {
+        ...update,
+        updatedAt: new Date(),
+      },
+    },
+  );
+
+  return result.matchedCount > 0;
+};
+
+/**
+ * Remove guestJwt from ticket by external call number
+ */
+export const clearGuestJwtByCallNumber = async (params: {
+  cityName: CityName;
+  callNumber: string;
+}): Promise<boolean> => {
+  const { cityName, callNumber } = params;
+
+  const result = await getTicketsCollection().updateOne(
+    { cityName, "externalCallFields.call_number": callNumber },
+    { $unset: { guestJwt: "" }, $set: { updatedAt: new Date() } },
+  );
+
+  return result.matchedCount > 0;
+};