@talkpilot/core-db 1.3.39 → 1.3.41

package/src/talkpilot/clientsConfig/__tests__/clientsConfig.spec.ts

@@ -1,212 +1,212 @@
-import {
-  createClientConfigDoc,
-  getClientConfig,
-  getClientDisplayName,
-} from "../clientsConfig.getters";
-import { createClientConfig } from "../../../test-utils/factories";
-
-describe("db.clientsConfig", () => {
-  describe("getClientConfig", () => {
-    it("should return client config by clientId", async () => {
-      const clientId = "test-client-id";
-      const clientConfig = createClientConfig({
-        clientId,
-        language: "Hebrew",
-        products: { feature1: true, feature2: false } as any,
-      });
-
-      await createClientConfigDoc(clientConfig);
-
-      const result = await getClientConfig(clientId);
-
-      expect(result).toMatchObject({
-        clientId,
-        language: "Hebrew",
-        products: { feature1: true, feature2: false },
-      });
-    });
-
-    it("should support websiteTalk product config", async () => {
-      const clientId = "websiteTalk-test";
-      const clientConfig = createClientConfig({
-        clientId,
-        products: {
-          websiteTalk: {
-            companyName: "Acme Ltd",
-            timezone: "Asia/Jerusalem",
-            language: "he",
-          },
-        },
-      });
-
-      await createClientConfigDoc(clientConfig);
-
-      const result = await getClientConfig(clientId);
-
-      expect(result).toMatchObject({
-        clientId,
-        products: {
-          websiteTalk: {
-            companyName: "Acme Ltd",
-            timezone: "Asia/Jerusalem",
-            language: "he",
-          },
-        },
-      });
-    });
-
-    it("should return null for non-existent clientId", async () => {
-      const result = await getClientConfig("non-existent-client");
-      expect(result).toBeNull();
-    });
-
-    it("should return quota.clientDisplayName when set on client config", async () => {
-      const clientId = "display-name-client";
-      await createClientConfigDoc(
-        createClientConfig({
-          clientId,
-          quota: { totalQuota: 100, usedQuota: 0, clientDisplayName: "Acme Corp" },
-        }),
-      );
-
-      expect(await getClientDisplayName(clientId)).toBe("Acme Corp");
-    });
-
-    it("should return '-' when quota.clientDisplayName is missing", async () => {
-      const clientId = "no-display-name-client";
-      await createClientConfigDoc(
-        createClientConfig({ clientId, quota: { totalQuota: 100, usedQuota: 0 } }),
-      );
-
-      expect(await getClientDisplayName(clientId)).toBe("-");
-    });
-
-    it("should return '-' when client config is missing", async () => {
-      expect(await getClientDisplayName("missing-client")).toBe("-");
-    });
-
-    it("given moked_106 with both toolsPrompts when saved and retrieved then both prompts are persisted", async () => {
-      // Given
-      const clientId = "tools-prompts-both";
-      const clientConfig = createClientConfig({
-        clientId,
-        products: {
-          municipal: {
-            cityName: "ashdod",
-            timezone: "Asia/Jerusalem",
-            moked_106: {
-              toolsPrompts: {
-                findSubjectsSystemPrompt: "Custom subjects prompt",
-                findStreetsSystemPrompt: "Custom streets prompt",
-              },
-            },
-          },
-        },
-      });
-
-      // When
-      await createClientConfigDoc(clientConfig);
-      const result = await getClientConfig(clientId);
-
-      // Then
-      expect(result?.products.municipal?.moked_106?.toolsPrompts).toMatchObject(
-        {
-          findSubjectsSystemPrompt: "Custom subjects prompt",
-          findStreetsSystemPrompt: "Custom streets prompt",
-        },
-      );
-    });
-
-    it("given moked_106 with findSubjectsSystemPrompt only when saved and retrieved then findStreetsSystemPrompt is undefined", async () => {
-      // Given
-      const clientId = "tools-prompts-subjects-only";
-      const clientConfig = createClientConfig({
-        clientId,
-        products: {
-          municipal: {
-            cityName: "ashdod",
-            timezone: "Asia/Jerusalem",
-            moked_106: {
-              toolsPrompts: {
-                findSubjectsSystemPrompt: "Subjects only prompt",
-              },
-            },
-          },
-        },
-      });
-
-      // When
-      await createClientConfigDoc(clientConfig);
-      const result = await getClientConfig(clientId);
-
-      // Then
-      expect(
-        result?.products.municipal?.moked_106?.toolsPrompts
-          ?.findSubjectsSystemPrompt,
-      ).toBe("Subjects only prompt");
-      expect(
-        result?.products.municipal?.moked_106?.toolsPrompts
-          ?.findStreetsSystemPrompt,
-      ).toBeUndefined();
-    });
-
-    it("given moked_106 without toolsPrompts when saved and retrieved then toolsPrompts is undefined", async () => {
-      // Given
-      const clientId = "tools-prompts-absent";
-      const clientConfig = createClientConfig({
-        clientId,
-        products: {
-          municipal: {
-            cityName: "ashdod",
-            timezone: "Asia/Jerusalem",
-            moked_106: {
-              avoidSaveTickets: true,
-            },
-          },
-        },
-      });
-
-      // When
-      await createClientConfigDoc(clientConfig);
-      const result = await getClientConfig(clientId);
-
-      // Then
-      expect(
-        result?.products.municipal?.moked_106?.toolsPrompts,
-      ).toBeUndefined();
-    });
-
-    it("should support communications config", async () => {
-      const clientId = "communications-test";
-      const clientConfig = createClientConfig({
-        clientId,
-        communications: {
-          sendGrid: {
-            emailTo: ["test@example.com"],
-            templateId: "temp-123",
-            senderId: "sender-123",
-          },
-          sms: {},
-          whatsapp: {},
-        },
-      });
-
-      await createClientConfigDoc(clientConfig);
-
-      const result = await getClientConfig(clientId);
-
-      expect(result).toMatchObject({
-        clientId,
-        communications: {
-          sendGrid: {
-            emailTo: ["test@example.com"],
-            templateId: "temp-123",
-            senderId: "sender-123",
-          },
-          sms: {},
-          whatsapp: {},
-        },
-      });
-    });
-  });
-});
+import {
+  createClientConfigDoc,
+  getClientConfig,
+  getClientDisplayName,
+} from "../clientsConfig.getters";
+import { createClientConfig } from "../../../test-utils/factories";
+
+describe("db.clientsConfig", () => {
+  describe("getClientConfig", () => {
+    it("should return client config by clientId", async () => {
+      const clientId = "test-client-id";
+      const clientConfig = createClientConfig({
+        clientId,
+        language: "Hebrew",
+        products: { feature1: true, feature2: false } as any,
+      });
+
+      await createClientConfigDoc(clientConfig);
+
+      const result = await getClientConfig(clientId);
+
+      expect(result).toMatchObject({
+        clientId,
+        language: "Hebrew",
+        products: { feature1: true, feature2: false },
+      });
+    });
+
+    it("should support websiteTalk product config", async () => {
+      const clientId = "websiteTalk-test";
+      const clientConfig = createClientConfig({
+        clientId,
+        products: {
+          websiteTalk: {
+            companyName: "Acme Ltd",
+            timezone: "Asia/Jerusalem",
+            language: "he",
+          },
+        },
+      });
+
+      await createClientConfigDoc(clientConfig);
+
+      const result = await getClientConfig(clientId);
+
+      expect(result).toMatchObject({
+        clientId,
+        products: {
+          websiteTalk: {
+            companyName: "Acme Ltd",
+            timezone: "Asia/Jerusalem",
+            language: "he",
+          },
+        },
+      });
+    });
+
+    it("should return null for non-existent clientId", async () => {
+      const result = await getClientConfig("non-existent-client");
+      expect(result).toBeNull();
+    });
+
+    it("should return quota.clientDisplayName when set on client config", async () => {
+      const clientId = "display-name-client";
+      await createClientConfigDoc(
+        createClientConfig({
+          clientId,
+          quota: { totalQuota: 100, usedQuota: 0, clientDisplayName: "Acme Corp" },
+        }),
+      );
+
+      expect(await getClientDisplayName(clientId)).toBe("Acme Corp");
+    });
+
+    it("should return '-' when quota.clientDisplayName is missing", async () => {
+      const clientId = "no-display-name-client";
+      await createClientConfigDoc(
+        createClientConfig({ clientId, quota: { totalQuota: 100, usedQuota: 0 } }),
+      );
+
+      expect(await getClientDisplayName(clientId)).toBe("-");
+    });
+
+    it("should return '-' when client config is missing", async () => {
+      expect(await getClientDisplayName("missing-client")).toBe("-");
+    });
+
+    it("given moked_106 with both toolsPrompts when saved and retrieved then both prompts are persisted", async () => {
+      // Given
+      const clientId = "tools-prompts-both";
+      const clientConfig = createClientConfig({
+        clientId,
+        products: {
+          municipal: {
+            cityName: "ashdod",
+            timezone: "Asia/Jerusalem",
+            moked_106: {
+              toolsPrompts: {
+                findSubjectsSystemPrompt: "Custom subjects prompt",
+                findStreetsSystemPrompt: "Custom streets prompt",
+              },
+            },
+          },
+        },
+      });
+
+      // When
+      await createClientConfigDoc(clientConfig);
+      const result = await getClientConfig(clientId);
+
+      // Then
+      expect(result?.products.municipal?.moked_106?.toolsPrompts).toMatchObject(
+        {
+          findSubjectsSystemPrompt: "Custom subjects prompt",
+          findStreetsSystemPrompt: "Custom streets prompt",
+        },
+      );
+    });
+
+    it("given moked_106 with findSubjectsSystemPrompt only when saved and retrieved then findStreetsSystemPrompt is undefined", async () => {
+      // Given
+      const clientId = "tools-prompts-subjects-only";
+      const clientConfig = createClientConfig({
+        clientId,
+        products: {
+          municipal: {
+            cityName: "ashdod",
+            timezone: "Asia/Jerusalem",
+            moked_106: {
+              toolsPrompts: {
+                findSubjectsSystemPrompt: "Subjects only prompt",
+              },
+            },
+          },
+        },
+      });
+
+      // When
+      await createClientConfigDoc(clientConfig);
+      const result = await getClientConfig(clientId);
+
+      // Then
+      expect(
+        result?.products.municipal?.moked_106?.toolsPrompts
+          ?.findSubjectsSystemPrompt,
+      ).toBe("Subjects only prompt");
+      expect(
+        result?.products.municipal?.moked_106?.toolsPrompts
+          ?.findStreetsSystemPrompt,
+      ).toBeUndefined();
+    });
+
+    it("given moked_106 without toolsPrompts when saved and retrieved then toolsPrompts is undefined", async () => {
+      // Given
+      const clientId = "tools-prompts-absent";
+      const clientConfig = createClientConfig({
+        clientId,
+        products: {
+          municipal: {
+            cityName: "ashdod",
+            timezone: "Asia/Jerusalem",
+            moked_106: {
+              avoidSaveTickets: true,
+            },
+          },
+        },
+      });
+
+      // When
+      await createClientConfigDoc(clientConfig);
+      const result = await getClientConfig(clientId);
+
+      // Then
+      expect(
+        result?.products.municipal?.moked_106?.toolsPrompts,
+      ).toBeUndefined();
+    });
+
+    it("should support communications config", async () => {
+      const clientId = "communications-test";
+      const clientConfig = createClientConfig({
+        clientId,
+        communications: {
+          sendGrid: {
+            emailTo: ["test@example.com"],
+            templateId: "temp-123",
+            senderId: "sender-123",
+          },
+          sms: {},
+          whatsapp: {},
+        },
+      });
+
+      await createClientConfigDoc(clientConfig);
+
+      const result = await getClientConfig(clientId);
+
+      expect(result).toMatchObject({
+        clientId,
+        communications: {
+          sendGrid: {
+            emailTo: ["test@example.com"],
+            templateId: "temp-123",
+            senderId: "sender-123",
+          },
+          sms: {},
+          whatsapp: {},
+        },
+      });
+    });
+  });
+});

package/src/talkpilot/clientsConfig/clientsConfig.getters.ts

@@ -6,9 +6,8 @@ import {
   KNOWN_PRODUCT_KEYS,
   KnownProductKey,
 } from "../index";
-import { Collection, UpdateFilter } from "mongodb";
+import { Collection } from "mongodb";
 import { resetClientQuotaSettings } from "../clients/clients.quota.getters";
-import { MAX_ACTIVE_SCANS } from "./clientsConfig.constants";
 
 export const getClientsConfigCollection = (): Collection<ClientConfigDoc> => {
   return getDb().collection<ClientConfigDoc>("clientsConfig");
@@ -18,9 +17,7 @@ export const getClientConfig = (clientId: string) => {
   return getClientsConfigCollection().findOne({ clientId });
 };
 
-export const getClientDisplayName = async (
-  clientId: string,
-): Promise<string> => {
+export const getClientDisplayName = async (clientId: string): Promise<string> => {
   const doc = await getClientsConfigCollection().findOne(
     { clientId },
     { projection: { "quota.clientDisplayName": 1, _id: 0 } },
@@ -74,24 +71,6 @@ export const getActiveScanId = async (
   return cfg?.products?.websiteTalk?.activeScanId;
 };
 
-/**
- * Returns the client's active scan ids as a list.
- * Falls back to wrapping the legacy singular `activeScanId` field when
- * `activeScanIds` is absent — lets clients on the old field keep working
- * without a data migration.
- */
-export const getActiveScanIds = async (clientId: string): Promise<string[]> => {
-  const cfg = await getClientConfig(clientId);
-  const list = cfg?.products?.websiteTalk?.activeScanIds;
-  if (list && list.length > 0) return list;
-  const legacy = cfg?.products?.websiteTalk?.activeScanId;
-  return legacy ? [legacy] : [];
-};
-
-/**
- * @deprecated Use `addActiveScanId` instead — supports multiple simultaneously
- * active scans. This function overwrites the entire single-value field.
- */
 export const updateActiveScanId = async (
   clientId: string,
   scanId: string,
@@ -99,38 +78,6 @@ export const updateActiveScanId = async (
   await updateProductConfig(clientId, "websiteTalk", { activeScanId: scanId });
 };
 
-/**
- * Adds a scan id to the client's active list. Writes the full list back
- * (rather than a bare array append) so a client still on the legacy
- * singular field gets migrated instead of silently losing it.
- */
-export const addActiveScanId = async (
-  clientId: string,
-  scanId: string,
-): Promise<void> => {
-  const current = await getActiveScanIds(clientId);
-  if (!current.includes(scanId) && current.length >= MAX_ACTIVE_SCANS) {
-    throw new Error(
-      `Client ${clientId} already has the maximum of ${MAX_ACTIVE_SCANS} active scans`,
-    );
-  }
-  const next = current.includes(scanId) ? current : [...current, scanId];
-  const result = await getClientsConfigCollection().updateOne(
-    { clientId },
-    {
-      $set: { "products.websiteTalk.activeScanIds": next },
-      $unset: { "products.websiteTalk.activeScanId": "" },
-    },
-  );
-  if (result.matchedCount === 0) {
-    throw new Error(`No client config found for clientId: ${clientId}`);
-  }
-};
-
-/**
- * @deprecated Use `removeActiveScanId` instead — removes a single scan from
- * the active list without clearing the others.
- */
 export const clearActiveScanId = async (clientId: string): Promise<void> => {
   const result = await getClientsConfigCollection().updateOne(
     { clientId },
@@ -141,67 +88,6 @@ export const clearActiveScanId = async (clientId: string): Promise<void> => {
   }
 };
 
-/**
- * Removes a single scan id from the active list. Also clears the legacy
- * singular field when it matches, so a not-yet-migrated client's removal
- * actually takes effect instead of silently no-op'ing.
- */
-export const removeActiveScanId = async (
-  clientId: string,
-  scanId: string,
-): Promise<void> => {
-  const cfg = await getClientConfig(clientId);
-  if (!cfg) {
-    throw new Error(`No client config found for clientId: ${clientId}`);
-  }
-  const updateOps: UpdateFilter<ClientConfigDoc> = {
-    $pull: { "products.websiteTalk.activeScanIds": scanId },
-  };
-  if (cfg.products?.websiteTalk?.activeScanId === scanId) {
-    updateOps.$unset = { "products.websiteTalk.activeScanId": "" };
-  }
-  await getClientsConfigCollection().updateOne({ clientId }, updateOps);
-};
-
-/** Returns the scan whose content seeds the phone call's opening description, if one is set. */
-export const getPrimaryScanId = async (
-  clientId: string,
-): Promise<string | undefined> => {
-  const cfg = await getClientConfig(clientId);
-  return cfg?.products?.websiteTalk?.primaryScanId;
-};
-
-/**
- * Sets the primary scan, replacing whatever was set before — exactly one
- * primary scan at a time. Throws if the client doesn't exist.
- */
-export const setPrimaryScanId = async (
-  clientId: string,
-  scanId: string,
-): Promise<void> => {
-  const result = await getClientsConfigCollection().updateOne(
-    { clientId },
-    { $set: { "products.websiteTalk.primaryScanId": scanId } },
-  );
-  if (result.matchedCount === 0) {
-    throw new Error(`No client config found for clientId: ${clientId}`);
-  }
-};
-
-/**
- * Clears the primary scan. Callers that need the opening description fall
- * back to the first active scan. Throws if the client doesn't exist.
- */
-export const clearPrimaryScanId = async (clientId: string): Promise<void> => {
-  const result = await getClientsConfigCollection().updateOne(
-    { clientId },
-    { $unset: { "products.websiteTalk.primaryScanId": "" } },
-  );
-  if (result.matchedCount === 0) {
-    throw new Error(`No client config found for clientId: ${clientId}`);
-  }
-};
-
 export async function listClientIdsWithConfiguredQuota(): Promise<string[]> {
   const docs = await getClientsConfigCollection()
     .find({ "quota.totalQuota": { $exists: true, $ne: null } })

package/src/talkpilot/clientsConfig/clientsConfig.types.ts

@@ -64,10 +64,6 @@ export type WebsiteTalkProduct = {
   timezone: string;
   language: string;
   activeScanId?: string;
-  /** Up to MAX_ACTIVE_SCANS scan ids simultaneously serving RAG for phone calls. */
-  activeScanIds?: string[];
-  /** The single scan whose content seeds the phone call's opening description. */
-  primaryScanId?: string;
 };
 
 // ---------------------------------------------------------------------------

package/src/talkpilot/clientsConfig/index.ts

@@ -1,3 +1,2 @@
-export * from "./clientsConfig.types";
-export * from "./clientsConfig.getters";
-export * from "./clientsConfig.constants";
+export * from "./clientsConfig.types";
+export * from "./clientsConfig.getters";