@talkpilot/core-db 1.3.39 → 1.3.40

package/src/municipal/departmentsSubjects/__tests__/departmentsSubjects.spec.ts

@@ -1,272 +1,272 @@
-import { ObjectId } from 'mongodb';
-import {
-  getDepartmentsSubjectsCollection,
-  getAllDepartmentsSubjectsByCity,
-  bulkWriteDepartmentsSubjects,
-  findDepartmentSubjectsByFilter,
-  updateDepartmentSubjectActive,
-} from '../departmentsSubjects.getters';
-import { createDepartmentSubject } from '../../../test-utils/factories/municipal/departmentsSubjects';
-
-const CITY = 'tests' as const;
-
-describe('DepartmentSubject — isActive field', () => {
-  describe('persistence', () => {
-    it('a document inserted without isActive is retrievable and the field is absent', async () => {
-      const subject = createDepartmentSubject({ cityName: CITY });
-      delete (subject as Partial<typeof subject>).isActive;
-
-      await getDepartmentsSubjectsCollection().insertOne(subject);
-
-      const saved = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
-      expect(saved).not.toBeNull();
-      expect(saved).not.toHaveProperty('isActive');
-    });
-
-    it('isActive: true is persisted and returned', async () => {
-      const subject = createDepartmentSubject({ cityName: CITY, isActive: true });
-      await getDepartmentsSubjectsCollection().insertOne(subject);
-
-      const saved = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
-      expect(saved?.isActive).toBe(true);
-    });
-
-    it('isActive: false is persisted and returned', async () => {
-      const subject = createDepartmentSubject({ cityName: CITY, isActive: false });
-      await getDepartmentsSubjectsCollection().insertOne(subject);
-
-      const saved = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
-      expect(saved?.isActive).toBe(false);
-    });
-  });
-
-  describe('querying', () => {
-    it('getAllDepartmentsSubjectsByCity returns all subjects regardless of isActive', async () => {
-      const activeSubject = createDepartmentSubject({ cityName: CITY, isActive: true });
-      const inactiveSubject = createDepartmentSubject({ cityName: CITY, isActive: false });
-      const noFlagSubject = createDepartmentSubject({ cityName: CITY });
-      delete (noFlagSubject as Partial<typeof noFlagSubject>).isActive;
-
-      await getDepartmentsSubjectsCollection().insertMany([activeSubject, inactiveSubject, noFlagSubject]);
-
-      const all = await getAllDepartmentsSubjectsByCity(CITY);
-      expect(all).toHaveLength(3);
-
-      const active = all.find((s) => s._id.equals(activeSubject._id));
-      const inactive = all.find((s) => s._id.equals(inactiveSubject._id));
-      const noFlag = all.find((s) => s._id.equals(noFlagSubject._id));
-
-      expect(active?.isActive).toBe(true);
-      expect(inactive?.isActive).toBe(false);
-      expect(noFlag?.isActive).toBeUndefined(); // absent in DB → getter is a pass-through, no normalization
-    });
-
-    it('filtering with isActive !== false excludes inactive and includes active and unset documents', async () => {
-      const activeSubject = createDepartmentSubject({ cityName: CITY, isActive: true });
-      const inactiveSubject = createDepartmentSubject({ cityName: CITY, isActive: false });
-      const noFlagSubject = createDepartmentSubject({ cityName: CITY });
-      delete (noFlagSubject as Partial<typeof noFlagSubject>).isActive;
-
-      await getDepartmentsSubjectsCollection().insertMany([activeSubject, inactiveSubject, noFlagSubject]);
-
-      // This is the exact filter pattern used by the sync script to skip already-inactive records
-      const notInactive = await getDepartmentsSubjectsCollection()
-        .find({ cityName: CITY, isActive: { $ne: false } })
-        .toArray();
-
-      expect(notInactive).toHaveLength(2);
-      expect(notInactive.map((s) => s._id.toString())).toEqual(
-        expect.arrayContaining([activeSubject._id.toString(), noFlagSubject._id.toString()])
-      );
-      expect(notInactive.map((s) => s._id.toString())).not.toContain(inactiveSubject._id.toString());
-    });
-  });
-
-  describe('updating', () => {
-    it('isActive can be set to false on an existing active document (deactivation)', async () => {
-      const subject = createDepartmentSubject({ cityName: CITY, isActive: true });
-      await getDepartmentsSubjectsCollection().insertOne(subject);
-
-      await getDepartmentsSubjectsCollection().updateOne(
-        { _id: subject._id },
-        { $set: { isActive: false, updatedAt: new Date() } }
-      );
-
-      const updated = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
-      expect(updated?.isActive).toBe(false);
-    });
-
-    it('isActive can be set to true on a deactivated document (reactivation)', async () => {
-      const subject = createDepartmentSubject({ cityName: CITY, isActive: false });
-      await getDepartmentsSubjectsCollection().insertOne(subject);
-
-      await getDepartmentsSubjectsCollection().updateOne(
-        { _id: subject._id },
-        { $set: { isActive: true, updatedAt: new Date() } }
-      );
-
-      const updated = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
-      expect(updated?.isActive).toBe(true);
-    });
-
-    it('deactivating a subject does not touch other fields', async () => {
-      const subject = createDepartmentSubject({
-        cityName: CITY,
-        isActive: true,
-        guidelines: 'handle with care',
-        instructions: [{ id: 1, instruction: 'call back within 2h' }],
-        sla: 48,
-      });
-      await getDepartmentsSubjectsCollection().insertOne(subject);
-
-      await getDepartmentsSubjectsCollection().updateOne(
-        { _id: subject._id },
-        { $set: { isActive: false, updatedAt: new Date() } }
-      );
-
-      const updated = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
-      expect(updated?.isActive).toBe(false);
-      expect(updated?.guidelines).toBe('handle with care');
-      expect(updated?.instructions).toEqual([{ id: 1, instruction: 'call back within 2h' }]);
-      expect(updated?.sla).toBe(48);
-    });
-  });
-
-  describe('bulkWriteDepartmentsSubjects', () => {
-    it('applies upsert and update operations from a single batch', async () => {
-      const existing = createDepartmentSubject({ cityName: CITY, subjectName: 'Old Name' });
-      await getDepartmentsSubjectsCollection().insertOne(existing);
-
-      const result = await bulkWriteDepartmentsSubjects(
-        [
-          {
-            updateOne: {
-              filter: { _id: existing._id },
-              update: { $set: { subjectName: 'New Name' } },
-            },
-          },
-          {
-            updateOne: {
-              filter: { cityName: CITY, subject_id: 'brand-new', sub_subject_id: 'sub-1' },
-              update: {
-                $set: { subjectName: 'Brand New Subject', sub_subject_name: 'Sub One' },
-                $setOnInsert: {
-                  subject_id: 'brand-new',
-                  sub_subject_id: 'sub-1',
-                  cityName: CITY,
-                  instructions: [],
-                  descriptions: [],
-                  createdAt: new Date(),
-                  isActive: true,
-                },
-              },
-              upsert: true,
-            },
-          },
-        ],
-        { ordered: false }
-      );
-
-      expect(result.modifiedCount).toBe(1);
-      expect(result.upsertedCount).toBe(1);
-
-      const updated = await getDepartmentsSubjectsCollection().findOne({ _id: existing._id });
-      expect(updated?.subjectName).toBe('New Name');
-
-      const inserted = await getDepartmentsSubjectsCollection().findOne({
-        subject_id: 'brand-new',
-        sub_subject_id: 'sub-1',
-      });
-      expect(inserted?.subjectName).toBe('Brand New Subject');
-    });
-
-    it('propagates a MongoBulkWriteError for an invalid operation, preserving partial results', async () => {
-      const existing = createDepartmentSubject({ cityName: CITY });
-      await getDepartmentsSubjectsCollection().insertOne(existing);
-
-      await expect(
-        bulkWriteDepartmentsSubjects(
-          [
-            {
-              updateOne: {
-                filter: { _id: existing._id },
-                update: { $set: { subjectName: 'Valid Update' } },
-              },
-            },
-            {
-              insertOne: {
-                // Duplicate _id triggers a write error without aborting the ordered:false batch
-                document: { ...existing },
-              },
-            },
-          ],
-          { ordered: false }
-        )
-      ).rejects.toMatchObject({ name: 'MongoBulkWriteError' });
-
-      const updated = await getDepartmentsSubjectsCollection().findOne({ _id: existing._id });
-      expect(updated?.subjectName).toBe('Valid Update');
-    });
-  });
-
-  describe('findDepartmentSubjectsByFilter', () => {
-    it('returns all documents matching the given filter', async () => {
-      const match1 = createDepartmentSubject({ cityName: CITY, subject_id: 'r1', sub_subject_id: 's1' });
-      const match2 = createDepartmentSubject({ cityName: CITY, subject_id: 'r1', sub_subject_id: 's2' });
-      const nonMatch = createDepartmentSubject({ cityName: CITY, subject_id: 'r2', sub_subject_id: 's3' });
-      await getDepartmentsSubjectsCollection().insertMany([match1, match2, nonMatch]);
-
-      const docs = await findDepartmentSubjectsByFilter({ cityName: CITY, subject_id: 'r1' });
-
-      expect(docs.map((doc) => doc._id.toString())).toEqual(
-        expect.arrayContaining([match1._id.toString(), match2._id.toString()])
-      );
-      expect(docs).toHaveLength(2);
-    });
-
-    it('returns an empty array when nothing matches', async () => {
-      const docs = await findDepartmentSubjectsByFilter({
-        cityName: CITY,
-        subject_id: 'does-not-exist',
-      });
-      expect(docs).toEqual([]);
-    });
-  });
-
-  describe('updateDepartmentSubjectActive', () => {
-    it('sets isActive on the document with the given _id and returns it', async () => {
-      const subject = createDepartmentSubject({ cityName: CITY, isActive: true });
-      await getDepartmentsSubjectsCollection().insertOne(subject);
-
-      const updated = await updateDepartmentSubjectActive(subject._id, false);
-
-      expect(updated?.isActive).toBe(false);
-      const saved = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
-      expect(saved?.isActive).toBe(false);
-    });
-
-    it('returns null when no document matches the given _id', async () => {
-      const updated = await updateDepartmentSubjectActive(new ObjectId(), true);
-      expect(updated).toBeNull();
-    });
-
-    it('does not touch other fields when updating isActive', async () => {
-      const subject = createDepartmentSubject({
-        cityName: CITY,
-        isActive: true,
-        guidelines: 'handle with care',
-        instructions: [{ id: 1, instruction: 'call back within 2h' }],
-        sla: 48,
-      });
-      await getDepartmentsSubjectsCollection().insertOne(subject);
-
-      await updateDepartmentSubjectActive(subject._id, false);
-
-      const updated = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
-      expect(updated?.isActive).toBe(false);
-      expect(updated?.guidelines).toBe('handle with care');
-      expect(updated?.instructions).toEqual([{ id: 1, instruction: 'call back within 2h' }]);
-      expect(updated?.sla).toBe(48);
-    });
-  });
-});
+import { ObjectId } from 'mongodb';
+import {
+  getDepartmentsSubjectsCollection,
+  getAllDepartmentsSubjectsByCity,
+  bulkWriteDepartmentsSubjects,
+  findDepartmentSubjectsByFilter,
+  updateDepartmentSubjectActive,
+} from '../departmentsSubjects.getters';
+import { createDepartmentSubject } from '../../../test-utils/factories/municipal/departmentsSubjects';
+
+const CITY = 'tests' as const;
+
+describe('DepartmentSubject — isActive field', () => {
+  describe('persistence', () => {
+    it('a document inserted without isActive is retrievable and the field is absent', async () => {
+      const subject = createDepartmentSubject({ cityName: CITY });
+      delete (subject as Partial<typeof subject>).isActive;
+
+      await getDepartmentsSubjectsCollection().insertOne(subject);
+
+      const saved = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
+      expect(saved).not.toBeNull();
+      expect(saved).not.toHaveProperty('isActive');
+    });
+
+    it('isActive: true is persisted and returned', async () => {
+      const subject = createDepartmentSubject({ cityName: CITY, isActive: true });
+      await getDepartmentsSubjectsCollection().insertOne(subject);
+
+      const saved = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
+      expect(saved?.isActive).toBe(true);
+    });
+
+    it('isActive: false is persisted and returned', async () => {
+      const subject = createDepartmentSubject({ cityName: CITY, isActive: false });
+      await getDepartmentsSubjectsCollection().insertOne(subject);
+
+      const saved = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
+      expect(saved?.isActive).toBe(false);
+    });
+  });
+
+  describe('querying', () => {
+    it('getAllDepartmentsSubjectsByCity returns all subjects regardless of isActive', async () => {
+      const activeSubject = createDepartmentSubject({ cityName: CITY, isActive: true });
+      const inactiveSubject = createDepartmentSubject({ cityName: CITY, isActive: false });
+      const noFlagSubject = createDepartmentSubject({ cityName: CITY });
+      delete (noFlagSubject as Partial<typeof noFlagSubject>).isActive;
+
+      await getDepartmentsSubjectsCollection().insertMany([activeSubject, inactiveSubject, noFlagSubject]);
+
+      const all = await getAllDepartmentsSubjectsByCity(CITY);
+      expect(all).toHaveLength(3);
+
+      const active = all.find((s) => s._id.equals(activeSubject._id));
+      const inactive = all.find((s) => s._id.equals(inactiveSubject._id));
+      const noFlag = all.find((s) => s._id.equals(noFlagSubject._id));
+
+      expect(active?.isActive).toBe(true);
+      expect(inactive?.isActive).toBe(false);
+      expect(noFlag?.isActive).toBeUndefined(); // absent in DB → getter is a pass-through, no normalization
+    });
+
+    it('filtering with isActive !== false excludes inactive and includes active and unset documents', async () => {
+      const activeSubject = createDepartmentSubject({ cityName: CITY, isActive: true });
+      const inactiveSubject = createDepartmentSubject({ cityName: CITY, isActive: false });
+      const noFlagSubject = createDepartmentSubject({ cityName: CITY });
+      delete (noFlagSubject as Partial<typeof noFlagSubject>).isActive;
+
+      await getDepartmentsSubjectsCollection().insertMany([activeSubject, inactiveSubject, noFlagSubject]);
+
+      // This is the exact filter pattern used by the sync script to skip already-inactive records
+      const notInactive = await getDepartmentsSubjectsCollection()
+        .find({ cityName: CITY, isActive: { $ne: false } })
+        .toArray();
+
+      expect(notInactive).toHaveLength(2);
+      expect(notInactive.map((s) => s._id.toString())).toEqual(
+        expect.arrayContaining([activeSubject._id.toString(), noFlagSubject._id.toString()])
+      );
+      expect(notInactive.map((s) => s._id.toString())).not.toContain(inactiveSubject._id.toString());
+    });
+  });
+
+  describe('updating', () => {
+    it('isActive can be set to false on an existing active document (deactivation)', async () => {
+      const subject = createDepartmentSubject({ cityName: CITY, isActive: true });
+      await getDepartmentsSubjectsCollection().insertOne(subject);
+
+      await getDepartmentsSubjectsCollection().updateOne(
+        { _id: subject._id },
+        { $set: { isActive: false, updatedAt: new Date() } }
+      );
+
+      const updated = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
+      expect(updated?.isActive).toBe(false);
+    });
+
+    it('isActive can be set to true on a deactivated document (reactivation)', async () => {
+      const subject = createDepartmentSubject({ cityName: CITY, isActive: false });
+      await getDepartmentsSubjectsCollection().insertOne(subject);
+
+      await getDepartmentsSubjectsCollection().updateOne(
+        { _id: subject._id },
+        { $set: { isActive: true, updatedAt: new Date() } }
+      );
+
+      const updated = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
+      expect(updated?.isActive).toBe(true);
+    });
+
+    it('deactivating a subject does not touch other fields', async () => {
+      const subject = createDepartmentSubject({
+        cityName: CITY,
+        isActive: true,
+        guidelines: 'handle with care',
+        instructions: [{ id: 1, instruction: 'call back within 2h' }],
+        sla: 48,
+      });
+      await getDepartmentsSubjectsCollection().insertOne(subject);
+
+      await getDepartmentsSubjectsCollection().updateOne(
+        { _id: subject._id },
+        { $set: { isActive: false, updatedAt: new Date() } }
+      );
+
+      const updated = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
+      expect(updated?.isActive).toBe(false);
+      expect(updated?.guidelines).toBe('handle with care');
+      expect(updated?.instructions).toEqual([{ id: 1, instruction: 'call back within 2h' }]);
+      expect(updated?.sla).toBe(48);
+    });
+  });
+
+  describe('bulkWriteDepartmentsSubjects', () => {
+    it('applies upsert and update operations from a single batch', async () => {
+      const existing = createDepartmentSubject({ cityName: CITY, subjectName: 'Old Name' });
+      await getDepartmentsSubjectsCollection().insertOne(existing);
+
+      const result = await bulkWriteDepartmentsSubjects(
+        [
+          {
+            updateOne: {
+              filter: { _id: existing._id },
+              update: { $set: { subjectName: 'New Name' } },
+            },
+          },
+          {
+            updateOne: {
+              filter: { cityName: CITY, subject_id: 'brand-new', sub_subject_id: 'sub-1' },
+              update: {
+                $set: { subjectName: 'Brand New Subject', sub_subject_name: 'Sub One' },
+                $setOnInsert: {
+                  subject_id: 'brand-new',
+                  sub_subject_id: 'sub-1',
+                  cityName: CITY,
+                  instructions: [],
+                  descriptions: [],
+                  createdAt: new Date(),
+                  isActive: true,
+                },
+              },
+              upsert: true,
+            },
+          },
+        ],
+        { ordered: false }
+      );
+
+      expect(result.modifiedCount).toBe(1);
+      expect(result.upsertedCount).toBe(1);
+
+      const updated = await getDepartmentsSubjectsCollection().findOne({ _id: existing._id });
+      expect(updated?.subjectName).toBe('New Name');
+
+      const inserted = await getDepartmentsSubjectsCollection().findOne({
+        subject_id: 'brand-new',
+        sub_subject_id: 'sub-1',
+      });
+      expect(inserted?.subjectName).toBe('Brand New Subject');
+    });
+
+    it('propagates a MongoBulkWriteError for an invalid operation, preserving partial results', async () => {
+      const existing = createDepartmentSubject({ cityName: CITY });
+      await getDepartmentsSubjectsCollection().insertOne(existing);
+
+      await expect(
+        bulkWriteDepartmentsSubjects(
+          [
+            {
+              updateOne: {
+                filter: { _id: existing._id },
+                update: { $set: { subjectName: 'Valid Update' } },
+              },
+            },
+            {
+              insertOne: {
+                // Duplicate _id triggers a write error without aborting the ordered:false batch
+                document: { ...existing },
+              },
+            },
+          ],
+          { ordered: false }
+        )
+      ).rejects.toMatchObject({ name: 'MongoBulkWriteError' });
+
+      const updated = await getDepartmentsSubjectsCollection().findOne({ _id: existing._id });
+      expect(updated?.subjectName).toBe('Valid Update');
+    });
+  });
+
+  describe('findDepartmentSubjectsByFilter', () => {
+    it('returns all documents matching the given filter', async () => {
+      const match1 = createDepartmentSubject({ cityName: CITY, subject_id: 'r1', sub_subject_id: 's1' });
+      const match2 = createDepartmentSubject({ cityName: CITY, subject_id: 'r1', sub_subject_id: 's2' });
+      const nonMatch = createDepartmentSubject({ cityName: CITY, subject_id: 'r2', sub_subject_id: 's3' });
+      await getDepartmentsSubjectsCollection().insertMany([match1, match2, nonMatch]);
+
+      const docs = await findDepartmentSubjectsByFilter({ cityName: CITY, subject_id: 'r1' });
+
+      expect(docs.map((doc) => doc._id.toString())).toEqual(
+        expect.arrayContaining([match1._id.toString(), match2._id.toString()])
+      );
+      expect(docs).toHaveLength(2);
+    });
+
+    it('returns an empty array when nothing matches', async () => {
+      const docs = await findDepartmentSubjectsByFilter({
+        cityName: CITY,
+        subject_id: 'does-not-exist',
+      });
+      expect(docs).toEqual([]);
+    });
+  });
+
+  describe('updateDepartmentSubjectActive', () => {
+    it('sets isActive on the document with the given _id and returns it', async () => {
+      const subject = createDepartmentSubject({ cityName: CITY, isActive: true });
+      await getDepartmentsSubjectsCollection().insertOne(subject);
+
+      const updated = await updateDepartmentSubjectActive(subject._id, false);
+
+      expect(updated?.isActive).toBe(false);
+      const saved = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
+      expect(saved?.isActive).toBe(false);
+    });
+
+    it('returns null when no document matches the given _id', async () => {
+      const updated = await updateDepartmentSubjectActive(new ObjectId(), true);
+      expect(updated).toBeNull();
+    });
+
+    it('does not touch other fields when updating isActive', async () => {
+      const subject = createDepartmentSubject({
+        cityName: CITY,
+        isActive: true,
+        guidelines: 'handle with care',
+        instructions: [{ id: 1, instruction: 'call back within 2h' }],
+        sla: 48,
+      });
+      await getDepartmentsSubjectsCollection().insertOne(subject);
+
+      await updateDepartmentSubjectActive(subject._id, false);
+
+      const updated = await getDepartmentsSubjectsCollection().findOne({ _id: subject._id });
+      expect(updated?.isActive).toBe(false);
+      expect(updated?.guidelines).toBe('handle with care');
+      expect(updated?.instructions).toEqual([{ id: 1, instruction: 'call back within 2h' }]);
+      expect(updated?.sla).toBe(48);
+    });
+  });
+});