@takodotid/circuit 0.18.3 → 0.18.4

package/dist/cli/index.js

@@ -792,7 +792,8 @@ async function apply(device, _network, plan) {
     for (const step of plan.steps) {
       for (const line of step.send) {
         let answer = await send(channel, substitute(line), 20000, 2000);
-        if (/[[(]y\/n[\])]|input 'y'/i.test(answer) || CONFIRM.test(line))
+        const asks = /[[(]y\/n[\])]|input 'y'/i.test(answer) || CONFIRM.test(line) && !/set successfully/i.test(answer);
+        if (asks)
           answer += await send(channel, "y", 1e4, 1000);
         if (REFUSED.test(answer))
           throw new Error(`${step.title}: ${line}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@takodotid/circuit",
-    "version": "0.18.3",
+    "version": "0.18.4",
     "description": "Declarative, vendor-neutral network configuration: describe each device in TypeScript, and Circuit makes the device match. Alpha.",
     "keywords": [
         "network",

package/src/adapters/devices/raisecom-ros/TRAPS.md

@@ -7,7 +7,7 @@ Behaviour that looks like something else. Each one has been hit on a RAX721 runn
 - `show running-config` stops about halfway with no error unless `terminal page-break disable` is sent first and the read waits several seconds of silence.
 - A `?` sent by a script is executed. Once it applied an address with a /8 mask.
 - An access-list cannot change while any service holds it: `ACL 1000 is in use`. Every holder is released first and bound again after. `no ssh2 access-list` needs the list number.
-- `portswitch`, `switchport trunk allowed vlan` and `switchport mode` ask for `y` and do nothing without it.
+- `portswitch`, `switchport trunk allowed vlan` and `switchport mode` ask for `y` and do nothing without it, except when they need no confirming: `switchport mode trunk` on a port leaving access mode answers `Set successfully` at once, and a `y` sent after it is refused, `Error input`.
 - A VLAN is removed with `no vlan <id>`, not `no create vlan`.
 - The factory account `raisecom` cannot be removed and its service type cannot change. Only its password is ours.
 - Factory SNMP communities survive hardening, and `private` can write. The render removes both.

package/src/adapters/devices/raisecom-ros/index.ts

@@ -479,7 +479,9 @@ export async function apply(device: Device, _network: readonly Device[], plan: P
         for (const step of plan.steps) {
             for (const line of step.send) {
                 let answer = await send(channel, substitute(line), 20_000, 2000);
-                if (/[[(]y\/n[\])]|input 'y'/i.test(answer) || CONFIRM.test(line)) answer += await send(channel, "y", 10_000, 1000);
+                // A confirming line asks for `y` unless the change needs no confirming, when the device sets it at once.
+                const asks = /[[(]y\/n[\])]|input 'y'/i.test(answer) || (CONFIRM.test(line) && !/set successfully/i.test(answer));
+                if (asks) answer += await send(channel, "y", 10_000, 1000);
                 if (REFUSED.test(answer)) throw new Error(`${step.title}: ${line}\n    device said: ${answer.trim().slice(0, 300)}`);
 
                 const release = RELEASE.exec(line);