@tailor-platform/erp-kit 0.8.0 → 0.9.0

package/src/modules/coa-management/command/activateChartOfAccounts.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it, vi } from "vitest";
+import { describe, expect, it } from "vitest";
 import { createMockDb } from "../../../testing/index";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
@@ -7,7 +7,7 @@ import {
   DuplicateActiveChartOfAccountsError,
 } from "../lib/errors.generated";
 import { baseDraftCoa, baseActiveCoa, baseArchivedCoa } from "../testing/fixtures";
-import { run, type AuditCommands } from "./activateChartOfAccounts";
+import { run } from "./activateChartOfAccounts";
 import type { CommandContext } from "@tailor-platform/erp-kit/module";
 
 const ctx: CommandContext = {
@@ -81,33 +81,4 @@ describe("activateChartOfAccounts", () => {
       expect(result.value.chartOfAccounts.status).toBe("ACTIVE");
     }
   });
-
-  it("emits audit event recording status transition from DRAFT to ACTIVE", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    const activatedCoa = { ...baseDraftCoa, status: "ACTIVE" };
-    spies.select
-      .mockReturnValueOnce(baseDraftCoa) // CoA lookup
-      .mockReturnValueOnce(undefined); // no existing ACTIVE CoA
-    spies.update.mockReturnValue(activatedCoa);
-
-    const mockLogAuditEvent = vi.fn().mockResolvedValue({ ok: true, value: {} });
-    const auditCommands: AuditCommands = { logAuditEvent: mockLogAuditEvent };
-
-    const result = await run(db, { id: baseDraftCoa.id }, ctx, auditCommands);
-
-    expect(result.ok).toBe(true);
-    expect(mockLogAuditEvent).toHaveBeenCalledWith(
-      db,
-      expect.objectContaining({
-        entityType: "ChartOfAccounts",
-        entityId: baseDraftCoa.id,
-        operationType: "UPDATE",
-        companyId: baseDraftCoa.companyId,
-        actorType: "USER",
-        actorId: ctx.actorId,
-        changes: [{ fieldName: "status", oldValue: "DRAFT", newValue: "ACTIVE" }],
-      }),
-      ctx,
-    );
-  });
 });

package/src/modules/coa-management/command/activateChartOfAccounts.ts

@@ -1,4 +1,3 @@
-import { randomUUID } from "node:crypto";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
   ChartOfAccountsNotFoundError,
@@ -12,23 +11,6 @@ export interface ActivateChartOfAccountsInput {
   from?: string[];
 }
 
-export interface AuditCommands {
-  logAuditEvent: (
-    db: Transaction,
-    input: {
-      eventId: string;
-      actorType: string;
-      actorId: string;
-      entityType: string;
-      entityId: string;
-      operationType: string;
-      companyId?: string;
-      changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[];
-    },
-    ctx: CommandContext,
-  ) => Promise<{ ok: true; value: unknown }>;
-}
-
 /**
  * Function: activateChartOfAccounts
  *
@@ -38,8 +20,7 @@ export interface AuditCommands {
 export async function run(
   db: Transaction,
   input: ActivateChartOfAccountsInput,
-  ctx: CommandContext,
-  auditCommands?: AuditCommands,
+  _ctx: CommandContext,
 ) {
   const { id, from = ["DRAFT"] } = input;
 
@@ -83,22 +64,5 @@ export async function run(
     .returningAll()
     .executeTakeFirst();
 
-  if (auditCommands) {
-    await auditCommands.logAuditEvent(
-      db,
-      {
-        eventId: randomUUID(),
-        actorType: "USER",
-        actorId: ctx.actorId,
-        entityType: "ChartOfAccounts",
-        entityId: id,
-        operationType: "UPDATE",
-        companyId: existing.companyId,
-        changes: [{ fieldName: "status", oldValue: existing.status, newValue: "ACTIVE" }],
-      },
-      ctx,
-    );
-  }
-
   return ok({ chartOfAccounts: chartOfAccounts! });
 }

package/src/modules/coa-management/command/createAccount.test.ts

@@ -710,34 +710,6 @@ describe("createAccount", () => {
     }
   });
 
-  it("emits audit event recording acting user, timestamp, CoA reference, account code, and classification", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    const created = {
-      ...baseDraftAccount,
-      code: "1500",
-      name: "Audit Account",
-    };
-    spies.select.mockReturnValueOnce(baseActiveCoa).mockReturnValueOnce(undefined);
-    spies.insert.mockReturnValue(created);
-
-    const result = await run(
-      db,
-      {
-        chartOfAccountsId: baseActiveCoa.id,
-        code: "1500",
-        name: "Audit Account",
-        accountType: "ASSET",
-      },
-      ctx,
-    );
-
-    // Audit event is emitted as part of successful creation
-    expect(result.ok).toBe(true);
-    if (result.ok) {
-      expect(result.value.account).toBeDefined();
-    }
-  });
-
   it("passes custom fields through to insert", async () => {
     const { db, spies } = createMockDb<Transaction>();
     const created = {

package/src/modules/coa-management/command/createAccount.ts

@@ -1,4 +1,3 @@
-import { randomUUID } from "node:crypto";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
   ChartOfAccountsNotFoundError,
@@ -34,23 +33,6 @@ export interface CreateAccountInput {
   accountGroupId?: string;
 }
 
-export interface AuditCommands {
-  logAuditEvent: (
-    db: Transaction,
-    input: {
-      eventId: string;
-      actorType: string;
-      actorId: string;
-      entityType: string;
-      entityId: string;
-      operationType: string;
-      companyId?: string;
-      changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[];
-    },
-    ctx: CommandContext,
-  ) => Promise<{ ok: true; value: unknown }>;
-}
-
 interface GetCurrencyDep {
   getCurrency: (
     db: Transaction,
@@ -81,7 +63,6 @@ export async function run<CF extends Record<string, unknown>>(
   input: CreateAccountInput & CF,
   ctx: CommandContext,
   deps?: GetCurrencyDep,
-  auditCommands?: AuditCommands,
 ) {
   const {
     chartOfAccountsId,
@@ -219,29 +200,5 @@ export async function run<CF extends Record<string, unknown>>(
     .returningAll()
     .executeTakeFirst();
 
-  // 11. Emit audit event
-  if (auditCommands) {
-    await auditCommands.logAuditEvent(
-      db,
-      {
-        eventId: randomUUID(),
-        actorType: "USER",
-        actorId: ctx.actorId,
-        entityType: "Account",
-        entityId: account!.id,
-        operationType: "CREATE",
-        companyId: coa.companyId,
-        changes: [
-          { fieldName: "code", newValue: code },
-          { fieldName: "name", newValue: name },
-          { fieldName: "accountType", newValue: accountType },
-          { fieldName: "classification", newValue: classification },
-          { fieldName: "reconciliation", newValue: reconciliation },
-        ],
-      },
-      ctx,
-    );
-  }
-
   return ok({ account: account! });
 }

package/src/modules/coa-management/command/createAccountGroup.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it, vi } from "vitest";
+import { describe, expect, it } from "vitest";
 import { createMockDb } from "../../../testing/index";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
@@ -11,7 +11,7 @@ import {
   InvalidNumberRangeError,
 } from "../lib/errors.generated";
 import { baseActiveCoa, baseArchivedCoa, baseRootGroup, baseChildGroup } from "../testing/fixtures";
-import { run, type AuditCommands } from "./createAccountGroup";
+import { run } from "./createAccountGroup";
 import type { CommandContext } from "@tailor-platform/erp-kit/module";
 
 const ctx: CommandContext = {
@@ -414,55 +414,6 @@ describe("createAccountGroup", () => {
     }
   });
 
-  it("emits audit event recording acting user, timestamp, CoA reference, group code, and initial field values", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    const createdGroup = {
-      ...baseRootGroup,
-      id: "new-group-id",
-      code: "4000",
-      name: "Expenses",
-      createdAt: new Date(),
-    };
-    spies.select
-      .mockReturnValueOnce(baseActiveCoa) // CoA lookup
-      .mockReturnValueOnce(undefined); // No duplicate code
-    spies.insert.mockReturnValue(createdGroup);
-
-    const mockLogAuditEvent = vi.fn().mockResolvedValue({ ok: true, value: {} });
-    const auditCommands: AuditCommands = { logAuditEvent: mockLogAuditEvent };
-
-    const result = await run(
-      db,
-      {
-        chartOfAccountsId: baseActiveCoa.id,
-        code: "4000",
-        name: "Expenses",
-      },
-      ctx,
-      auditCommands,
-    );
-
-    expect(result.ok).toBe(true);
-    expect(mockLogAuditEvent).toHaveBeenCalledWith(
-      db,
-      expect.objectContaining({
-        entityType: "AccountGroup",
-        entityId: "new-group-id",
-        operationType: "CREATE",
-        companyId: baseActiveCoa.companyId,
-        actorType: "USER",
-        actorId: ctx.actorId,
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-        changes: expect.arrayContaining([
-          { fieldName: "chartOfAccountsId", newValue: baseActiveCoa.id },
-          { fieldName: "code", newValue: "4000" },
-          { fieldName: "name", newValue: "Expenses" },
-        ]),
-      }),
-      ctx,
-    );
-  });
-
   it("passes custom fields through to insert", async () => {
     const { db, spies } = createMockDb<Transaction>();
     const createdGroup = {

package/src/modules/coa-management/command/createAccountGroup.ts

@@ -1,4 +1,3 @@
-import { randomUUID } from "node:crypto";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
   ChartOfAccountsNotFoundError,
@@ -21,23 +20,6 @@ export interface CreateAccountGroupInput {
   numberRangeEnd?: number | null;
 }
 
-export interface AuditCommands {
-  logAuditEvent: (
-    db: Transaction,
-    input: {
-      eventId: string;
-      actorType: string;
-      actorId: string;
-      entityType: string;
-      entityId: string;
-      operationType: string;
-      companyId?: string;
-      changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[];
-    },
-    ctx: CommandContext,
-  ) => Promise<{ ok: true; value: unknown }>;
-}
-
 /**
  * Function: createAccountGroup
  *
@@ -48,8 +30,7 @@ export interface AuditCommands {
 export async function run<CF extends Record<string, unknown>>(
   db: Transaction,
   input: CreateAccountGroupInput & CF,
-  ctx: CommandContext,
-  auditCommands?: AuditCommands,
+  _ctx: CommandContext,
 ) {
   const {
     chartOfAccountsId,
@@ -167,41 +148,5 @@ export async function run<CF extends Record<string, unknown>>(
     .returningAll()
     .executeTakeFirst();
 
-  // 9. Emit audit event
-  if (auditCommands) {
-    const changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[] = [
-      { fieldName: "chartOfAccountsId", newValue: chartOfAccountsId },
-      { fieldName: "code", newValue: code },
-      { fieldName: "name", newValue: name },
-    ];
-    if (parentAccountGroupId) {
-      changes.push({ fieldName: "parentAccountGroupId", newValue: parentAccountGroupId });
-    }
-    if (sortOrder !== undefined && sortOrder !== null) {
-      changes.push({ fieldName: "sortOrder", newValue: sortOrder });
-    }
-    if (rangeStart !== null) {
-      changes.push({ fieldName: "numberRangeStart", newValue: rangeStart });
-    }
-    if (rangeEnd !== null) {
-      changes.push({ fieldName: "numberRangeEnd", newValue: rangeEnd });
-    }
-
-    await auditCommands.logAuditEvent(
-      db,
-      {
-        eventId: randomUUID(),
-        actorType: "USER",
-        actorId: ctx.actorId,
-        entityType: "AccountGroup",
-        entityId: accountGroup!.id,
-        operationType: "CREATE",
-        companyId: coa.companyId,
-        changes,
-      },
-      ctx,
-    );
-  }
-
   return ok({ accountGroup: accountGroup! });
 }

package/src/modules/coa-management/command/createChartOfAccounts.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it, vi } from "vitest";
+import { describe, expect, it } from "vitest";
 import { createMockDb } from "../../../testing/index";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
@@ -441,54 +441,6 @@ describe("createChartOfAccounts", () => {
       expect(result.value.chartOfAccounts.status).toBe("DRAFT");
     }
   });
-
-  it("emits audit event recording acting user, timestamp, and initial field values", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    const createdCoa = { ...baseDraftCoa, id: "new-coa-id" };
-    spies.select.mockReturnValueOnce(baseActiveCompany);
-    spies.insert.mockReturnValue(createdCoa);
-
-    const mockLogAuditEvent = vi.fn().mockResolvedValue({ ok: true, value: {} });
-    const auditCommands = { logAuditEvent: mockLogAuditEvent };
-
-    const result = await run(db, validInput, ctx, undefined, undefined, auditCommands);
-
-    expect(result.ok).toBe(true);
-    expect(mockLogAuditEvent).toHaveBeenCalledWith(
-      db,
-      expect.objectContaining({
-        entityType: "ChartOfAccounts",
-        entityId: "new-coa-id",
-        operationType: "CREATE",
-        companyId: validInput.companyId,
-        actorType: "USER",
-        actorId: ctx.actorId,
-      }),
-      ctx,
-    );
-  });
-
-  it("audit event includes whether CoA was created from template or blank", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    const createdCoa = { ...baseDraftCoa, id: "new-coa-id" };
-    spies.select.mockReturnValueOnce(baseActiveCompany);
-    spies.insert.mockReturnValue(createdCoa);
-
-    const mockLogAuditEvent = vi.fn().mockResolvedValue({ ok: true, value: {} });
-    const auditCommands = { logAuditEvent: mockLogAuditEvent };
-
-    // Test blank creation
-    await run(db, validInput, ctx, undefined, undefined, auditCommands);
-
-    expect(mockLogAuditEvent).toHaveBeenCalledWith(
-      db,
-      expect.objectContaining({
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-        changes: expect.arrayContaining([{ fieldName: "templateUsed", newValue: "blank" }]),
-      }),
-      ctx,
-    );
-  });
 });
 
 // Helper type for custom fields test

package/src/modules/coa-management/command/createChartOfAccounts.ts

@@ -1,4 +1,3 @@
-import { randomUUID } from "node:crypto";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
   NameRequiredError,
@@ -51,23 +50,6 @@ export interface TemplateProvider {
   resolveTemplate: (id: string) => Promise<TemplateSnapshot | null>;
 }
 
-export interface AuditCommands {
-  logAuditEvent: (
-    db: Transaction,
-    input: {
-      eventId: string;
-      actorType: string;
-      actorId: string;
-      entityType: string;
-      entityId: string;
-      operationType: string;
-      companyId?: string;
-      changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[];
-    },
-    ctx: CommandContext,
-  ) => Promise<{ ok: true; value: unknown }>;
-}
-
 export interface OrganizationQueries {
   getCompany: (
     db: Transaction,
@@ -91,7 +73,6 @@ export async function run<CF extends Record<string, unknown>>(
   ctx: CommandContext,
   organizationQueries?: Pick<OrganizationQueries, "getCompany">,
   templateProvider?: TemplateProvider,
-  auditCommands?: AuditCommands,
 ) {
   const { name, companyId, description, templateId, ...customFields } = input;
 
@@ -209,38 +190,6 @@ export async function run<CF extends Record<string, unknown>>(
     }
   }
 
-  // 6. Emit audit event
-  if (auditCommands) {
-    const changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[] = [
-      { fieldName: "name", newValue: name },
-      { fieldName: "companyId", newValue: companyId },
-      { fieldName: "baseCurrencyId", newValue: baseCurrencyId },
-      { fieldName: "status", newValue: "DRAFT" },
-    ];
-    if (description) {
-      changes.push({ fieldName: "description", newValue: description });
-    }
-    changes.push({
-      fieldName: "templateUsed",
-      newValue: templateId ? "template" : "blank",
-    });
-
-    await auditCommands.logAuditEvent(
-      db,
-      {
-        eventId: randomUUID(),
-        actorType: "USER",
-        actorId: ctx.actorId,
-        entityType: "ChartOfAccounts",
-        entityId: coa!.id,
-        operationType: "CREATE",
-        companyId,
-        changes,
-      },
-      ctx,
-    );
-  }
-
   return ok({ chartOfAccounts: coa! });
 }
 

package/src/modules/coa-management/command/deactivateAccount.test.ts

@@ -181,19 +181,4 @@ describe("deactivateAccount", () => {
       expect(result.error).toBeInstanceOf(OpenBalancesExistError);
     }
   });
-
-  it("emits audit event recording status transition from ACTIVE to INACTIVE and successor mapping", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    const deactivated = { ...baseActiveAccount, status: "INACTIVE" };
-    spies.select.mockReturnValueOnce(baseActiveAccount).mockReturnValueOnce(baseActiveCoa);
-    spies.update.mockReturnValue(deactivated);
-
-    const result = await run(db, { id: baseActiveAccount.id }, ctx);
-
-    // Audit event is emitted as part of successful deactivation
-    expect(result.ok).toBe(true);
-    if (result.ok) {
-      expect(result.value.account.status).toBe("INACTIVE");
-    }
-  });
 });

package/src/modules/coa-management/command/deactivateAccount.ts

@@ -1,4 +1,3 @@
-import { randomUUID } from "node:crypto";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
   AccountNotFoundError,
@@ -15,23 +14,6 @@ export interface DeactivateAccountInput {
   preDeactivationHook?: (accountId: string) => Promise<boolean>;
 }
 
-export interface AuditCommands {
-  logAuditEvent: (
-    db: Transaction,
-    input: {
-      eventId: string;
-      actorType: string;
-      actorId: string;
-      entityType: string;
-      entityId: string;
-      operationType: string;
-      companyId?: string;
-      changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[];
-    },
-    ctx: CommandContext,
-  ) => Promise<{ ok: true; value: unknown }>;
-}
-
 /**
  * Function: deactivateAccount
  *
@@ -39,12 +21,7 @@ export interface AuditCommands {
  * journal postings while preserving history. An optional successor account
  * can be designated during deactivation.
  */
-export async function run(
-  db: Transaction,
-  input: DeactivateAccountInput,
-  ctx: CommandContext,
-  auditCommands?: AuditCommands,
-) {
+export async function run(db: Transaction, input: DeactivateAccountInput, _ctx: CommandContext) {
   const { id, successorAccountId, preDeactivationHook } = input;
 
   // 1. Find account with forUpdate
@@ -109,34 +86,5 @@ export async function run(
     .returningAll()
     .executeTakeFirst();
 
-  // 8. Emit audit event
-  if (auditCommands) {
-    const changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[] = [
-      { fieldName: "status", oldValue: "ACTIVE", newValue: "INACTIVE" },
-    ];
-    if (successorAccountId) {
-      changes.push({
-        fieldName: "successorAccountId",
-        oldValue: null,
-        newValue: successorAccountId,
-      });
-    }
-
-    await auditCommands.logAuditEvent(
-      db,
-      {
-        eventId: randomUUID(),
-        actorType: "USER",
-        actorId: ctx.actorId,
-        entityType: "Account",
-        entityId: id,
-        operationType: "UPDATE",
-        companyId: coa.companyId,
-        changes,
-      },
-      ctx,
-    );
-  }
-
   return ok({ account: updated! });
 }

package/src/modules/coa-management/command/deactivateChartOfAccounts.test.ts

@@ -1,9 +1,9 @@
-import { describe, expect, it, vi } from "vitest";
+import { describe, expect, it } from "vitest";
 import { createMockDb } from "../../../testing/index";
 import type { Transaction } from "../generated/kysely-tailordb";
 import { ChartOfAccountsNotFoundError, InvalidStateTransitionError } from "../lib/errors.generated";
 import { baseDraftCoa, baseActiveCoa, baseArchivedCoa } from "../testing/fixtures";
-import { run, type AuditCommands } from "./deactivateChartOfAccounts";
+import { run } from "./deactivateChartOfAccounts";
 import type { CommandContext } from "@tailor-platform/erp-kit/module";
 
 const ctx: CommandContext = {
@@ -61,31 +61,4 @@ describe("deactivateChartOfAccounts", () => {
       expect(result.value.chartOfAccounts.status).toBe("ARCHIVED");
     }
   });
-
-  it("emits audit event recording status transition from ACTIVE to ARCHIVED", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    const archivedCoa = { ...baseActiveCoa, status: "ARCHIVED" };
-    spies.select.mockReturnValueOnce(baseActiveCoa);
-    spies.update.mockReturnValue(archivedCoa);
-
-    const mockLogAuditEvent = vi.fn().mockResolvedValue({ ok: true, value: {} });
-    const auditCommands: AuditCommands = { logAuditEvent: mockLogAuditEvent };
-
-    const result = await run(db, { id: baseActiveCoa.id }, ctx, auditCommands);
-
-    expect(result.ok).toBe(true);
-    expect(mockLogAuditEvent).toHaveBeenCalledWith(
-      db,
-      expect.objectContaining({
-        entityType: "ChartOfAccounts",
-        entityId: baseActiveCoa.id,
-        operationType: "UPDATE",
-        companyId: baseActiveCoa.companyId,
-        actorType: "USER",
-        actorId: ctx.actorId,
-        changes: [{ fieldName: "status", oldValue: "ACTIVE", newValue: "ARCHIVED" }],
-      }),
-      ctx,
-    );
-  });
 });