@tailor-platform/erp-kit 0.6.0 → 0.8.0

package/src/modules/organization/command/updateCompany.ts

@@ -8,7 +8,7 @@ import {
 import type { PrimitivesQueries } from "../module";
 import { ok, err, type CommandContext } from "@tailor-platform/erp-kit/module";
 
-export interface UpdateCompanyInput {
+export type UpdateCompanyInput = {
   companyId: string;
   legalName?: string;
   taxId?: string;
@@ -19,8 +19,7 @@ export interface UpdateCompanyInput {
   state?: string;
   postalCode?: string;
   country?: string;
-}
-
+};
 /**
  * Function: updateCompany
  *
@@ -29,7 +28,7 @@ export interface UpdateCompanyInput {
  */
 export async function run<CF extends Record<string, unknown>>(
   db: Transaction,
-  input: UpdateCompanyInput & CF,
+  input: UpdateCompanyInput & Omit<Partial<CF>, "status">,
   ctx: CommandContext,
   primitivesQueries?: Pick<PrimitivesQueries, "getCurrency">,
 ) {

package/src/modules/organization/command/updateDepartment.test.ts

@@ -88,7 +88,7 @@ describe("updateDepartment", () => {
     }
   });
 
-  it("throws when department does not exist", async () => {
+  it("returns error when department does not exist", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValue(undefined);
 
@@ -103,7 +103,7 @@ describe("updateDepartment", () => {
     }
   });
 
-  it("throws when name is empty", async () => {
+  it("returns error when name is empty", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce(activeDepartment);
 
@@ -118,7 +118,7 @@ describe("updateDepartment", () => {
     }
   });
 
-  it("throws when name is whitespace-only", async () => {
+  it("returns error when name is whitespace-only", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce(activeDepartment);
 
@@ -133,7 +133,7 @@ describe("updateDepartment", () => {
     }
   });
 
-  it("throws when setting self as parent", async () => {
+  it("returns error when setting self as parent", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce(activeDepartment);
 
@@ -148,7 +148,7 @@ describe("updateDepartment", () => {
     }
   });
 
-  it("throws when parent does not exist", async () => {
+  it("returns error when parent does not exist", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select
       .mockReturnValueOnce(activeDepartment) // find department
@@ -165,7 +165,7 @@ describe("updateDepartment", () => {
     }
   });
 
-  it("throws when parent belongs to different company", async () => {
+  it("returns error when parent belongs to different company", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select
       .mockReturnValueOnce(activeDepartment) // find department
@@ -182,7 +182,7 @@ describe("updateDepartment", () => {
     }
   });
 
-  it("throws when reparenting creates circular reference", async () => {
+  it("returns error when reparenting creates circular reference", async () => {
     const { db, spies } = createMockDb<Transaction>();
     // activeDepartment -> childDepartment -> grandchildDepartment
     // Try to set activeDepartment's parent to grandchildDepartment

package/src/modules/organization/command/updateDepartment.ts

@@ -9,12 +9,11 @@ import {
 import { run as detectCircularReference } from "../query/detectDepartmentCircularReference";
 import { ok, err } from "@tailor-platform/erp-kit/module";
 
-export interface UpdateDepartmentInput {
+export type UpdateDepartmentInput = {
   departmentId: string;
   name?: string;
   parentDepartmentId?: string | null;
-}
-
+};
 /**
  * Function: updateDepartment
  *
@@ -23,20 +22,22 @@ export interface UpdateDepartmentInput {
  */
 export async function run<CF extends Record<string, unknown>>(
   db: Transaction,
-  input: UpdateDepartmentInput & CF,
+  input: UpdateDepartmentInput & Omit<Partial<CF>, "status">,
 ) {
-  const { departmentId, name, parentDepartmentId, ...customFields } = input;
+  const { name, parentDepartmentId, ...rest } = input;
+  const customFields = { ...rest } as Record<string, unknown>;
+  delete customFields.departmentId;
 
   // 1. Find department
   const existing = await db
     .selectFrom("Department")
     .selectAll()
-    .where("id", "=", departmentId)
+    .where("id", "=", input.departmentId)
     .forUpdate()
     .executeTakeFirst();
 
   if (!existing) {
-    return err(new DepartmentNotFoundError(departmentId));
+    return err(new DepartmentNotFoundError(input.departmentId));
   }
 
   // 2. Validate name if provided
@@ -47,8 +48,8 @@ export async function run<CF extends Record<string, unknown>>(
   // 3. Validate parentDepartmentId if provided
   if (parentDepartmentId !== undefined && parentDepartmentId !== null) {
     // Self-reference check
-    if (parentDepartmentId === departmentId) {
-      return err(new SelfReferenceError(departmentId));
+    if (parentDepartmentId === existing.id) {
+      return err(new SelfReferenceError(existing.id));
     }
 
     // Find parent department
@@ -69,11 +70,11 @@ export async function run<CF extends Record<string, unknown>>(
 
     // Circular reference detection via shared query
     const circularResult = await detectCircularReference(db, {
-      departmentId,
+      departmentId: existing.id,
       newParentId: parentDepartmentId,
     });
     if (circularResult.ok && circularResult.value.isCircular) {
-      return err(new CircularReferenceError(departmentId));
+      return err(new CircularReferenceError(existing.id));
     }
   }
 
@@ -112,7 +113,7 @@ export async function run<CF extends Record<string, unknown>>(
   const department = await db
     .updateTable("Department")
     .set(updateSet)
-    .where("id", "=", departmentId)
+    .where("id", "=", existing.id)
     .returningAll()
     .executeTakeFirst();
 

package/src/modules/organization/command/updateSite.test.ts

@@ -88,7 +88,7 @@ describe("updateSite", () => {
     }
   });
 
-  it("throws when site does not exist", async () => {
+  it("returns error when site does not exist", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValue(undefined);
 
@@ -100,7 +100,7 @@ describe("updateSite", () => {
     }
   });
 
-  it("throws when name is empty", async () => {
+  it("returns error when name is empty", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce(activeSite);
 
@@ -112,7 +112,7 @@ describe("updateSite", () => {
     }
   });
 
-  it("throws when name already exists in same company", async () => {
+  it("returns error when name already exists in same company", async () => {
     const { db, spies } = createMockDb<Transaction>();
     const otherSite = { ...activeSite, id: "site-other", name: "Existing Name" };
 
@@ -128,7 +128,7 @@ describe("updateSite", () => {
     }
   });
 
-  it("throws when type is invalid", async () => {
+  it("returns error when type is invalid", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce(activeSite);
 
@@ -140,7 +140,7 @@ describe("updateSite", () => {
     }
   });
 
-  it("throws when country code is invalid", async () => {
+  it("returns error when country code is invalid", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce(activeSite);
 
@@ -152,7 +152,7 @@ describe("updateSite", () => {
     }
   });
 
-  it("throws when timezone is invalid", async () => {
+  it("returns error when timezone is invalid", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce(activeSite);
 
@@ -179,7 +179,7 @@ describe("updateSite", () => {
     }
   });
 
-  it("throws when street is set to empty", async () => {
+  it("returns error when street is set to empty", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce(activeSite);
 
@@ -191,7 +191,7 @@ describe("updateSite", () => {
     }
   });
 
-  it("throws when city is set to empty", async () => {
+  it("returns error when city is set to empty", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce(activeSite);
 
@@ -203,7 +203,7 @@ describe("updateSite", () => {
     }
   });
 
-  it("throws when postalCode is set to empty", async () => {
+  it("returns error when postalCode is set to empty", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce(activeSite);
 
@@ -215,7 +215,7 @@ describe("updateSite", () => {
     }
   });
 
-  it("throws when country is set to empty", async () => {
+  it("returns error when country is set to empty", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce(activeSite);
 

package/src/modules/organization/command/updateSite.ts

@@ -10,7 +10,7 @@ import {
 } from "../lib/errors.generated";
 import { ok, err } from "@tailor-platform/erp-kit/module";
 
-export interface UpdateSiteInput {
+export type UpdateSiteInput = {
   siteId: string;
   name?: string;
   type?: string;
@@ -20,7 +20,7 @@ export interface UpdateSiteInput {
   postalCode?: string;
   country?: string;
   timezone?: string;
-}
+};
 
 const VALID_SITE_TYPES = ["OFFICE", "WAREHOUSE", "STORE", "FACTORY", "DISTRIBUTION_CENTER"];
 
@@ -42,7 +42,6 @@ function isValidTimezone(tz: string): boolean {
     return false;
   }
 }
-
 /**
  * Function: updateSite
  *
@@ -51,7 +50,7 @@ function isValidTimezone(tz: string): boolean {
  */
 export async function run<CF extends Record<string, unknown>>(
   db: Transaction,
-  input: UpdateSiteInput & CF,
+  input: UpdateSiteInput & Omit<Partial<CF>, "status">,
 ) {
   const {
     siteId,

package/src/modules/organization/docs/commands/UpdateCompany.md

@@ -49,10 +49,10 @@ flowchart TD
 - updates legal name on DRAFT company
 - updates address fields on ACTIVE company
 - updates tax ID and registration number
-- throws when company does not exist
-- throws when legal name is empty
-- throws when changing base currency on ACTIVE company
-- throws when changing base currency on INACTIVE company
-- throws when new base currency does not exist
-- throws when new base currency is inactive
+- returns error when company does not exist
+- returns error when legal name is empty
+- returns error when changing base currency on ACTIVE company
+- returns error when changing base currency on INACTIVE company
+- returns error when new base currency does not exist
+- returns error when new base currency is inactive
 - updates base currency on DRAFT company

package/src/modules/organization/docs/commands/UpdateDepartment.md

@@ -2,7 +2,7 @@
 
 ## Overview
 
-UpdateDepartment modifies the name or parent department of an existing department. The department code and company are immutable. Parent department changes are validated to prevent self-references and circular hierarchies. Updating is allowed on both ACTIVE and INACTIVE departments.
+UpdateDepartment modifies the name or parent department of an existing department. Department code and company ownership are fixed by the existing record and are not part of the update input. Parent department changes are validated to prevent self-references and circular hierarchies. Updating is allowed on both ACTIVE and INACTIVE departments.
 
 This command supports organizational restructuring and department renaming.
 
@@ -10,8 +10,7 @@ This command supports organizational restructuring and department renaming.
 
 - Department must exist
 - Name, if provided, must be non-empty
-- Department code cannot be changed
-- companyId cannot be changed
+- Department code and company ownership are not part of the update input
 - Parent department, if provided, must exist and belong to the same company
 - A department cannot reference itself as its own parent
 - Circular parent references are rejected
@@ -54,11 +53,11 @@ flowchart TD
 - updates department name
 - updates parent department
 - removes parent department (promotes to top-level)
-- throws when department does not exist
-- throws when name is empty
-- throws when name is whitespace-only
-- throws when setting self as parent
-- throws when parent does not exist
-- throws when parent belongs to different company
-- throws when reparenting creates circular reference
+- returns error when department does not exist
+- returns error when name is empty
+- returns error when name is whitespace-only
+- returns error when setting self as parent
+- returns error when parent does not exist
+- returns error when parent belongs to different company
+- returns error when reparenting creates circular reference
 - updates parent on INACTIVE department

package/src/modules/organization/docs/commands/UpdateSite.md

@@ -2,7 +2,7 @@
 
 ## Overview
 
-UpdateSite modifies fields on an existing site. Updatable fields include name, type, address fields, country, and timezone. The companyId is immutable after creation. Updating is permitted on both ACTIVE and INACTIVE sites.
+UpdateSite modifies fields on an existing site. Updatable fields include name, type, address fields, country, and timezone. Company ownership is fixed by the existing record and is not part of the update input. Updating is permitted on both ACTIVE and INACTIVE sites.
 
 This command supports address corrections, type reclassification, and timezone updates.
 
@@ -12,7 +12,7 @@ This command supports address corrections, type reclassification, and timezone u
 - Name, if provided, must be non-empty
 - Name, if changed, must remain unique within the same company
 - Type, if provided, must be one of the allowed classifications
-- companyId cannot be changed
+- companyId is not part of the update input
 - Timezone, if provided, must be a valid IANA timezone identifier
 - Country, if provided, must reference a valid country code
 - Address fields can be individually updated
@@ -64,17 +64,17 @@ flowchart TD
 - updates site address fields
 - updates site type
 - updates site timezone
-- throws when site does not exist
-- throws when name is empty
-- throws when name already exists in same company
-- throws when type is invalid
-- throws when country code is invalid
-- throws when timezone is invalid
+- returns error when site does not exist
+- returns error when name is empty
+- returns error when name already exists in same company
+- returns error when type is invalid
+- returns error when country code is invalid
+- returns error when timezone is invalid
 - updates site country
-- throws when street is set to empty
-- throws when city is set to empty
-- throws when postalCode is set to empty
-- throws when country is set to empty
+- returns error when street is set to empty
+- returns error when city is set to empty
+- returns error when postalCode is set to empty
+- returns error when country is set to empty
 - updates state/province field
 - clears state/province field
 - updates address fields on INACTIVE site

package/src/modules/product-management/command/updateProduct.test.ts

@@ -3,7 +3,6 @@ import { createMockDb } from "../../../testing/index";
 import type { GetUnitInput } from "../../primitives/query/getUnit";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
-  CodeImmutableError,
   InvalidUomError,
   MissingRequiredFieldError,
   NoFieldsToUpdateError,
@@ -51,16 +50,6 @@ describe("updateProduct", () => {
     }
   });
 
-  it("returns error when code change attempted", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    spies.select.mockReturnValueOnce({ ...baseDraftProduct });
-    const result = await run(db, { id: "product-1", code: "NEW-CODE" }, ctx, primitivesQueries);
-    expect(result.ok).toBe(false);
-    if (!result.ok) {
-      expect(result.error).toBeInstanceOf(CodeImmutableError);
-    }
-  });
-
   it("returns error when no fields provided", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce({ ...baseDraftProduct });
@@ -147,6 +136,23 @@ describe("updateProduct", () => {
     }
   });
 
+  it("looks up product by code and updates name", async () => {
+    const { db, spies } = createMockDb<Transaction>();
+    const updated = { ...baseDraftProduct, name: "Updated Name" };
+    spies.select.mockReturnValueOnce({ ...baseDraftProduct });
+    spies.update.mockReturnValueOnce(updated);
+    const result = await run(
+      db,
+      { code: baseDraftProduct.code, name: "Updated Name" },
+      ctx,
+      primitivesQueries,
+    );
+    expect(result.ok).toBe(true);
+    if (result.ok) {
+      expect(result.value.product.name).toBe("Updated Name");
+    }
+  });
+
   it("passes custom fields through", async () => {
     const { db, spies } = createMockDb<Transaction>();
     const updated = { ...baseDraftProduct, customField1: "value1" };

package/src/modules/product-management/command/updateProduct.ts

@@ -1,7 +1,6 @@
 import { Transaction } from "../generated/kysely-tailordb";
 import {
   ProductNotFoundError,
-  CodeImmutableError,
   NoFieldsToUpdateError,
   UomLockedError,
   InvalidUomError,
@@ -10,63 +9,81 @@ import {
 import type { PrimitivesQueries } from "../module";
 import { ok, err, type CommandContext } from "@tailor-platform/erp-kit/module";
 
-export interface UpdateProductInput {
-  id: string;
-  code?: string;
+export type UpdateProductInput = (
+  | {
+      id: string;
+    }
+  | {
+      code: string;
+    }
+) & {
   name?: string;
   description?: string;
   unitId?: string;
-}
+};
 
 /**
  * Function: updateProduct
  *
  * Updates mutable fields of an existing product.
+ * The product can be looked up by id or code. UoM can only be changed in DRAFT status.
  */
 export async function run<CF extends Record<string, unknown>>(
   db: Transaction,
-  input: UpdateProductInput & CF,
+  input: UpdateProductInput & Omit<Partial<CF>, "status">,
   ctx: CommandContext,
   primitivesQueries: Pick<PrimitivesQueries, "getUnit">,
 ) {
-  const { id, code, name, description, unitId, ...customFields } = input;
-
-  // Check product exists (with lock)
-  const product = await db
-    .selectFrom("Product")
-    .selectAll()
-    .where("id", "=", id)
-    .forUpdate()
-    .executeTakeFirst();
+  const { name, description, unitId } = input;
 
-  if (!product) {
-    return err(new ProductNotFoundError(id));
+  const KNOWN_KEYS = new Set(["id", "code", "name", "description", "unitId"]);
+  const customFields: Record<string, unknown> = {};
+  for (const [key, value] of Object.entries(input as Record<string, unknown>)) {
+    if (!KNOWN_KEYS.has(key)) {
+      customFields[key] = value;
+    }
   }
 
-  // Code is immutable
-  if (code !== undefined) {
-    return err(new CodeImmutableError(id));
+  // 1. Check product exists (lookup by id or code)
+  const product =
+    "id" in input
+      ? await db
+          .selectFrom("Product")
+          .selectAll()
+          .where("id", "=", (input as { id: string }).id)
+          .forUpdate()
+          .executeTakeFirst()
+      : await db
+          .selectFrom("Product")
+          .selectAll()
+          .where("code", "=", (input as { code: string }).code)
+          .forUpdate()
+          .executeTakeFirst();
+
+  if (!product) {
+    const key = "id" in input ? (input as { id: string }).id : (input as { code: string }).code;
+    return err(new ProductNotFoundError(key));
   }
 
-  // Check if any fields to update
+  // 2. Check if any fields to update
   const hasNameUpdate = name !== undefined;
   const hasDescriptionUpdate = description !== undefined;
   const hasUnitUpdate = unitId !== undefined;
   const hasCustomFields = Object.keys(customFields).length > 0;
 
   if (!hasNameUpdate && !hasDescriptionUpdate && !hasUnitUpdate && !hasCustomFields) {
-    return err(new NoFieldsToUpdateError(id));
+    return err(new NoFieldsToUpdateError(product.id));
   }
 
-  // Validate name if provided
+  // 3. Validate name if provided
   if (hasNameUpdate && !name?.trim()) {
     return err(new MissingRequiredFieldError("name"));
   }
 
-  // UoM can only be updated in DRAFT status
+  // 4. UoM can only be updated in DRAFT status
   if (hasUnitUpdate) {
     if (product.status !== "DRAFT") {
-      return err(new UomLockedError(id));
+      return err(new UomLockedError(product.id));
     }
     const unitResult = await primitivesQueries.getUnit(db, { id: unitId }, ctx);
     if (!unitResult.ok) return err(new InvalidUomError(unitId));
@@ -75,9 +92,9 @@ export async function run<CF extends Record<string, unknown>>(
     }
   }
 
-  // Build update payload
+  // 5. Build update payload
   const updates: Record<string, unknown> = {
-    ...(customFields as Record<string, unknown>),
+    ...customFields,
     updatedAt: new Date(),
   };
   if (hasNameUpdate) updates.name = name;
@@ -87,7 +104,7 @@ export async function run<CF extends Record<string, unknown>>(
   const updated = await db
     .updateTable("Product")
     .set(updates)
-    .where("id", "=", id)
+    .where("id", "=", product.id)
     .returningAll()
     .executeTakeFirst();
 

package/src/modules/product-management/command/updateProductAttribute.test.ts

@@ -1,11 +1,7 @@
 import { describe, expect, it } from "vitest";
 import { createMockDb } from "../../../testing/index";
 import { Transaction } from "../generated/kysely-tailordb";
-import {
-  AttributeNotFoundError,
-  CodeImmutableError,
-  MissingRequiredFieldError,
-} from "../lib/errors.generated";
+import { AttributeNotFoundError, MissingRequiredFieldError } from "../lib/errors.generated";
 import { baseColorAttribute } from "../testing/fixtures";
 import { run } from "./updateProductAttribute";
 
@@ -22,22 +18,6 @@ describe("updateProductAttribute", () => {
     }
   });
 
-  it("returns error when trying to change code", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    spies.select.mockReturnValueOnce(baseColorAttribute);
-
-    const result = await run(db, {
-      id: baseColorAttribute.id,
-      code: "NEW-CODE",
-      name: "Color",
-    });
-
-    expect(result.ok).toBe(false);
-    if (!result.ok) {
-      expect(result.error).toBeInstanceOf(CodeImmutableError);
-    }
-  });
-
   it("returns error when no fields provided", async () => {
     const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValueOnce(baseColorAttribute);
@@ -98,4 +78,19 @@ describe("updateProductAttribute", () => {
     }
     expect(spies.update).toHaveBeenCalled();
   });
+
+  it("looks up attribute by code and updates name", async () => {
+    const { db, spies } = createMockDb<Transaction>();
+    const updatedAttribute = { ...baseColorAttribute, name: "Updated Color" };
+
+    spies.select.mockReturnValueOnce(baseColorAttribute);
+    spies.update.mockReturnValue(updatedAttribute);
+
+    const result = await run(db, { code: baseColorAttribute.code, name: "Updated Color" });
+
+    expect(result.ok).toBe(true);
+    if (result.ok) {
+      expect(result.value.attribute.name).toBe("Updated Color");
+    }
+  });
 });