@tailor-platform/erp-kit 0.2.1 → 0.2.2

package/src/modules/user-management/command/createPermission.test.ts

@@ -1,7 +1,6 @@
 import { describe, expect, it } from "vitest";
-import { type CommandContext } from "../../shared/internal";
-import { createMockDb } from "../../testing/index";
-import { DB } from "../generated/kysely-tailordb";
+import { createMockDb } from "../../../testing/index";
+import { Transaction } from "../generated/kysely-tailordb";
 import {
   DuplicatePermissionKeyError,
   InvalidPermissionKeyFormatError,
@@ -11,16 +10,11 @@ import { basePermission } from "../testing/fixtures";
 import { run } from "./createPermission";
 
 describe("createPermission", () => {
-  const ctx: CommandContext = {
-    actorId: "test-actor",
-    permissions: ["user-management:createPermission"],
-  };
-
   // Error cases
   it("throws when key is empty", async () => {
-    const { db } = createMockDb<DB>();
+    const { db } = createMockDb<Transaction>();
 
-    const result = await run(db, { key: "" }, ctx);
+    const result = await run(db, { key: "" });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(MissingRequiredFieldError);
@@ -28,9 +22,9 @@ describe("createPermission", () => {
   });
 
   it("throws when key format is invalid (no colon)", async () => {
-    const { db } = createMockDb<DB>();
+    const { db } = createMockDb<Transaction>();
 
-    const result = await run(db, { key: "invalidkey" }, ctx);
+    const result = await run(db, { key: "invalidkey" });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(InvalidPermissionKeyFormatError);
@@ -38,9 +32,9 @@ describe("createPermission", () => {
   });
 
   it("throws when key format is invalid (multiple colons)", async () => {
-    const { db } = createMockDb<DB>();
+    const { db } = createMockDb<Transaction>();
 
-    const result = await run(db, { key: "resource:action:extra" }, ctx);
+    const result = await run(db, { key: "resource:action:extra" });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(InvalidPermissionKeyFormatError);
@@ -48,9 +42,9 @@ describe("createPermission", () => {
   });
 
   it("throws when key format is invalid (empty resource)", async () => {
-    const { db } = createMockDb<DB>();
+    const { db } = createMockDb<Transaction>();
 
-    const result = await run(db, { key: ":action" }, ctx);
+    const result = await run(db, { key: ":action" });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(InvalidPermissionKeyFormatError);
@@ -58,9 +52,9 @@ describe("createPermission", () => {
   });
 
   it("throws when key format is invalid (empty action)", async () => {
-    const { db } = createMockDb<DB>();
+    const { db } = createMockDb<Transaction>();
 
-    const result = await run(db, { key: "resource:" }, ctx);
+    const result = await run(db, { key: "resource:" });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(InvalidPermissionKeyFormatError);
@@ -68,10 +62,10 @@ describe("createPermission", () => {
   });
 
   it("throws when permission key already exists", async () => {
-    const { db, spies } = createMockDb<DB>();
+    const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValue(basePermission);
 
-    const result = await run(db, { key: basePermission.key }, ctx);
+    const result = await run(db, { key: basePermission.key });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(DuplicatePermissionKeyError);
@@ -80,7 +74,7 @@ describe("createPermission", () => {
 
   // Success cases
   it("creates permission with valid key", async () => {
-    const { db, spies } = createMockDb<DB>();
+    const { db, spies } = createMockDb<Transaction>();
     const createdPermission = {
       ...basePermission,
       id: "new-permission-id",
@@ -91,7 +85,7 @@ describe("createPermission", () => {
     spies.select.mockReturnValue(undefined); // No existing permission
     spies.insert.mockReturnValue(createdPermission);
 
-    const result = await run(db, { key: "users:read" }, ctx);
+    const result = await run(db, { key: "users:read" });
 
     expect(result.ok).toBe(true);
     if (result.ok) {
@@ -101,7 +95,7 @@ describe("createPermission", () => {
   });
 
   it("creates permission with description", async () => {
-    const { db, spies } = createMockDb<DB>();
+    const { db, spies } = createMockDb<Transaction>();
     const createdPermission = {
       ...basePermission,
       id: "new-permission-id",
@@ -112,14 +106,10 @@ describe("createPermission", () => {
     spies.select.mockReturnValue(undefined);
     spies.insert.mockReturnValue(createdPermission);
 
-    const result = await run(
-      db,
-      {
-        key: "users:write",
-        description: "Permission to write users",
-      },
-      ctx,
-    );
+    const result = await run(db, {
+      key: "users:write",
+      description: "Permission to write users",
+    });
 
     expect(result.ok).toBe(true);
     if (result.ok) {
@@ -129,7 +119,7 @@ describe("createPermission", () => {
   });
 
   it("passes custom fields through to insert", async () => {
-    const { db, spies } = createMockDb<DB>();
+    const { db, spies } = createMockDb<Transaction>();
     const createdPermission = {
       ...basePermission,
       id: "new-permission-id",
@@ -140,7 +130,7 @@ describe("createPermission", () => {
     spies.select.mockReturnValue(undefined);
     spies.insert.mockReturnValue(createdPermission);
 
-    await run(db, { key: "users:read", module: "user-management" }, ctx);
+    await run(db, { key: "users:read", module: "user-management" });
 
     expect(spies.values).toHaveBeenNthCalledWith(
       1,

package/src/modules/user-management/command/createPermission.ts

@@ -1,5 +1,5 @@
-import { ok, err, type CommandContext } from "../../shared/internal";
-import { DB } from "../generated/kysely-tailordb";
+import { ok, err } from "../../../shared";
+import { Transaction } from "../generated/kysely-tailordb";
 import {
   DuplicatePermissionKeyError,
   InvalidPermissionKeyFormatError,
@@ -20,10 +20,8 @@ const PERMISSION_KEY_PATTERN = /^[a-zA-Z0-9_-]+:[a-zA-Z0-9_-]+$/;
  * Validates that the key follows the correct format and is unique.
  */
 export async function run<CF extends Record<string, unknown>>(
-  db: DB,
+  db: Transaction,
   input: CreatePermissionInput & CF,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  _ctx: CommandContext,
 ) {
   const { key, description, ...customFields } = input;
 
@@ -39,6 +37,7 @@ export async function run<CF extends Record<string, unknown>>(
     .selectFrom("Permission")
     .selectAll()
     .where("key", "=", key)
+    .forUpdate()
     .executeTakeFirst();
 
   if (existingPermission) {

package/src/modules/user-management/command/createRole.generated.ts

@@ -1,5 +1,5 @@
 // @generated — do not edit
-import { defineCommand } from "../../shared/internal";
+import { defineCommand } from "../../../shared";
 import { permissions } from "../lib/permissions.generated";
 import { run } from "./createRole";
 

package/src/modules/user-management/command/createRole.test.ts

@@ -1,22 +1,16 @@
 import { describe, expect, it } from "vitest";
-import { type CommandContext } from "../../shared/internal";
-import { createMockDb } from "../../testing/index";
-import { DB } from "../generated/kysely-tailordb";
+import { createMockDb } from "../../../testing/index";
+import { Transaction } from "../generated/kysely-tailordb";
 import { DuplicateRoleNameError, MissingRequiredFieldError } from "../lib/errors.generated";
 import { baseRole } from "../testing/fixtures";
 import { run } from "./createRole";
 
 describe("createRole", () => {
-  const ctx: CommandContext = {
-    actorId: "test-actor",
-    permissions: ["user-management:createRole"],
-  };
-
   // Error cases
   it("throws when name is empty", async () => {
-    const { db } = createMockDb<DB>();
+    const { db } = createMockDb<Transaction>();
 
-    const result = await run(db, { name: "" }, ctx);
+    const result = await run(db, { name: "" });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(MissingRequiredFieldError);
@@ -24,9 +18,9 @@ describe("createRole", () => {
   });
 
   it("throws when name is whitespace only", async () => {
-    const { db } = createMockDb<DB>();
+    const { db } = createMockDb<Transaction>();
 
-    const result = await run(db, { name: "   " }, ctx);
+    const result = await run(db, { name: "   " });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(MissingRequiredFieldError);
@@ -34,10 +28,10 @@ describe("createRole", () => {
   });
 
   it("throws when role name already exists", async () => {
-    const { db, spies } = createMockDb<DB>();
+    const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValue(baseRole);
 
-    const result = await run(db, { name: baseRole.name }, ctx);
+    const result = await run(db, { name: baseRole.name });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(DuplicateRoleNameError);
@@ -46,7 +40,7 @@ describe("createRole", () => {
 
   // Success cases
   it("creates role with valid name", async () => {
-    const { db, spies } = createMockDb<DB>();
+    const { db, spies } = createMockDb<Transaction>();
     const createdRole = {
       ...baseRole,
       id: "new-role-id",
@@ -57,7 +51,7 @@ describe("createRole", () => {
     spies.select.mockReturnValue(undefined); // No existing role
     spies.insert.mockReturnValue(createdRole);
 
-    const result = await run(db, { name: "Viewer" }, ctx);
+    const result = await run(db, { name: "Viewer" });
 
     expect(result.ok).toBe(true);
     if (result.ok) {
@@ -67,7 +61,7 @@ describe("createRole", () => {
   });
 
   it("creates role with description", async () => {
-    const { db, spies } = createMockDb<DB>();
+    const { db, spies } = createMockDb<Transaction>();
     const createdRole = {
       ...baseRole,
       id: "new-role-id",
@@ -78,14 +72,10 @@ describe("createRole", () => {
     spies.select.mockReturnValue(undefined);
     spies.insert.mockReturnValue(createdRole);
 
-    const result = await run(
-      db,
-      {
-        name: "Editor",
-        description: "Can edit content",
-      },
-      ctx,
-    );
+    const result = await run(db, {
+      name: "Editor",
+      description: "Can edit content",
+    });
 
     expect(result.ok).toBe(true);
     if (result.ok) {
@@ -95,7 +85,7 @@ describe("createRole", () => {
   });
 
   it("passes custom fields through to insert", async () => {
-    const { db, spies } = createMockDb<DB>();
+    const { db, spies } = createMockDb<Transaction>();
     const createdRole = {
       ...baseRole,
       id: "new-role-id",
@@ -106,7 +96,7 @@ describe("createRole", () => {
     spies.select.mockReturnValue(undefined);
     spies.insert.mockReturnValue(createdRole);
 
-    await run(db, { name: "Viewer", department: "Engineering" }, ctx);
+    await run(db, { name: "Viewer", department: "Engineering" });
 
     expect(spies.values).toHaveBeenNthCalledWith(
       1,

package/src/modules/user-management/command/createRole.ts

@@ -1,5 +1,5 @@
-import { ok, err, type CommandContext } from "../../shared/internal";
-import { DB } from "../generated/kysely-tailordb";
+import { ok, err } from "../../../shared";
+import { Transaction } from "../generated/kysely-tailordb";
 import { DuplicateRoleNameError, MissingRequiredFieldError } from "../lib/errors.generated";
 
 interface CreateRoleInput {
@@ -14,10 +14,8 @@ interface CreateRoleInput {
  * Validates that the name is unique within the system.
  */
 export async function run<CF extends Record<string, unknown>>(
-  db: DB,
+  db: Transaction,
   input: CreateRoleInput & CF,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  _ctx: CommandContext,
 ) {
   const { name, description, ...customFields } = input;
 
@@ -29,6 +27,7 @@ export async function run<CF extends Record<string, unknown>>(
     .selectFrom("Role")
     .selectAll()
     .where("name", "=", name)
+    .forUpdate()
     .executeTakeFirst();
 
   if (existingRole) {

package/src/modules/user-management/command/createUser.generated.ts

@@ -1,5 +1,5 @@
 // @generated — do not edit
-import { defineCommand } from "../../shared/internal";
+import { defineCommand } from "../../../shared";
 import { permissions } from "../lib/permissions.generated";
 import { run } from "./createUser";
 

package/src/modules/user-management/command/createUser.test.ts

@@ -1,26 +1,20 @@
 import { describe, expect, it } from "vitest";
-import { type CommandContext } from "../../shared/internal";
-import { createMockDb } from "../../testing/index";
-import { DB } from "../generated/kysely-tailordb";
+import { createMockDb } from "../../../testing/index";
+import { Transaction } from "../generated/kysely-tailordb";
 import {
   InvalidEmailError,
   MissingRequiredFieldError,
   UserAlreadyExistsError,
 } from "../lib/errors.generated";
-import { activeUser, baseAuditEvent, pendingUser } from "../testing/fixtures";
+import { activeUser, pendingUser } from "../testing/fixtures";
 import { run } from "./createUser";
 
 describe("createUser", () => {
-  const ctx: CommandContext = {
-    actorId: "test-actor",
-    permissions: ["user-management:createUser"],
-  };
-
   // Error cases
   it("throws when email is empty", async () => {
-    const { db } = createMockDb<DB>();
+    const { db } = createMockDb<Transaction>();
 
-    const result = await run(db, { email: "", name: "Test User", actorId: "actor-1" }, ctx);
+    const result = await run(db, { email: "", name: "Test User" });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(MissingRequiredFieldError);
@@ -28,9 +22,9 @@ describe("createUser", () => {
   });
 
   it("throws when name is empty", async () => {
-    const { db } = createMockDb<DB>();
+    const { db } = createMockDb<Transaction>();
 
-    const result = await run(db, { email: "test@example.com", name: "", actorId: "actor-1" }, ctx);
+    const result = await run(db, { email: "test@example.com", name: "" });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(MissingRequiredFieldError);
@@ -38,13 +32,9 @@ describe("createUser", () => {
   });
 
   it("throws when name is whitespace only", async () => {
-    const { db } = createMockDb<DB>();
+    const { db } = createMockDb<Transaction>();
 
-    const result = await run(
-      db,
-      { email: "test@example.com", name: "   ", actorId: "actor-1" },
-      ctx,
-    );
+    const result = await run(db, { email: "test@example.com", name: "   " });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(MissingRequiredFieldError);
@@ -52,13 +42,9 @@ describe("createUser", () => {
   });
 
   it("throws when email format is invalid (no @)", async () => {
-    const { db } = createMockDb<DB>();
+    const { db } = createMockDb<Transaction>();
 
-    const result = await run(
-      db,
-      { email: "invalidemail", name: "Test User", actorId: "actor-1" },
-      ctx,
-    );
+    const result = await run(db, { email: "invalidemail", name: "Test User" });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(InvalidEmailError);
@@ -66,9 +52,9 @@ describe("createUser", () => {
   });
 
   it("throws when email format is invalid (no domain)", async () => {
-    const { db } = createMockDb<DB>();
+    const { db } = createMockDb<Transaction>();
 
-    const result = await run(db, { email: "test@", name: "Test User", actorId: "actor-1" }, ctx);
+    const result = await run(db, { email: "test@", name: "Test User" });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(InvalidEmailError);
@@ -76,14 +62,10 @@ describe("createUser", () => {
   });
 
   it("throws when email already exists", async () => {
-    const { db, spies } = createMockDb<DB>();
+    const { db, spies } = createMockDb<Transaction>();
     spies.select.mockReturnValue(activeUser);
 
-    const result = await run(
-      db,
-      { email: activeUser.email, name: "New User", actorId: "actor-1" },
-      ctx,
-    );
+    const result = await run(db, { email: activeUser.email, name: "New User" });
     expect(result.ok).toBe(false);
     if (!result.ok) {
       expect(result.error).toBeInstanceOf(UserAlreadyExistsError);
@@ -92,34 +74,21 @@ describe("createUser", () => {
 
   // Success cases
   it("creates user with PENDING status", async () => {
-    const { db, spies } = createMockDb<DB>();
+    const { db, spies } = createMockDb<Transaction>();
     const createdUser = {
       ...pendingUser,
       id: "new-user-id",
       email: "new@example.com",
       name: "New User",
     };
-    const createdAuditEvent = {
-      ...baseAuditEvent,
-      id: "new-event-id",
-      eventType: "USER_CREATED" as const,
-      actorId: "actor-1",
-      targetId: "new-user-id",
-      targetType: "User",
-    };
 
     spies.select.mockReturnValue(undefined); // No existing user
-    spies.insert.mockReturnValueOnce(createdUser).mockReturnValueOnce(createdAuditEvent);
-
-    const result = await run(
-      db,
-      {
-        email: "new@example.com",
-        name: "New User",
-        actorId: "actor-1",
-      },
-      ctx,
-    );
+    spies.insert.mockReturnValue(createdUser);
+
+    const result = await run(db, {
+      email: "new@example.com",
+      name: "New User",
+    });
 
     expect(result.ok).toBe(true);
     if (result.ok) {
@@ -130,42 +99,8 @@ describe("createUser", () => {
     expect(spies.insert).toHaveBeenCalled();
   });
 
-  it("logs USER_CREATED audit event", async () => {
-    const { db, spies } = createMockDb<DB>();
-    const createdUser = {
-      ...pendingUser,
-      id: "new-user-id",
-    };
-    const createdAuditEvent = {
-      ...baseAuditEvent,
-      eventType: "USER_CREATED" as const,
-      actorId: "actor-1",
-      targetId: "new-user-id",
-    };
-
-    spies.select.mockReturnValue(undefined);
-    spies.insert.mockReturnValueOnce(createdUser).mockReturnValueOnce(createdAuditEvent);
-
-    const result = await run(
-      db,
-      {
-        email: "test@example.com",
-        name: "Test User",
-        actorId: "actor-1",
-      },
-      ctx,
-    );
-
-    expect(result.ok).toBe(true);
-    if (result.ok) {
-      expect(result.value.auditEvent.eventType).toBe("USER_CREATED");
-      expect(result.value.auditEvent.actorId).toBe("actor-1");
-      expect(result.value.auditEvent.targetId).toBe(createdUser.id);
-    }
-  });
-
   it("passes custom fields through to insert", async () => {
-    const { db, spies } = createMockDb<DB>();
+    const { db, spies } = createMockDb<Transaction>();
     const createdUser = {
       ...pendingUser,
       id: "new-user-id",
@@ -173,48 +108,26 @@ describe("createUser", () => {
       name: "New User",
       department: "Engineering",
     };
-    const createdAuditEvent = {
-      ...baseAuditEvent,
-      id: "new-event-id",
-      eventType: "USER_CREATED" as const,
-      actorId: "actor-1",
-      targetId: "new-user-id",
-      targetType: "User",
-    };
 
     spies.select.mockReturnValue(undefined);
-    spies.insert.mockReturnValueOnce(createdUser).mockReturnValueOnce(createdAuditEvent);
-
-    const result = await run(
-      db,
-      {
-        email: "new@example.com",
-        name: "New User",
-        actorId: "actor-1",
-        department: "Engineering",
-      },
-      ctx,
-    );
+    spies.insert.mockReturnValue(createdUser);
+
+    const result = await run(db, {
+      email: "new@example.com",
+      name: "New User",
+      department: "Engineering",
+    });
 
     expect(result.ok).toBe(true);
     if (result.ok) {
       expect(result.value.user.id).toBe("new-user-id");
     }
-    expect(spies.insert).toHaveBeenCalledTimes(2);
+    expect(spies.insert).toHaveBeenCalledTimes(1);
 
     // User insert includes custom field
     expect(spies.values).toHaveBeenNthCalledWith(
       1,
       expect.objectContaining({ department: "Engineering" }),
     );
-
-    // Audit event payload includes custom field
-    expect(spies.values).toHaveBeenNthCalledWith(
-      2,
-      expect.objectContaining({
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-        payload: expect.stringContaining('"department":"Engineering"'),
-      }),
-    );
   });
 });

package/src/modules/user-management/command/createUser.ts

@@ -1,5 +1,5 @@
-import { ok, err, type CommandContext } from "../../shared/internal";
-import { DB } from "../generated/kysely-tailordb";
+import { ok, err } from "../../../shared";
+import { Transaction } from "../generated/kysely-tailordb";
 import {
   InvalidEmailError,
   MissingRequiredFieldError,
@@ -9,7 +9,6 @@ import {
 interface CreateUserInput {
   email: string;
   name: string;
-  actorId: string;
 }
 
 const EMAIL_PATTERN = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
@@ -18,15 +17,13 @@ const EMAIL_PATTERN = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
  * Function: createUser
  *
  * Creates a new user account in PENDING status.
- * Validates email format and uniqueness, and logs a USER_CREATED audit event.
+ * Validates email format and uniqueness.
  */
 export async function run<CF extends Record<string, unknown>>(
-  db: DB,
+  db: Transaction,
   input: CreateUserInput & CF,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  _ctx: CommandContext,
 ) {
-  const { email, name, actorId, ...customFields } = input;
+  const { email, name, ...customFields } = input;
 
   if (!email || email.trim() === "") {
     return err(new MissingRequiredFieldError("email"));
@@ -44,13 +41,13 @@ export async function run<CF extends Record<string, unknown>>(
     .selectFrom("User")
     .selectAll()
     .where("email", "=", email)
+    .forUpdate()
     .executeTakeFirst();
 
   if (existingUser) {
     return err(new UserAlreadyExistsError(email));
   }
 
-  // 5. Create user with PENDING status
   const user = await db
     .insertInto("User")
     .values({
@@ -64,20 +61,5 @@ export async function run<CF extends Record<string, unknown>>(
     .returningAll()
     .executeTakeFirst();
 
-  // 6. Log USER_CREATED audit event
-  const auditEvent = await db
-    .insertInto("AuditEvent")
-    .values({
-      eventType: "USER_CREATED",
-      actorId,
-      targetId: user!.id,
-      targetType: "User",
-      payload: JSON.stringify({ email, name, ...customFields }),
-      createdAt: new Date(),
-      updatedAt: null,
-    })
-    .returningAll()
-    .executeTakeFirst();
-
-  return ok({ user: user!, auditEvent: auditEvent! });
+  return ok({ user: user! });
 }

package/src/modules/user-management/command/deactivateUser.generated.ts

@@ -1,5 +1,5 @@
 // @generated — do not edit
-import { defineCommand } from "../../shared/internal";
+import { defineCommand } from "../../../shared";
 import { permissions } from "../lib/permissions.generated";
 import { run } from "./deactivateUser";