@tailgatefantasysports/seasonservice 0.6.0 → 0.6.1

package/SeasonService.js

@@ -72,30 +72,26 @@ module.exports = class SeasonService {
 
     /**
      * Get the last season that finished, including all of its types.
-     * @summary Walks backwards from `date` past every frame of the season `date` falls in, then
-     * collects all frames of the season before it, keyed by type.
+     * @summary Walks backwards from `date` a whole season at a time until it reaches one whose
+     * every frame has ended, then collects that season's frames keyed by type.
      *
-     * A season `date` sits inside has not finished, so it is never the answer. Skipping the
-     * whole season rather than just the current frame matters mid-season: from a regular-season
-     * date, stepping back one frame lands on that same season's preseason, which would report a
-     * partial in-progress season as the previous one.
+     * Stepping back one *frame* is not enough. Mid-season, one frame back is the same season's
+     * preseason. And in the gap between a season's preseason and its regular season, the
+     * nearest frame behind `date` is that same season's preseason — a season that has barely
+     * begun, not the last one to finish.
      *
      * @param {object} date - date to begin search
      * @returns {object|null} frames keyed by type, or null when no earlier season exists
      */
     getPreviousFullSeason(date) {
-        const current = this.getSeason(date);
-        let frame = current || this._getSeasonDirection(date, -1);
+        let frame = this.getSeason(date) || this._getSeasonDirection(date, -1);
+
+        while (frame && !this._isSeasonFinished(frame.season, date))
+            frame = this._skipSeason(frame);
+
         if (!frame)
             return null;
 
-        if (current) {
-            while (frame && frame.season === current.season)
-                frame = this._getSeasonDirection(new Date(frame.start - 1), -1);
-            if (!frame)
-                return null;
-        }
-
         const full = { };
         const season = frame.season;
         while (frame && frame.season === season) {
@@ -106,6 +102,33 @@ module.exports = class SeasonService {
         return full;
     }
 
+    /**
+     * Whether every configured frame of a season has ended by `date`.
+     * @param {string|number} season - season key into the timeframes config
+     * @param {object} date - js date to measure against
+     * @returns {boolean}
+     */
+    _isSeasonFinished(season, date) {
+        const frames = this.timeframes[season];
+        if (!frames)
+            return false;
+
+        return Object.values(frames).every(({ end }) => end <= date);
+    }
+
+    /**
+     * Walks backwards past every frame of `frame`'s season to the nearest frame before it.
+     * @param {object} frame - season frame to step back from
+     * @returns {object|undefined} the preceding season's latest frame, if any
+     */
+    _skipSeason(frame) {
+        const season = frame.season;
+        while (frame && frame.season === season)
+            frame = this._getSeasonDirection(new Date(frame.start - 1), -1);
+
+        return frame;
+    }
+
     /**
      * Returns the regular season frame for a given season year, or null if not configured.
      * @param {string|number} seasonYear

package/__tests__/SeasonService.test.js

@@ -169,7 +169,11 @@ describe('GetPreviousFullSeason — real calendar', () => {
     test.each([
         ['from the 2026 preseason', new Date('2026-08-23T00:00:00Z')],
         ['from mid 2026 regular season', new Date('2026-11-01T00:00:00Z')],
-        ['from the 2026 off-season', new Date('2026-05-01T00:00:00Z')]
+        ['from the 2026 off-season', new Date('2026-05-01T00:00:00Z')],
+        // The gap between the 2026 preseason ending and week 1 kicking off. No frame contains
+        // these dates, and the nearest one behind them is the 2026 preseason.
+        ['from the day the 2026 preseason ends', new Date('2026-09-02T00:00:00Z')],
+        ['from the eve of the 2026 regular season', new Date('2026-09-08T18:00:00Z')]
     ])('%s answers 2025, whole', (_tName, date) => {
         const full = configured.getPreviousFullSeason(date);
         expect(full).not.toBeNull();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tailgatefantasysports/seasonservice",
-  "version": "0.6.0",
+  "version": "0.6.1",
   "description": "Generic Season Service",
   "main": "index.js",
   "scripts": {