@taiga-ui/eslint-plugin-experience-next 0.510.0 → 0.511.0

package/README.md

@@ -103,6 +103,7 @@ from third-party plugins. The exact severities and file globs live in
 | [no-redundant-type-annotation](https://github.com/taiga-family/toolkit/tree/main/projects/eslint-plugin-experience-next/docs/no-redundant-type-annotation.md)                                       | Disallow redundant type annotations when the type is already inferred from the initializer          | ✅  | 🔧  |     |
 | [no-repeated-signal-in-conditional](https://github.com/taiga-family/toolkit/tree/main/projects/eslint-plugin-experience-next/docs/no-repeated-signal-in-conditional.md)                             | Disallow reading the same nullable Angular signal more than once in a conditional expression        | ✅  | 🔧  |     |
 | [no-side-effects-in-computed](https://github.com/taiga-family/toolkit/tree/main/projects/eslint-plugin-experience-next/docs/no-side-effects-in-computed.md)                                         | Disallow side effects and effectful helper calls inside Angular `computed()` callbacks              | ✅  |     |     |
+| [no-signal-outside-class](https://github.com/taiga-family/toolkit/tree/main/projects/eslint-plugin-experience-next/docs/no-signal-outside-class.md)                                                 | Disallow class properties that reference a module-scope Angular signal                              | ✅  |     |     |
 | [no-signal-reads-after-await-in-reactive-context](https://github.com/taiga-family/toolkit/tree/main/projects/eslint-plugin-experience-next/docs/no-signal-reads-after-await-in-reactive-context.md) | Disallow bare signal reads after `await` inside reactive callbacks                                  | ✅  |     |     |
 | [no-string-literal-concat](https://github.com/taiga-family/toolkit/tree/main/projects/eslint-plugin-experience-next/docs/no-string-literal-concat.md)                                               | Disallow string literal concatenation; merge adjacent literals into one                             | ✅  | 🔧  |     |
 | [no-untracked-outside-reactive-context](https://github.com/taiga-family/toolkit/tree/main/projects/eslint-plugin-experience-next/docs/no-untracked-outside-reactive-context.md)                     | Disallow `untracked()` outside reactive callbacks, except explicit post-`await` snapshots           | ✅  | 🔧  |     |

package/index.d.ts

@@ -125,6 +125,9 @@ declare const plugin: {
         'no-side-effects-in-computed': import("@typescript-eslint/utils/ts-eslint").RuleModule<"sideEffectInComputed", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
             name: string;
         };
+        'no-signal-outside-class': import("@typescript-eslint/utils/ts-eslint").RuleModule<"noSignalOutsideClass", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+            name: string;
+        };
         'no-signal-reads-after-await-in-reactive-context': import("@typescript-eslint/utils/ts-eslint").RuleModule<"readAfterAwait", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
             name: string;
         };

package/index.esm.js

@@ -1210,6 +1210,7 @@ var recommended = defineConfig([
             '@taiga-ui/experience-next/no-redundant-type-annotation': 'error',
             '@taiga-ui/experience-next/no-repeated-signal-in-conditional': 'error',
             '@taiga-ui/experience-next/no-side-effects-in-computed': 'error',
+            '@taiga-ui/experience-next/no-signal-outside-class': 'error',
             '@taiga-ui/experience-next/no-signal-reads-after-await-in-reactive-context': 'error',
             '@taiga-ui/experience-next/no-untracked-outside-reactive-context': 'error',
             '@taiga-ui/experience-next/no-useless-untracked': 'error',
@@ -46224,7 +46225,7 @@ function buildMultilineStartTag(node, sourceText) {
         closing,
     ].join('\n');
 }
-const rule$S = createRule({
+const rule$T = createRule({
     name: 'attrs-newline',
     rule: {
         create(context) {
@@ -46404,7 +46405,7 @@ function sameOrder(a, b) {
     return a.length === b.length && a.every((value, index) => value === b[index]);
 }
 
-const rule$R = createRule({
+const rule$S = createRule({
     create(context, [order]) {
         const decorators = new Set(Object.keys(order));
         return {
@@ -46540,7 +46541,7 @@ function getNodeLabel(node) {
     }
     return node instanceof dist$4.TmplAstBoundText ? 'binding' : 'text';
 }
-const rule$Q = createRule({
+const rule$R = createRule({
     name: 'element-newline',
     rule: {
         create(context) {
@@ -46679,7 +46680,7 @@ const PRESETS = {
     $VUE: ['$CLASS', '$ID', '$VUE_ATTRIBUTE'],
     $VUE_ATTRIBUTE: /^v-/,
 };
-const rule$P = createRule({
+const rule$Q = createRule({
     create(context, [options]) {
         const sourceCode = context.sourceCode;
         const settings = {
@@ -47010,7 +47011,7 @@ const config$4 = {
         type: 'suggestion',
     },
 };
-const rule$O = createRule({
+const rule$P = createRule({
     name: 'html-logical-properties',
     rule: config$4,
 });
@@ -248252,7 +248253,7 @@ function isImportUsedOnlyAsAngularDiFirstArg(node, sourceCode) {
     }
     return hasSafeRuntimeUsage;
 }
-const rule$N = createRule({
+const rule$O = createRule({
     create(context) {
         const { checker, esTreeNodeToTSNodeMap, sourceCode, tsProgram } = getTypeAwareRuleContext(context);
         const checkCycles = context.options[0]?.checkCycles ?? true;
@@ -248977,7 +248978,7 @@ function getNgDevModeDeclarationFix(program, fixer) {
         ? fixer.insertTextBefore(firstStatement, 'declare const ngDevMode: boolean;\n\n')
         : fixer.insertTextBeforeRange([0, 0], 'declare const ngDevMode: boolean;\n');
 }
-const rule$M = createRule({
+const rule$N = createRule({
     create(context) {
         const { sourceCode } = context;
         const program = sourceCode.ast;
@@ -249026,7 +249027,7 @@ const rule$M = createRule({
     name: 'injection-token-description',
 });
 
-const rule$L = createRule({
+const rule$M = createRule({
     create(context) {
         const { sourceCode } = context;
         const namespaceImports = new Map();
@@ -249121,7 +249122,7 @@ const DEFAULT_OPTIONS = {
     importDeclaration: '^@taiga-ui*',
     projectName: String.raw `(?<=^@taiga-ui/)([-\w]+)`,
 };
-const rule$K = createRule({
+const rule$L = createRule({
     create(context) {
         const { currentProject, deepImport, ignoreImports, importDeclaration, projectName, } = { ...DEFAULT_OPTIONS, ...context.options[0] };
         const hasNonCodeExtension = (source) => {
@@ -249213,7 +249214,7 @@ const nearestFileUpCache = new Map();
 const markerCache = new Map();
 const indexFileCache = new Map();
 const indexExportsCache = new Map();
-const rule$J = createRule({
+const rule$K = createRule({
     create(context) {
         const parserServices = dist$3.ESLintUtils.getParserServices(context);
         const program = parserServices.program;
@@ -249407,13 +249408,13 @@ const noDuplicateAttributesRule = angular.templatePlugin.rules?.['no-duplicate-a
 if (!noDuplicateAttributesRule) {
     throw new Error('angular-eslint template rule "no-duplicate-attributes" is not available');
 }
-const rule$I = createRule({
+const rule$J = createRule({
     name: 'no-duplicate-attrs',
     rule: noDuplicateAttributesRule,
 });
 
 const MESSAGE_ID$c = 'duplicateId';
-const rule$H = createRule({
+const rule$I = createRule({
     name: 'no-duplicate-id',
     rule: {
         create(context) {
@@ -249474,7 +249475,7 @@ function getTrackingKey(node) {
         ? 'link[rel=canonical]'
         : null;
 }
-const rule$G = createRule({
+const rule$H = createRule({
     name: 'no-duplicate-in-head',
     rule: {
         create(context) {
@@ -249530,7 +249531,7 @@ const rule$G = createRule({
 });
 
 const COMPONENT_DECORATORS = new Set(['Component']);
-const rule$F = createRule({
+const rule$G = createRule({
     create(context) {
         const { sourceCode } = context;
         return {
@@ -249823,7 +249824,7 @@ function walkAst(root, visitor) {
     }
 }
 
-const ANGULAR_CORE$1 = '@angular/core';
+const ANGULAR_CORE$2 = '@angular/core';
 /**
  * Returns the local name bound to a named import from a given source.
  * Handles aliased imports: `import { untracked as ngUntracked } from '@angular/core'`
@@ -249851,7 +249852,7 @@ function getLocalNameForImport(program, source, exportedName) {
 }
 function findAngularCoreImports(program) {
     return program.body.filter((node) => node.type === dist$3.AST_NODE_TYPES.ImportDeclaration &&
-        node.source.value === ANGULAR_CORE$1);
+        node.source.value === ANGULAR_CORE$2);
 }
 function findRuntimeAngularCoreImport(program) {
     return (findAngularCoreImports(program).find((node) => node.importKind !== 'type') ?? null);
@@ -249873,7 +249874,7 @@ function findAngularCoreImportSpecifier(program, exportedName) {
     return null;
 }
 
-const ANGULAR_CORE = '@angular/core';
+const ANGULAR_CORE$1 = '@angular/core';
 const SIGNAL_WRITE_METHODS = new Set(['mutate', 'set', 'update']);
 const AFTER_RENDER_EFFECT_PHASES = new Map([
     ['earlyRead', 'afterRenderEffect().earlyRead'],
@@ -249899,7 +249900,7 @@ function getPropertyName(property) {
     return typeof property.key.value === 'string' ? property.key.value : null;
 }
 function isAngularCoreCall(node, program, exportedName) {
-    const localName = getLocalNameForImport(program, ANGULAR_CORE, exportedName);
+    const localName = getLocalNameForImport(program, ANGULAR_CORE$1, exportedName);
     return localName
         ? node.callee.type === dist$3.AST_NODE_TYPES.Identifier &&
             node.callee.name === localName &&
@@ -250178,7 +250179,7 @@ const ANGULAR_SIGNALS_UNTRACKED_GUIDE_URL = 'https://angular.dev/guide/signals#r
 const ANGULAR_SIGNALS_ASYNC_GUIDE_URL = 'https://angular.dev/guide/signals#reactive-context-and-async-operations';
 const createUntrackedRule = createRule;
 
-const rule$E = createUntrackedRule({
+const rule$F = createUntrackedRule({
     create(context) {
         const { checker, esTreeNodeToTSNodeMap, program } = getTypeAwareRuleContext(context);
         const signalNodeMap = esTreeNodeToTSNodeMap;
@@ -250251,7 +250252,7 @@ const config$3 = {
         type: 'problem',
     },
 };
-const rule$D = createRule({
+const rule$E = createRule({
     name: 'no-href-with-router-link',
     rule: config$3,
 });
@@ -250312,7 +250313,7 @@ function getScopeRoot(node) {
     return (findAncestor(node, (ancestor) => ancestor.type === dist$3.AST_NODE_TYPES.Program || isFunctionLike(ancestor)) ?? node);
 }
 
-const rule$C = createRule({
+const rule$D = createRule({
     create(context) {
         const checkImplicitPublic = (node) => {
             const classRef = getEnclosingClass(node);
@@ -250374,7 +250375,7 @@ const rule$C = createRule({
     name: 'no-implicit-public',
 });
 
-const rule$B = createRule({
+const rule$C = createRule({
     create(context) {
         const { sourceCode } = context;
         return {
@@ -250430,7 +250431,7 @@ function isInfiniteLoopLiteral(node) {
 function isInfiniteLoopTest(test) {
     return test == null || isInfiniteLoopLiteral(test);
 }
-const rule$A = createRule({
+const rule$B = createRule({
     create(context) {
         return {
             DoWhileStatement(node) {
@@ -250475,7 +250476,7 @@ const rule$A = createRule({
 });
 
 const LEGACY_PEER_DEPS_PATTERN = /^legacy-peer-deps\s*=\s*true$/i;
-const rule$z = createRule({
+const rule$A = createRule({
     create(context) {
         return {
             Program(node) {
@@ -250935,7 +250936,7 @@ const OBSOLETE_HTML_ATTRS = {
 };
 
 const MESSAGE_ID$9 = 'obsolete';
-const rule$y = createRule({
+const rule$z = createRule({
     name: 'no-obsolete-attrs',
     rule: {
         create(context) {
@@ -251013,7 +251014,7 @@ const OBSOLETE_HTML_TAGS = new Set([
 ]);
 
 const MESSAGE_ID$8 = 'unexpected';
-const rule$x = createRule({
+const rule$y = createRule({
     name: 'no-obsolete-tags',
     rule: {
         create(context) {
@@ -251040,7 +251041,7 @@ const rule$x = createRule({
     },
 });
 
-const rule$w = createRule({
+const rule$x = createRule({
     create(context) {
         const { checker, esTreeNodeToTSNodeMap, sourceCode } = getTypeAwareRuleContext(context);
         return {
@@ -251184,7 +251185,7 @@ const config$2 = {
         type: 'problem',
     },
 };
-const rule$v = createRule({
+const rule$w = createRule({
     name: 'no-project-as-in-ng-template',
     rule: config$2,
 });
@@ -251221,7 +251222,7 @@ function collectArrayExpressions(node) {
     }
     return result;
 }
-const rule$u = createRule({
+const rule$v = createRule({
     create(context) {
         const { checker: typeChecker, esTreeNodeToTSNodeMap } = getTypeAwareRuleContext(context);
         const ignoreTupleContextualTyping = context.options[0]?.ignoreTupleContextualTyping ?? true;
@@ -251419,7 +251420,7 @@ function isOptionalMemberReceiver(call) {
         parent.object === current &&
         parent.optional);
 }
-const rule$t = createRule({
+const rule$u = createRule({
     create(context) {
         const { checker, esTreeNodeToTSNodeMap, sourceCode } = getTypeAwareRuleContext(context);
         const signalNodeMap = esTreeNodeToTSNodeMap;
@@ -251522,15 +251523,22 @@ const rule$t = createRule({
 });
 
 /**
- * Strips TypeScript-only wrapper nodes that have no runtime meaning:
- * `as` casts, non-null assertions (`!`), type assertions (`<T>expr`), and
- * optional-chain wrappers. Iterates until no more wrappers are found.
+ * Strips expression wrapper nodes that do not affect the underlying expression:
+ * parentheses, `as` casts, `satisfies`, non-null assertions (`!`), type
+ * assertions (`<T>expr`), and optional-chain wrappers. Iterates until no more
+ * wrappers are found.
  */
 function unwrapExpression(expression) {
     let current = expression;
     let didUnwrap = true;
     while (didUnwrap) {
         didUnwrap = false;
+        const parenthesized = getParenthesizedExpression(current);
+        if (parenthesized) {
+            current = parenthesized;
+            didUnwrap = true;
+            continue;
+        }
         switch (current.type) {
             case dist$3.AST_NODE_TYPES.ChainExpression:
                 current = current.expression;
@@ -251544,6 +251552,10 @@ function unwrapExpression(expression) {
                 current = current.expression;
                 didUnwrap = true;
                 break;
+            case dist$3.AST_NODE_TYPES.TSSatisfiesExpression:
+                current = current.expression;
+                didUnwrap = true;
+                break;
             case dist$3.AST_NODE_TYPES.TSTypeAssertion:
                 current = current.expression;
                 didUnwrap = true;
@@ -251552,6 +251564,19 @@ function unwrapExpression(expression) {
     }
     return current;
 }
+function isExpressionLike(value) {
+    return (typeof value === 'object' &&
+        value !== null &&
+        'type' in value &&
+        typeof value.type === 'string');
+}
+function getParenthesizedExpression(expression) {
+    const maybeExpression = expression;
+    return maybeExpression.type === 'ParenthesizedExpression' &&
+        isExpressionLike(maybeExpression.expression)
+        ? maybeExpression.expression
+        : null;
+}
 
 function unwrapMutationTarget(node) {
     let current = node;
@@ -251840,7 +251865,7 @@ function inspectComputedBody(root, context, localScopes, visitedFunctions, repor
         return;
     });
 }
-const rule$s = createRule({
+const rule$t = createRule({
     create(context) {
         const { checker, esTreeNodeToTSNodeMap, program, sourceCode, tsNodeToESTreeNodeMap, } = getTypeAwareRuleContext(context);
         const signalNodeMap = esTreeNodeToTSNodeMap;
@@ -251883,6 +251908,88 @@ const rule$s = createRule({
     name: 'no-side-effects-in-computed',
 });
 
+const ANGULAR_CORE = '@angular/core';
+const SIGNAL_FACTORIES = ['computed', 'effect', 'linkedSignal', 'signal'];
+function isSignalFactoryCall(node, factoryNames) {
+    if (!node) {
+        return false;
+    }
+    const expression = unwrapExpression(node);
+    return (expression.type === dist$3.AST_NODE_TYPES.CallExpression &&
+        expression.callee.type === dist$3.AST_NODE_TYPES.Identifier &&
+        factoryNames.has(expression.callee.name));
+}
+function getModuleScopeVariableDeclaration(statement) {
+    if (statement.type === dist$3.AST_NODE_TYPES.VariableDeclaration) {
+        return statement;
+    }
+    if (statement.type !== dist$3.AST_NODE_TYPES.ExportNamedDeclaration) {
+        return null;
+    }
+    return statement.declaration?.type === dist$3.AST_NODE_TYPES.VariableDeclaration
+        ? statement.declaration
+        : null;
+}
+function collectModuleScopeSignalNames(program, factoryNames) {
+    const names = new Set();
+    for (const statement of program.body) {
+        const declaration = getModuleScopeVariableDeclaration(statement);
+        if (!declaration) {
+            continue;
+        }
+        for (const declarator of declaration.declarations) {
+            if (declarator.id.type === dist$3.AST_NODE_TYPES.Identifier &&
+                isSignalFactoryCall(declarator.init, factoryNames)) {
+                names.add(declarator.id.name);
+            }
+        }
+    }
+    return names;
+}
+const rule$s = createRule({
+    create(context) {
+        const program = context.sourceCode.ast;
+        const factoryNames = new Set();
+        for (const name of SIGNAL_FACTORIES) {
+            const localName = getLocalNameForImport(program, ANGULAR_CORE, name);
+            if (localName) {
+                factoryNames.add(localName);
+            }
+        }
+        if (factoryNames.size === 0) {
+            return {};
+        }
+        const moduleScopeSignals = collectModuleScopeSignalNames(program, factoryNames);
+        return moduleScopeSignals.size === 0
+            ? {}
+            : {
+                PropertyDefinition(node) {
+                    const value = node.value ? unwrapExpression(node.value) : null;
+                    if (value?.type !== dist$3.AST_NODE_TYPES.Identifier ||
+                        !moduleScopeSignals.has(value.name)) {
+                        return;
+                    }
+                    context.report({
+                        data: { name: value.name },
+                        messageId: 'noSignalOutsideClass',
+                        node: value,
+                    });
+                },
+            };
+    },
+    meta: {
+        docs: {
+            description: 'Disallow class properties that reference a module-scope Angular signal; move the signal creation into the class body',
+        },
+        messages: {
+            noSignalOutsideClass: '`{{name}}` is a module-scope signal. Move it into the class body: `{{name}} = signal(...)`.',
+        },
+        schema: [],
+        type: 'problem',
+    },
+    name: 'no-signal-outside-class',
+});
+
 const rule$r = createUntrackedRule({
     create(context) {
         const { checker, esTreeNodeToTSNodeMap, program, sourceCode } = getTypeAwareRuleContext(context);
@@ -255592,36 +255699,37 @@ const plugin = {
     },
     rules: {
         'array-as-const': rule$5,
-        'attrs-newline': rule$S,
+        'attrs-newline': rule$T,
         'class-property-naming': rule$4,
-        'decorator-key-sort': rule$R,
-        'element-newline': rule$Q,
+        'decorator-key-sort': rule$S,
+        'element-newline': rule$R,
         'flat-exports': rule$3,
-        'host-attributes-sort': rule$P,
-        'html-logical-properties': rule$O,
-        'import-integrity': rule$N,
-        'injection-token-description': rule$M,
-        'no-commonjs-import-patterns': rule$L,
-        'no-deep-imports': rule$K,
-        'no-deep-imports-to-indexed-packages': rule$J,
-        'no-duplicate-attrs': rule$I,
-        'no-duplicate-id': rule$H,
-        'no-duplicate-in-head': rule$G,
-        'no-empty-style-metadata': rule$F,
-        'no-fully-untracked-effect': rule$E,
-        'no-href-with-router-link': rule$D,
-        'no-implicit-public': rule$C,
-        'no-import-assertions': rule$B,
-        'no-infinite-loop': rule$A,
-        'no-legacy-peer-deps': rule$z,
-        'no-obsolete-attrs': rule$y,
-        'no-obsolete-tags': rule$x,
-        'no-playwright-empty-fill': rule$w,
-        'no-project-as-in-ng-template': rule$v,
-        'no-redundant-type-annotation': rule$u,
-        'no-repeated-signal-in-conditional': rule$t,
+        'host-attributes-sort': rule$Q,
+        'html-logical-properties': rule$P,
+        'import-integrity': rule$O,
+        'injection-token-description': rule$N,
+        'no-commonjs-import-patterns': rule$M,
+        'no-deep-imports': rule$L,
+        'no-deep-imports-to-indexed-packages': rule$K,
+        'no-duplicate-attrs': rule$J,
+        'no-duplicate-id': rule$I,
+        'no-duplicate-in-head': rule$H,
+        'no-empty-style-metadata': rule$G,
+        'no-fully-untracked-effect': rule$F,
+        'no-href-with-router-link': rule$E,
+        'no-implicit-public': rule$D,
+        'no-import-assertions': rule$C,
+        'no-infinite-loop': rule$B,
+        'no-legacy-peer-deps': rule$A,
+        'no-obsolete-attrs': rule$z,
+        'no-obsolete-tags': rule$y,
+        'no-playwright-empty-fill': rule$x,
+        'no-project-as-in-ng-template': rule$w,
+        'no-redundant-type-annotation': rule$v,
+        'no-repeated-signal-in-conditional': rule$u,
         'no-restricted-attr-values': rule$2,
-        'no-side-effects-in-computed': rule$s,
+        'no-side-effects-in-computed': rule$t,
+        'no-signal-outside-class': rule$s,
         'no-signal-reads-after-await-in-reactive-context': rule$r,
         'no-string-literal-concat': rule$q,
         'no-untracked-outside-reactive-context': rule$p,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@taiga-ui/eslint-plugin-experience-next",
-  "version": "0.510.0",
+  "version": "0.511.0",
   "description": "An ESLint plugin to enforce a consistent code styles across taiga-ui projects",
   "repository": {
     "type": "git",

package/rules/recommended/no-signal-outside-class.d.ts

@@ -0,0 +1,4 @@
+export declare const rule: import("@typescript-eslint/utils/ts-eslint").RuleModule<"noSignalOutsideClass", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+    name: string;
+};
+export default rule;

package/rules/utils/ast/ast-expressions.d.ts

@@ -1,7 +1,8 @@
 import { type TSESTree } from '@typescript-eslint/utils';
 /**
- * Strips TypeScript-only wrapper nodes that have no runtime meaning:
- * `as` casts, non-null assertions (`!`), type assertions (`<T>expr`), and
- * optional-chain wrappers. Iterates until no more wrappers are found.
+ * Strips expression wrapper nodes that do not affect the underlying expression:
+ * parentheses, `as` casts, `satisfies`, non-null assertions (`!`), type
+ * assertions (`<T>expr`), and optional-chain wrappers. Iterates until no more
+ * wrappers are found.
  */
 export declare function unwrapExpression(expression: TSESTree.Expression): TSESTree.Expression;