@taiga-ui/eslint-plugin-experience-next 0.473.0 → 0.475.0

package/README.md

@@ -50,11 +50,12 @@ export default [
 | no-fully-untracked-effect                       | Disallow reactive callbacks where all signal reads are hidden inside `untracked()`                  | ✅  |     |     |
 | no-href-with-router-link                        | Do not use href and routerLink attributes together on the same element                              | ✅  | 🔧  |     |
 | no-implicit-public                              | Require explicit `public` modifier for class members and parameter properties                       | ✅  | 🔧  |     |
+| no-infinite-loop                                | Disallow `while (true)` and `for` loops without an explicit condition                               | ✅  |     |     |
 | no-legacy-peer-deps                             | Disallow `legacy-peer-deps=true` in `.npmrc`                                                        | ✅  |     |     |
 | no-playwright-empty-fill                        | Enforce `clear()` over `fill('')` in Playwright tests                                               | ✅  | 🔧  |     |
 | no-project-as-in-ng-template                    | `ngProjectAs` has no effect inside `<ng-template>` or dynamic outlets                               | ✅  |     |     |
 | no-redundant-type-annotation                    | Disallow redundant type annotations when the type is already inferred from the initializer          | ✅  | 🔧  |     |
-| no-side-effects-in-computed                     | Disallow observable side effects inside Angular `computed()` callbacks                              | ✅  |     |     |
+| no-side-effects-in-computed                     | Disallow side effects and effectful helper calls inside Angular `computed()` callbacks              | ✅  |     |     |
 | no-signal-reads-after-await-in-reactive-context | Disallow bare signal reads after `await` inside reactive callbacks                                  | ✅  |     |     |
 | no-string-literal-concat                        | Disallow string literal concatenation; merge adjacent literals into one                             | ✅  | 🔧  |     |
 | no-untracked-outside-reactive-context           | Disallow `untracked()` outside reactive callbacks, except explicit post-`await` snapshots           | ✅  | 🔧  |     |
@@ -441,6 +442,48 @@ class MyService {
 
 ---
 
+## no-infinite-loop
+
+<sup>`✅ Recommended`</sup>
+
+Disallows the two loop forms banned by this project: `while (true)` and `for` loops without a condition, including the
+canonical `for (;;)` form. These loops hide the real exit condition inside the body, which makes control flow harder to
+scan and review.
+
+```ts
+// ❌ error
+while (true) {
+  if (isDone) {
+    break;
+  }
+
+  process();
+}
+
+// ✅ ok
+while (!isDone) {
+  process();
+}
+```
+
+```ts
+// ❌ error
+for (;;) {
+  if (queue.length === 0) {
+    break;
+  }
+
+  flush(queue.shift());
+}
+
+// ✅ ok
+for (; queue.length > 0; ) {
+  flush(queue.shift());
+}
+```
+
+---
+
 ## no-legacy-peer-deps
 
 <sup>`✅ Recommended`</sup>
@@ -681,8 +724,9 @@ const doubled = computed(() => {
 <sup>`✅ Recommended`</sup>
 
 `computed()` should only derive a value from its inputs. This rule reports observable side effects inside Angular
-`computed()` callbacks, including signal writes (`.set()`, `.update()`, `.mutate()`), assignments to captured state,
-`++/--`, `delete`, and property mutations on objects that were not created inside the computation itself.
+`computed()` callbacks, including signal writes (`.set()`, `.update()`, `.mutate()`), `effect()`, `inject()`,
+assignments to captured state, `++/--`, `delete`, property mutations on objects that were not created inside the
+computation itself, and calls to local helper functions or methods when their bodies perform those operations.
 
 ```ts
 // ❌ error
@@ -691,8 +735,12 @@ import {computed, signal} from '@angular/core';
 const source = signal(0);
 const target = signal(0);
 
-const derived = computed(() => {
+function syncTarget(): void {
   target.set(source() + 1);
+}
+
+const derived = computed(() => {
+  syncTarget();
   return target();
 });
 ```

package/index.d.ts

@@ -49,6 +49,9 @@ declare const plugin: {
         'no-implicit-public': import("@typescript-eslint/utils/ts-eslint").RuleModule<"implicitPublic", readonly unknown[], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
             name: string;
         };
+        'no-infinite-loop': import("@typescript-eslint/utils/ts-eslint").RuleModule<"forLoop" | "whileLoop", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+            name: string;
+        };
         'no-legacy-peer-deps': import("@typescript-eslint/utils/ts-eslint").RuleModule<"noLegacyPeerDeps", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
             name: string;
         };