@taiga-ui/eslint-plugin-experience-next 0.462.0 → 0.463.0

package/README.md

@@ -46,7 +46,7 @@ export default [
 | injection-token-description         | They are required to provide a description for `InjectionToken`                                     | ✅  |     |     |
 | no-deep-imports                     | Disables deep imports of Taiga UI packages                                                          | ✅  | 🔧  |     |
 | no-deep-imports-to-indexed-packages | Disallow deep imports from packages that expose an index.ts next to ng-package.json or package.json | ✅  | 🔧  |     |
-| no-href-with-router-link            | Do not use href and routerLink attributes together on the same element                              |     | 🔧  |     |
+| no-href-with-router-link            | Do not use href and routerLink attributes together on the same element                              | ✅  | 🔧  |     |
 | no-implicit-public                  | Require explicit `public` modifier for class members and parameter properties                       | ✅  | 🔧  |     |
 | no-playwright-empty-fill            | Enforce `clear()` over `fill('')` in Playwright tests                                               | ✅  | 🔧  |     |
 | no-project-as-in-ng-template        | `ngProjectAs` has no effect inside `<ng-template>` or dynamic outlets                               |     |     |     |
@@ -232,6 +232,8 @@ import {Foo} from '@my-lib/internal';
 
 ## no-href-with-router-link
 
+> ✅ Included in `recommended` — processed by the angular-eslint template parser (`**/*.html`).
+
 Disallows using both `href` and `routerLink` on the same `<a>` element in Angular templates. Autofix removes the `href`
 attribute.
 

package/index.esm.js

@@ -55,7 +55,6 @@ var htmlEslint = defineConfig([
             parserOptions: { templateEngineSyntax: { '{{': '}}' } },
         },
         rules: {
-            '@taiga-ui/experience-next/no-href-with-router-link': 'error',
             'html/indent': 'off', // prettier conflicts
             'html/no-extra-spacing-attrs': 'off', // prettier conflicts
             'html/no-multiple-h1': 'off',
@@ -990,6 +989,7 @@ var recommended = defineConfig([
             '@angular-eslint/template/prefer-control-flow': angularVersion >= modernAngularRules.preferControlFlow ? 'error' : 'off',
             '@angular-eslint/template/prefer-self-closing-tags': 'error',
             '@angular-eslint/template/prefer-template-literal': angularVersion >= modernAngularRules.templateLiteral ? 'error' : 'off',
+            '@taiga-ui/experience-next/no-href-with-router-link': 'error',
             '@taiga-ui/experience-next/no-project-as-in-ng-template': 'error',
         },
     },
@@ -1991,37 +1991,34 @@ const ERROR_MESSAGE$1 = 'Do not use href and routerLink attributes together on t
 const config$1 = {
     create(context) {
         return {
-            Tag(node) {
-                const htmlNode = node;
-                if (htmlNode?.name?.toLowerCase() !== 'a') {
+            Element(rawNode) {
+                const node = rawNode;
+                if (node.name !== 'a') {
                     return;
                 }
-                let hrefAttribute = null;
-                let routerLinkAttribute = null;
-                let hasRouterLink = false;
-                let hasHref = false;
-                for (const attr of htmlNode.attributes ?? []) {
-                    const attrName = attr.key.value;
-                    if (attrName?.toLowerCase() === 'href') {
-                        hasHref = true;
-                        hrefAttribute = attr;
-                    }
-                    else if (attrName?.toLowerCase() === 'routerlink') {
-                        hasRouterLink = true;
-                        routerLinkAttribute = attr;
-                    }
-                }
-                if (hasHref && hasRouterLink) {
-                    context.report({
-                        fix: (fixer) => hrefAttribute?.range
-                            ? fixer.removeRange(hrefAttribute.range)
-                            : null,
-                        messageId: MESSAGE_ID$3,
-                        node: (routerLinkAttribute ??
-                            hrefAttribute ??
-                            htmlNode),
-                    });
+                const hrefAttr = node.attributes.find((attr) => attr.name === 'href');
+                const hasRouterLink = node.attributes.some((attr) => attr.name.toLowerCase() === 'routerlink') ||
+                    node.inputs.some((input) => input.name.toLowerCase() === 'routerlink');
+                if (!hrefAttr || !hasRouterLink) {
+                    return;
                 }
+                context.report({
+                    fix: (fixer) => fixer.removeRange([
+                        hrefAttr.sourceSpan.start.offset,
+                        hrefAttr.sourceSpan.end.offset,
+                    ]),
+                    loc: {
+                        end: {
+                            column: hrefAttr.sourceSpan.end.col,
+                            line: hrefAttr.sourceSpan.end.line + 1,
+                        },
+                        start: {
+                            column: hrefAttr.sourceSpan.start.col,
+                            line: hrefAttr.sourceSpan.start.line + 1,
+                        },
+                    },
+                    messageId: MESSAGE_ID$3,
+                });
             },
         };
     },
@@ -2029,6 +2026,7 @@ const config$1 = {
         docs: { description: ERROR_MESSAGE$1 },
         fixable: 'code',
         messages: { [MESSAGE_ID$3]: ERROR_MESSAGE$1 },
+        schema: [],
         type: 'problem',
     },
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@taiga-ui/eslint-plugin-experience-next",
-  "version": "0.462.0",
+  "version": "0.463.0",
   "description": "An ESLint plugin to enforce a consistent code styles across taiga-ui projects",
   "repository": {
     "type": "git",