@taiga-ui/eslint-plugin-experience-next 0.452.0 → 0.454.0

package/index.esm.js

@@ -418,7 +418,7 @@ var recommended = defineConfig([
             '@typescript-eslint/no-base-to-string': 'off',
             '@typescript-eslint/no-confusing-non-null-assertion': 'error',
             '@typescript-eslint/no-confusing-void-expression': 'off',
-            '@typescript-eslint/no-deprecated': 'off',
+            '@typescript-eslint/no-deprecated': 'off', // TODO: should be error?
             '@typescript-eslint/no-duplicate-enum-values': 'error',
             '@typescript-eslint/no-duplicate-type-constituents': 'error',
             '@typescript-eslint/no-empty-function': [
@@ -435,7 +435,7 @@ var recommended = defineConfig([
                 },
             ],
             '@typescript-eslint/no-empty-object-type': 'error',
-            '@typescript-eslint/no-explicit-any': 'off',
+            '@typescript-eslint/no-explicit-any': 'off', // TODO: should be error?
             '@typescript-eslint/no-extra-non-null-assertion': 'error',
             '@typescript-eslint/no-extraneous-class': [
                 'error',
@@ -446,14 +446,15 @@ var recommended = defineConfig([
                     allowWithDecorator: true,
                 },
             ],
-            '@typescript-eslint/no-floating-promises': 'off',
+            '@typescript-eslint/no-floating-promises': 'off', // TODO: should be error, just void before Promise
             '@typescript-eslint/no-for-in-array': 'error',
             '@typescript-eslint/no-implied-eval': 'error',
             '@typescript-eslint/no-import-type-side-effects': 'off', // verbatimModuleSyntax should be false
             '@typescript-eslint/no-inferrable-types': 'error',
             '@typescript-eslint/no-invalid-void-type': 'off',
+            '@typescript-eslint/no-loop-func': 'off', // TODO: should be error?
             '@typescript-eslint/no-magic-numbers': 'off',
-            '@typescript-eslint/no-misused-promises': 'off',
+            '@typescript-eslint/no-misused-promises': 'off', // TODO: ['error', {checksVoidReturn: {attributes: false}}],
             '@typescript-eslint/no-misused-spread': 'off',
             '@typescript-eslint/no-namespace': ['error', { allowDeclarations: true }],
             '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error',
@@ -491,22 +492,22 @@ var recommended = defineConfig([
                     },
                 },
             ],
-            '@typescript-eslint/no-shadow': 'off',
+            '@typescript-eslint/no-shadow': 'off', // TODO: should be error?
             '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
             '@typescript-eslint/no-unnecessary-condition': 'error',
             '@typescript-eslint/no-unnecessary-qualifier': 'error',
-            '@typescript-eslint/no-unnecessary-template-expression': 'off',
+            '@typescript-eslint/no-unnecessary-template-expression': 'error',
             '@typescript-eslint/no-unnecessary-type-arguments': 'error',
             '@typescript-eslint/no-unnecessary-type-assertion': 'error',
             '@typescript-eslint/no-unnecessary-type-constraint': 'error',
-            '@typescript-eslint/no-unnecessary-type-parameters': 'off',
-            '@typescript-eslint/no-unsafe-argument': 'off',
-            '@typescript-eslint/no-unsafe-assignment': 'off',
-            '@typescript-eslint/no-unsafe-call': 'off',
+            '@typescript-eslint/no-unnecessary-type-parameters': 'off', // TODO: should be error?
+            '@typescript-eslint/no-unsafe-argument': 'off', // TODO: should be error?
+            '@typescript-eslint/no-unsafe-assignment': 'off', // TODO: should be error?
+            '@typescript-eslint/no-unsafe-call': 'off', // TODO: should be error?
             '@typescript-eslint/no-unsafe-declaration-merging': 'error',
-            '@typescript-eslint/no-unsafe-member-access': 'off',
-            '@typescript-eslint/no-unsafe-return': 'off',
-            '@typescript-eslint/no-unsafe-type-assertion': 'off',
+            '@typescript-eslint/no-unsafe-member-access': 'off', // TODO: should be error?
+            '@typescript-eslint/no-unsafe-return': 'off', // TODO: should be error?
+            '@typescript-eslint/no-unsafe-type-assertion': 'off', // TODO: should be error?
             '@typescript-eslint/no-unused-expressions': [
                 'error',
                 {
@@ -540,7 +541,7 @@ var recommended = defineConfig([
             '@typescript-eslint/prefer-find': 'error',
             '@typescript-eslint/prefer-for-of': 'error',
             '@typescript-eslint/prefer-includes': 'error',
-            '@typescript-eslint/prefer-nullish-coalescing': 'off',
+            '@typescript-eslint/prefer-nullish-coalescing': 'off', // TODO: ['error', {ignorePrimitives: {boolean: true, number: true, string: true}}]
             '@typescript-eslint/prefer-optional-chain': 'error',
             '@typescript-eslint/prefer-readonly': ['error'],
             '@typescript-eslint/prefer-readonly-parameter-types': 'off',
@@ -559,9 +560,9 @@ var recommended = defineConfig([
             '@typescript-eslint/require-array-sort-compare': 'error',
             '@typescript-eslint/require-await': 'error',
             '@typescript-eslint/restrict-plus-operands': 'error',
-            '@typescript-eslint/restrict-template-expressions': 'off',
+            '@typescript-eslint/restrict-template-expressions': 'off', // TODO: should be error?
             '@typescript-eslint/sort-type-constituents': 'error',
-            '@typescript-eslint/strict-boolean-expressions': 'off',
+            '@typescript-eslint/strict-boolean-expressions': 'off', // TODO: should be error?
             '@typescript-eslint/switch-exhaustiveness-check': [
                 'error',
                 {
@@ -601,6 +602,7 @@ var recommended = defineConfig([
             'import/no-absolute-path': 'error',
             'import/no-cycle': 'error',
             'import/no-duplicates': ['error', { 'prefer-inline': true }],
+            'import/no-extraneous-dependencies': 'off',
             'import/no-mutable-exports': 'error',
             'import/no-named-as-default': 'error',
             'import/no-self-import': 'error',
@@ -643,7 +645,7 @@ var recommended = defineConfig([
                     skipTemplates: false,
                 },
             ],
-            'no-loop-func': 'error',
+            'no-loop-func': 'off',
             'no-nested-ternary': 'error',
             'no-prototype-builtins': 'off',
             'no-restricted-imports': [
@@ -708,6 +710,7 @@ var recommended = defineConfig([
                 },
             ],
             'no-return-assign': ['error', 'always'],
+            'no-shadow': 'off',
             'no-unneeded-ternary': 'error',
             'no-useless-escape': 'error',
             'no-useless-rename': [
@@ -765,7 +768,8 @@ var recommended = defineConfig([
             'promise/always-return': 'off',
             'promise/catch-or-return': 'off',
             'promise/no-callback-in-promise': 'off',
-            'promise/no-nesting': 'off',
+            'promise/no-nesting': 'off', // TODO: should be error?
+            'promise/no-return-in-finally': 'error',
             'promise/param-names': 'error',
             'regexp/no-unused-capturing-group': [
                 'error',
@@ -776,6 +780,8 @@ var recommended = defineConfig([
             ],
             'simple-import-sort/exports': 'error',
             'simple-import-sort/imports': 'error',
+            'sonarjs/cognitive-complexity': 'off', // TODO: should be error? ['error', 15]
+            'sonarjs/no-duplicate-string': 'off', // TODO: should be error? ['error', {threshold: 5}]
             'sonarjs/no-identical-functions': 'error',
             'sonarjs/no-inverted-boolean-check': 'error',
             'spaced-comment': ['error', 'always', { markers: ['/'] }],
@@ -784,18 +790,25 @@ var recommended = defineConfig([
             'unicorn/escape-case': 'error',
             'unicorn/filename-case': ['error', { case: 'kebabCase' }],
             'unicorn/new-for-builtins': 'error',
+            'unicorn/no-array-for-each': 'off', // TODO: should be error
             'unicorn/no-array-method-this-argument': 'error',
             'unicorn/no-array-push-push': 'error',
             'unicorn/no-await-in-promise-methods': 'error',
             'unicorn/no-empty-file': 'error',
             'unicorn/no-magic-array-flat-depth': 'error',
+            'unicorn/no-negated-condition': 'error',
             'unicorn/no-negation-in-equality-check': 'error',
             'unicorn/no-new-array': 'error',
+            'unicorn/no-object-as-default-parameter': 'off',
             'unicorn/no-single-promise-in-promise-methods': 'error',
             'unicorn/no-typeof-undefined': 'error',
             'unicorn/no-unnecessary-polyfills': 'error',
             'unicorn/no-useless-spread': 'error',
+            'unicorn/no-useless-undefined': ['error', { checkArguments: true }],
+            'unicorn/prefer-dom-node-append': 'off', // TODO: should be error?
             'unicorn/prefer-logical-operator-over-ternary': 'error',
+            'unicorn/prefer-number-properties': 'error',
+            'unicorn/prefer-prototype-methods': 'error',
             'unicorn/prefer-query-selector': 'error',
             'unicorn/prefer-set-size': 'error',
             'unicorn/prefer-string-raw': 'error',
@@ -1021,7 +1034,6 @@ var recommended = defineConfig([
         extends: [jest.configs['flat/recommended']],
         rules: {
             '@typescript-eslint/no-extraneous-class': 'off',
-            '@typescript-eslint/no-shadow': 'off',
             'compat/compat': 'off',
             'jest/expect-expect': 'off',
             'jest/max-expects': 'off',
@@ -1078,7 +1090,7 @@ var recommended = defineConfig([
                 { maxNumberOfTopLevelDescribes: 1 },
             ],
             'jest/unbound-method': 'off',
-            'jest/valid-title': 'error',
+            'jest/valid-title': 'off',
         },
     },
     {
@@ -1301,7 +1313,7 @@ function getFieldTypes(type, checker) {
         typeNames.push('string');
     }
     else {
-        const symbol = type.getSymbol() || type.aliasSymbol;
+        const symbol = type.getSymbol() ?? type.aliasSymbol;
         if (symbol) {
             typeNames.push(symbol.getName());
         }
@@ -1391,7 +1403,7 @@ const config$1 = {
         return {
             ClassDeclaration(node) {
                 const decorators = Array.from(node.decorators ?? []);
-                decorators.forEach((decorator) => {
+                for (const decorator of decorators) {
                     const { expression } = decorator;
                     const decoratorName = expression.callee?.name ?? '';
                     if (decoratorName in (order || {})) {
@@ -1423,7 +1435,7 @@ const config$1 = {
                             }
                         }
                     }
-                });
+                }
             },
         };
     },
@@ -1534,20 +1546,20 @@ var flatExports = createRule$c({
                     if (!isPureArray(arr)) {
                         continue;
                     }
-                    arr.elements.forEach((meta, index) => {
+                    for (const [index, meta] of arr.elements.entries()) {
                         if (!meta.isArrayLike) {
-                            return;
+                            continue;
                         }
                         const elementNode = arr.node.elements[index];
                         if (elementNode?.type !== AST_NODE_TYPES.Identifier) {
-                            return;
+                            continue;
                         }
                         const hasLocalArrayMeta = arrays.has(meta.name);
-                        const isExternalPure = !hasLocalArrayMeta
-                            ? isExternalPureTuple(typeChecker, meta.type)
-                            : false;
+                        const isExternalPure = hasLocalArrayMeta
+                            ? false
+                            : isExternalPureTuple(typeChecker, meta.type);
                         if (!hasLocalArrayMeta && !isExternalPure) {
-                            return;
+                            continue;
                         }
                         context.report({
                             data: { name: meta.name },
@@ -1557,7 +1569,7 @@ var flatExports = createRule$c({
                             messageId: MESSAGE_ID$5,
                             node: elementNode,
                         });
-                    });
+                    }
                 }
             },
             VariableDeclarator(node) {
@@ -1622,7 +1634,7 @@ const rule$8 = createRule$b({
             'NewExpression[callee.name="InjectionToken"]'(node) {
                 let token;
                 let name;
-                const [description] = node?.arguments || [];
+                const [description] = node?.arguments ?? [];
                 if (!description) {
                     return;
                 }
@@ -1701,8 +1713,8 @@ const rule$7 = createRule$a({
             const filePath = path
                 .relative(context.cwd, context.filename)
                 .replaceAll(/\\+/g, '/');
-            const [currentFileProjectName] = (currentProject && new RegExp(currentProject, 'g').exec(filePath)) || [];
-            const [importSourceProjectName] = source?.match(new RegExp(projectName, 'g')) || [];
+            const [currentFileProjectName] = (currentProject && new RegExp(currentProject, 'g').exec(filePath)) ?? [];
+            const [importSourceProjectName] = source?.match(new RegExp(projectName, 'g')) ?? [];
             return Boolean(currentFileProjectName &&
                 importSourceProjectName &&
                 currentFileProjectName === importSourceProjectName);
@@ -1986,7 +1998,7 @@ const config = {
                 let routerLinkAttribute = null;
                 let hasRouterLink = false;
                 let hasHref = false;
-                for (const attr of htmlNode.attributes || []) {
+                for (const attr of htmlNode.attributes ?? []) {
                     const attrName = attr.key.value;
                     if (attrName?.toLowerCase() === 'href') {
                         hasHref = true;
@@ -2003,8 +2015,8 @@ const config = {
                             ? fixer.removeRange(hrefAttribute.range)
                             : null,
                         messageId: MESSAGE_ID$2,
-                        node: (routerLinkAttribute ||
-                            hrefAttribute ||
+                        node: (routerLinkAttribute ??
+                            hrefAttribute ??
                             htmlNode),
                     });
                 }
@@ -2314,7 +2326,7 @@ const rule$4 = createRule$6({
                 if (node.parent.type === AST_NODE_TYPES.TaggedTemplateExpression) {
                     return;
                 }
-                node.expressions.forEach((expr, i) => {
+                for (const [i, expr] of node.expressions.entries()) {
                     if (expr.type === AST_NODE_TYPES.TemplateLiteral &&
                         expr.parent.type !== AST_NODE_TYPES.TaggedTemplateExpression) {
                         context.report({
@@ -2323,7 +2335,7 @@ const rule$4 = createRule$6({
                             node: expr,
                         });
                     }
-                });
+                }
             },
         };
     },
@@ -2382,7 +2394,7 @@ const rule$3 = createRule$5({
                 return false;
             }
             const [onlyProperty] = node.properties;
-            return !onlyProperty ? false : !isForbiddenProperty(onlyProperty);
+            return onlyProperty ? !isForbiddenProperty(onlyProperty) : false;
         };
         const unwrapExpression = (expression) => {
             let current = expression;
@@ -3021,7 +3033,7 @@ const rule$2 = createRule$3({
                     j++;
                 }
                 if (group.length > 1) {
-                    group.forEach((groupStmt, idx) => {
+                    for (const [idx, groupStmt] of group.entries()) {
                         context.report({
                             ...(idx === 0
                                 ? {
@@ -3038,7 +3050,7 @@ const rule$2 = createRule$3({
                             messageId: 'preferMultiArgPush',
                             node: groupStmt,
                         });
-                    });
+                    }
                 }
                 i = j;
             }
@@ -3133,7 +3145,7 @@ const rule$1 = createRule$2({
                         : importedAs.replace(/(?:Component|Directive)$/, '');
                     const fullText = sourceCode.getText();
                     const regex = new RegExp(String.raw `\b${importedAs}\b`, 'g');
-                    const usageCount = (fullText.match(regex) || []).length;
+                    const usageCount = (fullText.match(regex) ?? []).length;
                     const shouldDeleteImport = usageCount <= 2;
                     context.report({
                         data: { newName: short, oldName: importedAs },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@taiga-ui/eslint-plugin-experience-next",
-  "version": "0.452.0",
+  "version": "0.454.0",
   "description": "An ESLint plugin to enforce a consistent code styles across taiga-ui projects",
   "repository": {
     "type": "git",
@@ -31,10 +31,10 @@
     "glob": "13.0.6"
   },
   "peerDependencies": {
-    "@eslint/compat": "^2.0.3",
+    "@eslint/compat": "^2.0.4",
     "@eslint/markdown": "^8.0.1",
-    "@html-eslint/eslint-plugin": "^0.58.1",
-    "@html-eslint/parser": "^0.58.1",
+    "@html-eslint/eslint-plugin": "^0.59.0",
+    "@html-eslint/parser": "^0.59.0",
     "@smarttools/eslint-plugin-rxjs": "^1.0.22",
     "@stylistic/eslint-plugin": "^5.10.0",
     "@types/glob": "*",