@tagma/sdk 0.4.14 → 0.4.16

package/src/registry.ts

@@ -1,242 +1,255 @@
-import { createRequire } from 'node:module';
-import { pathToFileURL } from 'node:url';
-import type {
-  PluginCategory,
-  DriverPlugin,
-  TriggerPlugin,
-  CompletionPlugin,
-  MiddlewarePlugin,
-  PluginManifest,
-} from './types';
-
-type PluginType = DriverPlugin | TriggerPlugin | CompletionPlugin | MiddlewarePlugin;
-
-const VALID_CATEGORIES: ReadonlySet<PluginCategory> = new Set([
-  'drivers',
-  'triggers',
-  'completions',
-  'middlewares',
-]);
-
-const registries = {
-  drivers: new Map<string, DriverPlugin>(),
-  triggers: new Map<string, TriggerPlugin>(),
-  completions: new Map<string, CompletionPlugin>(),
-  middlewares: new Map<string, MiddlewarePlugin>(),
-};
-
-/**
- * Minimal contract enforcement so a malformed plugin fails fast at
- * registration time rather than crashing the engine mid-run.
- *
- * For drivers we materialize `capabilities` and assert each field is a
- * boolean — otherwise a plugin author can write
- *     get capabilities() { throw new Error('boom') }
- * and pass the basic typeof check, then crash preflight when the engine
- * touches `driver.capabilities.sessionResume`. (R8)
- */
-function validateContract(category: PluginCategory, handler: unknown): void {
-  if (!handler || typeof handler !== 'object') {
-    throw new Error(`Plugin handler for category "${category}" must be an object`);
-  }
-  const h = handler as Record<string, unknown>;
-  if (typeof h.name !== 'string' || h.name.length === 0) {
-    throw new Error(`Plugin handler for category "${category}" must declare a non-empty "name"`);
-  }
-  switch (category) {
-    case 'drivers': {
-      if (typeof h.buildCommand !== 'function') {
-        throw new Error(`drivers plugin "${h.name}" must export buildCommand()`);
-      }
-      // Materialize capabilities — this triggers any throwing getter NOW
-      // instead of during preflight.
-      let caps: unknown;
-      try {
-        caps = h.capabilities;
-      } catch (err) {
-        throw new Error(
-          `drivers plugin "${h.name}" capabilities accessor threw: ` +
-            (err instanceof Error ? err.message : String(err)),
-        );
-      }
-      if (!caps || typeof caps !== 'object') {
-        throw new Error(`drivers plugin "${h.name}" must declare capabilities object`);
-      }
-      const c = caps as Record<string, unknown>;
-      for (const field of ['sessionResume', 'systemPrompt', 'outputFormat'] as const) {
-        if (typeof c[field] !== 'boolean') {
-          throw new Error(
-            `drivers plugin "${h.name}".capabilities.${field} must be a boolean (got ${typeof c[field]})`,
-          );
-        }
-      }
-      // Optional methods, but if present must be functions.
-      for (const opt of ['parseResult', 'resolveModel', 'resolveTools'] as const) {
-        if (h[opt] !== undefined && typeof h[opt] !== 'function') {
-          throw new Error(`drivers plugin "${h.name}".${opt} must be a function or undefined`);
-        }
-      }
-      break;
-    }
-    case 'triggers':
-      if (typeof h.watch !== 'function') {
-        throw new Error(`triggers plugin "${h.name}" must export watch()`);
-      }
-      break;
-    case 'completions':
-      if (typeof h.check !== 'function') {
-        throw new Error(`completions plugin "${h.name}" must export check()`);
-      }
-      break;
-    case 'middlewares':
-      if (typeof h.enhance !== 'function') {
-        throw new Error(`middlewares plugin "${h.name}" must export enhance()`);
-      }
-      break;
-  }
-}
-
-export type RegisterResult = 'registered' | 'replaced' | 'unchanged';
-
-/**
- * Register a plugin under (category, type). Returns:
- *   - 'registered' on first registration
- *   - 'replaced'   when an existing entry was overwritten with a different handler
- *   - 'unchanged'  when the same handler instance was already present
- *
- * Throws if `category` is unknown, `type` is empty, or `handler` violates the
- * minimum interface contract for the category.
- */
-export function registerPlugin<T extends PluginType>(
-  category: PluginCategory,
-  type: string,
-  handler: T,
-): RegisterResult {
-  if (!VALID_CATEGORIES.has(category)) {
-    throw new Error(`Unknown plugin category "${category}"`);
-  }
-  if (typeof type !== 'string' || type.length === 0) {
-    throw new Error(`Plugin type must be a non-empty string (category="${category}")`);
-  }
-  validateContract(category, handler);
-  const registry = registries[category] as Map<string, T>;
-  const existing = registry.get(type);
-  if (existing === handler) return 'unchanged';
-  const wasReplaced = existing !== undefined;
-  registry.set(type, handler);
-  return wasReplaced ? 'replaced' : 'registered';
-}
-
-/**
- * Remove a plugin from the in-process registry. Returns true if a plugin
- * was actually removed. Note: ESM module caching is not affected, so
- * re-importing the same file after unregister will yield the cached module —
- * callers wanting a fresh load must restart the host process.
- */
-export function unregisterPlugin(category: PluginCategory, type: string): boolean {
-  if (!VALID_CATEGORIES.has(category)) return false;
-  return registries[category].delete(type);
-}
-
-export function getHandler<T extends PluginType>(category: PluginCategory, type: string): T {
-  const handler = registries[category].get(type);
-  if (!handler) {
-    throw new Error(
-      `${category} type "${type}" not registered.\n` +
-        `Install the plugin: bun add @tagma/${category.replace(/s$/, '')}-${type}`,
-    );
-  }
-  return handler as T;
-}
-
-export function hasHandler(category: PluginCategory, type: string): boolean {
-  return registries[category].has(type);
-}
-
-// Plugin name must be a scoped npm package or a tagma-prefixed package.
-// Reject absolute/relative paths and suspicious patterns to prevent
-// arbitrary code execution via crafted YAML configs.
-export const PLUGIN_NAME_RE = /^(@[a-z0-9-]+\/[a-z0-9._-]+|tagma-plugin-[a-z0-9._-]+)$/;
-
-export function isValidPluginName(name: unknown): name is string {
-  return typeof name === 'string' && PLUGIN_NAME_RE.test(name);
-}
-
-/**
- * Parse and validate the `tagmaPlugin` field of a `package.json` blob.
- *
- * Returns the strongly-typed manifest if the field is present and
- * well-formed (`category` is one of the four known categories and `type`
- * is a non-empty string). Returns `null` if the field is absent — that
- * is the host's signal that the package is a library, not a plugin.
- *
- * Throws if the field is present but malformed: that's a packaging bug
- * the plugin author should hear about loudly, not a silent skip.
- *
- * Hosts use this during auto-discovery to decide whether to load a
- * package as a plugin without having to dynamically `import()` it.
- */
-export function readPluginManifest(pkgJson: unknown): PluginManifest | null {
-  if (!pkgJson || typeof pkgJson !== 'object') return null;
-  const raw = (pkgJson as Record<string, unknown>).tagmaPlugin;
-  if (raw === undefined) return null;
-  if (!raw || typeof raw !== 'object') {
-    throw new Error('tagmaPlugin field must be an object with { category, type }');
-  }
-  const m = raw as Record<string, unknown>;
-  const category = m.category;
-  const type = m.type;
-  if (typeof category !== 'string' || !VALID_CATEGORIES.has(category as PluginCategory)) {
-    throw new Error(
-      `tagmaPlugin.category must be one of ${[...VALID_CATEGORIES].join(', ')}, got ${JSON.stringify(category)}`,
-    );
-  }
-  if (typeof type !== 'string' || type.length === 0) {
-    throw new Error(`tagmaPlugin.type must be a non-empty string, got ${JSON.stringify(type)}`);
-  }
-  return { category: category as PluginCategory, type };
-}
-
-/**
- * Load and register a list of plugin packages.
- *
- * @param pluginNames - Validated npm package names to load.
- * @param resolveFrom - Optional absolute path to resolve plugins from (e.g. the
- *   workspace's working directory). When omitted, the default ESM resolution
- *   uses the SDK's own `node_modules`, which will fail for plugins installed
- *   only in the user's workspace. CLI callers should pass `process.cwd()` or
- *   the workspace root so that workspace-local plugins resolve correctly.
- */
-export async function loadPlugins(
-  pluginNames: readonly string[],
-  resolveFrom?: string,
-): Promise<void> {
-  for (const name of pluginNames) {
-    if (!isValidPluginName(name)) {
-      throw new Error(
-        `Plugin "${name}" rejected: plugin names must be scoped npm packages ` +
-          `(e.g. @tagma/trigger-xyz) or tagma-plugin-* packages. ` +
-          `Relative/absolute paths are not allowed.`,
-      );
-    }
-    let moduleUrl: string = name;
-    if (resolveFrom) {
-      // Resolve the package entry point relative to the caller's directory so
-      // plugins installed in the workspace's node_modules are found even when
-      // the SDK itself lives elsewhere (e.g. a global install or a monorepo
-      // sibling package).
-      const req = createRequire(resolveFrom.endsWith('/') ? resolveFrom : resolveFrom + '/');
-      const resolved = req.resolve(name);
-      moduleUrl = pathToFileURL(resolved).href;
-    }
-    const mod = await import(moduleUrl);
-    if (!mod.pluginCategory || !mod.pluginType || !mod.default) {
-      throw new Error(`Plugin "${name}" must export pluginCategory, pluginType, and default`);
-    }
-    registerPlugin(mod.pluginCategory, mod.pluginType, mod.default);
-  }
-}
-
-export function listRegistered(category: PluginCategory): string[] {
-  return [...registries[category].keys()];
-}
+import { createRequire } from 'node:module';
+import { pathToFileURL } from 'node:url';
+import type {
+  PluginCategory,
+  DriverPlugin,
+  TriggerPlugin,
+  CompletionPlugin,
+  MiddlewarePlugin,
+  PluginManifest,
+} from './types';
+
+type PluginType = DriverPlugin | TriggerPlugin | CompletionPlugin | MiddlewarePlugin;
+
+const VALID_CATEGORIES: ReadonlySet<PluginCategory> = new Set([
+  'drivers',
+  'triggers',
+  'completions',
+  'middlewares',
+]);
+
+const registries = {
+  drivers: new Map<string, DriverPlugin>(),
+  triggers: new Map<string, TriggerPlugin>(),
+  completions: new Map<string, CompletionPlugin>(),
+  middlewares: new Map<string, MiddlewarePlugin>(),
+};
+
+/**
+ * Minimal contract enforcement so a malformed plugin fails fast at
+ * registration time rather than crashing the engine mid-run.
+ *
+ * For drivers we materialize `capabilities` and assert each field is a
+ * boolean — otherwise a plugin author can write
+ *     get capabilities() { throw new Error('boom') }
+ * and pass the basic typeof check, then crash preflight when the engine
+ * touches `driver.capabilities.sessionResume`. (R8)
+ */
+function validateContract(category: PluginCategory, handler: unknown): void {
+  if (!handler || typeof handler !== 'object') {
+    throw new Error(`Plugin handler for category "${category}" must be an object`);
+  }
+  const h = handler as Record<string, unknown>;
+  if (typeof h.name !== 'string' || h.name.length === 0) {
+    throw new Error(`Plugin handler for category "${category}" must declare a non-empty "name"`);
+  }
+  switch (category) {
+    case 'drivers': {
+      if (typeof h.buildCommand !== 'function') {
+        throw new Error(`drivers plugin "${h.name}" must export buildCommand()`);
+      }
+      // Materialize capabilities — this triggers any throwing getter NOW
+      // instead of during preflight.
+      let caps: unknown;
+      try {
+        caps = h.capabilities;
+      } catch (err) {
+        throw new Error(
+          `drivers plugin "${h.name}" capabilities accessor threw: ` +
+            (err instanceof Error ? err.message : String(err)),
+        );
+      }
+      if (!caps || typeof caps !== 'object') {
+        throw new Error(`drivers plugin "${h.name}" must declare capabilities object`);
+      }
+      const c = caps as Record<string, unknown>;
+      for (const field of ['sessionResume', 'systemPrompt', 'outputFormat'] as const) {
+        if (typeof c[field] !== 'boolean') {
+          throw new Error(
+            `drivers plugin "${h.name}".capabilities.${field} must be a boolean (got ${typeof c[field]})`,
+          );
+        }
+      }
+      // Optional methods, but if present must be functions.
+      for (const opt of ['parseResult', 'resolveModel', 'resolveTools'] as const) {
+        if (h[opt] !== undefined && typeof h[opt] !== 'function') {
+          throw new Error(`drivers plugin "${h.name}".${opt} must be a function or undefined`);
+        }
+      }
+      break;
+    }
+    case 'triggers':
+      if (typeof h.watch !== 'function') {
+        throw new Error(`triggers plugin "${h.name}" must export watch()`);
+      }
+      break;
+    case 'completions':
+      if (typeof h.check !== 'function') {
+        throw new Error(`completions plugin "${h.name}" must export check()`);
+      }
+      break;
+    case 'middlewares':
+      if (typeof h.enhance !== 'function') {
+        throw new Error(`middlewares plugin "${h.name}" must export enhance()`);
+      }
+      break;
+  }
+}
+
+export type RegisterResult = 'registered' | 'replaced' | 'unchanged';
+
+/**
+ * Register a plugin under (category, type). Returns:
+ *   - 'registered' on first registration
+ *   - 'replaced'   when an existing entry was overwritten with a different handler
+ *   - 'unchanged'  when the same handler instance was already present
+ *
+ * Throws if `category` is unknown, `type` is empty, or `handler` violates the
+ * minimum interface contract for the category.
+ */
+export function registerPlugin<T extends PluginType>(
+  category: PluginCategory,
+  type: string,
+  handler: T,
+): RegisterResult {
+  if (!VALID_CATEGORIES.has(category)) {
+    throw new Error(`Unknown plugin category "${category}"`);
+  }
+  if (typeof type !== 'string' || type.length === 0) {
+    throw new Error(`Plugin type must be a non-empty string (category="${category}")`);
+  }
+  validateContract(category, handler);
+  const registry = registries[category] as Map<string, T>;
+  const existing = registry.get(type);
+  if (existing === handler) return 'unchanged';
+  const wasReplaced = existing !== undefined;
+  registry.set(type, handler);
+  if (wasReplaced) {
+    // D18: surface silent shadowing. Hot-reload flows legitimately replace
+    // handlers; installing two different plugin packages that both claim
+    // the same (category, type) does not — the second wins and breaks the
+    // first's consumers with no audit trail. A console.warn is cheap,
+    // respects existing callers that rely on 'replaced', and gives ops a
+    // grep-able signal when registrations collide unexpectedly.
+    // eslint-disable-next-line no-console
+    console.warn(
+      `[tagma-sdk] registerPlugin: replaced existing ${category}/${type} — ` +
+        `check for duplicate plugin packages claiming the same type.`,
+    );
+  }
+  return wasReplaced ? 'replaced' : 'registered';
+}
+
+/**
+ * Remove a plugin from the in-process registry. Returns true if a plugin
+ * was actually removed. Note: ESM module caching is not affected, so
+ * re-importing the same file after unregister will yield the cached module —
+ * callers wanting a fresh load must restart the host process.
+ */
+export function unregisterPlugin(category: PluginCategory, type: string): boolean {
+  if (!VALID_CATEGORIES.has(category)) return false;
+  return registries[category].delete(type);
+}
+
+export function getHandler<T extends PluginType>(category: PluginCategory, type: string): T {
+  const handler = registries[category].get(type);
+  if (!handler) {
+    throw new Error(
+      `${category} type "${type}" not registered.\n` +
+        `Install the plugin: bun add @tagma/${category.replace(/s$/, '')}-${type}`,
+    );
+  }
+  return handler as T;
+}
+
+export function hasHandler(category: PluginCategory, type: string): boolean {
+  return registries[category].has(type);
+}
+
+// Plugin name must be a scoped npm package or a tagma-prefixed package.
+// Reject absolute/relative paths and suspicious patterns to prevent
+// arbitrary code execution via crafted YAML configs.
+export const PLUGIN_NAME_RE = /^(@[a-z0-9-]+\/[a-z0-9._-]+|tagma-plugin-[a-z0-9._-]+)$/;
+
+export function isValidPluginName(name: unknown): name is string {
+  return typeof name === 'string' && PLUGIN_NAME_RE.test(name);
+}
+
+/**
+ * Parse and validate the `tagmaPlugin` field of a `package.json` blob.
+ *
+ * Returns the strongly-typed manifest if the field is present and
+ * well-formed (`category` is one of the four known categories and `type`
+ * is a non-empty string). Returns `null` if the field is absent — that
+ * is the host's signal that the package is a library, not a plugin.
+ *
+ * Throws if the field is present but malformed: that's a packaging bug
+ * the plugin author should hear about loudly, not a silent skip.
+ *
+ * Hosts use this during auto-discovery to decide whether to load a
+ * package as a plugin without having to dynamically `import()` it.
+ */
+export function readPluginManifest(pkgJson: unknown): PluginManifest | null {
+  if (!pkgJson || typeof pkgJson !== 'object') return null;
+  const raw = (pkgJson as Record<string, unknown>).tagmaPlugin;
+  if (raw === undefined) return null;
+  if (!raw || typeof raw !== 'object') {
+    throw new Error('tagmaPlugin field must be an object with { category, type }');
+  }
+  const m = raw as Record<string, unknown>;
+  const category = m.category;
+  const type = m.type;
+  if (typeof category !== 'string' || !VALID_CATEGORIES.has(category as PluginCategory)) {
+    throw new Error(
+      `tagmaPlugin.category must be one of ${[...VALID_CATEGORIES].join(', ')}, got ${JSON.stringify(category)}`,
+    );
+  }
+  if (typeof type !== 'string' || type.length === 0) {
+    throw new Error(`tagmaPlugin.type must be a non-empty string, got ${JSON.stringify(type)}`);
+  }
+  return { category: category as PluginCategory, type };
+}
+
+/**
+ * Load and register a list of plugin packages.
+ *
+ * @param pluginNames - Validated npm package names to load.
+ * @param resolveFrom - Optional absolute path to resolve plugins from (e.g. the
+ *   workspace's working directory). When omitted, the default ESM resolution
+ *   uses the SDK's own `node_modules`, which will fail for plugins installed
+ *   only in the user's workspace. CLI callers should pass `process.cwd()` or
+ *   the workspace root so that workspace-local plugins resolve correctly.
+ */
+export async function loadPlugins(
+  pluginNames: readonly string[],
+  resolveFrom?: string,
+): Promise<void> {
+  for (const name of pluginNames) {
+    if (!isValidPluginName(name)) {
+      throw new Error(
+        `Plugin "${name}" rejected: plugin names must be scoped npm packages ` +
+          `(e.g. @tagma/trigger-xyz) or tagma-plugin-* packages. ` +
+          `Relative/absolute paths are not allowed.`,
+      );
+    }
+    let moduleUrl: string = name;
+    if (resolveFrom) {
+      // Resolve the package entry point relative to the caller's directory so
+      // plugins installed in the workspace's node_modules are found even when
+      // the SDK itself lives elsewhere (e.g. a global install or a monorepo
+      // sibling package).
+      const req = createRequire(resolveFrom.endsWith('/') ? resolveFrom : resolveFrom + '/');
+      const resolved = req.resolve(name);
+      moduleUrl = pathToFileURL(resolved).href;
+    }
+    const mod = await import(moduleUrl);
+    if (!mod.pluginCategory || !mod.pluginType || !mod.default) {
+      throw new Error(`Plugin "${name}" must export pluginCategory, pluginType, and default`);
+    }
+    registerPlugin(mod.pluginCategory, mod.pluginType, mod.default);
+  }
+}
+
+export function listRegistered(category: PluginCategory): string[] {
+  return [...registries[category].keys()];
+}