@tadnt2003/n8n-nodes-infisical 0.3.6 → 0.3.8

package/dist/utils/syncOperations.js

@@ -211,13 +211,25 @@ const CREDENTIAL_FIELD_MAPS = {
         { param: 'algorithm', secretKey: 'algorithm' },
     ],
 };
-function toSlug(name) {
-    return name.trim().replace(/[^a-zA-Z0-9_-]+/g, '-').replace(/-+/g, '-').replace(/^-|-$/g, '');
+// Lossless encoding: [A-Za-z0-9-] pass through, _ → __, everything else → _XX hex sequences.
+// Infisical folder names only allow [a-zA-Z0-9_-], so % cannot be used as an escape character.
+function toFolderName(name) {
+    return [...name].map(c => {
+        if (/[A-Za-z0-9-]/.test(c))
+            return c;
+        if (c === '_')
+            return '__';
+        return encodeURIComponent(c).replace(/%/g, '_');
+    }).join('');
+}
+function fromFolderName(slug) {
+    const restored = slug.replace(/_([0-9A-Fa-f]{2}|_)/g, (_, p1) => p1 === '_' ? '_' : '%' + p1);
+    return decodeURIComponent(restored);
 }
 function buildSecretPath(rootPath, credentialName) {
     const root = rootPath.replace(/\/+$/, '') || '/';
-    const slug = toSlug(credentialName);
-    return root === '/' ? `/${slug}` : `${root}/${slug}`;
+    const folder = toFolderName(credentialName);
+    return root === '/' ? `/${folder}` : `${root}/${folder}`;
 }
 // Fix 7.4: handles `number` type (port, connectTimeout, maxConnections, etc.)
 // Fix 7.7: reads schema's own `default` before falling back to enum heuristic
@@ -257,18 +269,19 @@ function coerceValue(raw, def) {
 //
 // When condKey IS in schema properties, fire only when the current value matches condValues.
 //
-// When condKey is NOT in schema properties (e.g. useDynamicClientRegistration on
-// googleOAuth2Api), JSON Schema evaluates the if-clause vacuously — the properties keyword
-// has nothing to check, so it passes, and both the [true] branch and the [false] branch
-// appear to fire simultaneously. That is the "vacuous truth" problem.
-//
-// n8n avoids it by internally defaulting the absent key to false before validating, so only
-// the branch whose condValues contain a falsy value actually fires (the "standard mode"
-// branch). We mirror that: condValues=[false] fires, condValues=[true] does not.
+// When condKey is NOT in schema properties (e.g. useDynamicClientRegistration or grantType on
+// googleOAuth2Api / googleSheetsOAuth2Api), JSON Schema evaluates the if-clause vacuously:
+// the `properties` keyword only constrains keys that ARE present, so an absent key always
+// satisfies the constraint. The if-clause passes → then fires (else never fires) for every
+// such branch, regardless of condValues. n8n's own schema validator follows this standard
+// JSON Schema behaviour — when useDynamicClientRegistration is absent, BOTH the [true] and
+// [false] allOf branches fire, requiring serverUrl AND clientId/clientSecret simultaneously.
+// We mirror that by always returning true for vacuous-truth branches.
 function conditionFires(condKeyInSchema, condValues, condVal) {
     if (condKeyInSchema)
         return condValues.includes(condVal);
-    return condValues.some((v) => !v);
+    // Vacuous truth: absent key → if always passes → then always fires.
+    return true;
 }
 // Validate credential data against the n8n schema's required fields and conditional requirements.
 // For form mode, pass availableFormFields to skip checks for fields the form cannot provide.
@@ -580,7 +593,8 @@ async function autoSyncFromInfisical(ctx, apiUrl, baseHeaders, i) {
                 credentialData[key] = coerceValue(raw, schemaInfo === null || schemaInfo === void 0 ? void 0 : schemaInfo.props[key]);
             }
         }
-        const existing = credByName.get(folderName);
+        const credentialName = fromFolderName(folderName);
+        const existing = credByName.get(credentialName);
         if (existing) {
             // Fix 7.2: apply the same fullData build logic as the create path so that condition-key
             // changes (e.g. ssl:false→true) get their required fields filled and their prohibited
@@ -618,7 +632,7 @@ async function autoSyncFromInfisical(ctx, apiUrl, baseHeaders, i) {
                 method: 'POST',
                 url: `${n8nApiUrl}/api/v1/credentials`,
                 headers: n8nHeaders,
-                body: { name: folderName, type: credentialType, data: fullData },
+                body: { name: credentialName, type: credentialType, data: fullData },
             });
             results.push({
                 json: Object.assign(Object.assign({}, created), { action: 'created', secretPath, secretCount: secrets.length }),
@@ -702,7 +716,7 @@ async function executeSyncOperation(ctx, apiUrl, baseHeaders, operation, i) {
             method: 'POST',
             url: `${apiUrl}/v2/folders`,
             headers: baseHeaders,
-            body: { projectId, environment, name: toSlug(credentialName), path: folderPath },
+            body: { projectId, environment, name: toFolderName(credentialName), path: folderPath },
         });
     }
     catch (err) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tadnt2003/n8n-nodes-infisical",
-  "version": "0.3.6",
+  "version": "0.3.8",
   "description": "n8n community node for Infisical - Secret management platform",
   "keywords": [
     "n8n-community-node-package",