@tadnt2003/n8n-nodes-infisical 0.3.0 → 0.3.6

package/LICENSE

@@ -1,22 +1,22 @@
-MIT License
-
-Copyright (c) 2025 Kennis AI
-Copyright (c) 2026 Nguyen Thanh Dat
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+MIT License
+
+Copyright (c) 2025 Kennis AI
+Copyright (c) 2026 Nguyen Thanh Dat
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/dist/utils/syncOperations.js

@@ -15,6 +15,7 @@ const CREDENTIAL_FIELD_MAPS = {
         { param: 'httpNode', secretKey: 'httpNode' },
     ],
     googleOAuth2Api: [
+        { param: 'serverUrl', secretKey: 'serverUrl' },
         { param: 'clientId', secretKey: 'clientId' },
         { param: 'clientSecret', secretKey: 'clientSecret' },
         { param: 'scope', secretKey: 'scope' },
@@ -210,18 +211,13 @@ const CREDENTIAL_FIELD_MAPS = {
         { param: 'algorithm', secretKey: 'algorithm' },
     ],
 };
+function toSlug(name) {
+    return name.trim().replace(/[^a-zA-Z0-9_-]+/g, '-').replace(/-+/g, '-').replace(/^-|-$/g, '');
+}
 function buildSecretPath(rootPath, credentialName) {
     const root = rootPath.replace(/\/+$/, '') || '/';
-    return root === '/' ? `/${credentialName}` : `${root}/${credentialName}`;
-}
-// Fix 7.5: removed `typeof value === 'boolean' && value === false` — false is a meaningful value
-// that must be written to Infisical (e.g. ssl:false, sshTunnel:false as condition keys).
-function isEmptyValue(value) {
-    if (value === null || value === undefined)
-        return true;
-    if (typeof value === 'string' && value.trim() === '')
-        return true;
-    return false;
+    const slug = toSlug(credentialName);
+    return root === '/' ? `/${slug}` : `${root}/${slug}`;
 }
 // Fix 7.4: handles `number` type (port, connectTimeout, maxConnections, etc.)
 // Fix 7.7: reads schema's own `default` before falling back to enum heuristic
@@ -257,6 +253,23 @@ function coerceValue(raw, def) {
         return raw === 'true' || raw === '1';
     return raw;
 }
+// Decide whether a conditional branch fires given its condition key and values.
+//
+// When condKey IS in schema properties, fire only when the current value matches condValues.
+//
+// When condKey is NOT in schema properties (e.g. useDynamicClientRegistration on
+// googleOAuth2Api), JSON Schema evaluates the if-clause vacuously — the properties keyword
+// has nothing to check, so it passes, and both the [true] branch and the [false] branch
+// appear to fire simultaneously. That is the "vacuous truth" problem.
+//
+// n8n avoids it by internally defaulting the absent key to false before validating, so only
+// the branch whose condValues contain a falsy value actually fires (the "standard mode"
+// branch). We mirror that: condValues=[false] fires, condValues=[true] does not.
+function conditionFires(condKeyInSchema, condValues, condVal) {
+    if (condKeyInSchema)
+        return condValues.includes(condVal);
+    return condValues.some((v) => !v);
+}
 // Validate credential data against the n8n schema's required fields and conditional requirements.
 // For form mode, pass availableFormFields to skip checks for fields the form cannot provide.
 function validateAgainstSchema(data, schemaInfo, availableFormFields) {
@@ -264,20 +277,20 @@ function validateAgainstSchema(data, schemaInfo, availableFormFields) {
     for (const field of schemaInfo.topRequired) {
         if (availableFormFields && !availableFormFields.has(field))
             continue;
-        if (isEmptyValue(data[field])) {
-            errors.push(`"${field}" is required but missing or empty`);
+        if (data[field] === undefined || data[field] === null) {
+            errors.push(`"${field}" is required but not provided`);
         }
     }
     for (const { condKey, condValues, thenRequired } of schemaInfo.condBranches) {
         const condVal = data[condKey];
         const condKeyInSchema = condKey in schemaInfo.props;
-        if (!condKeyInSchema || condValues.includes(condVal)) {
+        if (conditionFires(condKeyInSchema, condValues, condVal)) {
             for (const field of thenRequired) {
                 if (availableFormFields && !availableFormFields.has(field))
                     continue;
-                if (isEmptyValue(data[field])) {
+                if (data[field] === undefined || data[field] === null) {
                     const when = condKeyInSchema ? ` when "${condKey}" is "${String(condVal)}"` : '';
-                    errors.push(`"${field}" is required${when} but missing or empty`);
+                    errors.push(`"${field}" is required${when} but not provided`);
                 }
             }
         }
@@ -430,10 +443,8 @@ function applyCondBranches(fullData, schemaInfo) {
     var _a, _b;
     for (const { condKey, condValues, thenRequired, elseProhibited } of schemaInfo.condBranches) {
         const condVal = fullData[condKey];
-        // When condKey is absent from schema properties it can't appear in the data,
-        // so JSON Schema's `properties` validator skips it → condition fires vacuously.
         const condKeyInSchema = condKey in schemaInfo.props;
-        if (!condKeyInSchema || condValues.includes(condVal)) {
+        if (conditionFires(condKeyInSchema, condValues, condVal)) {
             // Condition fires → fill any missing then-required fields with safe defaults.
             for (const field of thenRequired) {
                 if (field in fullData)
@@ -691,7 +702,7 @@ async function executeSyncOperation(ctx, apiUrl, baseHeaders, operation, i) {
             method: 'POST',
             url: `${apiUrl}/v2/folders`,
             headers: baseHeaders,
-            body: { projectId, environment, name: credentialName, path: folderPath },
+            body: { projectId, environment, name: toSlug(credentialName), path: folderPath },
         });
     }
     catch (err) {
@@ -701,12 +712,14 @@ async function executeSyncOperation(ctx, apiUrl, baseHeaders, operation, i) {
             throw err;
         }
     }
-    // Collect non-empty credential fields as Infisical secrets
+    // Collect credential fields as Infisical secrets; empty strings are written as "" so that
+    // required-but-blank fields (e.g. serverUrl on googleOAuth2Api) don't fail schema validation
+    // on the way back. Only null/undefined is skipped.
     const secretMetadata = [{ key: 'n8n_credential_type', value: credentialType }];
     const secrets = [];
     if (inputMode === 'json') {
         for (const [key, value] of Object.entries(parsedJson !== null && parsedJson !== void 0 ? parsedJson : {})) {
-            if (isEmptyValue(value))
+            if (value === null || value === undefined)
                 continue;
             if (fetchedSchemaProps && !(key in fetchedSchemaProps))
                 continue;
@@ -721,7 +734,7 @@ async function executeSyncOperation(ctx, apiUrl, baseHeaders, operation, i) {
         }
         for (const { param, secretKey } of fieldMap) {
             const value = ctx.getNodeParameter(param, i, '');
-            if (isEmptyValue(value))
+            if (value === null || value === undefined)
                 continue;
             secrets.push({ secretKey, secretValue: String(value), secretMetadata });
         }

package/package.json

@@ -1,57 +1,57 @@
-{
-  "name": "@tadnt2003/n8n-nodes-infisical",
-  "version": "0.3.0",
-  "description": "n8n community node for Infisical - Secret management platform",
-  "keywords": [
-    "n8n-community-node-package",
-    "n8n",
-    "infisical",
-    "secrets",
-    "secrets-management"
-  ],
-  "license": "MIT",
-  "homepage": "https://github.com/TadNT2003/n8n-nodes-infisical",
-  "author": {
-    "name": "Nguyen Thanh Dat",
-    "email": "ntdatwows2003@gmail.com",
-    "url": "https://github.com/TadNT2003"
-  },
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/TadNT2003/n8n-nodes-infisical.git"
-  },
-  "scripts": {
-    "build": "tsc && gulp build",
-    "dev": "tsc --watch",
-    "format": "prettier nodes credentials --write",
-    "lint": "eslint nodes credentials package.json",
-    "lintfix": "eslint nodes credentials package.json --fix",
-    "prepublishOnly": "npm run build && npm run lint"
-  },
-  "files": [
-    "dist"
-  ],
-  "n8n": {
-    "n8nNodesApiVersion": 1,
-    "credentials": [
-      "dist/credentials/InfisicalApi.credentials.js"
-    ],
-    "nodes": [
-      "dist/nodes/Infisical/Infisical.node.js",
-      "dist/nodes/InfisicalSync/InfisicalSync.node.js"
-    ]
-  },
-  "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "^5.62.0",
-    "@typescript-eslint/parser": "^5.45.0",
-    "eslint": "^8.29.0",
-    "eslint-plugin-n8n-nodes-base": "^1.11.0",
-    "gulp": "^4.0.2",
-    "n8n-workflow": "^1.120.0",
-    "prettier": "^2.7.1",
-    "typescript": "~5.3.0"
-  },
-  "peerDependencies": {
-    "n8n-workflow": "*"
-  }
-}
+{
+  "name": "@tadnt2003/n8n-nodes-infisical",
+  "version": "0.3.6",
+  "description": "n8n community node for Infisical - Secret management platform",
+  "keywords": [
+    "n8n-community-node-package",
+    "n8n",
+    "infisical",
+    "secrets",
+    "secrets-management"
+  ],
+  "license": "MIT",
+  "homepage": "https://github.com/TadNT2003/n8n-nodes-infisical",
+  "author": {
+    "name": "Nguyen Thanh Dat",
+    "email": "ntdatwows2003@gmail.com",
+    "url": "https://github.com/TadNT2003"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/TadNT2003/n8n-nodes-infisical.git"
+  },
+  "scripts": {
+    "build": "tsc && gulp build",
+    "dev": "tsc --watch",
+    "format": "prettier nodes credentials --write",
+    "lint": "eslint nodes credentials package.json",
+    "lintfix": "eslint nodes credentials package.json --fix",
+    "prepublishOnly": "npm run build && npm run lint"
+  },
+  "files": [
+    "dist"
+  ],
+  "n8n": {
+    "n8nNodesApiVersion": 1,
+    "credentials": [
+      "dist/credentials/InfisicalApi.credentials.js"
+    ],
+    "nodes": [
+      "dist/nodes/Infisical/Infisical.node.js",
+      "dist/nodes/InfisicalSync/InfisicalSync.node.js"
+    ]
+  },
+  "devDependencies": {
+    "@typescript-eslint/eslint-plugin": "^5.62.0",
+    "@typescript-eslint/parser": "^5.45.0",
+    "eslint": "^8.29.0",
+    "eslint-plugin-n8n-nodes-base": "^1.11.0",
+    "gulp": "^4.0.2",
+    "n8n-workflow": "^1.120.0",
+    "prettier": "^2.7.1",
+    "typescript": "~5.3.0"
+  },
+  "peerDependencies": {
+    "n8n-workflow": "*"
+  }
+}

package/dist/nodes/Infisical/infisical-legacy.svg

@@ -1,5 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="none">
-  <rect width="24" height="24" rx="4" fill="#000000"/>
-  <path d="M12 6L6 9v6c0 3.5 2.5 6.5 6 7.5 3.5-1 6-4 6-7.5V9l-6-3z" fill="#FFFFFF"/>
-  <path d="M12 11v5M10 13l2 2 2-2" stroke="#000000" stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round"/>
-</svg>

package/dist/nodes/Infisical/infisical.svg

@@ -1,5 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="none">
-  <rect width="24" height="24" rx="4" fill="#000000"/>
-  <path d="M12 6L6 9v6c0 3.5 2.5 6.5 6 7.5 3.5-1 6-4 6-7.5V9l-6-3z" fill="#FFFFFF"/>
-  <path d="M12 11v5M10 13l2 2 2-2" stroke="#000000" stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round"/>
-</svg>