@tablation/crew 0.78.1 → 0.79.1

package/dist/cli.js

@@ -7131,6 +7131,28 @@ async function finishRunWorktree(dir, cfg, branch) {
 // src/handoff-guard.ts
 var HANDOFF_BOUNCED_MARKER = calloutHeader("WARNING", "Hand-off Bounced");
 var pushedEventBody = (sha, remote, branch) => `pushed ${sha} to ${remote}/${branch}`;
+function acceptanceLines(description) {
+  if (typeof description !== "string") return [];
+  const out = [];
+  let inside = false;
+  for (const raw of description.split("\n")) {
+    const heading = /^#{1,6}\s+(.*?)\s*$/.exec(raw);
+    if (heading) {
+      inside = /^acceptance\b/i.test(heading[1]);
+      continue;
+    }
+    if (!inside) continue;
+    const bullet = /^\s*(?:[-*+]|\d+[.)])\s+(?:\[[ xX]\]\s+)?(.+?)\s*$/.exec(raw);
+    if (bullet) out.push(bullet[1]);
+  }
+  return out;
+}
+var flat = (s) => s.replace(/[`*_>]/g, "").replace(/\s+/g, " ").trim().toLowerCase();
+function unquotedAcceptance(lines, comment) {
+  const body = flat(comment);
+  return lines.filter((l) => !body.includes(flat(l)));
+}
+var ACCEPTANCE_BOUNCED_MARKER = calloutHeader("WARNING", "Acceptance Checklist Missing");
 function remoteTip(dir, remote, branch) {
   const out = gitOk(dir, ["ls-remote", "--heads", remote, `refs/heads/${branch}`]);
   if (out === null) return null;
@@ -7206,6 +7228,27 @@ async function takenOverSince(i, ticketRow) {
     return !!by && by !== i.shipName;
   });
 }
+async function missingAcceptance(i, t) {
+  const lines = acceptanceLines(t.description);
+  if (lines.length === 0 || !i.writer.comments) return null;
+  const cc = i.contract.comments;
+  const mine = (await i.writer.comments()).map((c) => c).filter((r) => r[cc.parent] === t.id && r[cc.author] === i.seatId).sort((a, b) => String(a[cc.createdAt] ?? "").localeCompare(String(b[cc.createdAt] ?? "")));
+  const last = mine.at(-1);
+  const missing = unquotedAcceptance(lines, last ? String(last[cc.body] ?? "") : "");
+  return missing.length > 0 ? missing : null;
+}
+function acceptanceBounceComment(missing, shipName2) {
+  return `${ACCEPTANCE_BOUNCED_MARKER}
+
+**Hand-off bounced: the hand-off comment does not quote every line of the ticket's Acceptance section.**
+
+${shipName2 ? `Ship: ${shipName2}
+
+` : ""}Not quoted verbatim:
+${missing.map((l) => `- ${l}`).join("\n")}
+
+Set back to \`in_progress\`. Post a comment that lists every Acceptance line verbatim, each followed by the test, command or manual check that exercised it in this run and its result (a line you could not exercise is listed with the reason, never omitted), then set \`fixed\` again. The branch is already pushed.`;
+}
 async function enforceHandoff(i) {
   try {
     const t = await i.writer.ticket(i.ticketId);
@@ -7221,6 +7264,26 @@ async function enforceHandoff(i) {
       i.log.warn(`${t.issue_id} is at ${t.status} but the push was not checked: ${v.why}`, log);
       return { kind: "unverified", why: v.why };
     }
+    if (v.kind === "pushed" && !claimed) {
+      const missing = await missingAcceptance(i, t);
+      if (missing) {
+        const heldNow = i.hold ? t[i.hold.column] : void 0;
+        if (i.hold && heldNow && heldNow !== i.hold.shipId || await takenOverSince(i, t.id)) {
+          i.log.warn(`${t.issue_id} is held by another ship now \u2014 the acceptance check is stale, left alone`, log);
+          return { kind: "unverified", why: "ticket is held by another ship" };
+        }
+        await i.writer.updateTicket(t.id, {
+          status: i.contract.statuses.building,
+          ...t.assignee_id ? {} : { assignee_id: i.seatId },
+          ...i.hold && !heldNow ? { [i.hold.column]: i.hold.shipId } : {}
+        });
+        await i.writer.postEvent(t.id, acceptanceBounceComment(missing, i.shipName), i.seatId, "bounced").catch(() => {
+          i.log.warn("bounced, but the note failed to post", log);
+        });
+        i.log.warn(`${t.issue_id} bounced back to ${i.contract.statuses.building}: hand-off comment lacks the acceptance checklist`, log);
+        return { kind: "bounced" };
+      }
+    }
     if (v.kind === "pushed") {
       await i.writer.postEvent(t.id, pushedEventBody(v.sha, v.remote, v.branch), i.seatId, "pushed");
       i.log.emit(`${t.issue_id} pushed at ${v.sha.slice(0, 7)} \u2014 handed on to QA`, log);
@@ -11325,14 +11388,14 @@ function dedupeChangelogEntries(entries, ticket) {
   return out;
 }
 var BUMP_LINE = /^Bump:[ \t]*(major|minor|patch)\b/gim;
-function planMerge(cwd, tickets, contract, lastReleased, branchFor = (t) => branchForIssue(cwd, t.issue_id), base = "main", blockerInfo) {
+function planMerge(cwd, tickets, contract, lastReleased, branchFor = (t) => branchForIssue(cwd, t.issue_id), base = "main", blockerInfo, ref = "HEAD") {
   const held = new Set(heldByBlockers(tickets, contract.statuses.verified, blockerInfo).map((h) => h.ticket.id));
   const verified = tickets.filter((t) => t.status === contract.statuses.verified && !held.has(t.id)).sort((a, b) => Number.parseInt(a.issue_id.replace(/^\D+/, ""), 10) - Number.parseInt(b.issue_id.replace(/^\D+/, ""), 10));
   return verified.map((ticket) => {
     const branch = branchFor(ticket);
     if (!branch) {
       const keys = referenceKeys(ticket);
-      const unreleased = lastReleased ? findKeyInRange(cwd, keys, `${lastReleased}..HEAD`) : null;
+      const unreleased = lastReleased ? findKeyInRange(cwd, keys, `${lastReleased}..${ref}`) : null;
       if (unreleased) {
         return {
           ticket,
@@ -11344,7 +11407,7 @@ function planMerge(cwd, tickets, contract, lastReleased, branchFor = (t) => bran
           skipReason: "already-merged"
         };
       }
-      const anywhere = findKeyInRange(cwd, keys, "HEAD");
+      const anywhere = findKeyInRange(cwd, keys, ref);
       if (anywhere) {
         return {
           ticket,
@@ -11441,21 +11504,22 @@ ${section}`;
   return [...lines.slice(0, anchor), section, ...lines.slice(anchor)].join("\n");
 }
 var RELEASE_COMMIT_SUBJECT = /^Release \S+$/;
-function subjectsSince(cwd, sha) {
-  if (!isAncestor(cwd, sha, "HEAD")) return null;
-  return (gitOk(cwd, ["log", "--format=%h %s", `${sha}..HEAD`]) ?? "").split("\n").filter(Boolean);
+function subjectsSince(cwd, sha, ref = "HEAD") {
+  if (!isAncestor(cwd, sha, ref)) return null;
+  return (gitOk(cwd, ["log", "--format=%h %s", `${sha}..${ref}`]) ?? "").split("\n").filter(Boolean);
 }
 var isReleaseCommitLine = (line) => RELEASE_COMMIT_SUBJECT.test(line.replace(/^\S+ /, ""));
 function decideRelease(cwd, tickets, contract, opts = {}) {
   const pattern = opts.tagPattern ?? "v*";
   const base = opts.base ?? "main";
-  const block = checkGuards(cwd, base);
-  const lastTag = latestReleaseTag(cwd, pattern, "HEAD");
+  const ref = opts.ref ?? "HEAD";
+  const block = opts.guard === false ? null : checkGuards(cwd, base);
+  const lastTag = latestReleaseTag(cwd, pattern, ref);
   const lastReleased = lastTag ? tagCommit(cwd, lastTag) : null;
-  const head = resolve2(cwd, "HEAD") ?? "";
-  const merges = block ? [] : planMerge(cwd, tickets, contract, lastReleased, opts.branchFor ?? ((t) => branchForIssue(cwd, t.issue_id)), base, opts.blockerInfo);
-  const unreleasedCommits = lastReleased ? countCommits(cwd, `${lastReleased}..HEAD`) : 0;
-  const unreleasedWork = lastReleased ? (gitOk(cwd, ["log", "--format=%s", `${lastReleased}..HEAD`]) ?? "").split("\n").filter((l) => l && !RELEASE_COMMIT_SUBJECT.test(l)).length : 0;
+  const head = resolve2(cwd, ref) ?? "";
+  const merges = block ? [] : planMerge(cwd, tickets, contract, lastReleased, opts.branchFor ?? ((t) => branchForIssue(cwd, t.issue_id)), opts.ref ?? base, opts.blockerInfo, ref);
+  const unreleasedCommits = lastReleased ? countCommits(cwd, `${lastReleased}..${ref}`) : 0;
+  const unreleasedWork = lastReleased ? (gitOk(cwd, ["log", "--format=%s", `${lastReleased}..${ref}`]) ?? "").split("\n").filter((l) => l && !RELEASE_COMMIT_SUBJECT.test(l)).length : 0;
   return {
     block,
     merges,
@@ -12170,10 +12234,14 @@ async function runReleaseCycle(o, movedPast2, localRefSkips) {
     }
     if (drop.size) releasable = releasable.filter((t) => !drop.has(t.id));
   }
+  const { remote, base } = o.repo.branch;
+  const inPlace = o.dryRun || !!o.mergeOnly || !remoteBranchExists(o.cwd, remote, base);
+  const remoteRef = `${remote}/${base}`;
   const decision = decideRelease(o.cwd, releasable, o.contract, {
     tagPattern,
-    base: o.repo.branch.base,
+    base,
     blockerInfo: o.blockerInfo,
+    ...inPlace ? {} : { ref: remoteRef, guard: false },
     // CREW-1364: a branch another ship built and pushed at `fixed` exists
     // here only on the remote. Materialize it so the squash below has a ref.
     // A dry run only looks.
@@ -12202,7 +12270,7 @@ async function runReleaseCycle(o, movedPast2, localRefSkips) {
   o.state?.clearBlocked();
   const failedAt = o.state?.deployFailedSha();
   if (!o.force && failedAt) {
-    const since2 = failedAt === decision.head ? [] : subjectsSince(o.cwd, failedAt);
+    const since2 = failedAt === decision.head ? [] : subjectsSince(o.cwd, failedAt, inPlace ? "HEAD" : remoteRef);
     const real = since2?.filter((l) => !isReleaseCommitLine(l)) ?? null;
     if (real && real.length === 0) {
       o.emit.warn(
@@ -12229,10 +12297,13 @@ async function runReleaseCycle(o, movedPast2, localRefSkips) {
     const review = await reviewHandoff(o, externalClosures, decision.merges, reviewing);
     return { merged: [], deployed: false, stopped: "external", decision, externalClosures, review };
   }
-  const { remote, base } = o.repo.branch;
-  if (o.dryRun || o.mergeOnly || !remoteBranchExists(o.cwd, remote, base)) {
+  if (inPlace) {
     return mergeAndRelease(o, decision, fresh);
   }
+  const primary = checkGuards(o.cwd, base);
+  if (primary) {
+    o.emit.emit(scoped(`primary checkout not fast-forwarded: ${primary.detail}; its dist/ is stale until rebuilt`), { step: "release" });
+  }
   let checkout;
   const stranded = recoverStrandedReleaseCheckouts(o.cwd);
   if (stranded.length > 0) o.emit.warn(scoped(`dropped release checkout(s) stranded by a crash: ${stranded.join(", ")}`));
@@ -17889,9 +17960,11 @@ ${changed2.map((c) => `  - ${c}
           preModes
         );
         reportUnplaceable(c.route, preUnplaceable, tracker.contract.statuses.verified, remit);
+        const remoteBase = remoteBranchExists(target.dir, repo.branch.remote, repo.branch.base);
         const d = decideRelease(target.dir, pre, tracker.contract, {
           tagPattern: repo.release.tagPattern ?? "v*",
-          base: repo.branch.base
+          base: repo.branch.base,
+          ...remoteBase ? { ref: `${repo.branch.remote}/${repo.branch.base}`, guard: false } : {}
         });
         const unstamped = planReleasedBranches(
           target.dir,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tablation/crew",
-  "version": "0.78.1",
+  "version": "0.79.1",
   "description": "A standing team of headless agents that picks work off a Tablation board, does it on a machine you control, and reports back.",
   "type": "module",
   "license": "MIT",

package/prompts/default/personas/lane-qa.md

@@ -94,6 +94,11 @@ pass.
    Judge by exit code and summary line, and quote the summary in your
    comment.
 7. **Check the hand-off itself.**
+   - **Acceptance checklist.** Start from the builder's checklist: their
+     comment quotes each Acceptance line with the check that exercised it.
+     Re-run the checks that matter, and when a line fails, a bounce cites that
+     line by its quoted text. A line the builder marked unexercised is yours
+     to exercise.
    - **Documentation.** If the repository's agent instructions (CLAUDE.md,
      AGENTS.md, GEMINI.md or equivalent) name a user-facing documentation
      location, a change to a user-facing surface must come with a matching

package/prompts/default/skills/crew-lane-agent.md

@@ -416,6 +416,14 @@ before going further, and never change a ticket's `report_type` yourself.
    used, and anything you could not test yourself. Anything not committed and
    pushed is gone.
 
+   **When the ticket has an Acceptance section, your last progress comment
+   quotes it.** List every line of that section verbatim, each followed by the
+   test, command or manual check that exercised it in this run and its result.
+   A line you could not exercise is listed with the reason, never omitted. The
+   runner checks your newest comment for every line and, if one is missing,
+   sets the ticket back to `in_progress` instead of passing it to QA. A ticket
+   with no Acceptance section is unaffected.
+
 ## Step 4 — you never merge, and you never deploy
 
 **Nothing you do touches the base branch.** The release phase takes every

package/prompts/dev-qa/personas/lane-qa.md

@@ -93,6 +93,11 @@ pass.
    Judge by exit code and summary line, and quote the summary in your
    comment.
 7. **Check the hand-off itself.**
+   - **Acceptance checklist.** Start from the builder's checklist: their
+     comment quotes each Acceptance line with the check that exercised it.
+     Re-run the checks that matter, and when a line fails, a bounce cites that
+     line by its quoted text. A line the builder marked unexercised is yours
+     to exercise.
    - **Documentation.** If the repository's agent instructions (CLAUDE.md,
      AGENTS.md, GEMINI.md or equivalent) name a user-facing documentation
      location, a change to a user-facing surface must come with a matching

package/prompts/dev-qa/skills/crew-lane-agent.md

@@ -411,6 +411,14 @@ before going further, and never change a ticket's `report_type` yourself.
    used, and anything you could not test yourself. Anything not committed and
    pushed is gone.
 
+   **When the ticket has an Acceptance section, your last progress comment
+   quotes it.** List every line of that section verbatim, each followed by the
+   test, command or manual check that exercised it in this run and its result.
+   A line you could not exercise is listed with the reason, never omitted. The
+   runner checks your newest comment for every line and, if one is missing,
+   sets the ticket back to `in_progress` instead of passing it to QA. A ticket
+   with no Acceptance section is unaffected.
+
 ## Step 4 — you never merge, and you never deploy
 
 **Nothing you do touches the base branch.** The release phase takes every