@tablation/crew 0.75.1 → 0.75.3

package/dist/cli.js

@@ -2571,8 +2571,8 @@ function parseOneRoute(c, where, file, base, stateDir, raw, missing, crewHome, t
   }
   const hasRepos = Object.keys(repoDirs).length > 0;
   const reposBasePath = expand(String(c?.reposBasePath ?? raw.ship?.reposBasePath ?? DEFAULT_REPOS_BASE_PATH), base);
-  const dirIsCloneBase = !c?.dir && !hasRepos && c?.repos && typeof c.repos === "object" && !Array.isArray(c.repos);
-  const dir = c?.dir ? expand(String(c.dir), base) : hasRepos ? Object.values(repoDirs)[0] : dirIsCloneBase ? join9(reposBasePath, splitRoute(route)[0]) : missing.req(void 0, `${where}.dir (or ${where}.repos)`) ?? "";
+  const dirIsCloneBase = !c?.dir && !hasRepos && !Array.isArray(c?.repos);
+  const dir = c?.dir ? expand(String(c.dir), base) : hasRepos ? Object.values(repoDirs)[0] : dirIsCloneBase ? join9(reposBasePath, splitRoute(route)[0]) : "";
   const weight = c?.weight === void 0 ? void 0 : Number(c.weight);
   if (weight !== void 0 && !(Number.isFinite(weight) && weight > 0)) {
     missing.add(`${where}.weight must be a positive number (got "${c?.weight}")`);
@@ -5168,6 +5168,7 @@ var DEFAULT_CONTRACT = {
     resolutionNote: "resolution_note",
     verifiedSha: "verified_sha",
     prRef: "pr_ref",
+    externalId: "external_id",
     position: "position"
   },
   comments: {
@@ -5652,6 +5653,29 @@ var State = class _State {
       }
     };
   }
+  /**
+   * The previous cycle's unroutable ticket ids for one route (CREW-2548): open
+   * tickets with no repository that are not exempt. `poll.ts` diffs against it
+   * so each ticket warns once when it becomes unroutable, not every cycle; the
+   * caller persists the new set beside `attention(route).persist(...)`. A
+   * missing or corrupt file reads as empty, so a fresh install warns once.
+   */
+  unroutable(route) {
+    const file = `.unroutable-${_State.safe(route)}.json`;
+    return {
+      previous: () => {
+        try {
+          const parsed = JSON.parse(readFileSync12(this.path(file), "utf8"));
+          return Array.isArray(parsed) ? parsed.filter((x) => typeof x === "string") : [];
+        } catch {
+          return [];
+        }
+      },
+      persist: (next) => {
+        writeFileSync8(this.path(file), JSON.stringify(next));
+      }
+    };
+  }
   /**
    * Open ship-level attention items (CREW-1373), ship-wide rather than
    * per-route: a parked role or a missing hook command is about this
@@ -9349,6 +9373,14 @@ function filingErrors(tickets, opts = {}) {
     return !exempt.has(t[reportTypeColumn]);
   });
 }
+function unroutableChanges(unroutable, previous, tickets, externalIdColumn) {
+  const prev = new Set(previous);
+  const now = new Set(unroutable.map((t) => t.id));
+  return {
+    added: unroutable.filter((t) => !prev.has(t.id)).map((t) => ({ ticket: t, synced: !!t[externalIdColumn] })),
+    gained: tickets.filter((t) => prev.has(t.id) && !now.has(t.id) && !!t.repo_id)
+  };
+}
 function sweepComment(step) {
   return step.action === "park" ? `Parked as **Blocked** by the crew \u2014 waiting on: ${step.blockers}.
 
@@ -10131,15 +10163,30 @@ async function decideCycle(o) {
       emit.emit(`every child is done \u2014 this coordinating ticket is too`, { ticket: r.parent.issue_id });
     }
   }
-  for (const t of filingErrors(tickets, {
+  const unroutableTickets = filingErrors(tickets, {
     ...coordinating,
     repoExemptValues: tracker.contract.repoExemptReportTypes
-  })) {
+  });
+  const unroutable = unroutableTickets.map((t) => t.id);
+  const { added, gained } = unroutableChanges(
+    unroutableTickets,
+    state.unroutable(route.route).previous(),
+    tickets,
+    tracker.contract.columns.externalId
+  );
+  for (const { ticket: t, synced } of added) {
     emit.warn(
-      "no repo and not marked coordinating/question/investigation \u2014 a filing error, not an epic, and unroutable as written",
+      synced ? "no repository \u2014 not crew work until one is set" : "no repo and not marked coordinating/question/investigation \u2014 a filing error, not an epic, and unroutable as written",
       { ticket: t.issue_id }
     );
   }
+  for (const t of gained) emit.emit("now has a repository \u2014 no longer unroutable", { ticket: t.issue_id });
+  if (unroutableTickets.length) {
+    emit.emit(
+      `${unroutableTickets.length} open ticket(s) have no repository and are not routable (${added.length} new since last cycle)`,
+      { step: "sweep", data: { unroutable: unroutableTickets.map((t) => t.issue_id), newUnroutable: added.map((a) => a.ticket.issue_id) } }
+    );
+  }
   const attentionCurrent = {};
   for (const t of tickets) {
     const reasons = attentionReasons(t, tracker.contract);
@@ -10212,7 +10259,8 @@ async function decideCycle(o) {
     watermark,
     directionEvents,
     selectionInput,
-    attention: attentionCurrent
+    attention: attentionCurrent,
+    unroutable
   };
   const advanced = state.advanceWatermark([...comments, ...tickets]);
   if (advanced !== watermark) {
@@ -10798,7 +10846,7 @@ function renderShipBlock(a) {
       agent: { bin: a.agentBin },
       ...a.extraPath ? { extraPath: a.extraPath } : {}
     }
-  });
+  }, { lineWidth: 0 });
 }
 function renderFullConfig(a, routeBlock) {
   return `${renderShipBlock(a)}
@@ -13128,7 +13176,10 @@ async function decideFleet(o) {
     if (e.error || !e.decision) continue;
     const won = best?.route.route === e.route.route;
     o.state.fairness(e.route.route).record(e.decision.actionable.count, e.decision.actionable.top?.issue_id, won);
-    if (!o.dryRun) o.state.attention(e.route.route).persist(e.decision.attention);
+    if (!o.dryRun) {
+      o.state.attention(e.route.route).persist(e.decision.attention);
+      o.state.unroutable(e.route.route).persist(e.decision.unroutable);
+    }
   }
   return {
     entries,
@@ -13916,23 +13967,18 @@ async function createOperatorRow(o, found) {
   }
 }
 function renderConnection(d, route, dir, opts = {}) {
-  const apiKeyFileLine = opts.keychainBacked ? `    # apiKey: resolved automatically from the OS keychain (crew connect) \u2014 no apiKeyFile needed` : opts.apiKeyFile ? `    apiKeyFile: "${opts.apiKeyFile}"` : `    apiKeyFile: "REPLACE \u2014 a file holding this workspace's key"`;
+  const apiKeyFileLine = opts.keychainBacked ? "" : opts.apiKeyFile ? `    apiKeyFile: "${opts.apiKeyFile}"` : `    apiKeyFile: "REPLACE \u2014 a file holding this workspace's key"`;
   const apiKeyVarLine = opts.keychainBacked ? "" : opts.apiKeyVar ? `
     apiKeyVar: ${opts.apiKeyVar}` : `
     apiKeyVar: REPLACE_KEY_VAR`;
+  const baseUrlLine = opts.baseUrl ? opts.baseUrl.replace(/\/+$/, "") === DEFAULT_BASE_URL ? "" : `    baseUrl: "${opts.baseUrl}"
+` : '    baseUrl: "REPLACE \u2014 the same baseUrl as your other routes"\n';
+  const keyLines = [apiKeyFileLine, apiKeyVarLine.replace(/^\n/, "")].filter(Boolean).join("\n");
   return `  - route: ${route}
-    enabled: false          # arm it deliberately, once doctor is green
+    enabled: false          # set to true once \`crew doctor\` is green
 ${opts.area ? `    area: "${opts.area}"
-` : ""}    ${dir === null ? "repos: {}              # `crew repos clone` / `crew repos add` fill this in" : `dir: "${dir}"`}
-    # worktreePrefix: omitted \u2014 each repo derives its own from its checkout's
-    # directory name (ISSUE-400). Only set this if every repo this route
-    # serves genuinely wants the SAME prefix, which is rare once an area has
-    # more than one repo.
-    # What a host must be to build this \u2014 unix, macos, linux, or windows \u2014
-    # belongs in each repo's own .crew.yaml, not here (see docs/REPO_SPEC.md).
-    baseUrl: ${opts.baseUrl ? `"${opts.baseUrl}"` : '"REPLACE \u2014 the same baseUrl as your other routes"'}
-${opts.hostPassengers ? "    hostPassengers: true\n" : ""}${apiKeyFileLine}${apiKeyVarLine}
-`;
+` : ""}${dir === null ? "" : `    dir: "${dir}"
+`}${baseUrlLine}${opts.hostPassengers ? "    hostPassengers: true\n" : ""}${keyLines ? keyLines + "\n" : ""}`;
 }
 
 // src/cli.ts
@@ -16276,6 +16322,7 @@ async function runOnePassUnguarded(o) {
   }
   const decision = await decide(ctx);
   o.state.attention(o.route.route).persist(decision.attention);
+  o.state.unroutable(o.route.route).persist(decision.unroutable);
   if (decision.sweep.length) {
     const tracker = new Tracker(o.route, o.ship);
     const seat = o.route.resolved?.seats.qa ?? o.route.resolved?.seats.dev ?? "";
@@ -18034,7 +18081,10 @@ ${changed2.map((c) => `  - ${c}
         break;
       }
       const decision = await decideCycle({ route, ship: cfg.ship, state, emit });
-      if (!dryRun) state.attention(route.route).persist(decision.attention);
+      if (!dryRun) {
+        state.attention(route.route).persist(decision.attention);
+        state.unroutable(route.route).persist(decision.unroutable);
+      }
       if (decision.sweep.length) {
         if (dryRun) {
           for (const s of decision.sweep) {
@@ -20567,6 +20617,8 @@ Signed in as ${result.identity.email} \u2014 minted an API key in workspace "${r
             // Additive (CREW-1496): each project and its work mode. `version` stays 1.
             projects: projects.map((p) => ({ id: p.id, name: p.name, workMode: p.mode })),
             dir: route.dir,
+            // Additive (CREW-2548): open tickets with no repository, as of the last cycle.
+            unroutable: state.unroutable(route.route).previous().length,
             enabled: route.enabled,
             area: route.area ?? null,
             // Additive (CREW-1511): the toolchain this route's sessions run on.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tablation/crew",
-  "version": "0.75.1",
+  "version": "0.75.3",
   "description": "A standing team of headless agents that picks work off a Tablation board, does it on a machine you control, and reports back.",
   "type": "module",
   "license": "MIT",