@tablation/crew 0.6.1 → 0.7.0

package/dist/cli.js

@@ -824,6 +824,7 @@ function parseResolved(raw, m, where) {
     operator: m.req(raw.operator, `${where}.resolved.operator`),
     holds: holds2,
     contract: raw.contract ?? void 0,
+    ...typeof raw.releaseSeat === "string" && raw.releaseSeat ? { releaseSeat: raw.releaseSeat } : {},
     ...Object.keys(agentPersonas).length > 0 ? { agentPersonas } : {},
     ...Object.keys(agentSkills).length > 0 ? { agentSkills } : {}
   };
@@ -1083,6 +1084,10 @@ async function hydrateApiKeys(routes, getStore = getSessionStore) {
     }
   }
 }
+function releaseSeat(rt) {
+  const r = rt.resolved;
+  return r?.releaseSeat ?? r?.seats.dev ?? r?.seats.qa ?? "";
+}
 function configuredMembers(rt) {
   const r = rt.resolved;
   if (!r) throw new ConfigError(`route "${rt.route}" has no resolved ids \u2014 run \`crew connect\``);
@@ -1675,7 +1680,9 @@ var DEFAULT_CONTRACT = {
     updatedAt: "updated_at",
     needsDesign: "needs_design",
     reportType: "report_type",
-    epic: "epic_id"
+    epic: "epic_id",
+    author: "filed_by_id",
+    ship: "ship_id"
   },
   comments: {
     parent: "ticket_id",
@@ -1683,7 +1690,8 @@ var DEFAULT_CONTRACT = {
     author: "team_member_id",
     kind: "kind",
     eventKind: "event",
-    createdAt: "created_at"
+    createdAt: "created_at",
+    ship: "ship_id"
   },
   statuses: {
     open: ["new", "accepted", "blocked", "in_progress", "needs_info", "fixed", "qa", "verified"],
@@ -2471,6 +2479,12 @@ var Tracker = class {
   client;
   models;
   userAgent;
+  shipName;
+  /**
+   * The once-per-process authorship probe (CREW-1371), memoised as a promise
+   * so concurrent first writes share one round of field-metadata reads.
+   */
+  authorship;
   stateDir;
   constructor(route, ship) {
     this.route = route;
@@ -2482,6 +2496,7 @@ var Tracker = class {
     this.models = route.resolved.models;
     this.contract = resolveContract(route.contract);
     this.userAgent = ship.userAgent;
+    this.shipName = ship.name;
     this.stateDir = ship.stateDir;
     this.client = new TablationClient({
       baseUrl: `${route.baseUrl}/api`,
@@ -2834,13 +2849,60 @@ var Tracker = class {
    * someone else" wake signal.
    */
   async postEvent(ticketId, body, memberId) {
+    const auth = await this.authorshipProbe();
     await this.client.records.create(this.models.comments, {
       ticket_id: ticketId,
       body,
       team_member_id: memberId,
-      kind: "event"
+      kind: "event",
+      ...auth.commentShip && auth.shipId ? { [this.contract.comments.ship]: auth.shipId } : {}
     });
   }
+  /**
+   * The authorship probe (CREW-1371), read once per process: which optional
+   * `filed_by_id`/`ship_id` columns exist on Issues and Comments, and this
+   * ship's own Ships row id. Memoised as a promise so concurrent first writes
+   * share one round of metadata reads. A table whose metadata cannot be read
+   * reads as "column absent", the same way `connect.ts`'s `owner_id` probe does.
+   */
+  authorshipProbe() {
+    this.authorship ??= this.probeAuthorship();
+    return this.authorship;
+  }
+  async probeAuthorship() {
+    const [issueFields, commentFields, shipRow] = await Promise.all([
+      this.columnNames(this.models.issues),
+      this.columnNames(this.models.comments),
+      // No name (a caller that only beats or patches, never stamps) means no row to find.
+      this.shipName ? this.myShipRow(this.shipName) : Promise.resolve(void 0)
+    ]);
+    return {
+      issueAuthor: issueFields.has(this.contract.columns.author),
+      issueShip: issueFields.has(this.contract.columns.ship),
+      commentShip: commentFields.has(this.contract.comments.ship),
+      shipId: shipRow?.id ?? null
+    };
+  }
+  async columnNames(modelId) {
+    try {
+      const model = await this.client.dataModels.get(modelId);
+      return new Set(model.fields.map((f) => f.columnName));
+    } catch {
+      return /* @__PURE__ */ new Set();
+    }
+  }
+  /**
+   * The authorship columns this workspace is missing, as `table.column` names
+   * for `crew doctor` to report (CREW-1371). Empty on a fully updated install.
+   */
+  async missingAuthorshipColumns() {
+    const auth = await this.authorshipProbe();
+    const missing = [];
+    if (!auth.issueAuthor) missing.push(`Issues.${this.contract.columns.author}`);
+    if (!auth.issueShip) missing.push(`Issues.${this.contract.columns.ship}`);
+    if (!auth.commentShip) missing.push(`Comments.${this.contract.comments.ship}`);
+    return missing;
+  }
   /**
    * The public `/v/<slug>/r/<token>` link for one ticket (ISSUE-928) —
    * fetch-or-create via `POST /views/:viewId/record-links`, so a repeated
@@ -2882,8 +2944,13 @@ var Tracker = class {
    * not among them (`postEvent` above hardcodes its own fields the same
    * way).
    */
-  async fileTicket(fields) {
-    return this.client.records.create(this.models.issues, fields);
+  async fileTicket(fields, memberId) {
+    const auth = await this.authorshipProbe();
+    return this.client.records.create(this.models.issues, {
+      ...fields,
+      ...auth.issueAuthor && memberId ? { [this.contract.columns.author]: memberId } : {},
+      ...auth.issueShip && auth.shipId ? { [this.contract.columns.ship]: auth.shipId } : {}
+    });
   }
 };
 
@@ -2933,7 +3000,8 @@ function rosterMarkdown(roster, meId) {
     `You are **${selfName}**. Address your shipmates by name in ticket`,
     "comments the way you would a colleague; add the role in parentheses only",
     "where a reader would otherwise not know which seat you mean. Your own",
-    "row id is what you write to `assignee_id` and `team_member_id`.",
+    "row id is what you write to `assignee_id` and `team_member_id`, and to",
+    "`filed_by_id` on a ticket you file (where the Environment section names it).",
     "",
     "| seat | name | Crew row id |",
     "|---|---|---|"
@@ -3390,20 +3458,36 @@ function attentionTransitions(previous, current) {
 function displayKey2(t) {
   return t.issue_tag ?? t.issue_id ?? "?";
 }
-function author(c, me, roster) {
+function author(c, i) {
+  const { me, roster } = i;
   if (c.team_member_id === me) return "you";
   if (c.team_member_id === null || c.team_member_id === void 0) {
     const byIdentity = memberByIdentity(roster, c.created_by_id);
     if (byIdentity) return byIdentity.id === me ? "you" : crewLabel(byIdentity) ?? byIdentity.name;
     return `${c.reporter_name ?? "anon"} (no identity)`;
   }
-  return crewLabel(roster.get(c.team_member_id)) ?? "someone off this ship";
+  return (crewLabel(roster.get(c.team_member_id)) ?? "someone off this ship") + shipSuffix(c, i);
+}
+function shipSuffix(c, i) {
+  if (!c.ship_id || c.ship_id === i.myShipId) return "";
+  const name = i.ships?.find((s) => s.id === c.ship_id)?.name;
+  return name ? ` (${name})` : "";
+}
+function filedBy(t, i) {
+  const member = (t.filed_by_id ? i.roster.get(t.filed_by_id) : void 0) ?? memberByIdentity(i.roster, t.created_by_id);
+  if (member) {
+    if (member.id === i.me) return "you";
+    const label = crewLabel(member) ?? member.name;
+    const ship = t.ship_id && t.ship_id !== i.myShipId ? i.ships?.find((s) => s.id === t.ship_id)?.name : void 0;
+    return ship ? `${label} (${ship})` : label;
+  }
+  return t.reporter_name ? `${t.reporter_name} (unverified)` : "\u2014";
 }
 function lastComment(i, ticketId) {
   const forTicket = i.comments.filter((c) => c.ticket_id === ticketId).sort((a, b) => a.created_at < b.created_at ? -1 : a.created_at > b.created_at ? 1 : 0);
   const last = forTicket[forTicket.length - 1];
   if (!last) return "\u2014";
-  return `${last.created_at.slice(0, 16)}Z ${author(last, i.me, i.roster)}`;
+  return `${last.created_at.slice(0, 16)}Z ${author(last, i)}`;
 }
 function newFromOthers(i, ticketId) {
   return i.comments.filter(
@@ -3435,14 +3519,14 @@ ${sorted(ts).map(row).join("\n")}
 `;
 }
 function buildingDigest(i) {
-  const header = "| ticket | repo | branch | worktree | status | assignee | sev | pri | eff | updated | last comment | new since last poll |\n|---|---|---|---|---|---|---|---|---|---|---|---|";
+  const header = "| ticket | repo | branch | worktree | status | assignee | filed by | sev | pri | eff | updated | last comment | new since last poll |\n|---|---|---|---|---|---|---|---|---|---|---|---|---|";
   const row = (t) => {
     const n = newFromOthers(i, t.id);
     const branch = i.branchFor ? i.branchFor(t) : "";
     const worktree = i.worktreeFor ? i.worktreeFor(t) : "";
     const dir = i.dirFor ? i.dirFor(t) : null;
     const repo = i.dirFor ? dir ?? "**NO CHECKOUT**" : "";
-    return `| ${displayKey2(t)} | ${repo} | ${branch} | ${worktree} | ${t.status} | ${who(t, i)} | ${t.severity ?? "\u2014"} | ${t.priority ?? "\u2014"} | p${effectivePriority(t)} | ${t.updated_at.slice(0, 16)}Z | ${lastComment(i, t.id)} | ${n > 0 ? `**${n} new**` : "\u2014"} |`;
+    return `| ${displayKey2(t)} | ${repo} | ${branch} | ${worktree} | ${t.status} | ${who(t, i)} | ${filedBy(t, i)} | ${t.severity ?? "\u2014"} | ${t.priority ?? "\u2014"} | p${effectivePriority(t)} | ${t.updated_at.slice(0, 16)}Z | ${lastComment(i, t.id)} | ${n > 0 ? `**${n} new**` : "\u2014"} |`;
   };
   const blockedRow = (t) => `| ${displayKey2(t)} | ${t.status} | ${who(t, i)} | p${effectivePriority(t)} | ${blockers(t, i)} |`;
   const blockedTable = (ts) => ts.length === 0 ? "\n_None._\n" : `
@@ -3474,7 +3558,7 @@ ${sorted(ts).map(blockedRow).join("\n")}
   ]);
 }
 function qaDigest(i) {
-  const header = "| ticket | repo | status | built by | assignee | sev | pri | eff | branch | worktree | updated | last comment | new since last poll |\n|---|---|---|---|---|---|---|---|---|---|---|---|---|";
+  const header = "| ticket | repo | status | built by | assignee | filed by | sev | pri | eff | branch | worktree | updated | last comment | new since last poll |\n|---|---|---|---|---|---|---|---|---|---|---|---|---|---|";
   const branchCell = (t) => {
     if (i.dirFor && i.dirFor(t) === null) return "\u2014";
     if (!i.existingBranchFor) return "";
@@ -3489,7 +3573,7 @@ function qaDigest(i) {
     const n = newFromOthers(i, t.id);
     const dir = i.dirFor ? i.dirFor(t) : null;
     const repo = i.dirFor ? dir ?? "**NO CHECKOUT**" : "";
-    return `| ${displayKey2(t)} | ${repo} | ${t.status} | ${builtBy(t)} | ${who(t, i)} | ${t.severity ?? "\u2014"} | ${t.priority ?? "\u2014"} | p${effectivePriority(t)} | ${branchCell(t)} | ${worktreeCell(t)} | ${t.updated_at.slice(0, 16)}Z | ${lastComment(i, t.id)} | ${n > 0 ? `**${n} new**` : "\u2014"} |`;
+    return `| ${displayKey2(t)} | ${repo} | ${t.status} | ${builtBy(t)} | ${who(t, i)} | ${filedBy(t, i)} | ${t.severity ?? "\u2014"} | ${t.priority ?? "\u2014"} | p${effectivePriority(t)} | ${branchCell(t)} | ${worktreeCell(t)} | ${t.updated_at.slice(0, 16)}Z | ${lastComment(i, t.id)} | ${n > 0 ? `**${n} new**` : "\u2014"} |`;
   };
   return stream([
     "## Current queue \u2014 built for you by the poll\n",
@@ -3952,11 +4036,12 @@ async function decideCycle(o) {
   const { route, ship, state, emit } = o;
   const tracker = new Tracker(route, ship);
   emit.enter("poll");
-  const [tickets, comments, crewRows, epicRows] = await Promise.all([
+  const [tickets, comments, crewRows, epicRows, ships] = await Promise.all([
     tracker.openTickets(),
     tracker.comments(200),
     tracker.crewRows(),
-    tracker.epicRows()
+    tracker.epicRows(),
+    tracker.shipRows()
   ]);
   emit.emit(`${tickets.length} open ticket(s), ${comments.length} comment(s)`, {
     data: { tickets: tickets.length, comments: comments.length }
@@ -4069,6 +4154,7 @@ async function decideCycle(o) {
     tickets,
     comments,
     roster,
+    ships,
     blocked,
     info,
     sweep,
@@ -4147,6 +4233,10 @@ function writeDigest(o, d, role, stateDir) {
       comments: d.comments,
       me,
       roster: d.roster,
+      // CREW-1371: a comment from another ship is labelled with that ship's
+      // name, so two ships under one API key are distinguishable on the queue.
+      ships: d.ships,
+      myShipId: d.ships.find((s) => (s.name ?? "").trim() === o.ship.name.trim())?.id ?? null,
       watermark: d.watermark,
       blocked: d.blocked,
       blockerInfo: d.info
@@ -4422,6 +4512,14 @@ import { createHash as createHash2 } from "crypto";
 // src/environment.ts
 import { basename as basename4 } from "path";
 var API_KEY_VAR = "CREW_API_KEY";
+function authorshipBullets(a, contract) {
+  if (!a) return [];
+  return [
+    ...a.issueAuthor ? [`- \`${contract.columns.author}\`: your own Crew row id, from "Your crew" above \u2014 who filed it`] : [],
+    ...a.issueShip && a.shipId ? [`- \`${contract.columns.ship}\`: \`${a.shipId}\` \u2014 this ship, where it was filed from`] : [],
+    ...a.commentShip && a.shipId ? [`- \`${contract.comments.ship}\` on every comment you post: \`${a.shipId}\` \u2014 this ship`] : []
+  ];
+}
 var HOOK_PURPOSE = [
   ["setup", "make a fresh worktree usable \u2014 dependencies, generated clients"],
   ["isolate", "point this worktree at state of its own; prints KEY=value overrides to export"],
@@ -4628,6 +4726,7 @@ function renderEnvironment(i) {
       ...only?.id ? [`- \`${contract.columns.repo}\`: \`${only.id}\` (this repository)`] : repos.filter((r) => r.id).map(
         (r) => `- \`${contract.columns.repo}\`: \`${r.id}\` \u2014 when the new ticket belongs to ${r.name}`
       ),
+      ...authorshipBullets(i.authorship, contract),
       "",
       ...i.sourceTicket ? [
         `Name ${i.sourceTicket} \u2014 the ticket you were working when you noticed this \u2014 in the new`,
@@ -6128,7 +6227,7 @@ Still failing: ${n.detail ?? n.headline}`, memberId);
       report_type: "bug",
       severity: "s2",
       reporter_name: "Crew release"
-    });
+    }, memberId);
     const label = created.issue_id ? displayKey(created) : created.id;
     log.warn(`release failure \u2014 filed ${label}`, { step: "release" });
     return { kind: "filed", issueId: label };
@@ -7158,7 +7257,19 @@ async function discover(o) {
     }
     const pairId = seatFor(scoped, "pair") || (shipRowId ? seatFor(unclaimed, "pair") : void 0);
     if (pairId) out.seats.pair = pairId;
-    const seatIds = new Set(Object.values(out.seats));
+    if (shipRowId) {
+      const releaseId = seatFor(scoped, "release");
+      if (releaseId) out.releaseSeat = releaseId;
+      else {
+        const created = await post2(o, `/data-models/${out.models.crew}/records`, {
+          name: "Release agent",
+          ship_id: shipRowId
+        });
+        out.releaseSeat = created.id;
+        provisioning.push("created Crew row for the release seat");
+      }
+    }
+    const seatIds = /* @__PURE__ */ new Set([...Object.values(out.seats), ...out.releaseSeat ? [out.releaseSeat] : []]);
     out.holds = rows.filter((r) => !seatIds.has(r.id)).map((r) => ({ id: r.id, name: r.name ?? "" }));
     if (out.holds.length === 0) {
       problems.push("no non-seat Crew rows \u2014 which row is the operator?");
@@ -8732,7 +8843,8 @@ async function runRoleAgent(role, decision, ctx) {
   }
 }
 async function buildEnvironment(route, ship, ticket) {
-  const contract = new Tracker(route, ship).contract;
+  const tracker = new Tracker(route, ship);
+  const contract = tracker.contract;
   const repos = reposOf(route).map((t) => {
     const id = repoIdForName(route, t.name);
     const o = route.repoOverrides[t.name];
@@ -8747,7 +8859,8 @@ async function buildEnvironment(route, ship, ticket) {
       }, t.dir)
     };
   });
-  return renderEnvironment({ route, userAgent: ship.userAgent, repos, contract, sourceTicket: ticket });
+  const authorship = await tracker.authorshipProbe().catch(() => null);
+  return renderEnvironment({ route, userAgent: ship.userAgent, repos, contract, sourceTicket: ticket, authorship });
 }
 
 // src/cli.ts
@@ -9336,13 +9449,15 @@ ${changed2.map((c) => `  - ${c}
     return (await resolvedRepos(c)).map((r) => `${r.name} requires ${r.config.platform}`).join(", ");
   }
   async function environmentFor(c, ticket) {
-    const contract = new Tracker(c, cfg.ship).contract;
+    const tracker = new Tracker(c, cfg.ship);
+    const contract = tracker.contract;
     return renderEnvironment({
       route: c,
       userAgent: cfg.ship.userAgent,
       repos: await resolvedRepos(c),
       contract,
-      sourceTicket: ticket
+      sourceTicket: ticket,
+      authorship: await tracker.authorshipProbe().catch(() => null)
     });
   }
   const unplaceableReported = /* @__PURE__ */ new Set();
@@ -9444,7 +9559,7 @@ ${changed2.map((c) => `  - ${c}
         try {
           const g = outcome.gateRed;
           const comments = await tracker.comments();
-          const seat = c.resolved?.seats.dev ?? c.resolved?.seats.qa ?? "";
+          const seat = releaseSeat(c);
           for (const t of gateRedTickets(outcome.merged, outcome.decision.merges)) {
             if (alreadyReported(t, g, comments)) continue;
             await tracker.postEvent(t.id, gateRedComment(g), seat);
@@ -9462,7 +9577,7 @@ ${changed2.map((c) => `  - ${c}
       if (news) {
         const notified = await notify(c, cfg.ship, news, remit, dryRun);
         if (!notified && news.level === "fail") {
-          const memberId = c.resolved?.seats.dev ?? c.resolved?.seats.qa ?? "";
+          const memberId = releaseSeat(c);
           await applyFailureAlert(tracker, news, scope, all, memberId, remit, dryRun).catch((e) => {
             remit.warn(`could not file/update a failure ticket: ${e.message}`, { step: "release" });
           });
@@ -9470,7 +9585,7 @@ ${changed2.map((c) => `  - ${c}
       }
       if (outcome.conflicts?.length || outcome.unbuildable?.length) {
         const comments = await tracker.comments();
-        const seat = c.resolved?.seats.dev ?? c.resolved?.seats.qa ?? "";
+        const seat = releaseSeat(c);
         for (const f of outcome.conflicts ?? []) {
           try {
             const bounce = planConflictBounce(
@@ -10616,6 +10731,7 @@ Signed in as ${result.identity.email} \u2014 minted an API key in workspace "${r
           models: found.models,
           seats: found.seats,
           holds: found.holds.map((h) => ({ id: h.id, role: h.name })),
+          ...found.releaseSeat ? { releaseSeat: found.releaseSeat } : {},
           ...operator ? { operator } : {},
           ...contract ? { contract } : {},
           ...reviewedStatuses.length > 0 ? { reviewedStatuses } : {},
@@ -11264,6 +11380,14 @@ routes:            ${cfg.routes.map((c) => c.route).join(", ")}
 `);
         }
       }
+      const missingAuthorship = await tracker.missingAuthorshipColumns();
+      process.stdout.write(
+        missingAuthorship.length === 0 ? "authorship:       filed_by_id, ship_id present\n" : `authorship:       missing ${missingAuthorship.join(", ")} \u2014 update the Issues template
+`
+      );
+      process.stdout.write(
+        route.resolved?.releaseSeat ? "release seat:    this ship has its own Release Crew row\n" : "release seat:    none \u2014 release comments are credited to the dev seat; run `crew connect` once the Crew table has this ship's row\n"
+      );
       const [ships, crewRows] = await Promise.all([tracker.shipRows(), tracker.crewRows()]);
       if (ships.length === 0) {
         process.stdout.write("ship record:       this workspace has no Ships table (fine)\n");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tablation/crew",
-  "version": "0.6.1",
+  "version": "0.7.0",
   "description": "A standing team of headless agents that picks work off a Tablation board, does it on a machine you control, and reports back.",
   "type": "module",
   "license": "MIT",

package/prompts/default/personas/common.md

@@ -619,6 +619,11 @@ filed without them has nowhere to route to — it sits unclaimed by any
 per-repo queue until a person notices and fixes it by hand, however
 urgent its priority.
 
+If that block also lists `filed_by_id` (your own Crew row) or `ship_id` (the
+ship you are running on), set those too, and `ship_id` on every comment you
+post. They record who filed the ticket and from where. The block lists a column
+only when this workspace has it, so a column it does not name is not yours to set.
+
 Name the ticket you were working when you noticed it in the new ticket's
 description. Only put it in the new ticket's `blocked by` column if your
 own ticket genuinely cannot proceed without the new one being fixed

package/prompts/dev-qa/personas/common.md

@@ -600,6 +600,11 @@ filed without them has nowhere to route to — it sits unclaimed by any
 per-repo queue until a person notices and fixes it by hand, however
 urgent its priority.
 
+If that block also lists `filed_by_id` (your own Crew row) or `ship_id` (the
+ship you are running on), set those too, and `ship_id` on every comment you
+post. They record who filed the ticket and from where. The block lists a column
+only when this workspace has it, so a column it does not name is not yours to set.
+
 Name the ticket you were working when you noticed it in the new ticket's
 description. Only put it in the new ticket's `blocked by` column if your
 own ticket genuinely cannot proceed without the new one being fixed