@tablation/crew 0.127.4 → 0.127.5

package/dist/cli.js

@@ -9683,18 +9683,28 @@ async function missingAcceptance(i, t) {
   if (lines2.length === 0 || !i.writer.comments) return null;
   const cc = i.contract.comments;
   const mine = (await i.writer.comments()).map((c) => c).filter((r) => r[cc.parent] === t.id && r[cc.author] === i.seatId).sort((a, b) => String(a[cc.createdAt] ?? "").localeCompare(String(b[cc.createdAt] ?? "")));
-  const last = mine.at(-1);
-  const missing = unquotedAcceptance(lines2, last ? String(last[cc.body] ?? "") : "");
-  return missing.length > 0 ? missing : null;
+  const from = i.since ? Date.parse(i.since) : NaN;
+  const recent = Number.isNaN(from) ? [] : mine.filter((r) => Date.parse(String(r[cc.createdAt] ?? "")) >= from);
+  const candidates2 = recent.length > 0 ? recent : mine.slice(-1);
+  if (candidates2.length === 0) return { missing: lines2, judged: null };
+  let best = null;
+  for (const c of candidates2) {
+    const missing = unquotedAcceptance(lines2, String(c[cc.body] ?? ""));
+    if (missing.length === 0) return null;
+    if (!best || missing.length <= best.missing.length) best = { missing, judged: String(c[cc.createdAt] ?? "") || null };
+  }
+  return best;
 }
-function acceptanceBounceComment(missing, shipName2) {
+function acceptanceBounceComment(missing, shipName2, judged) {
   return `${ACCEPTANCE_BOUNCED_MARKER}
 
 **Hand-off bounced: the hand-off comment does not quote every line of the ticket's Acceptance section.**
 
 ${shipName2 ? `Ship: ${shipName2}
 
-` : ""}Not quoted verbatim:
+` : ""}${judged ? `Judged the comment posted at ${judged}; no comment this run quoted every line.
+
+` : "This seat has no comment on the ticket.\n\n"}Not quoted verbatim:
 ${missing.map((l) => `- ${l}`).join("\n")}
 
 Set back to \`in_progress\`. Post a comment that lists every Acceptance line verbatim, each followed by the test, command or manual check that exercised it in this run and its result (a line you could not exercise is listed with the reason, never omitted), then set \`fixed\` again. The branch is already pushed.`;
@@ -9715,8 +9725,8 @@ async function enforceHandoff(i) {
       return { kind: "unverified", why: v.why };
     }
     if (v.kind === "pushed" && !claimed) {
-      const missing = await missingAcceptance(i, t);
-      if (missing) {
+      const gap = await missingAcceptance(i, t);
+      if (gap) {
         const heldNow = i.hold ? t[i.hold.column] : void 0;
         if (i.hold && heldNow && heldNow !== i.hold.shipId || await takenOverSince(i, t.id)) {
           i.log.warn(`${t.issue_id} is held by another ship now \u2014 the acceptance check is stale, left alone`, log);
@@ -9724,10 +9734,11 @@ async function enforceHandoff(i) {
         }
         await i.writer.updateTicket(t.id, {
           status: i.contract.statuses.building,
-          ...t.assignee_id ? {} : { assignee_id: i.seatId },
+          // CREW-2962: the hand-off may have assigned QA's seat; a bounce is the building seat's again.
+          assignee_id: i.seatId,
           ...i.hold && !heldNow ? { [i.hold.column]: i.hold.shipId } : {}
         });
-        await i.writer.postEvent(t.id, acceptanceBounceComment(missing, i.shipName), i.seatId, "bounced").catch(() => {
+        await i.writer.postEvent(t.id, acceptanceBounceComment(gap.missing, i.shipName, gap.judged), i.seatId, "bounced").catch(() => {
           i.log.warn("bounced, but the note failed to post", log);
         });
         i.log.warn(`${t.issue_id} bounced back to ${i.contract.statuses.building}: hand-off comment lacks the acceptance checklist`, log);
@@ -9781,7 +9792,7 @@ async function enforceHandoff(i) {
     }
     await i.writer.updateTicket(t.id, {
       status: i.contract.statuses.building,
-      ...t.assignee_id ? {} : { assignee_id: i.seatId },
+      assignee_id: i.seatId,
       ...i.hold && !heldBy ? { [i.hold.column]: i.hold.shipId } : {}
     });
     await i.writer.postEvent(t.id, bounceComment(v, i.shipName, pushError), i.seatId, "bounced").catch(() => {
@@ -9921,7 +9932,7 @@ ${i.shipName ? `${i.shipName}'s ` : "A "}${i.role} run set it to \`${st.handoff}
           i.log.warn(`${t.issue_id}: \`${v.remote}/${v.branch}\` is at ${v.origin.slice(0, 7)}, not a tip this checkout built \u2014 left alone`, at);
           continue;
         }
-        await i.writer.updateTicket(t.id, { status: st.building, ...t.assignee_id ? {} : { assignee_id: i.seatId } });
+        await i.writer.updateTicket(t.id, { status: st.building, assignee_id: i.seatId });
         await i.writer.postEvent(t.id, bounceComment(v, i.shipName), i.seatId, "bounced").catch(() => {
         });
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tablation/crew",
-  "version": "0.127.4",
+  "version": "0.127.5",
   "description": "A standing team of headless agents that picks work off a Tablation board, does it on a machine you control, and reports back.",
   "type": "module",
   "license": "MIT",