@systemfsoftware/stryker-js 23.0.1 → 23.1.0

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @systemfsoftware/stryker-js
 
+## 23.1.0
+
+`stryker audit` reports an orphaned test with one of two reasons:
+
+- `every-kill-held-by-a-kept-mutant`: every mutant the test kills is dropped, and every pair of those mutants is a contained Pass. The kept set therefore detects the same faults, and the orphan is reported without failing the audit.
+- `every-killed-mutant-dropped`: anything else. It still fails the audit, and `failures.orphanedTests` counts only these.
+
 ## 23.0.1
 
 The workspace dogfoods @systemfsoftware/stryker-js 23.0.0 and the TypeScript checker 10.0.0, and every package resolves one @systemfsoftware/effect-cell-types (12.1.4). The TypeScript checker and the vitest runner bundle 12.1.4 in place of 12.0.0, and stryker-js and the checker bundle @jsr/std__jsonc 1.0.3 in place of 1.0.2. Every package that takes @systemfsoftware/effect-cell-types from the catalog publishes the range ^12.1.4 in place of ^12.0.0.

package/dist/index.mjs

@@ -1,6 +1,6 @@
 import { t as __exportAll } from "./rolldown-runtime-8H4AJuhK.mjs";
 import { i as Mutant_exports, l as Report_exports, n as mergeConfigs } from "./merge-config-BWQeU3-p.mjs";
-import { $ as IncrementalReportSchema, $t as checkCell, A as optionalField, At as ExtendsStepDone, B as nodePlatformLayer, Bt as createDefaultOptions, C as offerSkipsIfAny, Ct as WorkerLauncher, D as dryRunChoiceOf, Dt as importModule, E as reusedTestCoverage, Et as decideExtendsStep, F as diffScopeDecisionOf, Ft as ConfigError, G as git_diff_service_exports, Gt as ImportedModuleSchema, H as SourceParser, Ht as ConfigDocumentSchema, I as DryRunCoverageReused, It as ConfigFileInvalidError, J as git_diff_schema_exports, Jt as ReadConfigCommand, K as ChangedSince, Kt as MergeCommand, L as scoped$1, Lt as ConfigFileNotFoundError, M as relativeNormalizedFileName, Mt as ExtendsStepRefused, N as requireDryRun, Nt as ExtendsStepResolve, O as requireDryRunCommandOf, Ot as initialExtendsStepState, P as readProjectCell, Pt as FileMatcher, Q as classifyWorkerExit, Qt as groupCell, R as makeCheckerPoolHandle, Rt as ConfigFileUnreadableError, S as instrumentFiles, St as makeWorkerClient, T as readIncrementalReuse, Tt as ReproducerSchema, U as source_parser_service_exports, Ut as ExtendsStepDocumentSchema, V as layerWorkerProtocol, Vt as defaultOptions, W as GitDiff, Wt as ExtendsStepStateSchema, X as ClassifyWorkerExitCommand, Xt as forkOptionsSchema, Y as EmptyDirectory, Yt as extendsPropertySchema, Z as ClassifyWorkerExitDecision, Zt as survivorsPriorReport, _ as testRunnerConfigOf, _t as metricsResultFromFiles, a as HtmlReporter_exports, an as ShardPlan, at as RunEnvironment, b as planPrepare, bt as spawnReporterWorker, c as instrumentCell, cn as SpanTaxonomy_exports, ct as SurfacingFields, d as isCommandRunner, dn as CheckerSkippedRequested, dt as RunEvents, en as ChildProcessCrashedError, et as validateOptions, f as mutantDetailEventsOf, ft as RunIdentity, g as isVmRunner, gt as staticVerdictOf, h as readPrepare, ht as VerdictEnvelope, i as MachineConsole, in as RunEvent_exports$1, it as readConfig, j as import_closure_cell_exports, jt as ExtendsStepRead, k as incrementalReportTextsOf, kt as StrykerError, l as buildTestRunner, ln as CheckerAnsweredUnrequested, lt as SurvivorRef, m as admitPreparedProject, mt as generateRunId, n as RunEventDrain, nn as WorkerBootTimeoutError, nt as describeErrors, o as mutationTestCell, on as ShardPlanVersion, ot as IdGenerator, p as concurrencyCell, pt as buildVerdictEnvelope, q as WholeProject, qt as MergeResult, r as makeRunEventStream, rn as OutputMode_exports, rt as forkCoreSchema, s as prepareCell, sn as ShardProject, st as surfacedSurvivorsOf, t as strykerCell, tn as OutOfMemoryError, tt as loadConfigCell, u as makeChildProcessTestRunner, un as CheckerIgnoredWithoutRule, ut as StrykerPackage, v as vmRunnerPluginUrl, vt as MetricsResultFromReport, w as planInstrumentation, wt as make, x as enteringInstrumentPhase, xt as withPhaseSpan, y as vmTestRunnerConfig, yt as reporterWorkerFactory, z as programDigestOf, zt as ConfigFileUnsupportedError } from "./run-stages-CNIjqDP3.mjs";
+import { $ as IncrementalReportSchema, $t as checkCell, A as optionalField, At as ExtendsStepDone, B as nodePlatformLayer, Bt as createDefaultOptions, C as offerSkipsIfAny, Ct as WorkerLauncher, D as dryRunChoiceOf, Dt as importModule, E as reusedTestCoverage, Et as decideExtendsStep, F as diffScopeDecisionOf, Ft as ConfigError, G as git_diff_service_exports, Gt as ImportedModuleSchema, H as SourceParser, Ht as ConfigDocumentSchema, I as DryRunCoverageReused, It as ConfigFileInvalidError, J as git_diff_schema_exports, Jt as ReadConfigCommand, K as ChangedSince, Kt as MergeCommand, L as scoped$1, Lt as ConfigFileNotFoundError, M as relativeNormalizedFileName, Mt as ExtendsStepRefused, N as requireDryRun, Nt as ExtendsStepResolve, O as requireDryRunCommandOf, Ot as initialExtendsStepState, P as readProjectCell, Pt as FileMatcher, Q as classifyWorkerExit, Qt as groupCell, R as makeCheckerPoolHandle, Rt as ConfigFileUnreadableError, S as instrumentFiles, St as makeWorkerClient, T as readIncrementalReuse, Tt as ReproducerSchema, U as source_parser_service_exports, Ut as ExtendsStepDocumentSchema, V as layerWorkerProtocol, Vt as defaultOptions, W as GitDiff, Wt as ExtendsStepStateSchema, X as ClassifyWorkerExitCommand, Xt as forkOptionsSchema, Y as EmptyDirectory, Yt as extendsPropertySchema, Z as ClassifyWorkerExitDecision, Zt as survivorsPriorReport, _ as testRunnerConfigOf, _t as metricsResultFromFiles, a as HtmlReporter_exports, an as ShardPlan, at as RunEnvironment, b as planPrepare, bt as spawnReporterWorker, c as instrumentCell, cn as SpanTaxonomy_exports, ct as SurfacingFields, d as isCommandRunner, dn as CheckerSkippedRequested, dt as RunEvents, en as ChildProcessCrashedError, et as validateOptions, f as mutantDetailEventsOf, ft as RunIdentity, g as isVmRunner, gt as staticVerdictOf, h as readPrepare, ht as VerdictEnvelope, i as MachineConsole, in as RunEvent_exports$1, it as readConfig, j as import_closure_cell_exports, jt as ExtendsStepRead, k as incrementalReportTextsOf, kt as StrykerError, l as buildTestRunner, ln as CheckerAnsweredUnrequested, lt as SurvivorRef, m as admitPreparedProject, mt as generateRunId, n as RunEventDrain, nn as WorkerBootTimeoutError, nt as describeErrors, o as mutationTestCell, on as ShardPlanVersion, ot as IdGenerator, p as concurrencyCell, pt as buildVerdictEnvelope, q as WholeProject, qt as MergeResult, r as makeRunEventStream, rn as OutputMode_exports, rt as forkCoreSchema, s as prepareCell, sn as ShardProject, st as surfacedSurvivorsOf, t as strykerCell, tn as OutOfMemoryError, tt as loadConfigCell, u as makeChildProcessTestRunner, un as CheckerIgnoredWithoutRule, ut as StrykerPackage, v as vmRunnerPluginUrl, vt as MetricsResultFromReport, w as planInstrumentation, wt as make, x as enteringInstrumentPhase, xt as withPhaseSpan, y as vmTestRunnerConfig, yt as reporterWorkerFactory, z as programDigestOf, zt as ConfigFileUnsupportedError } from "./run-stages-CMs0dSA_.mjs";
 import { n as StageError } from "./Run.schema-DuaneDGd.mjs";
 import { Blueprint, Cell, Handle, Sandwich, Workflow } from "@systemfsoftware/effect-cell-types";
 import * as S from "effect/Schema";

package/dist/main.mjs

@@ -82762,7 +82762,7 @@ const makeHtmlReporter = dual(2, (options, _init) => (events) => build(nodeFsPat
 var HtmlReporter_exports = /* @__PURE__ */ __exportAll$3({ makeHtmlReporter: () => makeHtmlReporter });
 //#endregion
 //#region package.json
-var version = "23.0.1";
+var version = "23.1.0";
 //#endregion
 //#region ../../node_modules/.pnpm/effect@4.1.2/node_modules/effect/dist/cli/internal/ansi.js
 /**
@@ -108994,7 +108994,13 @@ const OrphanedTest = Struct({
 	project: String$7,
 	test: String$7,
 	killed: NonEmptyArray(String$7),
-	reason: Literal("every-killed-mutant-dropped"),
+	/**
+	* `every-killed-mutant-dropped`: some mutant the test kills has a pair that is not a contained Pass, so the drop
+	* may lose a fault the full set detects; this fails the audit. `every-kill-held-by-a-kept-mutant`: every mutant the
+	* test kills is dropped for kept mutants whose every killer also kills it, so the kept set detects the same faults
+	* and the test only stops adding to the score; this is reported and does not fail the audit.
+	*/
+	reason: Literals$3(["every-killed-mutant-dropped", "every-kill-held-by-a-kept-mutant"]),
 	next: String$7
 });
 const DropAuditFields = {
@@ -109153,7 +109159,10 @@ const NEXT_ACTION = {
 	"status-unsettled": `The kill matrix holds the pair as Pending. ${RERUN_MATRIX}`
 };
 const UNATTESTED_NEXT = `No drop of this rule joined the kill matrix, so nothing checks it. ${RERUN_MATRIX} Do not ship the rule until a pair joins.`;
-const ORPHANED_NEXT = `Signal lost: this test kills only dropped mutants, so it kills nothing once they are dropped. ${FIX_THE_RULE}`;
+const ORPHAN_NEXT = {
+	"every-killed-mutant-dropped": `Signal lost: this test kills only dropped mutants, and some of them are not held by a kept mutant whose killers they share. ${FIX_THE_RULE}`,
+	"every-kill-held-by-a-kept-mutant": "No signal lost: every mutant this test kills is dropped for a kept mutant whose every killer also kills it, so the kept set detects the same faults. The test no longer adds to the score; keep it as a specification, or extend it to kill the kept mutant."
+};
 const EMPTY_INDEX = {
 	mutants: {},
 	tests: {}
@@ -109290,20 +109299,40 @@ const isUnattested = (rule) => valueTags(rule, {
 	Attested: () => false,
 	Unattested: () => true
 });
-const orphansOf = (project, index, dropped) => {
+const isContainmentVerdict = (verdict) => valueTags(verdict, {
+	Pass: (passed) => passed.reason === "killers-contained",
+	Vacuous: () => false,
+	AttributionUnverified: () => false,
+	Fail: () => false
+});
+const isContainedPass = (pair) => valueTags(pair, {
+	UnjoinablePair: () => false,
+	JoinedPair: (joined) => isContainmentVerdict(joined.verdict)
+});
+/** The dropped mutants of a project whose every pair is a contained Pass: a kept mutant holds each of their kills. */
+const heldOf = (pairs) => lookupOf(Object.entries(groupBy(pairs, (pair) => pair.mutant)).filter(([, mutantPairs]) => mutantPairs.every(isContainedPass)).map(([mutant]) => mutant));
+const orphanReasonOf = (killed, held) => match$1(killed.every((mutant) => has$6(held, mutant)), {
+	onTrue: () => "every-kill-held-by-a-kept-mutant",
+	onFalse: () => "every-killed-mutant-dropped"
+});
+const orphansOf = (project, index, dropped, held) => {
 	const droppedIds = lookupOf(dropped.map((drop) => drop.mutant));
 	const kills = project.mutants.filter((mutant) => mutant.status === "Killed").flatMap((mutant) => mutant.killedBy.map((test) => ({
 		test,
 		mutant: mutant.id
 	}))).filter((kill) => has$6(index.tests, kill.test));
 	return Object.entries(groupBy(kills, (kill) => kill.test)).flatMap(([test, killedBy]) => match$1(killedBy.every((kill) => has$6(droppedIds, kill.mutant)), {
-		onTrue: () => [{
-			project: project.project,
-			test,
-			killed: map$10(killedBy, (kill) => kill.mutant),
-			reason: "every-killed-mutant-dropped",
-			next: ORPHANED_NEXT
-		}],
+		onTrue: () => {
+			const killed = map$10(killedBy, (kill) => kill.mutant);
+			const reason = orphanReasonOf(killed, held);
+			return [{
+				project: project.project,
+				test,
+				killed,
+				reason,
+				next: ORPHAN_NEXT[reason]
+			}];
+		},
 		onFalse: () => []
 	}));
 };
@@ -109318,7 +109347,8 @@ const decide$36 = (command) => {
 		const rule = headNonEmpty(drops).subsumed.rule;
 		return ruleSummaryOf(rule, drops.length, getOrElse$1(fromUndefinedOr(pairsByRule[rule]), () => []));
 	}), mapInput$2(String$11, (rule) => rule.rule));
-	const orphanedTests = sort(command.matrix.flatMap((project) => orphansOf(project, getOrElse$1(get$12(indexes, project.project), () => EMPTY_INDEX), dropsOf(project))), orphanOrder);
+	const pairsByProject = groupBy(pairs, (pair) => pair.project);
+	const orphanedTests = sort(command.matrix.flatMap((project) => orphansOf(project, getOrElse$1(get$12(indexes, project.project), () => EMPTY_INDEX), dropsOf(project), heldOf(getOrElse$1(get$12(pairsByProject, project.project), () => [])))), orphanOrder);
 	const fields = {
 		schemaVersion: "1",
 		scope: command.scope,
@@ -109334,7 +109364,7 @@ const decide$36 = (command) => {
 	const failures = {
 		pairs: tallyCountsOf(pairs).fail,
 		unattestedRules: rules.filter(isUnattested).length,
-		orphanedTests: orphanedTests.length
+		orphanedTests: orphanedTests.filter((orphan) => orphan.reason === "every-killed-mutant-dropped").length
 	};
 	return match$1(failures.pairs + failures.unattestedRules + failures.orphanedTests === 0, {
 		onTrue: () => DropAuditPassed.make(fields),

package/dist/promises.mjs

@@ -1,4 +1,4 @@
-import { B as nodePlatformLayer, t as strykerCell } from "./run-stages-CNIjqDP3.mjs";
+import { B as nodePlatformLayer, t as strykerCell } from "./run-stages-CMs0dSA_.mjs";
 import * as Effect from "effect/Effect";
 import { dual } from "effect/Function";
 //#region src/promises/run.ts

package/dist/{run-stages-CNIjqDP3.mjs → run-stages-CMs0dSA_.mjs}

@@ -12200,7 +12200,7 @@ const strykerOutputFilesOf = (options) => STRYKER_OUTPUTS.map((output) => output
 STRYKER_OUTPUTS.map((output) => output.label);
 //#endregion
 //#region package.json
-var version = "23.0.1";
+var version = "23.1.0";
 //#endregion
 //#region src/stryker-package.schema.ts
 var StrykerPackage = class extends S.Class("StrykerPackage")({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@systemfsoftware/stryker-js",
-  "version": "23.0.1",
+  "version": "23.1.0",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/systemfsoftware/stryker-js-effect.git",