@systemfsoftware/stryker-js-typescript-checker 1.2.2 → 1.2.3

package/.turbo/turbo-build.log

@@ -2,11 +2,11 @@ $ tsdown
 ℹ tsdown v0.22.9 powered by rolldown v1.2.0
 ℹ config file: /home/runner/work/systemfsoftware/systemfsoftware/packages/stryker-js/typescript-checker/tsdown.config.ts 
 ℹ entry: ./src/index.ts
-
 ℹ tsconfig: tsconfig.json
-ℹ Build start
+
  WARN  `noExternal` is deprecated. Use `deps.alwaysBundle` instead.
 
+ℹ Build start
 
  WARN  TypeScript 7.0 does not yet have a stable API and is experimental. Some options will be unavailable.
 
@@ -15,7 +15,7 @@ $ tsdown
 See more at https://tsdown.dev/options/dependencies#deps-onlybundle
 Detected dependencies in bundle:
 - @jsr/std__jsonc
-ℹ dist/index.mjs    31.56 kB │ gzip: 8.67 kB
+ℹ dist/index.mjs    31.51 kB │ gzip: 8.65 kB
 ℹ dist/index.d.mts   4.66 kB │ gzip: 1.52 kB
-ℹ 2 files, total: 36.22 kB
-✔ Build complete in 561ms
+ℹ 2 files, total: 36.17 kB
+✔ Build complete in 635ms

package/dist/index.mjs

@@ -311,9 +311,7 @@ function overrideOptions(config, useBuildMode) {
 	const compilerOptions = {
 		...config.compilerOptions,
 		...COMPILER_OPTIONS_OVERRIDES,
-		...useBuildMode ? LOW_EMIT_OPTIONS_FOR_PROJECT_REFERENCES : NO_EMIT_OPTIONS_FOR_SINGLE_PROJECT,
-		target: "es2022",
-		moduleResolution: "bundler"
+		...useBuildMode ? LOW_EMIT_OPTIONS_FOR_PROJECT_REFERENCES : NO_EMIT_OPTIONS_FOR_SINGLE_PROJECT
 	};
 	if (!useBuildMode && compilerOptions["declarationDir"] !== void 0 && compilerOptions["declarationDir"] !== null) delete compilerOptions["declarationDir"];
 	if (useBuildMode) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@systemfsoftware/stryker-js-typescript-checker",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/systemfsoftware/systemfsoftware.git",
@@ -30,8 +30,8 @@
     "rimraf": "^6.1.3",
     "tsdown": "^0.22.9",
     "vitest": "^4",
-    "@systemfsoftware/tsconfig": "^1.3.0",
-    "@systemfsoftware/vitest-config": "^0.1.0"
+    "@systemfsoftware/vitest-config": "^0.1.0",
+    "@systemfsoftware/tsconfig": "^1.3.1"
   },
   "inlinedDependencies": {
     "@jsr/std__jsonc": "1.0.2"

package/src/tsconfig-helpers.ts

@@ -117,13 +117,13 @@ export function determineBuildModeEnabled(tsconfigFileName: string): boolean {
  * @param useBuildMode whether or not `--build` mode is used
  */
 export function overrideOptions(config: TsConfig, useBuildMode: boolean): string {
+  // `target` and `moduleResolution` are deliberately absent: both belong to the consumer.
+  // Forcing `moduleResolution` contradicts `module: NodeNext`/`Node16` (TS5095 + TS5109),
+  // and forcing `target` hides lib features the consumer's own target allows (TS2550).
   const compilerOptions: Record<string, unknown> = {
     ...config.compilerOptions,
     ...COMPILER_OPTIONS_OVERRIDES,
     ...(useBuildMode ? LOW_EMIT_OPTIONS_FOR_PROJECT_REFERENCES : NO_EMIT_OPTIONS_FOR_SINGLE_PROJECT),
-    // TypeScript 7 removed some legacy defaults that the upstream fixtures still use.
-    target: 'es2022',
-    moduleResolution: 'bundler',
   }
 
   if (

package/test/integration/nodenext-project.it.spec.ts

@@ -0,0 +1,101 @@
+import fs from 'fs'
+import path from 'path'
+import { fileURLToPath } from 'url'
+
+import { CheckStatus } from '@stryker-mutator/api/check'
+import type { Location, Mutant, StrykerOptions } from '@stryker-mutator/api/core'
+import type { Logger } from '@stryker-mutator/api/logging'
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
+
+import { HybridFileSystem } from '../../src/fs/hybrid-file-system.js'
+import { TypescriptChecker } from '../../src/typescript-checker.js'
+import { TypescriptCompiler } from '../../src/typescript-compiler.js'
+
+const resolveTestResource = path.resolve.bind(
+  path,
+  path.dirname(fileURLToPath(import.meta.url)),
+  '..',
+  '..',
+  'testResources',
+  'nodenext-project',
+) as unknown as typeof path.resolve
+
+function createLogger(): Logger {
+  return {
+    isTraceEnabled: () => false,
+    isDebugEnabled: () => false,
+    isInfoEnabled: () => false,
+    isWarnEnabled: () => false,
+    isErrorEnabled: () => false,
+    isFatalEnabled: () => false,
+    trace: () => {},
+    debug: () => {},
+    info: () => {},
+    warn: () => {},
+    error: () => {},
+    fatal: () => {},
+  }
+}
+
+function createChecker(tsconfigFile: string): TypescriptChecker {
+  const options = {
+    tsconfigFile,
+    typescriptChecker: { prioritizePerformanceOverAccuracy: true },
+  } as unknown as StrykerOptions
+  const logger = createLogger()
+  const fileSystem = new HybridFileSystem()
+  const compiler = new TypescriptCompiler(logger, options, fileSystem)
+  return new TypescriptChecker(logger, options, compiler)
+}
+
+const utilSource = fs.readFileSync(resolveTestResource('src', 'util.ts'), 'utf8')
+
+function createMutant(
+  findText: string,
+  replacement: string,
+  id: string,
+): Mutant {
+  const lines = utilSource.split('\n')
+  const lineNumber = lines.findIndex((line) => line.includes(findText))
+  if (lineNumber === -1) {
+    throw new Error(`Cannot find ${findText} in util.ts`)
+  }
+  const column = lines[lineNumber]!.indexOf(findText)
+  const location: Location = {
+    start: { line: lineNumber, column },
+    end: { line: lineNumber, column: column + findText.length },
+  }
+  return {
+    id,
+    fileName: resolveTestResource('src', 'util.ts'),
+    mutatorName: 'test-mutator',
+    location,
+    replacement,
+  }
+}
+
+describe('Typescript checker on a NodeNext project targeting es2024', () => {
+  let sut: TypescriptChecker
+
+  beforeEach(() => {
+    sut = createChecker(resolveTestResource('tsconfig.json'))
+    return sut.init()
+  })
+
+  afterEach(() => {
+    // @ts-expect-error private close method
+    sut.tsCompiler.close()
+  })
+
+  it('should validate a mutant that keeps the project compiling', async () => {
+    const mutant = createMutant('value % 2 === 0', 'value % 2 !== 0', 'passing')
+    const actual = await sut.check([mutant])
+    expect(actual).toEqual({ passing: { status: CheckStatus.Passed } })
+  })
+
+  it('should invalidate a mutant that violates the declared return type', async () => {
+    const mutant = createMutant("'even'", '42', 'breaking')
+    const actual = await sut.check([mutant])
+    expect(actual['breaking']!.status).toBe(CheckStatus.CompileError)
+  })
+})

package/test/integration/tsconfig-helpers.it.spec.ts

@@ -142,11 +142,30 @@ describe('overrideOptions', () => {
     expect(parsed.compilerOptions).toMatchObject({
       allowUnreachableCode: true,
       noEmit: true,
-      target: 'es2022',
-      moduleResolution: 'bundler',
     })
   })
 
+  it('should not inject a moduleResolution that contradicts the consumer module', () => {
+    const config = expectRight(
+      parseTsConfig('tsconfig.json', '{"compilerOptions":{"module":"NodeNext"}}'),
+    )
+    const output = JSON.parse(overrideOptions(config, false))
+    expect(output.compilerOptions.module).toBe('NodeNext')
+    expect(output.compilerOptions.moduleResolution).toBeUndefined()
+  })
+
+  it('should preserve the consumer target and moduleResolution verbatim', () => {
+    const config = expectRight(
+      parseTsConfig(
+        'tsconfig.json',
+        '{"compilerOptions":{"target":"es2024","moduleResolution":"NodeNext"}}',
+      ),
+    )
+    const output = JSON.parse(overrideOptions(config, false))
+    expect(output.compilerOptions.target).toBe('es2024')
+    expect(output.compilerOptions.moduleResolution).toBe('NodeNext')
+  })
+
   it('should preserve unknown top-level keys and unknown compilerOptions through to the output', () => {
     const config = expectRight(
       parseTsConfig(

package/testResources/errors/compile-error/tsconfig.json

@@ -1,6 +1,5 @@
 {
   "compilerOptions": {
-    "target": "ES5",
     "types": []
   }
 }

package/testResources/nodenext-project/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "nodenext-project",
+  "version": "0.0.0",
+  "private": true,
+  "type": "module"
+}

package/testResources/nodenext-project/src/index.ts

@@ -0,0 +1,5 @@
+import { evenOdd } from './util.js'
+
+const numbers = [1, 2, 3, 4]
+
+export const groupedWithEs2024ObjectGroupBy = Object.groupBy(numbers, evenOdd)

package/testResources/nodenext-project/src/util.ts

@@ -0,0 +1,3 @@
+export function evenOdd(value: number): string {
+  return value % 2 === 0 ? 'even' : 'odd'
+}

package/testResources/nodenext-project/tsconfig.json

@@ -0,0 +1,16 @@
+{
+  "$schema": "https://json.schemastore.org/tsconfig",
+  "compilerOptions": {
+    "strict": true,
+    "module": "NodeNext",
+
+    // `moduleResolution` is deliberately absent and `target` is deliberately newer
+    // than es2022: the checker must not supply either. See nodenext-project.it.spec.ts.
+    "target": "es2024",
+
+    "verbatimModuleSyntax": true,
+    "outDir": "dist",
+    "types": []
+  },
+  "include": ["src/**/*.ts"]
+}

package/testResources/project-references/tsconfig.settings.json

@@ -1,8 +1,6 @@
 {
   "compilerOptions": {
     "strict": true,
-    "target": "es5",
-    "moduleResolution": "node",
     "module": "commonjs",
     "composite": true,
     "declaration": true,

package/testResources/project-with-ts-buildinfo/tsconfig.json

@@ -1,8 +1,6 @@
 {
   "compilerOptions": {
     "strict": true,
-    "target": "es5",
-    "moduleResolution": "node",
     "module": "commonjs",
     "outDir": "dist",
 

package/testResources/single-project/tsconfig.json

@@ -2,8 +2,6 @@
   "$schema": "https://json.schemastore.org/tsconfig",
   "compilerOptions": {
     "strict": true,
-    "target": "es5",
-    "moduleResolution": "node",
     "module": "commonjs",
     "outDir": "dist",